- 19 Feb, 2020 40 commits
-
-
Sergey Poromov authored
This reverts commit e490a00a. Reason for revert: Sheriff here: Consistent failure of Linux MSan Tests: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests First failed run: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357 Original change's description: > Reland "Make PWA titlebar and icons flex and animate properly." > > This reverts commit de7cd485. > > Reason for revert: Fixing issue with Mac tests. > > Original change's description: > > Revert "Make PWA titlebar and icons flex and animate properly." > > > > This reverts commit 8f2f4243. > > > > Reason for revert: speculative revert for test failures on Mac > > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g. > > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700 > > > > Original change's description: > > > Make PWA titlebar and icons flex and animate properly. > > > > > > Nested layouts now allocate available space properly to their > > > descendents. Also, we consistently use flex layout in the PWA titlebar. > > > > > > Removed a couple of invalid assumptions that were encoded as DCHECKs. > > > > > > There are still some inkdrop issues but they are purely cosmetic, see > > > crbug.com/1006162 for more detail. > > > > > > Bug: 1048061 > > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264 > > > Commit-Queue: Dana Fried <dfried@chromium.org> > > > Reviewed-by: Peter Boström <pbos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#738874} > > > > TBR=pbos@chromium.org,dfried@chromium.org > > > > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1048061 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738907} > > TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org > > Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1048061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326 > Reviewed-by: Dana Fried <dfried@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742203} TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1048061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742549}
-
bttk authored
Bug: 1046181 Change-Id: I371ad290e454e55c0f8133b4397b26a9b902e3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024176 Auto-Submit: bttk <bttk@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#742548}
-
Miyoung Shin authored
This is a follow-up CL of https://crrev.com/c.2043181, and remove IconType by directly using mojom::blink::FaviconIconType in Blink. Bug: 1040099 Change-Id: If2d589ca5579f5fbba45f13e4fb9cda450ccf121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053908 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742547}
-
Manuel Rego Casasnovas authored
The methods to check and set the visual overflow recalc flags were both doing similar checks, so we were duplicating those calls. In this change we somehow inline the code of that methods so we avoid repeating those operations. This is intended to improve performance in perf_tests/shadow_dom/v1-small-deep-distribution.html. BUG=1051342,941180 Change-Id: Ica18dd6d07b9f8bca9c35c9db438fbc09bb4a53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062430 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742546}
-
Nikita Podguzov authored
Bug: 996785 Change-Id: Icfce332a4cc763bdabed6a235224a6cea014c203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015040Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#742545}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/333b29e11603..53bc9c82f33f Created with: gclient setdep -r src-internal@53bc9c82f33f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic040b66cffb1b667df8dd46c12f7147619df3c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742544}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4af84fff. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I96fef74d2fd31792ad7a61a6d2917d69654a284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063451Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742543}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a git log 77fefe765c06..79f8caf9154a --date=short --first-parent --format='%ad %ae %s' 2020-02-18 bclayton@google.com vscode: Add missing fields to schema.Opcode (#3169) 2020-02-18 siglesias@igalia.com spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@79f8caf9154a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I93668639b207123df68ca91e88586e7db4eee031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064055Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742542}
-
Morten Stenshorne authored
fragmentation/auto-overflow.html now starts to fail, but that test is invalid, so removing it. A block with overflow:auto is potentially scrollable, and treating it as monolithic therefore makes sense. All other browsers do this as well. Note that we did actually "always" treat it as monolithic, as far as LayoutBox::GetPaginationBreakability() was concerned, but since our legacy engine doesn't really understand fragmentation, we ended up slicing it, making the test pass. LayoutNG will now let such tall objects overflow the column instead, which wouldn't match the expectation. Bug: 829028 Change-Id: Id2ca5488049ef8e768a363e4dbe8767c7bc4d645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062351Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#742541}
-
anina koehler authored
Deprecate the policy schema SCHEMA_ALLOW_INVALID since it only has a different value from SCHEMA_ALLOW_UNKNOWN on Mac OS and Android and in a low percentage of its use cases. Bug: 969706 Change-Id: Ie5251e1ceaa6a4bc8472e6bb1477b7a6de45fc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018946 Commit-Queue: Anina Koehler <aninak@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#742540}
-
Marc Treib authored
Bug: 1053171 Change-Id: I197a7fda2e2f2521fe2cafc556749bf4fd1a424c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751786Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742539}
-
Hitoshi Yoshida authored
- adds more native_value_traits_impl.h includes - adds include for a union type Bug: 839389 Change-Id: I454f2e5a2e9d757439ee3def1edafa53c18bb860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060443Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL changes behavior to use always off-the-record profile for HelpAndFeedback activity, because it is "incognito learn more" button and it is always called in incognito mode. Bug: 1041781 Change-Id: I4438919d6afcd0efbec1dc5198fb94729c981707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060073Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742537}
-
Julie Jeongeun Kim authored
This CL converts FrameMsg_ChildFrameProcessGone to RenderFrameProxy and removes FrameMsg_ChildFrameProcessGone message. Bug: 1051137 Change-Id: I55e24ee59d2c15273988f7d1636edfe2f0198f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062010Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#742536}
-
Alan Cutter authored
This CL moves BookmarkAppRegistrarBrowserTest into being a HostedAppBrowserTest. Additionally it renames the existing HostedAppBrowserTests to HostedOrBookmarkAppBrowserTests to more accurately reflect the params its instantiated. Now HostedAppBrowserTest is only for hosted apps. Branch: +hosted-app-not-web-app Change-Id: Ic7dbe52669cf10895006d584a1d08ed8f7f8e8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059698 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#742535}
-
Side Yilmaz authored
incognito. |Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL changes behavior to use always off-the-record profile for incognitoLearnMoreClickListener. Bug: 1041781 Change-Id: I39911b87ada97db6187aa4fb540c382c061a203d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054963Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#742534}
-
Alan Cutter authored
This CL updates AppRegistrar::FindAppWithUrlInScope() to ignore the IsShortcutApp() status of a web app and just use the default scope the same as a specified scope. This makes web apps with default scopes will be treated the same as web apps with scopes specified in their manifest reducing the behavioural differences between promoted installs and "create shortcut" installs. Bug: 910016 Change-Id: Ifa2c94132fa806a013a6d210dff0d7505df4c3f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051464 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#742533}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Icaecfbdc9596cf7fb8eaf12b99b3e3ae8839de94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062348Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742532}
-
Vasilii Sukhanov authored
They are - oauthaccountmanager.googleapis.com - passwordsleakcheck-pa.googleapis.com Bug: 1049177 Change-Id: I256a5530209f7601c8587d64e4789c2c46ff22b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062408Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742531}
-
Tarun Bansal authored
Change-Id: Ie27b6fe8ed3f9b2e769baf4111c2229f0f3a6803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063894 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Kunihiko Sakamoto authored
It's been a long time since these features got enabled by default (SignedHTTPExchange in M73 and SignedExchangeReportingForDistributors in M74). There's no reason to associate them with the Experimental Web Platform Features flag anymore. This will eliminate the confusion that the combination of --disable-features=SignedHTTPExchange and --enable-experimental-web-platform-features does not disable SignedExchange. Bug: 1052251 Change-Id: I9e70b850d86473df0ac40ef43a43c5b123d50ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063195Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742529}
-
Kuo Jen Wei authored
Bug: None Test: Manually check GA event is (not) emitted from network panel for tast and manual run. Change-Id: Ia42e8b18378a8a5bf53a31209a34dc7c642ed6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060217 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#742528}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates HelpAndFeedback activity initialization at settings classes. Since settings is considered as always running on regular mode, it is safe to use regular profile even called in incognito mode. For this reason, there is no need to make change on code behavior to act differently for each profile. Therefore, it is safe to leave behavior as-is today. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: Ic3bc99d747d28aa6269b7243d7f9feb7337ed75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058817Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-4028.0-1580123479-benchmark-81.0.4044.0-r1 to 82-4044.5-1581936665-benchmark-82.0.4058.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I0938ff21d18fa36bce4aa014a34225a496f57338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064054Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for InkDropHighlight::AnimationType. enum class is more type safety. Bug: 940736 Change-Id: I4fb353a460efd4387f7caa16aed4ee968c426728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062017 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742525}
-
Lei Zhang authored
- Use early returns to avoid 5 levels of indentations. - Call base::File::GetInfo() earlier to retrieve the file size, and avoid making a separate GetLength() call. - Use std::vector and avoid a memory allocation with "new". Change-Id: I8a036047df1b09ac0871ec6b264935c91c9b57c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055996 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If2f15406be74e3dc9db2a98020f7fd4857cde465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063815Reviewed-by:
-
Mike West authored
The specification is ~done, Chromium has enabled the entirety of the feature by default as of 80, and this pass at the tests seems reasonable to consider Good Enough. Change-Id: I21b38e49885d6238f645045b6e7156dfb7a7c122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995162 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#742522}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Ia1a13b29864a9e7450e68029d01df92e12913082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062013 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Rakina Zata Amni authored
This is a reland of c08274e9 The CL was previously reverted because the viewport activation test is flaky, probably due to uncertain timing of near-the-viewport activation. I've updated the test to only test for in-the-viewport activation, I'll investigate further on why it's flaky for near-the-viewport (manual testing shows activation happens consistently). SHERIFFS: please don't revert this CL if it introduces a new flaky test. Instead, please disable them and I'll investigate. Original change's description: > DL: Don't include skip-viewport-activation subtrees in the AX tree > > Now both render-subtree: skip-viewport-activation and skip-activation > subtrees are not in the AX subtree at all, as discussed in > https://github.com/WICG/display-locking/issues/102#issuecomment-564205445 > > Now only render-subtree:invisible subtrees are in the AX tree, and they > are automatically marked as offscreen because the nodes are activated > when they are on screen. > > Bug: 1001930 > Change-Id: I1de511672f60078a02b3ddf3d989f2da1c44ae9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028883 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740531} Bug: 1001930 Change-Id: Icdf43cff86ade7e7e8f2aee76933dfc51e3f022c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054649Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#742520}
-
David Munro authored
Create a crostini_disk helper which allows callers to fetch disk information about a VM, needed for disk resizing. Test: unit tests, manual (run with ugly local UI and see data come back) Bug: chromium:858815 Change-Id: I85706476deb86bdcb970d05e514c7046230a7d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060218Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#742519}
-
Yutaka Hirano authored
Use weak ptr to avoid use-after-free. Bug: 1053700 Change-Id: I2c9bfc022535923d0a5841775e3a65a1e5e21e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062842 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#742518}
-
Alan Cutter authored
This CL rewrites some of the SystemWebAppManagerBrowserTest code to use web_app::AppRegistrar instead of the Extension interface. This is necessary to migrate web apps off the Extension system. Bug: 1052348, 876576 Change-Id: If75fdbb1c25b089961b40f47a48d09a8f3ffcdd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059356 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#742517}
-
Eriko Kurimoto authored
This CL adds design docs for ES modules for dedicated/shared workers. Bug: n/a Change-Id: I93b1ec931a05ffadb139ca37438a0d95b92ccb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061917 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742516}
-
Alan Cutter authored
Prior to this CL, mixed-security content was blocked entirely in standalone PWA windows with scopes. This CL allows those PWAs to display mixed-security content, but when this happens, the window will show the CustomTabBarView with the URL and a "Not Secure" indicator to indicate the presence of mixed content. Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1 This removes a behavioural difference between promoted PWAs and "create shortcut" apps without manifest scopes. Bug: 910016 Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This CL is a preparation to perform App (tab) specific setup when the app is launched. WebAppTabHelper will determine the AppId right before the navigation is to be committed. It is okay to do this because DidFinishNavigation is always called right after ReadyToCommitNavigation. So we will end up navigating to the page, thus this change will not lead to behavior differences. Bug: 1024655 Change-Id: I3be85ae7e0ba5b87c25a150207a8b35468a60bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059694 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
After the following change, DevTools support for the XHR replay feature with Blink CORS was partially removed. https://chromium-review.googlesource.com/c/chromium/src/+/2051443 Blink CORS is still alive behind an enterprise policy, but this change will be acceptable. NOTRY=true TBR: jarhar@chromium.org Bug: 958524, 780935 Change-Id: Ieb18c3204efff3eb50ca4fccd21869fb35bd91a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062118Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#742513}
-
Anders Hartvoll Ruud authored
A few token types are not allowed in <any-value>, and therefore ConsumeGeneralEnclosed must return kParseFailure rather than kUnknown if these tokens are observed. Change-Id: Iedcf120739d2a65d24b047286da66f8a435ebf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057124 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742512}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f5ddd865. With Chromium commits locally applied on WPT: ec83d167 "Update performance.measureMemory to the latest proposal" d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I051a91661e45232127afecc4762b7ce6c623e075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063751Reviewed-by:
-
Takashi Toyoshima authored
Mark shared-worker-redirect.html tests as [ Failure ]. These tests started showing console error messages for the worker script fetch failures only in Blink-CORS. NOTRY=true Bug: 1050438 Change-Id: I8a11ec7897d0ba9627d51db547fdd40fe4b4197f TBR: elkurin@google.com, nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063559Reviewed-by:
-
