GitLab

Also displays data grouped by source ID.

Change-Id: Ibd7b796e9a92b50fbbc15ef96e748d650da9fa8a
Reviewed-on: https://chromium-review.googlesource.com/587393Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491110}

R=jbudorick@chromium.org

Bug: 670879
Change-Id: Id793f8d5a0ac9e47ea1229496af7c3275f940c83
Reviewed-on: https://chromium-review.googlesource.com/595220Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491109}

The code review policy:
specifically prohibits emeritus.

https: //chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md
Change-Id: I345344d94f501364433d14284c72f73aab7cc3a8
Reviewed-on: https://chromium-review.googlesource.com/596676Reviewed-by: Matthew Dempsky <mdempsky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491108}

Previously ScoredHistoryMatch did not correctly flag match_after_host
and match_in_subdomain when the term spans multiple components.

This CL fixes that.

Bug: 732582
Change-Id: I240b9681a9d5c5ddea95de9aaa6fee4ed35d258e
Reviewed-on: https://chromium-review.googlesource.com/595040Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491107}

Even with properly set timeouts, mash_browser_tests timeout about half the time
on the Mojo FYI bot. I want to see if an increased timeout can get them
consistently passing.

TBR=sky@chromium.org
TEST=none

Bug: 678687
Change-Id: I1b86980f981a3c00e5caf1c4aaae9f4c6ad06d8f
Reviewed-on: https://chromium-review.googlesource.com/593851Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491106}

We only use SsbService to pass signed in account data for Icing. On
low-end devices, Icing is disabled, so we don't need this data.

BUG=750365

Change-Id: I00d9faa3a592de4b5471ec5226508facbd48c637
Reviewed-on: https://chromium-review.googlesource.com/592487
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491105}

Change-Id: I9e9535994e3ee42a691729a6d8836f2fd3d68caa
Reviewed-on: https://chromium-review.googlesource.com/596552Reviewed-by: F . <zpeng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: F . <zpeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491104}

changes:
(1) Define a TypeToVectorIcon used for app list, as for new launcher,
the assets are different from AutocompleteMatch::TypeToVectorIcon.
(2) update domain/search/history/bookmark/calculator icons.
(3) update icon related layouts.

screenshot 1: https://screenshot.googleplex.com/iiY03xRvK8q
screenshot 2: https://screenshot.googleplex.com/DPK5Jjv6D8Q

specs: https://screenshot.googleplex.com/8Xvhv8svjbg
Test: emulator test with/without fullscreen app list flag
Bug: 748667
Change-Id: I852eb4a1a204b22cf143dd2ccac11121fe9a8a37
Reviewed-on: https://chromium-review.googlesource.com/590503Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491103}

This CL also refactors ProximityAuthProfilePRefManager to handle the syncing of
profile prefs to local state.

BUG=748879

Change-Id: Ia09a772b10b7b3e2305153c52b1457101cd950c5
Reviewed-on: https://chromium-review.googlesource.com/585899
Commit-Queue: Tim Song <tengs@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491102}

Tests is failing, see bug below.

TBR=hbos@chromium.org

Bug: 751211
Change-Id: Ic7e09dde421f1fa2b85db7da3de48c1001e128d3
Reviewed-on: https://chromium-review.googlesource.com/596513Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491101}

Using LazyInstance seems to be discouraged (crbug.com/686866) now that
Chrome supports Thread-safe static initialization.

Change-Id: I7649ad76ada5bd2292341f46fa1955d2ae51385e
BUG: 686866,720131
Reviewed-on: https://chromium-review.googlesource.com/594491Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491100}

R=reveman@chromium.org

Bug: 722935
Change-Id: Ib412fda34cf0e55529a0f288863decbca7f73616
Reviewed-on: https://chromium-review.googlesource.com/596515Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491099}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4d5d88c3e04c..3ec578154f4f

$ git log 4d5d88c3e..3ec578154 --date=short --no-merges --format='%ad %ae %s'
2017-08-01 simonhatch Dashboard - Clone Pinpoint dialog into Dashboard

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I68347b886136f6658a666527279a0221ed249a6b
Reviewed-on: https://chromium-review.googlesource.com/596532
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491098}

We need to be able to simulate the removal of a characteristic.  This
addition to the interface seems to be the most straightforward way of
accomplishing this goal.

BUG=569709

Change-Id: If700ea99a6df9badc98fc81ef5f7461e574b7985
Reviewed-on: https://chromium-review.googlesource.com/583640Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491097}

TBR=alexclarke@chromium.org, eseckler@chromium.org

Bug: 751180
Change-Id: Ied56d06a9147c92903d1680159ddbbd4956cf28f
Reviewed-on: https://chromium-review.googlesource.com/596767
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491096}

This CL removes old class="..." entries for cr-dialog .title, .body,
.button-container, and .footer. The CSS that used those classes have
changed to [slot=...] instead.

Bug: 747552
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ice802ab9cd238e24c8e66809e5d7907141a0b339
Reviewed-on: https://chromium-review.googlesource.com/584001
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491095}

Bug: 667560
Change-Id: I4f8f168de679d5cdcc16353349332c9aaedce709
Reviewed-on: https://chromium-review.googlesource.com/592497
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491094}

This CL Removes the use of the following commands and uses the dispatcher
instead:
IDC_READER_MODE
IDC_SHOW_READING_LIST


Bug: 738881
Change-Id: I72e1dd2add7905e3168daca502084c53a42fa4c8
Reviewed-on: https://chromium-review.googlesource.com/596530
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491093}

This CL follows how run_telemetry_as_googletest.py handles --xvfb flag.

BUG=717738

Change-Id: I0bb746d18be7818c782b7086ca96605a60af0761
Reviewed-on: https://chromium-review.googlesource.com/595227
Commit-Queue: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491092}

Background blur is enabled behind the appropriate flag.
The flag will be set for either certain devices or all devices
based on blur performance.
The flag will eventually be removed when blur is acceptable for
all devices.

Bug: 739405
Change-Id: If03bbc7bcfbeb5f8609def3b582a05113ef1571e
Reviewed-on: https://chromium-review.googlesource.com/592289
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491091}

Examples:

  # Fetches the certificate chain for www.google.com and pretty prints it
  ./print_certificates.py www.google.com

  # Pretty prints all the certificates contained in certs.pem, followed by
  # the single DER-encoded certificate foo.crt
  ./print_certificates.py certs.pem foo.crt

Change-Id: I3719d1bd3bddc262829f4e6afd7309a205f15c4b
Reviewed-on: https://chromium-review.googlesource.com/585570Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491090}

Sets default values for all relevant parameters to the ones we decided
to launch.  In particular, this change:
* makes it so that URLs that match the input--even if only visited
  once or twice--are likely to score above low quality query suggestions
  that come from the server.
* boosts a URL suggestion if it appears the URL suggestion is clearly
  seeking that URL.  In particular, if the omnibox input only matches that
  single URL from history, it gets a 3x boost (in effect we count it as
  having three times as many visits).  This boost decreases as the number of
  matching URLs increases, so that if the user input matches five or more
  items from history, nothing gets a boost.
* lowers the threshold for how well a URL must match the input in order
  to be displayed.  Previously, for example, we wouldn't return URLs that
  match a word in the input if the word matches in the ?query or #hash
  section of the URL.  Now we do.
* reduces the relative weight of a "typed visit" (a time the URL is selected
  from the omnibox) compared with a regular visit (click on a link).
  It used to be that the former was worth 20x the latter.  Now it's only
  1.5x.
* changes to a scoring model in which additional visits to a URL are
  guaranteed to increase its score.  Previously we used a model based on
  the average quality of a visit, which means that if a URL has many
  typed visits and then gets a new untyped visit, its score (the average)
  will go down.  Now we use simply a sum, which means the score will
  definitely increase.

Precisely, in terms of code / config, we're launching the following settings:
  "HQPExperimentalScoringBuckets": "0.0:550,1:625,9.0:1300,90.0:1399",
  "HQPTypedValue": "1.5",
  "HQPFreqencyUsesSum": "true",
  "HQPNumMatchesScores": "1:3,2:2.5,3:2,4:1.5",
  "HQPExperimentalScoringTopicalityThreshold": "0.5"

In the process, removes some of the flags for frequency scoring that
I don't think are useful (not the right model for scoring) and aren't
worth going back to.

Bug: 695560, 327085, 369989, 508262, 580688, 591981, 598184
Change-Id: Id349c5aaa2e09e6b5284c55fc5790f4b14b8fa7b
Reviewed-on: https://chromium-review.googlesource.com/585377
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491089}

This reverts commit 7405f12a.

Reason for revert: <INSERT REASONING HERE>
This CL breaks ios_showcase_tests.
https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS/builds/30194

Original change's description:
> Add AccessibilityCustomAction to ContentSuggestions
> 
> In order to have the feature accessible, all the actions using gestures
> (long press, swipe to dismiss) must have custom accessibility actions.
> Also adds action sheet to Read Later cells.
> 
> Bug: 749131
> Change-Id: I2c81f6443a49bdf0cdccc3ec747b0ffd42513ef1
> Reviewed-on: https://chromium-review.googlesource.com/593652
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Jean-François Geyelin <jif@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490930}

TBR=jif@chromium.org,gambard@chromium.org

Change-Id: I805e907403106623dc9c67cc89ccbbc5546d0ee1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749131
Reviewed-on: https://chromium-review.googlesource.com/596591Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Menglu Huang <huangml@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491088}

BUG=chromium:730036

Change-Id: Ie31d6e2f0375655185b7fcd8a9809bc24969b861
Reviewed-on: https://chromium-review.googlesource.com/595982
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491087}

base::RandBytes() may be called with output_length=0 and all
implementations supported this case, except Fuchsia. On Fuchsia the
function was crashing due to a failed CHECK(). This was breaking
MemoryDataSourceTest.EmptySource test.

Bug: 737802
Change-Id: Ib9ec20a82dd6966a146f0c66936e232c061466a5
Reviewed-on: https://chromium-review.googlesource.com/595012
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491086}

Disable integer overflow warnings in integer overflow tests.

TBR=thakis@chromium.org

Bug: 751198
Change-Id: Ia5680199a51f0ecb951744838e624f9d6f1d7573
Reviewed-on: https://chromium-review.googlesource.com/596511Reviewed-by: Justin Schuh <jschuh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Justin Schuh <jschuh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491085}

We need to migrate pagesets to WprGo but I don't think
blink_memory_mobile is worth updating because it tracks almost the same
metrics as system_health benchmarks do. This benchmark should be
superseded by system_health.memory_mobile.

BUG=730036

Change-Id: Ic6877c733efce8ffd42cb3d570fb8ec55456d7b7
Reviewed-on: https://chromium-review.googlesource.com/595347Reviewed-by: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#491084}

Bug: 729154
Change-Id: Ifc313411a21c340588fd41a97ba74ccc9a84dbfa
Reviewed-on: https://chromium-review.googlesource.com/570767Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491083}

When tiling masks, sometimes we get tiles that are completely outside
the layer's visible rect. This would lead to problems in determining
whether quad rect contains visible rect, because an empty rect's origin
is not always contained by a quad rect that locates at a random origin.

This would result in problems when converting draw quads to RPDQs in
IPC, thus breaking Android WebView.

This CL makes RenderSurfaceImpl::TileMaskLayer throw away such quads.

Bug: 740810
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I07c4024894740d09ba4708d5ead37a4bec99d7ea
Reviewed-on: https://chromium-review.googlesource.com/570630Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491082}

VC++ is much less frequently used now so it can easily accumulate
compiler warnings. A couple were fixed a few hours ago but two more
remain. This fixes them by adding casts.

Arguably the better fix would be to make the types actually match so
that no casts are required.

TBR=toyoshim@chromium.org
BUG=750999

Change-Id: I1776d93a66db6b74175ed02548525e458be05117
Reviewed-on: https://chromium-review.googlesource.com/596348Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491081}

This change rewrites the single Payments API layout test that uses Mojo
mock services to use the new Mojo JS bindings.

Bug: 699569
Change-Id: I6fa74bfb2e926d35ccf3232c87f7a0114592ce9a
Reviewed-on: https://chromium-review.googlesource.com/595246
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491080}

This change rewrites the WebShare API layout tests to use the new Mojo
JS bindings.

Bug: 699569
Change-Id: Id95a016765c5b101ee347f760e7cec8b74ec4b7e
Reviewed-on: https://chromium-review.googlesource.com/587412Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491079}

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ida67f99137833161bdccc05b29f41e0f184bb7a0
Reviewed-on: https://chromium-review.googlesource.com/592132Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491078}

This relands commit cc2fbf55,
which was reverted by f87a709b.

We create threads to load icons while initializing
ArcPlayStoreSearchResult objects,  so we have to wait for
them to finish, otherwise the test will be flaky and fail
the base::MessageLoop::current()->IsIdleForTesting() test
in test_browser_thread_bundle.cc.

Bug=736552

Change-Id: Icd054ea66367f3c28c3333522795e85475f40a1f
Reviewed-on: https://chromium-review.googlesource.com/590027Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491077}

Some devices/emulators run quickly so requests take less than 1ms,
which causes some test failures.  Fix them using MetricsTestUtil.assertAfter()
and also clean up copies of that code.

Bug: 751184
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icdce80479a887276b8921b4168a96c65b12d0143
Reviewed-on: https://chromium-review.googlesource.com/596073
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491076}

This reverts commit cfa74c50.

Reason for revert: Broke downstream compile

Original change's description:
> Android: Make all targets depend on specific play services targets
> 
> Deletes google_play_services_library GN variable. This should reduce
> compile times a bit, but mostly is just a good idea in general.
> 
> Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f
> Reviewed-on: https://chromium-review.googlesource.com/585450
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Paul Miller <paulmiller@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Michael Case <mikecase@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490968}

TBR=lambroslambrou@chromium.org,nyquist@chromium.org,mariakhomenko@chromium.org,mikecase@chromium.org,agrieve@chromium.org,paulmiller@chromium.org,jochen@chromium.org

Change-Id: I404413dfe809a6918015d109524c4995ec202789
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 751199
Reviewed-on: https://chromium-review.googlesource.com/596807Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491075}

CanCut() should be renamed to CanEditText() because this method can also
be used for asking a plugin if it can paste text. As before, with
respect to the PDF plugin, this method returns true if focus is within
a user-editable form text area and returns false otherwise.

BUG=59266

Change-Id: I0ac86a86c96d64c42cc1246615b54ad3246c8513
Reviewed-on: https://chromium-review.googlesource.com/588067
Commit-Queue: Diana Gage <drgage@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491074}

This change rewrites the Budget API layout tests to use the new Mojo
JS bindings.

Bug: 699569
Change-Id: I4af6e3a78c16cf4ecc6aeedc5317eaf1021ca9eb
Reviewed-on: https://chromium-review.googlesource.com/595234
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491073}

Using field editors is finicky especially when
there's multiple textfields. Using one field editor
is enough, so this CL combines the name and URL
field editors into one.

In addition, like what the
AutocompleteTextFieldEditor is doing, the field
editor's fieldEditor property will reset each time
windowWillReturnFieldEditor:toObject: is called so
that notifications will be sent properly.

Bug: 744211
Change-Id: I2367d2abc788aaf1ef3daa037c879a222440015a
Reviewed-on: https://chromium-review.googlesource.com/595214Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491072}

Previously, LayoutUnit's between NearlyMax() and Max() would round
down, even though their fractional parts are > 0.5.  Similarly,
LayoutUnit's between Min() and NearlyMin() would round up (toward
zero), even though their fractional parts are < -0.5.

Change-Id: I824db066f6f45b58512a30ed32c1d280604bfefe
Reviewed-on: https://chromium-review.googlesource.com/592854Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491071}