- 24 Jun, 2020 40 commits
-
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: I921183f206930fd668fd39178bde892b7c309c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261107Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#781914}
-
Nico Weber authored
No behavior change. The 11 SDK linker warns that building for both 10.6 and 10.7 is deprecated and we build with -fatal_warnings, to that's a build error. Ideally we get a flag to disable this warning. Else we could not pass -fatal_warnings for this target and have a linker wrapper again to filter out the warning ( :/ ), or we could bump up the deployment target (which after this change requires changing only a single number instead of 2). But that's for a future CL. Bug: 1098738 Change-Id: I7952345f1333be023fab997cbf81baf394dfcc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264592 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#781913}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d95138b684b8..29d59a140248 2020-06-24 nisse@webrtc.org Add method PeerConfigurer::SetBitrateSettings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I13d67c26c46f22c9809effc979e1a4b2a36688ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264382Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781912}
-
Ng Zhi An authored
Couple of fixes here include: - change `file` to `open` - add `universal_newlines=True` to subprocess calls, since the output is later compared to a string - change buffer to line buffer, this is the only "breaking" change that might cause a different behavior. For the buffer behavior, unbuffered output is only allowed in binary mode, but we are always printing strings. So the compromise here is to use line buffering (we could also omit it). Bug: v8:9871,chromium:941669 Change-Id: I5c1e69da022d13f4234921fe5fe717d53c96f058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252867 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#781911}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a6c1ece07a47..fe3dbd22c12e 2020-06-24 tcwang@google.com afdo: Prepare/Bundle Android/Linux profiles in a separate handler 2020-06-24 dhanyaganesh@chromium.org constants: Disable Tast Retries 2020-06-23 pprabhu@chromium.org cbuildbot: Set explicit quota account for paygen tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2312075c2ffa247fd2d08f7b1246d442c8981ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264379Reviewed-by:
-
Charlene Yan authored
Bug: 1018230, 1095793 Change-Id: I1ebd3320f48dc7adc66e1fe272df885de9405a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262253 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781909}
-
Elly Fong-Jones authored
It is flaky under ASAN. Bug: 1082355 Change-Id: I8173311710c4b78268e35501bd9137497cbbcd98 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264594Reviewed-by:
-
Mikel Astiz authored
This test suite exercises the integration of the main components under components/sync/engine_impl, covering basic scenarios for the commit and getupdates paths. Many of these scenarios have a corresponding integration test under chrome/browser/sync/test/integration, but operating at these levels simplifies the test setup (single sequence) and allows more fine-grained control of events. Many tests were outdated and no longer applicable, despite the deletion of the trivial cases in previous patches. These leftovers get deleted in this patch, and the ones that still apply in a post-Directory era are now converted to exercise the codepath for nonblocking types (USS). Bug: 923287 Change-Id: I72702cd452b106ad239b7702387832c606cd7b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263192 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#781907}
-
Xiaoqian Dai authored
Bug: 972162 Change-Id: I6094906b78fe53afd50670ab1c5ca08ec61d3f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261892Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#781906}
-
evliu authored
This CL adds logic to delete the SODA binary and accompanying SODA files on browser start-up if the Live Caption feature is disabled at the time of start up. This is an alternative to the more complicated proposal at go/component-updater-delayed-deletion. Optimization of this behavior will be determined by user metrics once the feature lands. Bug: 1097948 Change-Id: I858ec034f1b1c89a80611db3f51049d500877a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258576Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#781905}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If04a0dbd2a205cafacd715ec49c1a1338e6025b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264198Reviewed-by:
-
Piotr Bialecki authored
ArCoreGl (roughly corresponding to an immersive-ar session) currently does not receive requested features list. The list will eventually be needed to remove the assumption in blink about world space being equivalent to local space (or sometimes unbounded, see [0]). [0] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/modules/xr/xr_reference_space.cc;l=112 Bug: 953503 Change-Id: I5b7773b83d1c9cdac4de7f8f4635da69d607c91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140952Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#781903}
-
Marian Fechete authored
This CL adds a new onboarding informational text for two new intents. Bug: b/159783364 Change-Id: I95205c1e5f68d1f90f424f92a4e6719a3e11c0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2263892 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#781902}
-
Kevin McNee authored
Since portal activation involves swapping WebContents, it severed the Safe Browsing referrer chain. We now treat activation as a navigation event, so that we identify the portal host as part of the referrer chain. Bug: 1096115 Change-Id: I045b8dcb397f5ceaf25f152d54cfda5694138dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254464 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781901}
-
Sahel Sharify authored
After this cl Chrome will check for a valid country code inside the address bundle passed to changeShippingAddress. This makes the changeShippingAddress implementation for intent-based android payment apps consistent with its implementation for web-based payment apps. Bug: 1026667 Change-Id: I051801d940bae7dd8f36e26f19eb595b29335707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258461 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781900}
-
Kyle Horimoto authored
This CL adds a new Mojo API for observing changes to search availability. It will be used by the search UI so that the UI updates itself when its results become stale and no longer usable. Bug: 1096867 Change-Id: I89e77d01d86d6d55aa69548f267dfb88f8d0090a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261191Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#781899}
-
Benoit Lize authored
To have uniform semantics across OSes, we call memset() in DecommitSystemPages() on macOS. This is costly and potentially wasteful, as this may bring back compressed/swpped out pages from disk, just to call memset(). To avoid that, call mmap() on top of the existing mapping. Bug: 1086388 Change-Id: Iedbf8d1b5d9882cc5e229765b80f95e9ee12a8de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238118Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781898}
-
Dale Curtis authored
This is a reland of 822a9853 Original change's description: > Ensure no frames have been decoded for video context loss tests. > > Once we have a valid video frame back from the decoder, we assume the > decoder is good and toss the encoded data we hold onto for fallback. > > It's unclear to me how the current tests have ever worked. Since we > only fire canplaythrough after 4 frames have been decoded. > > The fix for this is to ensure we don't decode any frames before > triggering the gpu crash. This is fine for the purpose of this test > which is for testing the rendering and not decoding. > > R=kbr > > Bug: 1082761 > Change-Id: I7e798ff219ded36582b1576919b6e5bf9541f5fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258772 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781665} TBR=kbr@chromium.org Bug: 1082761 Change-Id: I732940008118cf348cad1f6ed6adf1bcb4e09423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264452Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781897}
-
Elly Fong-Jones authored
Bug: 1098782 Change-Id: I1a0221bb27a2180284b1193e59f73a31da5b8f74 Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264572Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592992485-a3304fe8e62cee32c33382f74cb798b9cbbe04f7.profdata to chrome-win64-master-1592999982-7acc1dacb3c35b59c797d873c3b61ca4b0010cd2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I81f58ebbaf2fc048f857695f8041a33e24cacb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264377Reviewed-by:
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/2225371. Change-Id: I6eae5368367f1ddc85cc086bc34f9a0bd352e54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240129Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#781894}
-
Leonard Grey authored
Followup to r779859 Bug: 979743 Change-Id: Id3b3fd10d5a637b7d34aaee1739d39eb67ce8dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254469 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Peter Wen authored
Lint can use a good amount of RAM for generating build graphs for its checks. Use the same pool as linking/proguarding to avoid bot OOMs. e.g. chrome_modern_public_apk__lint's lint call takes about 1.7GB /usr/bin/time -v lint_cmd... Maximum resident set size (kbytes): 1679060 This should not affect local builds since usually only one lint task is run (while building a single apk/app_bundle). Bug: 1098333,1098752 Change-Id: I921642f01b31f08ae2b6524da737072a63bc09c0 Fixed: 1098333,1098752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264454Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781892}
-
Marc Treib authored
This CL also clears the opt-in for the account-scoped password storage when Sync is turned off (and the Sync consent is revoked). Bug: 1098382 Change-Id: I4211a4f66c580f02d0844771dc1d09a03be268a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261272 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#781891}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5040a447f271..92cf2828f7e4 2020-06-24 sigurds@chromium.org Fix stylelint-config-standard issues in css_overview/cssOverviewProcessingView.css 2020-06-24 tvanderlippe@chromium.org Fix newline additions in package.json files in `node_modules/` 2020-06-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0eadd2fbae422a6b7be68603891ea42098597210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264374Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07a3ce625213..e16b0f211117 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bsep@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1090082 Tbr: bsep@google.com Change-Id: Ic6a7e41857a95e64bfff25d71a71b96dcb5b1457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264012Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781889}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46ce35498890..e5f58adc98e4 2020-06-24 lalitm@google.com Merge "ui: remove vsync tracks" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie71d8fdd9accb003ea4a49b64ca35c8f62b7707a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264375Reviewed-by:
-
Mirko Bonadei authored
This reverts commit b51cc5df. Reason for revert: Reverting the component build, see crbug.com/1098761. Original change's description: > Remove duplicate symbols in .def for absl.dll > > Bug: None > Change-Id: I89c105a652db701c083a03f1c0c891e00d2e6776 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260754 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Danil Chapovalov <danilchap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781413} TBR=mbonadei@chromium.org,danilchap@chromium.org Change-Id: I85e28005c25270b150503c0f889363e47c4c2ad1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264125Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#781887}
-
Xianzhu Wang authored
An opaque layer with transformed rasterization enabled should clear the canvas before drawing the display list because transformed rasterization makes the pixels along the edges of the canvas translucent. I added code to clear the canvas in crrev.com/780083, but didn't modify the GPU raster path. This CL makes them consistent. Bug: 1077071 Change-Id: I2a28f81d7c9da98d1199ae3e72a4068269dd7296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262132Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781886}
-
Javier Ernesto Flores Robles authored
Adds "Button" to table view cells. Adds a11y label for details button. Adds a11y notification for copy menu. Bug: 1044639 Change-Id: Ied49f7d7061bea3152cf41867ac7b65b038fb233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264355 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#781885}
-
Becca Hughes authored
Update test target to support other non-JS browser tests. Change-Id: I2626ca89ce5ce19824e30684268a38b127885a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261356Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#781884}
-
Julian Pastarmov authored
Now that restrictions apply to macOS similar to Windows the policy documentation needs to be updated to reflect this. Side cleanup - alphabetized the kSensitivePolicies list and removed the DefaultSearchProviderContextMenuAccessAllowed policy from it as it does not need to be on the list as it is guarded by the DefaultSearchProviderEnabled policy like all other policies in this group. BUG=1084222 Change-Id: I3208eeebcaceffdecb225d4f1e92d68446562d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253742 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781883}
-
Xianzhu Wang authored
In CAP, some frame overlays paint contents directly into display items without a composited layer. Now invalidate the FrameOverlay as DisplayItemClient in UpdatePrePaint() (just like pre-CAP always invalidates the GraphicsLayer). Bug: 1047359 Change-Id: Ic3aa9c35f390bea4b0cd142c5a3a01b090cf4909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261134 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781882}
-
Nico Weber authored
PAGE_SIZE now needs an explicit include of mac/vm_param.h. Bug: 1098738 Change-Id: Ib56e3b080919edb08aa12aeae0fe3357d5022881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264255 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781881}
-
Dominic Mazzoni authored
This is motivated by http://reddit.com/r/pics, where there are two levels of divs in-between the link element and the img element. With this small change Chrome provides image labels for pictures on Reddit again. Bug: 1091538 Change-Id: I7a9775b7ff1febe4ae3b5f1741a624e0664b0582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252801 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#781880}
-
chrome://managementAndreea Costinas authored
If the device is offline, there is no default network to read proxy configuration from. Bug:1098234 Test:unit_tests --gtest_filter= ManagementUIHandlerTests.ProxyServerShowReportDeviceOffline Change-Id: I4850cdaace2cbc86e583f32a1bbddcc863e3ecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260652Reviewed-by:Omar Morsi <omorsi@google.com> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#781879}
-
Xianzhu Wang authored
ScrollableArea::LayerForScrolling() works for pre-CAP only. Now use a method working for both CAP and pre-CAP. Change-Id: Ia22c868d3794b685ebf435cc77d83ec30d9d9dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261414Reviewed-by:
-
Elad Alon authored
This makes it clearer that WebRtcEventLogUploaderImpl runs on the same task runner as WebRtcRemoteEventLogManager, and makes following the threading issues easier. Bug: 1092071 Change-Id: I0a72973525a03632b423dc69afc495439dfdaed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260568 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#781877}
-
Bruce Dawson authored
The UCRT is not a redistributable component on ARM64 so it can't be a required SDK component. This adjust the required list of files for ARM64. The toolchain roll made these files required which broke the ARM64 FYI bot: https://ci.chromium.org/p/chromium/builders/ci/win32-arm64-rel Local testing shows that this fixes ARM64 builds, at least enough to build base. Bug: 1089996 Change-Id: Ic32526aa48f717cdb8bbe42f2e45e9449ede5164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264153Reviewed-by:
-
Patrick Noland authored
This reverts commit 0b009d85. Reason for revert: Causes several tests to crash on Lollipop Tablet Tests (see e.g. https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4cfd793242a15611/+/logcat_logcat_org.chromium.chrome.browser.page_info.PageInfoViewTest.testShowWithPermissionsAndCookieBlocking_20200624T054824-UTC_09e0d212) Original change's description: > WebLayer: hook up CookieControlsBridge. > > When enabled, and when third party cookies are being blocked, this will > show an extra toggle in the page info bubble. > > Test: run_weblayer_shell example.com --args="--enable-features=\"ImprovedCookieControls\"" > Bug: 1071775 > > Change-Id: Ib0a6d6a1c80cafa4b8aeeea19cb9919df55a7f83 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240011 > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781552} TBR=estade@chromium.org,tedchoc@chromium.org,dullweber@chromium.org,nator@chromium.org Change-Id: I7594ba7b5b22dc2b402a5446d90645a9a26930e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264199Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#781875}
-
