- 07 Jan, 2020 40 commits
-
-
Dominick Ng authored
The SiteEngagementService histograms IsZero, ScoreDecayedTo, ScoreDecayedFrom, and PercentOriginsWithMaxEngagement are retired, with recording and tests removed. Various other histograms have their expiry date set to a year from now as they are important heartbeat metrics for the teams. BUG=1037361,1037295,1037294,1036925 Change-Id: Id32e3ec4718810ba396d6b4329833c9fb60c198b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985825Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#728795}
-
Jesse Schettler authored
Replace the PrintMsg_PrintPreview IPC message with a new Mojo method, and update PrintPreviewHandler to use this new method. Also, add a FakePrintRenderFrame to intercept print preview requests from the browser for unit tests. Bug: 1008939 Test: PrintPreviewHandlerTest and PrintRenderFrameHelperPreviewTest Change-Id: I7cac4e7ec5615513116fe96d1f4c7be145b781de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972307Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#728794}
-
Mansi Awasthi authored
Fire UIA selection changed event in browser_accessibility_manager_win.cc when document selection is changed. Bug: 1030731 Change-Id: Ibeb72db403222d1e5a9bef540fafc42b9e01b02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975693Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728793}
-
Austin Tankiang authored
Bug: 1039563 Change-Id: I02133e097c99c0a9487e8c44e97ab3ab04251e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989306Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#728792}
-
Alex Gough authored
This has not been the case since https://codereview.chromium.org/566693002. Change-Id: I1681d3a7ea67ea1bd8d68f071d86348d8137885b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982797 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728791}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcd83e09..2fff8d91 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a4a4bbb036fccc46988725eef59cd16fb8617fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989046Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728790}
-
Peter Kasting authored
Multiple independent subclasses wanted this, so it removes duplication. It also moves in the direction of collapsing everything onto one infobar delegate/view, which I think is the right long-term move. Most of the CL is reordering the declarations and definitions in subclasses to match this order. No intended behavior change. Bug: none Change-Id: Iced9e4e8ce17ace87db398a537ead8536b052aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983434Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728789}
-
Wenbin Zhang authored
The logs printed by process_perf_results.py do not have timestamps. This CL added the timestamps by updating the config for python logging. Bug: chromium:1035935 Change-Id: I824dcc4c594904ff7c2437248679df9e503052ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985219 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#728788}
-
Lucas Furukawa Gadani authored
Bug: 759184 Change-Id: I13b092293ddfd0c78f2556452d4f4776591c3105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988918Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#728787}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/content_index. Bug: 1001114 Change-Id: I630f9474a55d4a15500b440e342495ae8e1f127c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986474Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728786}
-
Miyoung Shin authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process without relying on the InterfaceProvider API. Bug: 936482, 1002647 Change-Id: I559c52c82b5e1d00ae8a6a5d55cb3b56404898e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973438 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728785}
-
Nate Fischer authored
No change to logic. This disables a flaky test across all API levels. TBR=peconn@chromium.org Bug: 692025 Test: None Change-Id: I3d2c5b730c088d22495e59f51078fffa4811830f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988738Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728784}
-
Tomasz Wiszkowski authored
The offset comes from the editurl layout which seems to be 1 pixel off compared to all other suggestions. I used EditUrlSuggestion as a reference when fixing alignment of all omnibox suggestion icons and text. This difference will go away after we convert EditUrlSuggestion to the new suggestion layout. Bug: 1034020 Change-Id: I9122bd9e6ae5db7d255b6af2a2cf094f26f76525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988381Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728783}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I92de761095b0e7b7fa0e65a0e65df14df13560a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988740Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728782}
-
Eric Stevenson authored
It's just noise until we actually want to enable it. Also make the resource_ids_provider dep settable on a per-target basis. Bug: 901465 Change-Id: I696a7256d51b9b249a481700fa6abadde72e3f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988727 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#728781}
-
Natalie Chouinard authored
All BUILD.gn files have been migrated from using java_files to sources, so replace use of java_files with sources in Android build rules. Bug: 1035082 Change-Id: I73fa5ecc53ca0b0acd3146562c2eb10ded533ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988516Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#728780}
-
Hesen Zhang authored
- This API is going to be used in display flow, validating in BeforeShowNotification call. Bug: 1013685 Change-Id: Ifa9d90e4b0db37234551e87bffe79819b040b6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984709 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728779}
-
Nasko Oskov authored
The name validated_params made sense in an earlier IPC version of the code, when unvalidated params were passed in and checks were performed. The name was incorrectly used in many places during the transition to Mojo, implying that validation had already occurred (but calls like FilterURL weren't being done until later). This CL renames validated_params in a bunch of methods to just params, to make it clear that we have not performed any extra validation except what can be expected by Mojo serialization/deserialization. Bug: 1015882 Change-Id: I70ed5aa9a08999be50d549224c6d00510787459b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982919 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#728778}
-
Fergus Dall authored
Currently we will check for an active network connection, a charging battery, and at least 1 GiB of disk space. Bug: 930901 Change-Id: Id742be21a985232ab8dc6f55e11e109151c13833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959242Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#728777}
-
Ricky Liang authored
GpuMemoryBuffer-based video capture is enabled on selected Chrome OS boards to reduce memory copies. This CL allows the Pepper video capture host to convert the GpuMemoryBuffer-based VideoFrames to the I420 buffer PPAPI supports. https://onlinemictest.com/webcam-test-in-adobe-flash/ Bug: b:146938785 Test: Manually tested on Soraka and verify that camera works on Change-Id: I13bbf857b50a900293706dc98ba6e51a8c985986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985832Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#728776}
-
Robert Liao authored
This reverts commit 400050e6. Reason for revert: Failure on WebKit Linux MSAN https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3734 [3153/4358] external/wpt/uievents/idlharness.window.html failed unexpectedly (test timed out) Original change's description: > Fix toJSON in WindowPerformance and PerformanceResourceTiming > > Per https://heycam.github.io/webidl/#es-default-tojson, it is correct to > directly add the attribute values of the interface to the builder > instead of adding the results of toJSONForBinding(). > > Change-Id: I07f7ee5992de59938c0116f90dc4b5229c5d6e9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982792 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728540} TBR=jbroman@chromium.org,npm@chromium.org Change-Id: I06ebf62eb1217de6e7241b4c3ffa6a77d2c696da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986572Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#728775}
-
Sammie Quon authored
Failing because new hotseat window targeter was eating events that the EasyResizeWindowTargeter was handling. Changed the hotseat window targeter to only be active when the hotseat is extended. Test: ash_unittests Fixed: 1037927 Change-Id: Iff20db682d55348cc3ac090f5af90b86db268d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987114 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#728774}
-
Lachlan Ford authored
If the browser is running in sandboxed mode on win32, only OpenXR runtimes that support running in an appcontainer should be used. Runtimes declare this support through the XR_EXT_win32_appcontainer_compatible extension. Fixes: 1036527 Change-Id: Ia4d18542439712e1d169b0b54588ab9b47489ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979526 Commit-Queue: Lachlan Ford <laford@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#728773}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f6a6ff85. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I49e919f6d0311c7471656e0f861fabc2e79e6390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989047Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728772}
-
Hayato Ito authored
The test is flaky on other than ASAN and TSAN. TBR=tommycli@chromium.org,robliao@chromium.org Bug: 1030551 Change-Id: I8cf22b93f1c7f3bc4c7c21b3e3d0e484fe6d5458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986544Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728771}
-
Jack Lynch authored
This CL disables some tests that will be broken by [1] and fixed by [2]. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267 [2] https://chromium-review.googlesource.com/c/chromium/src/+/1636716 Bug: 963183 Change-Id: I2eba775c16c8be2918329a51e996d3fa9684b2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894751 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Cr-Commit-Position: refs/heads/master@{#728770}
-
Brian Sheedy authored
Switches wayland_client_perftests to use PerfResultReporter instead of PrintResult and whitelists it for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: Ie90b89386aafe88fe1b3274eda193237a2d328b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988859 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#728769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ccbcf70c079..a8b0b9cbdf85 Created with: gclient setdep -r src-internal@a8b0b9cbdf85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3667803fefc0fcb22d19092c431b78a37f4e22ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989105Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728768}
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.18-1577702544-benchmark-81.0.4016.0-r1 to 81-3987.18-1578309018-benchmark-81.0.4016.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6c6348e7ee5bb8f8c381acd93b21b623c6e7a9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728767}
-
Dale Curtis authored
Crashes suggest that we're sometimes passing out an AudioBuffer which has an unknown sample format. This shouldn't be allowed. BUG=1032338 TEST=none, can't reproduce. R=tguilbert Change-Id: I2562e8c60a9666e91a2003c5272d600474720ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988891 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#728766}
-
Taylor Bergquist authored
Change-Id: I86d84f3e59c57fc7ff71e1d2de01489e70a5479f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987129 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#728765}
-
Nate Fischer authored
No change to logic. This disables a flaky test across all API levels. TBR=qinmin@chromium.org Bug: 1039491 Test: None Change-Id: I556322058b88387492cb0e4af3e98c61b1b4fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989088Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#728764}
-
Bettina authored
chrome_password_protection_service.cc calls a stack that eventually needs site_engagement_details.mojom.h and the dependency wasn't specified in the BUILD file previously. Bug: 1038845 Fixes: 1038845 Change-Id: I746b55cd13f23e1935e934f9a4c1653fd2a45e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987194Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#728763}
-
Ahmed Mehfooz authored
Bug: 1035134 Change-Id: I219e533a62db489d23b9b873f38bc8f884fe533d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974601 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#728762}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I64a3e011fc59c538e44153b13d5241afdb499a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988805Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#728761}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/mediastream. Bug: 1001114 Change-Id: I3fde5022c2a992e5f04e4419fd9e960c5a42dbb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988126Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728760}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/scheduler. Bug: 1001114 Change-Id: Ic51051ce7b109e30a8995f8c5185abb6eef9d25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980262Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728759}
-
Hirokazu Honda authored
It is needed that a thread has made GL context current before FrameRendererThumbnail::CreateVideoFrame() is called. Otherwise, the gl functions called in CreateTexture() causes a segmentation fault. But the test code doesn't fulfill this if it runs with VaapiVDA. This fixes the issue by making GL context current in FrameRendererThumbnail::CreateVideoFrame(). Bug: 1037926 Test: VDA test on guado Change-Id: I41e9778886d205196038deac17c1a84cc0874635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985738 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#728758}
-
Miriam Zimmerman authored
Bug: 997480 Change-Id: I6738a19078beb447e5e67e307ec700fc77665502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973358 Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#728757}
-
Tsuyoshi Horo authored
When HtmlImportsRequestInitiatorLock is disabled, FrameLoader::document_loader_ is cleared by FrameLoader::DetachDocument() before FrameLoader::DetachDocument() calls Document::Shutdown() -> HTMLImportsController::Dispose() -> HTMLImportLoader::Dispose() -> Document::ClearImportsController() -> ResourceFetcher::ClearContext() -> DetachableResourceFetcherProperties::Detach() -> FrameResourceFetcherProperties::WebBundlePhysicalUrl() -> FrameOrImportedDocument::GetMasterDocumentLoader() -> FrameLoader::GetDocumentLoader() So frame_or_imported_document_->GetMasterDocumentLoader() returns invalid reference of DocumentLoader. This is causing crashes from Dec 20 when HtmlImportsRequestInitiatorLock was disabled in M80 using Field Trial Testing Configuration. To avoid this crash, this cl change FrameResourceFetcherProperties not to call ResourceFetcherProperties::WebBundlePhysicalUrl() from DetachableResourceFetcherProperties::Detach(). Bug: 1036049 Change-Id: If6a947ebec0dbbea0e39d5eb979eed8c8d39f018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978340Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728756}
-