- 22 Jan, 2021 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/beb8370c49f2..957dfeae2968 2021-01-21 smaier@chromium.org Timeout for ADB commands increased If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1168280 Tbr: wenbinzhang@google.com Change-Id: Ib3bbf0d6bb3801afcf11efc3c1bafe3201e008c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643458Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845928}
-
Chris Thompson authored
Bumps the expiration for the Security.SecurityLevel.DownloadStarted, Security.SecurityLevel.FormSubmission, and Security.PageInfo.TimeOpen metrics for another six months. Fixed: 1160748,1160749,1160769,1160773,1160774,1160775,1160776,1160777,1160778 Change-Id: If251de68098a0009b710dc941540e8b4657ad897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644069 Commit-Queue: Chris Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845927}
-
Zach Trudo authored
Bug: b:159750481 Change-Id: Ie159965cb3911fd6c4effeb601f98af7ab517114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616321 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845926}
-
Ian Kilpatrick authored
This is only truly correct for parallel min/max content contributions which are inside indefinite track(s). Things which are wrong: - parallel min/max content contributions need to use the correct percentage resolution sizes. - orthogonal min/max content contributions need to determine the available/percentages sizes based on base/used row/column tracks (if available). - minimum contributions are all wrong. Bug: 1045599 Change-Id: I196efc81dbb44077217135aa59619567120da761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630626Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845925}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..dc8ef8034344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iefa9d674d4d9c71114e3370e944b583ad9334d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643484Reviewed-by:
-
Findit authored
This reverts commit bdb876e8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 845919 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JkYjg3NmU4ZThmZmFiMmU1MGMyMDZiODUxYjA5M2NlMWVkZmU1MDkM Sample Failed Build: https://ci.chromium.org/b/8857436794807907248 Sample Failed Step: compile Original change's description: > PDF Viewer: Make toolbar manager support zoom toolbar only > > No more need to manage a top toolbar, so support only a zoom toolbar > in the toolbar manager. > > Also move toolbar manager to Print Preview build only, and move the > corresponding test to c/t/d/webui/print_preview/ > > To avoid needing to read isPrintPreview in the simplified toolbar > manager, also remove isPrintPreview property from the zoom toolbar and > related styles. > > Bug: 1164004 > Change-Id: Ifccb1481af314dcef7054fde189be2a6769a006f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641805 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845919} Change-Id: I2f980c53ae368c31df4bfa25241b1a44ac657fb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643108 Cr-Commit-Position: refs/heads/master@{#845923}
-
Katie Dillon authored
This CL is a follow-up to this CL[1]. It adds some methods to MainThreadTaskQueue such that anywhere where we need to pass a pointer to the task queue when doing thorottling logic happens on the MainThreadTaskQueue. This change moves us towards removing access to the raw pointer to the task queue outside of MainThreadTaskQueue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Bug: 1143007 Change-Id: Ie5f1ace08cc3329a89e5784010cc936d00832499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521443 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845922}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07a24ad5b02e..212d6814bec1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com,hesen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1155587,chromium:1164189,chromium:1166878 Tbr: yosin@google.com,hesen@google.com Change-Id: Icc0c6b711e7508d2683423e8e541db0b7330ecce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644279Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845921}
-
Tommy Steimel authored
This CL refactors the System Media Controls to use the product name from media::AudioManager::GetGlobalAppName() instead of inferring the product name from branding buildflags. Bug: 942114 Change-Id: Idd1c77ae90b7a89d676e391f83623ab8c4d33a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607504 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845920}
-
rbpotter authored
No more need to manage a top toolbar, so support only a zoom toolbar in the toolbar manager. Also move toolbar manager to Print Preview build only, and move the corresponding test to c/t/d/webui/print_preview/ To avoid needing to read isPrintPreview in the simplified toolbar manager, also remove isPrintPreview property from the zoom toolbar and related styles. Bug: 1164004 Change-Id: Ifccb1481af314dcef7054fde189be2a6769a006f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641805 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845919}
-
Sophie Chang authored
Bug: 1146151 Change-Id: I551d3ca08377836d6354fc6034b7938f6ac9408c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643222 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845918}
-
James Vecore authored
This change points Nearby to the Phone_Hub_M89_V2 branch which has the following cherry picked cls: cl/351271597 cl/351272707 - slightly modified to not have the timeout Bug: 1163991 Change-Id: I95b0ab091e3dbe63f73fa582b1d5bedc5dddbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628082 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845917}
-
Xing Liu authored
Keep both read/unread section header in reading list UI when there is only 1 reading list item. Also add a 15dp padding between. Bug: 1166394 Change-Id: Iac54ed461c0610045427825ac1b888cfd041239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628447 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#845916}
-
Alex Newcomer authored
Update the enum 3 to have a human readable label. Bug: 1164526 Change-Id: Ic716ceff4128c4778f61e98eb70d46d837288bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643414 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845915}
-
Hui Yingst authored
Currently PDFiumEngine::GetNamedDestination() uses the public API FPDFDest_GetView() to get a named destination's view, which outputs 0 if a parameter is null. However, for the x and y coordinates from an XYZ named destination, 0 is a valid input while null should be treated as an empty input. This CL adds a string `xyz_params` in PDFEngine::NamedDestination so that null parameters can be passed to the viewport and get treated differently from 0 for x and y coordinates. Bug: 1157061, 1163701 Change-Id: I81a5a7c4b9c895263e580473a68a070e8b7965dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634130 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845914}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bba017b4..12aab80c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia83fcb38db85e4d08fc742ded7077b9cd69b2571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643221Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845913}
-
Joel Hockey authored
Ensure URL starts with 'file://', not just 'file:'. Disallow invalid URLs such as file:path or file:/path. When testing clipboard file copy, I noticed some linux apps that send '/path' rather than 'file:///path'. Originally I planned to relax checking in order to support this invalid format, but I changed my mind when I saw that it also sends corrupted values for the path which makes me think that it is just plain buggy. I now prefer to be strict. Using std::string for URL rather than StringPiece since we only deal with UTF8 input. Bug: b/162602338 Change-Id: I12c90adcb4b295219b570ca470fd6631942321a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642660 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845912}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d600abac. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I8100542494356e0437adbc7e818ed7a9f635f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644216Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845911}
-
Sean Topping authored
This allows us to eventually unify both internal and external service interconnection under a single framework (BrokerService). This patch creates some temporary hooks which make it easier for us to migrate from Service Manager to BrokerService. As part of the transition, the lifetime of the Cast BrokerService is no long scoped by the Service Manager; it will instead by created eagerly in the Cast main process and expose a service request handler so that clients can still use the Service Manager to connect to it. Merge-With: eureka-internal/513086 Bug: internal b/169098077 Test: CQ Change-Id: I20960c2b57d2b2481c3fcac44b20ca7e3a658786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622577Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#845910}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/94ca9a9578a7..dc8ef8034344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I98f068040c1a1f6c02d94d6977ca61f7740be08d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643713Reviewed-by:
-
Christoph Schwering authored
This CL registers a TranslationDriver::LanguageDetectionObserver and re-runs Autofill's heuristics when the language has been detected. Forms are extracted from the DOM and sent to Autofill before the page language has been determined. Therefore, without the listener, Autofill will be informed about the page language only after the renderer proactively sends updated forms to the browser, which happens upon certain user actions and certain dynamic changes of the DOM (e.g., when the user focuses a field). By then, it may very well be too late to re-run Autofill's heuristics. This CL fixes this issue: Autofill is now notified about the page language once it is determined by Translate. Autofill then re-runs the heuristics for the specific language. Note that this is about language determination, not about actual translation. Autofill does not need notifications about translations. Once the site is translated and a re-parse happens, Autofill will use the translated language to run the heuristics, but this behaviour is not affected by this CL. This CL has a side-effect on repeated-field type rationalization, which previously was only run when server predictions were received. This appears to have been a bug in one way or another; it will be addressed later. For now, this CL adjusts the test expectations (*.out files) to take into account repeated-field type rationalization. This CL builds on crrev.com/c/2575080. Bug: 1150895, 1168239 Change-Id: Ie018b9281305895f74541245076c0958828e3de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561838 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Michael Bai <michaelbai@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Cr-Commit-Position: refs/heads/master@{#845908}
-
Yue Zhang authored
Bug: 1157892 Change-Id: Ibae1711b252cf824ee5da91b7f39ecb12df03002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634132 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#845907}
-
Ian Kilpatrick authored
Previously we had two separate issues. 1) We were using border/padding to determine the %-block-size rather than border/scrollbar/padding. 2) For OOF nodes, we weren't subtracting the border/scrollbar/padding at all. This patch fixes both these issues. Bug: 1060904, 1158406 Change-Id: I266d69725c6cecdb0888e29489e46f1a82ffccc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641294 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#845906}
-
Lukasz Anforowicz authored
Bug: 1164416 Change-Id: I3834ffb77ff1ef23f39c8886049b563753ab6cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630625 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#845905}
-
Vladimir Levin authored
This patch ensures that we reset some state that we accumulate and only reset if we actually report a layout shift. The problem is that the accumulated values can later cause us _not_ to early out from ObjectShifted and report a layout shift where we should not have reported one. By resetting the state after every prepaint, we ensure that we reset the accumulated state. R=skobes@chromium.org Change-Id: I2e764d3d847669cbdf06219da183cda02df57684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639862 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#845904}
-
Moe Ahmadi authored
This is the final step to transfer ownership of realbox to omnibox team. Bug: 1159934 Change-Id: I15814c0ffd32e3c5a2a6e3349bf612406071ed34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641808 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845903}
-
Eugene But authored
Workaround for null context was necessary on iOS 12 as confirmed by Navigation.IOSNullContextInDidFailProvisionalNavigation histogram. Also stop recording Navigation.IOSNullContextInDidFailProvisionalNavigation as this histogram has expired and served its purpose. Bug: None Change-Id: Id2df18c8e92c134049a820b6a38af403c38bac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638447 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#845902}
-
Yaron Friedman authored
From flaky portal these are among top 15 flakiest: org.chromium.chrome.browser.bookmarks.BookmarkTest#testReadingListEmptyView org.chromium.chrome.browser.bookmarks.BookmarkTest#testReadingListFolderShown Sample failure looks to be because bookmarkmodel isn't loaded: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8857470340605361056/+/steps/chrome_public_test_apk_on_Android_device_Pixel_2__with_patch_/0/logs/Flaky_failure:_org.chromium.chrome.browser.bookmarks.BookmarkTest_testReadingListEmptyView__status_FAILURE_SUCCESS_/0 Change-Id: Ie7c050345d31fd03f3bdb4eb41b1f2253c135bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643487Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#845901}
-
Xiaocheng Hu authored
This patch introduces a dirty bit to CounterStyle to indicate whether the information is stale. In general, a CounterStyle is dirtied if its underlying @counter-style rule has changed, or if any other @counter-style rule that it can reach via the 'extends' and 'fallback' references have changed. A dirtied CounterStyle will be removed or replaced in the corresponding CounterStyleMap. The overall process is very similar to how FontFallbackList is dirtied when @font-face rules or loading status are changed. This dirty bit allows partial invalidation of style and layout after @counter-style rule changes. A follow-up patch will implement such partial invalidation. Bug: 687225 Change-Id: I950af0b76381bfdb88adcb5a4ce38ca990e6b6cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641157Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#845900}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611251835-492ad3518ecdcc200059acbff6fa6ac0a2007e2f.profdata to chrome-linux-master-1611272973-8e4032da22e18455d35fc6237c90007c71899d37.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie38c5f91ed587143802917d1f2934000df0abd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644283Reviewed-by:
-
Ben Joyce authored
Bug: 1169407 Change-Id: I66080a99bfcd36ce17fce4e5d5bfc8ed09de7e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644062Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Auto-Submit: benjamin joyce <bjoyce@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#845898}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1611251835-293c4fab8514e5eb6bd360b905bded2a6927bf71.profdata to chrome-mac-master-1611272973-25501ceb667d7bff805b8f0169ae53268fd6f0a5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie12a54d6e66fc7b846535cd18dc0018cc4aaa08b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644282Reviewed-by:
-
Tibor Goldschwendt authored
Makes the logo Finch-configurable. Flag is enabled by default. This is a reland of 660b7591 with a fix for the msan builder. See crbug/1169070 for more details. Original change's info: > Bug: 1168361 > Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845490} Bug: 1168361 Fixed: 1169070 Change-Id: I9f038b06cfd7551bf0acb94a7ac08cb8d49d7095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643179 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845896}
-
Mason Freed authored
This code was added in [1] to work around a bug [2] in the layout test system that doesn't seem to still reproduce. The "open" attribute is not a presentation attribute, so it shouldn't be marked as one. This should not change any behavior. [1] https://source.chromium.org/chromium/chromium/src/+/f56b6ef2b68e305e106e0310fd884c620861fb8b [2] https://bugs.webkit.org/show_bug.cgi?id=91058 Change-Id: If03bf98075db8b94e56f27370199a36e508106b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640923 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845895}
-
Andrew Grieve authored
Makes the arg take effect more universally by having it be a flag on proguard.py rather than work by having targets add the correct proguard configs. Also enabled -repackageclasses '' for L8, which means it should produce a smaller .dex file. Bug: 1168672 Change-Id: I9c07d337755efedbdf1fabbe8822a9fdfba49fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641306 Commit-Queue: David Trainor <dtrainor@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#845894}
-
Pete Williamson authored
This histogram is reaching its expiration date, and we realized that we will need it as long as we have a feed. After a quick discussion with the team, we decided to change it to never expire. Bug: 1167830 Change-Id: I4740a4f76c6ebc285792d803af66a4aac7dd68c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643361Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#845893}
-
David Tseng authored
AX-Relnotes: n/a Bug: none R=katie@chromium.org Change-Id: Id29f9a97d0342e8333f8bebff9781460fb05fa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643758Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845892}
-
Takumi Fujimoto authored
UpdateAndMaybeSwitch() is hit even when not mirroring, so we should record the remoting compatibility only when mirroring. Bug: 1163944 Change-Id: I05415bc9b15115526f66cdb6006cb9e946a0d379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638494 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#845891}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc8ef8034344..302f83f07614 2021-01-21 fmayer@google.com Merge "style: Remove unnecessary cast." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6445b471adad871a9637d5cefe4e73266bdc5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642832Reviewed-by:
-
Michael Thiessen authored
See bug for context. FLAG_IMMUTABLE should be used as the default for PendingIntents when mutability is not required as it is more secure. A mutability flag should be explicitly set for all PendingIntents as when unspecified Android makes PendingIntents mutable. Bug: 1163529 Change-Id: I28bf2d277c72edaf03a7133a0302326ad2357f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643099Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845889}
-
