- 07 Oct, 2020 40 commits
-
-
Maksim Moskvitin authored
Bug: 1094326 Change-Id: I1cc440f13b92fc825cc749c042e8599fdab793c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455447 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814665}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. TBR=skyostil@chromium.org Bug: 1018739 Change-Id: I163c10cfb9ff34ad117fb0b74b6c598a09cfe61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442795 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814664}
-
Fredrik Söderqvist authored
This allows simplifying callers a bit since most of them pass a constant set of flags, and we can tailor the code better based on that. For example there should be no need to call InvalidateClipPathCache() when a filter is being invalidated, and similarly we shouldn't need to mark for paint invalidation since we no longer have a paint dependence for the filter handling. While at it, wrap up the common sequence for invalidating the filter cache into a function. Bug: 1028063 Change-Id: Ieada3250cf7dd096f432b6fd605f584aafbeb268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454053Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#814663}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602050190-974fbc4c4bfed178912ed1051cd970c3d7aa5e65.profdata to chrome-mac-master-1602071853-210420531a6e235ee5a49a220c20aeed2a3958f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iadc8888c0da80d54ce0c7c9c1fc5e8b72e8a4109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814662}
-
Ben Kelly authored
In order to support throttling network requests in install events we would like to run a trial that measures changes in install time and success rate. We have existing histograms for these measures, but they cover all install events. We suspect that there are many install events that do not fetch any resources at all; e.g. push notifications scripts. This dilutes the signal we get from looking at these histograms in the trial. This CL adds separate histograms to measure install time and success rate for only events where the script performs a network fetch. It also adds a histogram to measure how many fetches are performed for each install event. To support this histogram we plumb a count of fetches from the GlobalFetch::ScopedFetcher to the service_workers_metrics.cc utility code. Bug: 1035448 Change-Id: Id6eb4a553452b01d71c0a42b88a8c9df56819c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443044 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#814661}
-
Alice Wang authored
This CL migrates the name and return type of the signin method in ChromeBrowserTestRule to be consistent with new signin API. Bug: 1135510 Change-Id: I060484a615b0e0a9f173469927724d79652f439d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450198Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814660}
-
Eric Willigers authored
AppServiceShelfContextMenuWebAppBrowserTest no longer relies on ProviderType, as BMO as shipped. Bug: 1065748 Change-Id: If7ef9a2dfd89644288a5e59686dd5efd01c81ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454593 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#814659}
-
Finnur Thorarinsson authored
Bug: 1130909 Change-Id: I63bb59f057deffd849469538336f959e2b644d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454084Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#814658}
-
Dale Curtis authored
Will be replaced by a platform-agnostic one later. Fixed: 1123574 Change-Id: I8bb240aad3e2e66a83e1366aa875b9c0cd3ad1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453892 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#814657}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4ab7a75eb5a..4af799c5156f 2020-10-07 alexrudenko@chromium.org Migrate HelpQuickOpen.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0615412782caf90faaf0a6a54f9cbff7778b9cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455906Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 45d4d482. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ieaa9accb7b9bd2f19a6b720be5dbc39b316dd58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454281Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814655}
-
Rune Lillesveen authored
Change-Id: I6a81ef095db774d175bc63c8b6b48787031d7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455449Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#814654}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. We no longer need to use ScopedFeatureList. Bug: 1065748 Change-Id: I9f55a24cb390776ed2f8bfb6d3242d24e97c1d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454578 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be parameterized. Bug: 1065748 Change-Id: I451f0252cc0785b7f553a13e120c264ddd07ab7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454439 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
Sophey Dong authored
Bug: 1135311 Change-Id: Ie7afa6a9dfd4e10ea80785c93fd1667c5573ac24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453500Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#814651}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/57c37ad0e4c8..df47abcbb993 2020-10-07 kjlubick@google.com [canvaskit] Add make rule to check types If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I5b84183985de22d18129346b6a97429e622600a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455542Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86a4dade..223fd5da Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7082fcddde55a6b8897b7e8e14f9bc3cb2e3d0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454280Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814649}
-
Peter Marshall authored
This test includes a JSSample event that has no stackTrace property which is not valid. The frontend assumes this property always exists even if it is an empty array. Drive-by fix the unused `model` var and change event to a const. Bug: 1127827 Change-Id: Ia33e0103ba85b22e7ab18c7d7074935d65130c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454083Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814648}
-
Fredrik Söderqvist authored
This is always the current ComputedStyle for the LayoutObject that is passed, so just access it via the LayoutObject. Bug: 1028063 Change-Id: I2579603bdbb86a17fe9663d09d0b88563cb3676c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455746 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Stephen McGruer authored
This adds some basic documentation laying out what the project is, how to use it, and the MVP bots. It is intended as a user guide rather than technical details. Bug: None Change-Id: I7d90f542d2aeb33eecfd836693f2741ad91588c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451505 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#814646}
-
Oleh Lamzin authored
Remove // from path for README.md since it's not searchable and README.md file path is components/services/app_service/README.md in code search. Change-Id: I2ac9033a5584b4d75d841996606b58d102988547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453255 Auto-Submit: Oleh Lamzin <lamzin@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6e7d3e86fcbc..b364d20b12d2 2020-10-07 hjd@google.com Merge "ui: Fix <O recording docs link" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I62c1541b8acba3551a166f91ccce742a7a703c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455534Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8af9ef3b260f..10d329d9803b 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 02da53e45d9e to 618e41c871d6 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4a76df38b1854a4d4a0ffb2c69b49e373994b9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455535Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601974327-16d759bfb740e331cae500f5af505af81f39b1ea.profdata to chrome-win32-master-1602039546-1494d436e25ae807c20aabdd04cfd168e713ca95.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I52f3ea1ae6669b3f5929cb25a08835badbcf0df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455090Reviewed-by:
-
sauski authored
Improve performance of recording cookie accesses by only writing the existing in memory cookie store to the database on top level frame origin change, or on record access. Bug: 1136016 Change-Id: I97159f75d4afaea004da00b3a37988816a972f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450281 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#814641}
-
Alice Wang authored
This CL adds a test to check the profile data updata from IdentityManager. Bug: 1135087 Change-Id: I6b7f4d1b5a591810d754935c07f6a5f7aba5fc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449332Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814640}
-
Tymofii Chudakov authored
Implemented exceptions section redesign of the content settings pages. This CL includes redesign of the following content setting categories: - ADS - MIDI_DEVICES - AR - MIXEDSCRIPT - AUTOMATIC_DOWNLOADS - MOTION_SENSORS - BACKGROUND_SYNC - PAYMENT_HANDLER - CAMERA - PLUGINS - CLIPBOARD - POPUPS - FILE_SYSTEM_WRITE - PROTECTED_CONTENT - GEOLOCATION - SOUND - IMAGES - UNSANDBOXED_PLUGINS - JAVASCRIPT - VR - MIC Bug: 1113642 Change-Id: I843de142fa297323b795480cecc9ecaaafc18fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403280 Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#814639}
-
Joanmarie Diggs authored
If an existing node becomes ignored or unignored, we notify platform ATs that the parent of that node has changed children, but not that the children of that node have a changed parent. Some platforms, such as AT-SPI2, cache parent information separately from child information and expect notifications about parent changes to maintain an accurate cache. Address this problem by creating a new AXEventGenerator parent-changed event and emit it on the existing children of a newly-un(ignored) node. It turns out that the ordering of these notifications can also matter. If an about-to-become-focused node is in an about-to-be-reparented subtree, we need to notify ATs about the reparenting before we notify them about the focus change. If we do the reverse, the AT may have stale information about where the new focus is with respect to the accessibility tree which in turn can break AT-driven navigation. But BrowserAccessibilityManager::OnAccessibilityEvents was firing focus events prior to events for any other tree updates in order to ensure screen readers will correctly process events associated with the focused node. We should be able to address both needs by first firing tree updates that come from the ancestors of the focused node, then then firing a focus event if needed, and finally firing the remaining events. Also add expectations for existing related content browser tests for which AuraLinux expectations did not exist, along with fixing a bug in the AuraLinux accessible-event recorder and adding detail for children- changed events. AXRelnotes: The Orca screen reader has a non-performant workaround for the lack of parent-changed notifications, namely to not use the AT-SPI parent caching feature. This fix will make it possible for Orca to use AT-SPI's parent caching and improve performance. Bug: 1047496 Change-Id: I6421543f471054c10cf6a4fa657de4d184cd6bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418652 Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814638}
-
Shakti Sahu authored
This CL moves AsyncImageView to components/browser_ui/widget, which includes moving AutoAnimatorDrawable, ForegroundRounderCornerImageView, and unavailable/waiting drawable XML files. Bug: 1134412 Change-Id: I0466620ec4571a75f9839fa575b9d07f1f201b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444172Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814637}
-
Peter Marshall authored
This test calls generateJSFrame after createPerformanceModelWithEvents, except this already calls generateJSFrames. It just happens that this is idempotent under some circumstances which this test narrowly falls into. This meant that `events` was always empty and thus the merge did not. Remove all this. Test results are still the same. Bug: 1127827 Change-Id: I6c1d0d776bf692f3563583ea4fa72d1fff9ea3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455706Reviewed-by:
-
Olesia Marukhno authored
If you request a permission, then open another tab and request the same permission, the chip appears without animating and the origin in the omnibox disappears. This patch fixes this behaviour. If request was already shown to user and user switches back to a tab with a pending request, request stays collaped and won't reanimate. Bug: 1019129 Change-Id: I9d46f1fbe479de584bcce988d7a20deb4e7e76a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445774Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#814635}
-
chrome://accessibilitydpapad authored
Calling JS functions by name from C++ is an obsolete pattern. Use FireWebUIListener/addWebUIListener which is the suggested approach. Also extracting all chrome.send() calls to a local BrowserProxy class which makes the code more readable and is consistent with the BrowserProxy pattern used in other WebUIs. Bug: None Change-Id: I911b114b6687e7b0108296a38636811bc066dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450722 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
-
Renato Silva authored
Add some extra logging information to some of the enrollment steps to help us on determining if forced enrollment is preventing some integrating tests from running. Bug: 1109176 Change-Id: Icd375f78bb238a40380d9bc9234a6301ab521e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442534Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#814633}
-
sandromaggi authored
Both methods are refactored to take an |ElementFinder::Result| instead of a |Selector|. Bug: b/168107066 Change-Id: I99e93d0b7683be74a4390735ac254cbb4017683a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426505 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#814632}
-
Arthur Hemery authored
Refactors the is_coop_coep_cross_origin_isolated and coop_coep_cross_origin_isolated_origin parameters all over content into a class. Change-Id: I5df8ffcb951c783c2d077567ba2c35d214dd1c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412287 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814631}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8274c1978a88..306f83589eb0 2020-10-07 tikuta@chromium.org Revert "Roll out new goma client binary VERSION=206" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I79d08712b709e8ead1774a14debe5d37d7f2ce6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455532Reviewed-by:
-
Vasilii Sukhanov authored
Tbr: bsep@chromium.org Bug: 1136011 Change-Id: Ie874f5f4b10479856af54f7ab3fd4d9012b60d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454719Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814629}
-
Vasilii Sukhanov authored
This reverts commit 6b3c4bdb. Reason for revert: Broke PolicyServiceAndroidTest.PolicyUpdateEvent on Android ASAN https://ci.chromium.org/p/chromium/builders/ci/android-asan/8133 Original change's description: > Add onPolicyUpdate notification in Java. > > Support PolicyService::onPolicyUpdate event in Java. Same as other > functions, only Chrome policies are supported. > > Other changes: > 1) Implement PolicyMap.equals() > 2) Use ObserverList instead of Set to manage PolicyService's observers. > > Bug: 1127469 > Change-Id: I40c6958e87c746aa40afec306ee632bba52183f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446639 > Commit-Queue: Owen Min <zmin@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814310} TBR=zmin@chromium.org,skym@chromium.org Change-Id: Ibde93e22e01f4d3eb8d9eb2a8d4d9c42166ed191 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454653Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e79d255b3b9..025eeee82946 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC vasilii@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1135707 Tbr: vasilii@google.com Change-Id: I65709ccf799796d2babfb32102f263b90bf6fa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455303Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814627}
-
Vasilii Sukhanov authored
This reverts commit de6bbcbc. Reason for revert: Broke SystemWebAppLaunchProfileBrowserTest tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85648 Original change's description: > system-web-apps: better handle incognito in LaunchSystemWebApp > > LaunchSystemWebApp used whatever profile is provided in the parameter to > create SWA windows and launching SWAs, even if the profile may not > suitable to host a SWA window. > > This CL adds logic to determine the appropriate profile if the provided > one is unsuitable. This serves as a mid-term solution for launching > SWAs, and acts as a safety net to prevent chrome crashing if unsuitable > profiles are provided. > > Specifically, it catches these two types of profiles: > - Guest session "original" profile: launch into guest session's > primary off the record profile (which is used for guest session > browsing and SWAs). > - Normal session incognito profile: launch into the original profile, > because we don't support incognito SWAs. > > Fixed: 1109594 > Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814602} TBR=ortuno@chromium.org,qjw@chromium.org Change-Id: Ie46ed4204f9c841be9d4dff8772fd2f9af85c96f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455747Reviewed-by:
-
