GitLab

This CL implements the ContinueWindow on ChromeOS, which will
be shown to the user for confirmation after 10 minutes into a Remote
Assistance session.

To implement the ContinueWindow, this CL introduces a new class
MessageBox, which is a re-usable component built on top of the
widget framework.

BUG=424908

Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d
Cr-Commit-Position: refs/heads/master@{#302657}

Review URL: https://codereview.chromium.org/690183002

Cr-Commit-Position: refs/heads/master@{#302706}

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/700893003

Cr-Commit-Position: refs/heads/master@{#302705}

For multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed.

The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total
height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger
leading to it getting clipped. Example where this breaks is in the message center notifications where the line height
is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better.

BUG=429108

Review URL: https://codereview.chromium.org/692803004

Cr-Commit-Position: refs/heads/master@{#302704}

[Autofill] Autofill fails to show suggestions for suggested input for forms having credit card number split across multiple fields.

BUG=420323

Review URL: https://codereview.chromium.org/622773002

Cr-Commit-Position: refs/heads/master@{#302703}

This will work better with the new 3 part version, where the minor
version is now the 2nd last element, instead of the last.

BUG=

Review URL: https://codereview.chromium.org/681423002

Cr-Commit-Position: refs/heads/master@{#302702}

BUG=374264

Review URL: https://codereview.chromium.org/688403002

Cr-Commit-Position: refs/heads/master@{#302701}

This patch added Observer in FaviconTabHelper, so the favicon retrieved by FaviconHandler could be used right away.

BUG=428218

Review URL: https://codereview.chromium.org/684983003

Cr-Commit-Position: refs/heads/master@{#302700}

Various things (cr.ui.MenuButtons, checkboxes) call .preventDefault()
while handling 'mousedown' events which messes with focus. Account for this.

R=arv@chromium.org
BUG=424475

Review URL: https://codereview.chromium.org/685783003

Cr-Commit-Position: refs/heads/master@{#302699}

In Chrome OS, chrome://help (the About page) redirects to chrome://settings/help.
But the Settings page should not be loaded in Incognito (and
causes the browser to crash).

BUG=426618
R=ben@chromium.org

Review URL: https://codereview.chromium.org/649053003

Cr-Commit-Position: refs/heads/master@{#302698}

This tidies the code up a bit, and I use these interfaces in a subsequent changelist (for EC keys).

The vision is that jwk.h/jwk.cc should just define these two helpers, and all the other algorithm-specific logic (EC keys, RSA keys, AES keys, HMAC keys etc..) is built using JwkReader/JwkWriter, and lives in the algorithm-specific files.

BUG=399094

Review URL: https://codereview.chromium.org/687063002

Cr-Commit-Position: refs/heads/master@{#302697}

BUG=425651
R=eroman@chromium.org

Review URL: https://codereview.chromium.org/689883002

Cr-Commit-Position: refs/heads/master@{#302696}

This is a step closer to the point of making _RunState --> UserStoryState with
the 4 main methods:

__init__ that does classSetUp
SetUpBeforeRunPage that does setUp before each page run
TearDownAfterRunPage that does tearDown after each page run
TearDownAfterRunPageSet that does final classTearDown

BUG=418278

Review URL: https://codereview.chromium.org/692973003

Cr-Commit-Position: refs/heads/master@{#302695}

Previous instrumentations showed that URLRequestJob::NotifyHeadersComplete
alone is responsible for ~57.1 janks per hour in IO thread. I need to instrument
the code inside it to find out which part causes jank.

This is a mechanical change that adds instrumentation required to locate the
source of jankiness (i.e. a long-running fragment of code executed as a part of
the task that causes jank) in the code. See the bug for details on what kind of
jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've
helped to find and fix janky code. The code of the instrumentation is highly
optimized and is not expected to affect performance. The code simply creates a
diagnostic task which is identical to ones created by PostTask or IPC message
handlers. The task gets created only in developer build and in Canary channel.

BUG=423948

Review URL: https://codereview.chromium.org/696483002

Cr-Commit-Position: refs/heads/master@{#302694}

On clang, this flag is a no-op, and Blink code has a long way to go to be
clean with respect to these warnings on GCC toolchains. The GYP build has
never had -Wextra set, so let's just make GN in line with that.

BUG=424334
TEST=try bots
TBR=brettw

Review URL: https://codereview.chromium.org/692313002

Cr-Commit-Position: refs/heads/master@{#302693}

The ShouldHandleRequest call in the handlers is just the
prefix matching, implementing a filter-chain pattern,
and failure is normal.

BUG=None
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/700923003

Cr-Commit-Position: refs/heads/master@{#302692}

the uninstall dialog showing.

BUG=424999, 397396
TEST=ExtensionUninstallDialogViewBrowserTest.TrackParentWindowDestruction

Review URL: https://codereview.chromium.org/697023002

Cr-Commit-Position: refs/heads/master@{#302691}

We might accidentally turn off hardware acceleration in instrumentation
tests without knowing since tests are supposed to work in software mode
as well. So add a meta test to check this.

BUG=

Review URL: https://codereview.chromium.org/687803009

Cr-Commit-Position: refs/heads/master@{#302690}

(This CL is tries to fix http://crrev.com/700503002 that was reverted
due to some failing Android content_browsertests.)

Original message ------------------------------------------------------

YCWebCameraSource.ax causes a huge amount of Chrome crashes. This CL
changes the initialization model of the Device Thread, a.k.a Audio
Thread, from Multiple Thread appartment model to Single Thread model,
MTA -> STA.

We'll monitor the crash rate in the Canaries to see if it has the
desired effect.

BUG=427192, 421991

Review URL: https://codereview.chromium.org/706443002

Cr-Commit-Position: refs/heads/master@{#302689}

This is temporary.

BUG=424024
TEST=
TBR=kbr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/704633002

Cr-Commit-Position: refs/heads/master@{#302688}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/649203003

Cr-Commit-Position: refs/heads/master@{#302687}

Previous instrumentations showed that the jank is in this line:
*data = rb.GetRawDataResource(resource_id_).as_string();
And its average run time is 15.1 ms.
I also know that the expensive operation is outside of ResourceBundle::GetRawDataResourceForScale.
So, we have to suggest that it's indeed copying the string that is responsible for the jank.

BUG=422489

Review URL: https://codereview.chromium.org/702543005

Cr-Commit-Position: refs/heads/master@{#302686}

This change improves responsiveness of chrome UI thread by eliminating wasted work that BookmarkChangeProcessor
does in BookmarkNodeFaviconChanged in a scenario when user initially connects sync to an account with a large
number of bookmarks. This is achieved by ignoring the notification earlier when there is no FavIcon image, before doing any expensive work. Please note that the notification is called twice for each bookmark - first when a change in FavIcon is detected and then when the icon is uploaded to the bookmark model. The change cuts the work associated with the first call on the sync side.

Estimated saving on the UI thread is about 10-12% (as measured by reduction of samples in sampling profile).

BUG=239621

Review URL: https://codereview.chromium.org/661883002

Cr-Commit-Position: refs/heads/master@{#302685}

Code cleanup

Since rasterize_time, analysis_time and rasterized_pixel_count are
no longer used, they can be removed and as a result, a lot of
plumbing to push these stats around can also be removed.

R=vmpstr, ernstm, reveman

Review URL: https://codereview.chromium.org/683863003

Cr-Commit-Position: refs/heads/master@{#302684}

BUG=403419
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/691393002

Cr-Commit-Position: refs/heads/master@{#302683}

users.

BUG=418242

Review URL: https://codereview.chromium.org/509203002

Cr-Commit-Position: refs/heads/master@{#302682}

BUG=422618

Review URL: https://codereview.chromium.org/696543002

Cr-Commit-Position: refs/heads/master@{#302681}

BUG=427719
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/690123002

Cr-Commit-Position: refs/heads/master@{#302680}

BUG=413439

Review URL: https://codereview.chromium.org/690483003

Cr-Commit-Position: refs/heads/master@{#302679}

BUG=429941

Review URL: https://codereview.chromium.org/687653003

Cr-Commit-Position: refs/heads/master@{#302678}

Fix the reference to the sanitizers to not be needed on windows,
and remove a stray reference to a file that doesn't exist any more.

TBR=brettw@chromium.org, scottmg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/694263004

Cr-Commit-Position: refs/heads/master@{#302677}

Review URL: https://codereview.chromium.org/685983007

Cr-Commit-Position: refs/heads/master@{#302676}

This is a companion change to https://codereview.chromium.org/696353005/.

BUG=412374,412376
R=smut@google.com, smut@chromium.org

Review URL: https://codereview.chromium.org/693183003

Cr-Commit-Position: refs/heads/master@{#302675}

This change prevents overwriting a foreign session SessionTab  with a data from another node if the SessionTab we already have has a newer timestamp. This ensures that if there are multiple tabs with the same ID, the tab that we end up associating with a window is the most recent one.

BUG=423501

Review URL: https://codereview.chromium.org/699033002

Cr-Commit-Position: refs/heads/master@{#302674}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/697413002

Cr-Commit-Position: refs/heads/master@{#302673}

Adds a histogram to measure the difference between the bandwidth estimate at 2 seconds and 20 seconds into a WebRTC call.

BUG=425925
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/682813004

Cr-Commit-Position: refs/heads/master@{#302672}

BUG=426640

Review URL: https://codereview.chromium.org/685963004

Cr-Commit-Position: refs/heads/master@{#302671}

This CL adds a new extension API that can be used to implement VPN clients by third party.

BUG=407541

Review URL: https://codereview.chromium.org/671163002

Cr-Commit-Position: refs/heads/master@{#302670}

Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/)

Reason for revert:
It was temporary and no longer needed.

Original issue's description:
> Add logs to debug a flakiness on GPU Mac bots.
>
> This is temporary and will be removed after we pin down the issue.
>
> BUG=424024
> TEST=
> R=kbr@chromium.org
> TBR=dgozman@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0
> Cr-Commit-Position: refs/heads/master@{#302371}

TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/698353002

Cr-Commit-Position: refs/heads/master@{#302669}

Revert of Adding more logs for the browser.GetSystemInfo() random crash. (patchset #1 id:1 of https://codereview.chromium.org/699043002/)

Reason for revert:
This CL was temporary and is no longer needed

Original issue's description:
> Adding more logs for the browser.GetSystemInfo() random crash.
>
> This is temporary - will be removed once we pin down the crash.
>
> BUG=424024
> TEST=
> TBR=kbr@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/c3b22dcdcb90725e9c3d9ffe05847a56e8fd1e10
> Cr-Commit-Position: refs/heads/master@{#302512}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/703633004

Cr-Commit-Position: refs/heads/master@{#302668}

Revert of Adding more logging to see why DevToolsHttpHandlerImpl::BrowserTarget is flaky. (patchset #2 id:20001 of https://codereview.chromium.org/702503002/)

Reason for revert:
It was temporary and no longer needed.

Original issue's description:
> Adding more logging to see why DevToolsHttpHandlerImpl::BrowserTarget is flaky.
>
> BUG=424024
> TEST=
> TBR=kbr@chromium.org
>
> Committed: https://crrev.com/d3ac15e57aade01f1524f554e00c6113e8e9b364
> Cr-Commit-Position: refs/heads/master@{#302453}

TBR=kbr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=424024

Review URL: https://codereview.chromium.org/702773002

Cr-Commit-Position: refs/heads/master@{#302667}