- 08 Aug, 2018 40 commits
-
-
Mike Klein authored
Change-Id: I775a9de0e99e4e45b2facfccb6e79e17c9c41b90 Reviewed-on: https://chromium-review.googlesource.com/1167204 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#581629}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/c7db3232c397aa3feb1d474d63a1c4dd674b6349..6410e18e9190b6b0c71955119fbf3cae1b9eedb7 BUG=none Change-Id: Ib6b65420f57dcffed50898113d7f910ee4a332f4 Reviewed-on: https://chromium-review.googlesource.com/1167469 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#581628}
-
David 'Digit' Turner authored
This is done to avoid a runtime crash at startup when Chrome starts up on devices with a very old Linux kernel. This is only one way to address the problem, but probably the simplest patch to fix it. See bug entry for all details and alternatives considered. BUG=871722 R=agrieve@chromium.org, pcc@chromium.org, thakis@chromium.org Change-Id: I9a197a347538ae9cf9ce6de7b243f522cb425043 Reviewed-on: https://chromium-review.googlesource.com/1167502Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#581627}
-
Jordy Greenblatt authored
The whitelist list irrelevant to the EasyUnlock prefs and we are about to move at least one of them to a new location. Rather than update this unecessary reference, I'd like to just get rid of it before the migration. Bug: 824568 Change-Id: Id9a90fff2139f665c9696f104f45bc6590decb93 Reviewed-on: https://chromium-review.googlesource.com/1166286Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#581626}
-
Xiaohan Wang authored
Also move README.chromium up one level as it's expected by tools/licenses.py. TBR=tinskip@chromium.org Bug: 729194 Change-Id: I52551222bf635d5e525d7baa0580243d0a30aa8a Reviewed-on: https://chromium-review.googlesource.com/1166325 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581625}
-
Xiaohui Chen authored
This makes sure other always_on_top windows won't be covered by the divider. Bug: b:112266826 Test: locally build and start assistant in split view, see assistant Test: window always above divider. Change-Id: I7183a4fc01c1bd831bf73e99d90300b0ea803a7e Reviewed-on: https://chromium-review.googlesource.com/1166255 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581624}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f8335664915c..964e15665fbc git log f8335664915c..964e15665fbc --date=short --no-merges --format='%ad %ae %s' 2018-08-08 treehugger-gerrit@google.com Merge "TraceProcessor: add support for complete JSON events" Created with: gclient setdep -r src/third_party/perfetto@964e15665fbc The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icfacdbc0efed246c419731c0684a8f17afd0ed27 Reviewed-on: https://chromium-review.googlesource.com/1167126Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581623}
-
Robert Ogden authored
Removes the "Offline" string from the XML and moves it to Java to allow it to be chosen dynamically. See bug for more context. Also fixes the text appearance presubmit stuff from https://crbug.com/775198 Bug: 871839 Change-Id: I0973b1e874f48dd4b913bbe1467b245971fdc335 Reviewed-on: https://chromium-review.googlesource.com/1166155Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#581622}
-
Scott Violet authored
This allows for multiple Envs at the same time. Additionally: . NativeWidgetPrivate::CreateNativeWidget: now takes InitParams . NativeWidgetPrivate::IsMouseButtonDown() is now an member function. BUG=847992 TEST=covered by tests Change-Id: Ic35b274c0a927a7c602809a7e611383b5d3dd3e2 Reviewed-on: https://chromium-review.googlesource.com/1166148 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#581621}
-
sczs authored
Bug: 871200 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73ec397b9fcc9d243766753e2251ba261c443022 Reviewed-on: https://chromium-review.googlesource.com/1164256Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581620}
-
Morten Stenshorne authored
Remove InvalidateBackgroundObscurationStatus() from various UpdateLayout() methods, and call it from UpdateAfterLayout() instead. LayoutNG doesn't use UpdateLayout(), but it does still call UpdateAfterLayout() when it has done its layout thing. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3467d3c466e9c02885ffd7153d71f17e2c12da3a Reviewed-on: https://chromium-review.googlesource.com/1166917Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#581619}
-
Wez authored
This test appears to have timing/scheduling-dependent flakes. TBR=miu Bug: 872340 Change-Id: I92a42315b4b5e15bfae88f5b7430b4e0210a3ea7 Reviewed-on: https://chromium-review.googlesource.com/1167560Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581618}
-
Oksana Zhuravlova authored
This change moves the logic from DeviceOrientationDispatcher into DeviceOrientationEventPump and removes DeviceOrientationDispatcher. DeviceOrientationController now uses DeviceOrientationEventPump directly, and a separate instance of DeviceOrientationEventPump is created for every document. Webkit layout tests were updated to reflect this, and webkit unit tests have been updated to use a MockDeviceOrientationController. Bug: 861902 Change-Id: I1c376ec54208abb3fcfb627304f47a4cbd01894d Reviewed-on: https://chromium-review.googlesource.com/1161446 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#581617}
-
Khushal authored
This was used in the code-path where animation of images was driven by blink, which is not the case anymore. R=pdr@chromium.org, ericrk@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1ba09724b87e461e41d0675c9132a0d8fb655dd Reviewed-on: https://chromium-review.googlesource.com/1161562Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#581616}
-
erikchen authored
The method returns an object that needs to be released. All existing callers were failing to do so. Change-Id: Ic50117c3359004b958a6c373ab4acaec826abc0e Reviewed-on: https://chromium-review.googlesource.com/1167365 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Becca Hughes authored
This implements slide #13 of the spec attached to the bug. When we enable the new unified autoplay sound settings UI the sound settings dropdown on the page info UI should have custom wording based on the state of the sound content setting and the unified autoplay enabled pref. BUG=865548 Change-Id: Ib7fcb5625cc9f71add1f84ca5dbf6301aefc1007 Reviewed-on: https://chromium-review.googlesource.com/1158857 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#581614}
-
Sammie Quon authored
This was already happening on tablet mode. Ux said it is ok to match the two now. Also change some values for the header fade in animation. Test: manual Bug: 829292 Change-Id: I428081f0d19d1b8508e8576f5ea8a36e75843e6b Reviewed-on: https://chromium-review.googlesource.com/1164534Reviewed-by:
-
Morten Stenshorne authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib62c9cdd67d33019d2e80df59c2a4ead4357691a Reviewed-on: https://chromium-review.googlesource.com/1165142Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581612}
-
Steven Bennetts authored
This dependency is no longer required, this CL just cleans up some includes and makes a minor change to FakeAuthPolicyClient::RefreshUserPolicy to remove the cryptohome dependency and support tests. For minor fix to chrome/browser/chromeos/policy/ includes: TBR=emaxx@chromium.org Bug: 863439 Change-Id: I519ea33d7e5ad9355c45bfc172f97a4cb51b8122 Reviewed-on: https://chromium-review.googlesource.com/1165491 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#581611}
-
Eric Willigers authored
CompositeOpaqueScrollers has been shipping since M56. https://codereview.chromium.org/2450473002 BUG=644833, 651305 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2efd8b92d96177ebfa45b360c02a5cf5e31a18dc Reviewed-on: https://chromium-review.googlesource.com/1166611Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581610}
-
David Tseng authored
This reverts commit 9871f52a. Reason for revert: <INSERT REASONING HERE> Was not the culprit of failing chromeos dbg SpokenFeedbackTests. Original change's description: > Revert "Always build ChromeVox as compressed js" > > This reverts commit 725ceeda. > > Reason for revert: Broke lots of tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg > > chromevox test: > BackgroundTest.NavigationEscapesEdit > > interactive_ui_tests > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1 > TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1 > LoggedInSpokenFeedbackTest.KeyboardShortcutViewer > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/0 > TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusShelf/1 > GuestSpokenFeedbackTest.FocusToolbar > > > Original change's description: > > Always build ChromeVox as compressed js > > > > ChromeVox can be run as both compressed (minified js) and uncompressed. The latter facilitates faster development. > > > > It appears that in some instances, with the kevin board in particular, gn evaluates the ChromeVox build file incorrectly. > > > > The end result is we end up with both uncompressed and compressed js files in ChromeVox leading to duplicate js objects. > > > > Bug: 868579 > > Test: clean build for > > 1. prior to this patch > > 2. after this patch > > > > Before each deployment, ensure we delete the chromevox folder on-device. This should be equilvanet to a new image. > > > > Change-Id: I64cf826bda9239edc7764ba598bfed6dd0572d56 > > Reviewed-on: https://chromium-review.googlesource.com/1165787 > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581325} > > TBR=dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com > > Change-Id: Ifb3c2556f44b07161f491b18b49d556e364963fb > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868579 > Reviewed-on: https://chromium-review.googlesource.com/1167442 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581564} TBR=avi@chromium.org,dtseng@chromium.org,newcomer@chromium.org,oxyflush@google.com Change-Id: Ifb1ec50fd3cbaa1e0b97a5b5cfdb7b3b9712b353 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868579 Reviewed-on: https://chromium-review.googlesource.com/1167604Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581609}
-
Harald Alvestrand authored
Bug: chromium:653531 Change-Id: I3d9741962cd3845a5f351587509c5beb4e27c796 Reviewed-on: https://chromium-review.googlesource.com/1164949Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#581608}
-
David Tseng authored
This reverts commit feb758c3. Reason for revert: <INSERT REASONING HERE> SpokenFeedbackTests failing on chromeos dbg Original change's description: > Only alert accessibility when a notification's text changes > > Bug: 867426 > Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208 > Reviewed-on: https://chromium-review.googlesource.com/1166231 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581474} TBR=stevenjb@chromium.org,dtseng@chromium.org Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867426 Reviewed-on: https://chromium-review.googlesource.com/1167603Reviewed-by:
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I276f74b89cfaab3b3d45ed1e1d0b335ff6299fae Reviewed-on: https://chromium-review.googlesource.com/1165853Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581606}
-
liberato@chromium.org authored
Previously, VideoFrameCompositor assumed that, if it had a client, that the client would drive VideoFrame updates based on the vsync clock. If an external consumer (e.g., WebGL) painted the frame, VFC would still not update the current frame, since the client would take care of it. VideoFrameSubmitter is a client that sometimes elides frame updates, if it believes that no consumer is present (e.g., if the corresponding SurfaceLayer is not in the layer tree, or is not visible). However, this would break external consumers, since they would no longer get current VideoFrames. This CL allows a VideoFrameProvider::Client to signal that it isn't doing frame updates. In this case, VFC will still try to move the frame forward to match the wall clock, so that external consumers get current frames. Additionally, this CL causes SurfaceLayerImpl to signal that it's no longer visible upon destruction. This catches cases where a video element is removed from the DOM. Bug: 869277 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia53a349af4add6d4792ef16e0306aa7c139ab70c Reviewed-on: https://chromium-review.googlesource.com/1159274Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581605}
-
Joe Mason authored
This is a workaround for assertion failures in debug builds. GetParamNameForTest uses operator<< to format test params, and the wrong override is being chosen for ExecutionMode parameters. TBR=proberge Bug: 872324 Change-Id: Ifc6a561835f61454af54960829a9ceb8303e16f2 Reviewed-on: https://chromium-review.googlesource.com/1167552Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#581604}
-
Ryan Sturm authored
This CL modifies the heavy page load capping strings to match newly defined strings. Bug: 709493 Change-Id: I98a2a091e19db6554f86e10204c345e8f75d0572 Reviewed-on: https://chromium-review.googlesource.com/1161501Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#581603}
-
Alexis Hetu authored
Enable swiftshader on the cast_shell_linux bot. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iea43992a2dad75de479c214cbdfeed8dac0452c8 Reviewed-on: https://chromium-review.googlesource.com/1165883Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581602}
-
Raphael Kubo da Costa authored
Commit b7e7131a ("Introduce EvalJs, a replacement for ExecuteScript and friends") broke the GCC build with the JsLiteralHelper::Convert() overloads for base::Value and base::ListValue: In file included from ../../content/public/test/test_frame_navigation_observer.h:11:0, from ../../content/public/test/test_frame_navigation_observer.cc:5: ../../content/public/test/browser_test_utils.h:416:13: error: explicit specialization in non-namespace scope ‘struct content::JsLiteralHelper<T>’ template <> ^ ../../content/public/test/browser_test_utils.h:421:13: error: explicit specialization in non-namespace scope ‘struct content::JsLiteralHelper<T>’ template <> ^ Since base::Value and base::ListValue overloads are not template specializations anyway, and a non-template overload is preferred over a specialized one, we can just drop the "template <>" part and fix the build. Bug: 819294 Change-Id: I20c4bbed63b2ad7bb3f9146d790159ae1468ece6 Reviewed-on: https://chromium-review.googlesource.com/1167059 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#581601}
-
David Tseng authored
This reverts commit a382e8df. Reason for revert: <INSERT REASONING HERE> Original change's description: > All SpokenFeedback tests hand in ChromeOS dbg. > > TBR=jamescook@chromium.org > > Bug: 872267 > Change-Id: I8ff0cf1d3615bb73c04b5342a96c24f0c914fe75 > Reviewed-on: https://chromium-review.googlesource.com/1167294 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581559} TBR=avi@chromium.org,jamescook@chromium.org,dtseng@chromium.org,futhark@chromium.org Change-Id: Ie0834cb7f690ec20acc426ea05504d478e46604f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872267 Reviewed-on: https://chromium-review.googlesource.com/1167623Reviewed-by:
-
David Tseng authored
This reverts commit e41039e1. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disabled failing chromevox test. > > BackgroundTest.NavigationEscapesEdit fails on linux-chromeos-dbg. > > TBR=dtseng@chromium.org > > Bug: 872258 > Change-Id: I4dc957a290bebb4cfa9d60c0a5240100de111240 > Reviewed-on: https://chromium-review.googlesource.com/1167057 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581543} TBR=avi@chromium.org,dtseng@chromium.org,futhark@chromium.org Change-Id: Iac7ac28fd2734f166515922d28447b29a2d7b6cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872258 Reviewed-on: https://chromium-review.googlesource.com/1167602Reviewed-by:
-
Zhuoyu Qian authored
The TODOs in document_marker_painter.cc have been done, remove them. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If421a709a4ca8fd73c6e9f651a1e3a8e908afdcc Reviewed-on: https://chromium-review.googlesource.com/1166777Reviewed-by:
-
John Abd-El-Malek authored
Per the bug and local testing, this functionality is still needed (interstitials, Android WebView, maybe Android). So implement this in the network service path to achieve parity. Bug: 581037 Change-Id: Ie6415f443ac6327a53841ca9dfa0827b81c8f9e3 Reviewed-on: https://chromium-review.googlesource.com/1164542Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#581597}
-
bsheedy authored
Moves the vr_perf_tests isolate target over to the newer run_performance_tests.py script. Bug: 865533 Change-Id: Ie68eceb2072f55d6ea1a2634ac06b833cd92d886 Reviewed-on: https://chromium-review.googlesource.com/1165694 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#581596}
-
Tommy C. Li authored
When there is a selected keyword label, i.e. "Search Google", we already indent the selected keyword label to align with the suggestions text. Further jogging over the textfield just moves the text for no apparent purpose. This CL fixes that. Bug: 871265 Change-Id: I956577e741359efa8a3293ef160de39f4c2c952c Reviewed-on: https://chromium-review.googlesource.com/1166299 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#581595}
-
Eric Willigers authored
Rendering of Unicode control characters shipped in M56. https://chromiumcodereview.appspot.com/2431603003 https://www.chromestatus.com/features/6232200047493120 BUG=530342 Change-Id: I75520fd466339f91ff98b776b5f5f6bb82cc9c63 Reviewed-on: https://chromium-review.googlesource.com/1166749 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#581594}
-
Mathieu Guay-Paquet authored
Bug: 866462 Change-Id: If09ba70f7c777482fd1225b08047231876c3938b Reviewed-on: https://chromium-review.googlesource.com/1156854 Commit-Queue: Mathieu Guay-Paquet <mguaypaq@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581593}
-
Friedrich Horschig authored
When triggering the search, the whole page would visibly update although the effective query hadn't changed. This is intended for pages where opening the search box already hides certain elements. With this CL, the Site Settings treats no open search and and empty search query as equal search inputs which prevents the rebuild of an unchanged list. Bug: 872198 Change-Id: I1188a28703cdaa99b262900a6edac93d6435e798 Reviewed-on: https://chromium-review.googlesource.com/1167503 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Manu Cornet authored
Note that some polishes are still necessary, for instance when pinning/unpinning items wihtout any reordering, the separator behavior isn't quite right yet. But this is a good first version which is protected by the shelf new UI flag. Bug: 805612 Change-Id: I329050037716a7592ff562c57e33cd641174f73d Reviewed-on: https://chromium-review.googlesource.com/1165595Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is a reland of a9dac60b I added an optional arg to ZipDir not to change zipped path. Original change's description: > Generate deterministic zip file for remoting > > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic. > > This is a part of effort to utilize cache of test execution on swarming. > > Bug: 870611 > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be > Reviewed-on: https://chromium-review.googlesource.com/1163349 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581034} Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official Bug: 870611 Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951 Reviewed-on: https://chromium-review.googlesource.com/1164682Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
