- 10 Oct, 2020 40 commits
-
-
ssid authored
The task execution and log events are handled specially for writing proto arguments because we did not have the support for typed events in base and interning support for the event macros. Now these events can use the new client library API. The events have to be migrated together because the source location interning index is common for all events in the API and does not account for the special handling in event sink. BUG=1136635 TBR=chirantan@chromium.org Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#815911}
-
Caroline Rising authored
This change also updates read later list item button containers to set up for keyboard navigation. By updating the width, overflow, and icon-button-fill-color, the buttons can still exist so that backward keyboard navigation works correctly while not being visible or taking up space when not hovered. Bug: 1109316 Change-Id: I0cdc9f7ad5191b2872962e5d4e08024eeada733c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461936Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#815910}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/0aca3ca9427d..139f5c351e1f 2020-10-10 natsu@google.com Update virlg_hw path to reflect Minigbm If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifab57d321b149fe7be80f81c7a237269a97e4ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815909}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602266368-0e61a032fa7157fa29bc804c0d7295bad87c6193.profdata to chrome-linux-master-1602287771-5a4744893ab8d8351bab84c392978fd4b5e8c1e1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifaaf49a347ffa872fdc319968752faf63dcf6234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463754Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cdf1ab1f8288..781dccef6e13 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128753,chromium:1130700 Tbr: Change-Id: Idf50096e3b18e4068a53e7ffbefc6116499919bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464382Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815907}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d7d0b90f7d38..b073999c6f90 2020-10-09 ehmaldonado@google.com git-cl: Print response content on Gerrit transient errors. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136295 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I9f478d5cb9d9e52a674da0daf182fbb25a7896d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464384Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 51dc8887. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Ib6d71b74e3a7dd47bffbe1ec48ce2a6b058aa1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464166Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815905}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602266368-92d2928e0040ad47ba60bbcac401f36efe1994de.profdata to chrome-mac-master-1602287771-6582fddffd79e54a4c5bb374e875a47a445d5a13.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic4e0c32d888b7aa2c86ca601c6eccb1add299622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464385Reviewed-by:
-
Brandon Jones authored
Removes stage_parameters from VRDisplayInfo and updates the XR frame request loop to exchange an stage_parameters_id to indicate what version of the parameters the session has so that only updates need to be sent. Part of an ongoing process to remove VRDisplayInfo entirely. Bug: 998146 Change-Id: I6f41dc2426b529694903d1e46cdadc16841b2b37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460976 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#815903}
-
James Hollyer authored
We used to only consider filters if they had something to filter. However, this means that if there is a filter with a name prefix we do not consider it as Android does not have a name prefix filter. Since the filters are unioned together, missing a filter could cause results we are looking for to be filtered out. To ensure this does not happen we are adding an open filter to replace the name prefix filter instead of disregarding it entirely. Therefore we never filter out a result which should pass through the name prefix filter. Bug: 1121697 Change-Id: Ib6f4ff52978c62e0a5f16056524459f1116576a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389340 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#815902}
-
Dale Curtis authored
There's no need to keep more than 1 frame if none are effective. If any are effective, there's no reason to keep any of the ones that aren't effective. R=eugene Bug: 1111273 Change-Id: I88bd309f7bc347fbfa84ee5f8a0e40d393a86cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462666 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815901}
-
Tom Anderson authored
The current key translation code doesn't look at the XKB group encoded in the modifiers. This is causing an issue where accelerators don't work in environments that use groups to support multiple layouts. This is a minimal fix so that it can be merged back to M87 and M86. It temporarily reintroduces an Xlib function. R=sky Bug: 1125886, 1136265, 1136248, 1136206 Change-Id: Ic6ac82e2918482652f79b35c5a046f56bf5da760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462490 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815900}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I624dd4ff451e0721cd338d127905de2fbff77fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464283Reviewed-by:
-
Rakina Zata Amni authored
If we've dispatched the 'pagehide' event with the 'persisted' property set to true, we should not dispatch the unload event after that. This is because the 'persisted' property is set to the 'salvageable' status of the page, which also determines whether the unload event is fired. If 'salvageable' is true, 'persisted' will be true and 'unload' won't be dispatched. If 'salvageable' is false, 'persisted' will be false and 'unload' should be dispatched. Relevant spec PR: https://github.com/whatwg/html/pull/5889 More context: https://groups.google.com/a/google.com/g/chrome-bfcache/c/L-ZreZDY4n0/m/jna_jQJkCQAJ Bug: 1110744 Change-Id: I54b44cfdcb6c2922ca57071d695df6c4c2d77d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455510 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815898}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/294729f33cbf..55169d89c60e 2020-10-09 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 15eae87d..9186bb4a (815630:815743) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice1848139b435057aa8df0863279530f9b73fe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463798Reviewed-by:
-
chrome://flagsZhuoyu Qian authored
Has been hidden since M78, so time to remove. Bug: 1110589 Change-Id: Ic195337a541eadfd859022ed7cd49768303b552b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418595Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Dana Fried authored
Previously, the target tab preview size for the tablet (Mohnstrudel) tabstrip was determined by the size of the web viewport. However, the size of the viewport can be affected by the visibility of the bookmark bar, which is dependent on a number of factors including whether the user has opted to enable the bar, whether the current page is the NTP, whether the current page is crashed, etc. That resulted in a situation where the size of the thumbnails in the tabstrip could change as the user switched between tabs. This CL standardizes the thumbnail size to be based on the size of the viewport if the bookmark bar were completely visible, regardless of the current bookmark bar state. The result is that in the event the user has disabled the bookmark bar, the resulting thumbnail may be slightly shorter than it would otherwise be, which can result in a couple of pixels being trimmed off the right and left when the thumbnail is displayed. However, it's extremely hard to notice this slight reduction in fidelity compared to the benefit of having the thumbnail size constantly changing. Bug: 1066652 Change-Id: I05fc47ac6f99e1323ebe682a636151fb81360229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462492 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#815895}
-
Erik Chen authored
This CL has no intended behavior change. This is a prerequisite to passing base::Token as a stable UUID for interfaces. Bug: 1136652 Change-Id: Icab69978c7abc5e88fbb40bfb650fecf08c9e9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461723 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815894}
-
Matt Reynolds authored
content::HidService incorrectly decrements the active frame count when revoking a permission for a device with no open connections. This CL changes the behavior so the active frame count is only decremented if a connection was closed as a result of revoking the permission. BUG=1137031 Change-Id: I686d1e11193991c8e5ddeb7a90d50c77b848fe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463997 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Shrek Shao authored
TBR=kbr@chromium.org Bug: 1135785 Change-Id: If06cf5b8d4d584acd23c768a645d9a23fc82bed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464048Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#815892}
-
chrome://safe-browsing/#tab-rt-lookupXinghui Lu authored
This flag was added for testing purpose. It is now misleading because RT Lookup can still be performed when this flag is false(e.g. for ESB users). The same information can also be checked in chrome://safe-browsing, so this flag is not needed anymore. Bug: 1069651 Change-Id: Ib96f9e456b6477bff77e18f9049309b5d75728b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146795Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#815891}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/793a07e36636..1c25198384e7 2020-10-10 enrico.galli@intel.com Adding multiple of 4 validation on indirect draws and dispatches If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ibee6c61f563c3375251eb8fabdee1dae7cb37d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463073Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/61003cde7688..13fc260c7080 2020-10-09 johnstiles@google.com Reject struct vardecls with modifiers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: Ie67945dbfdf6fed2cbc30de18e804a57e5b5ee59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461133Reviewed-by:
-
Ng Zhi An authored
There was a typo in arch64, the intention is aarch64, and the implementation uses ssat/usat, which is arm (32-bit) specific, and would not work for aarch64. So remove the check (and support) for aarch64. Change-Id: I9985c0c370781a8dcaccf55e2b6f182421848c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440971 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#815888}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/815983783a76..109c355900d1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5af2117f10863c34c9f4e64ae982f9e345678bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464088Reviewed-by:
-
yiyix authored
After the cl, Merge ImageData::data_union into ImageData::data. Some code assume the data type is uint8 array and the size per pixel is 4. I left some TODOs in the code to address all the remaining problems. This cl addresses all issues in image_data and shape_detector. ref cl: https://chromium-review.googlesource.com/c/chromium/src/+/2379653 Bug: 1115317 Change-Id: If46ea1cc6986d8e2c1e4b40e8f98ecd55b31d9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437606 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#815886}
-
Rachel Wong authored
This CL does the following: - Remove the default focus action. This allows ChromeVox to immediately select and read out the notice when the search box is opened. - Make all of the text behave as one entity for ChromeVox, which can also activate it as the link. - Use the AppListColorProvider to get the correct shading color when the close button is focused. This ensures that the color will still contrast with the background in dark mode. Bug: 1112714 Change-Id: I798d532a030a0f331845ab440b8f6aabced46af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463024 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815885}
-
Ahmed Mehfooz authored
Modify mic slider view padding and overall detailed view padding to bring up to spec provided in the bug. Bug: 1086993 Change-Id: I2b8719811070234b9a06694053370bfb8c7eae82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464242Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815884}
-
Sammie Quon authored
Change the capture session widgets to be POPUP. If they are window, they need to be clicked first to gain capture. For example, press and drag of capture button. Then to close, you have to first click the bar and then click the exit button. This happens before this patch, but it is more noticeable with the inkdrop visuals. Change ShouldCaptureLabelEvent so that it can get events directed at it that have no location (ENTER, CAPTURELOST, EXIT). The capture button is now centered in the region if it can be with a minimum amount of padding on both sides. Otherwise it will go on either slightly above or below the region, based on its proximity to the root bottom edge. Test: ash_unittests CaptureModeTest.CaptureRegionCaptureButtonLocation Bug: 1131211 Change-Id: I732a1871120ffa9b9eee4fbadd5361fc9aec0ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427865Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#815883}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/80d095c4dc41..d7d0b90f7d38 2020-10-09 ehmaldonado@google.com git-drover: Fix error printing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1135320 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I029f10f763dccce0abf4519e0971c4bf87c10d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463796Reviewed-by:
-
Leonid Baraz authored
Add ProcessGap entry point to Uploader, so that later on StorageQueue will be able to call it whenever there are no records in the queue that server expects to get, or if records are corrupt (e.g., file was deleted or altered). Currently StorageQueue enumerated records from the first it has and calls ProcessRecord for every one. If something goes wrong, it bails out. The plan is to change it like this in further CLs: 1) Separate last confirmed seq id from the first queue has. 2) If the last confirmed is lower, call ProcessGap for all those that are missing. 3) If anything is wrong, call ProcessGap for that one and switch to the next record regardless. ProcessRecord will add EncryptedRecord with data to the request to send. ProcessGap will add one or more Encrypted records with no data - that seems to be the easiest approach. Bug: b:169248924 Change-Id: I3cd600daf819a5ca8428c79788669be59f6d01dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463766 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#815881}
-
Ahmed Mehfooz authored
Bug: 1136836 Change-Id: I36c98b23b714f36a09c7bce702bf9ef3c5347eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464001Reviewed-by:
-
Pavel Yatsuk authored
This CL: - Introduces MessageDispatcher and its implementation - Makes it available through WindowAndroid, following the pattern of BottomSheetController - Refactors MessageQueueManager removing it from public messages target BUG=1123947 R=lazzzis@chromium.org Change-Id: Ieeece06f4b2f6b31abfd9c6cfd8df5b428076f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446195Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#815879}
-
Akihiro Ota authored
Move method to a utilitiy file, since it doesn't need to be defined on the ChromeVox Next testing class. Bug: N/A Change-Id: I504be13fbaeb1012671102155b460d3cea256515 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461947 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#815878}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1602201537-a14eb3c04e9257cb13970f54aebda7b1af96d2f4.profdata to chrome-win32-master-1602255148-ebeb3da431f3690e2790a05d46a0bb31c66dafca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0e259b7a52c42317d13d7bad6d40147ecc3e5ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463726Reviewed-by:
-
Fabrice de Gans-Riberi authored
* Kill the Session after 10s of no activity in the audio or video stream. * Kill the Session after 5s if no offer message is received. * Fix reporting of messages from unknown namespaces in the Cast Streaming MessagePort. Bug: 1087528, 1087528 Change-Id: I69b44bea3b142e7cf12c32106a279ef37710c56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451525Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#815876}
-
Curt Clemens authored
ReceiveObserver originally had an OnIncomingTransfer method that was called when a transfer update occurred with status kAwaitingLocalConfirmation. Instead, all transfer updates are sent to the mojo interface to facilitate future work. Test: unit_tests, browser_tests Change-Id: I7f57db1b67ccb6fc9c3337419ca236a492d0c53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453914 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#815875}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I06a90eb08ee7445e11f30409420ea5e1bef50aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459266Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815874}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6dc612511e7b..cdf1ab1f8288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lukasza@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093386 Tbr: lukasza@google.com Change-Id: I72bf3937791d0fddc635fa9329683e983a81dd6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463792Reviewed-by:
-
Bo Liu authored
Add an API that allows client to declare the action mode items it wants to override. When overridden, the selected text is passed to the client and whatever the default action in weblayer does not happen. Currently only support search and share since they are always enabled. Bug: b/159070012 Change-Id: Ibabc253a9d990fbf4c1746fd402068df4aeafff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463989Reviewed-by:
-
