- 26 Sep, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7f386135788a..d08de1904727 2020-09-25 vadimsh@chromium.org [lucicfg] Update to v1.20.0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130833 Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: Ia8cd9798a459d78199a70adaa87adcc9fc7f5e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432785 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810888}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I76d57b1c8197cf6386bde982fbce6c65c1559c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432680Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810887}
-
Xiaocheng Hu authored
This patch enables the feature by default following the discussion in: https://docs.google.com/document/d/1L-Aphp1oGwJyPw8k_NEKPPR2siSUc2pBq9bJf7lXFXk/edit The enabled default parameters are: - intervention-mode: swap - lcp-limit-in-ms: 2000 Bug: 1065508 Change-Id: Iac8a1932ad9a4c468011ddf98ad723fe30f96d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430045Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#810886}
-
ssid authored
The Android services use profile key to get provider and the provider in the key should be valid for incognito profile too. BUG=1124790 Change-Id: I392956f2b587fdf82a910a8b7db959c057f81cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432212 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810885}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1601034748-023a9c52685bf2df5bc5619a1b9c5135fdad71eb.profdata to chrome-win64-master-1601066350-377534304780c9dba5c0cc3dbbf14390e280f62b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@chromium.org Change-Id: I40944542dca3a65d91842a9d9d4892513a26f397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432798Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b6c8813f8281..236c96a322d8 2020-09-25 michael.liao@microsoft.com [Accessibility]: Adding alert message to Application Cookies table to read how many cookies are shown after modifying the entries through filters/clear/etc. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1131142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9458449211771d7f076ff3f7dc686822152c6b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432588Reviewed-by:
-
Reid Kleckner authored
This reverts commit 3b4a4ace. Reason for revert: Increases the size of official chrome.dll by 3.5% Original change's description: > Use /O2 everywhere during both PGO phase 1 and 2 > > This greatly reduces object file size during PGO phase 1 (20GB -> 9GB), > and makes the linker use a lot less memory (160+GB -> 7.5GB private > bytes). > > Bug: 1058040 > Change-Id: I7dd433b46afab4b4c52b63d5698c75cad206f407 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427438 > Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810282} TBR=thakis@chromium.org,rnk@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058040, 1132257 Change-Id: Iad463791d95e0172524f229314dfe98b04860553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431703Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#810882}
-
Kenneth Russell authored
Flakiness - sometimes infrequent, sometimes frequent - is seen across a large number of WebGL conformance tests on this configuration. Flakiness is seen in other suites (e.g. validating) as well, which will be addressed in other bugs. Limit the suppression to Android P in case a later OS / driver upgrade fixes this issue. Bug: 1132297 Change-Id: Ib8aa70a29c3aa79e84cb3977d65f25a3510cc7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432320 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#810881}
-
Xiaocheng Hu authored
Now the function always returns false, this patch removes it together with the relevant code paths. Bug: 441925 Change-Id: I1e7974ca4cf376e3fa57d3afd97cf1b82e029594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429530 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Add an IntersectionObserver to the thumbnail bar. When the thumbnails scroll into the observable area, fire an event to request the thumbnail. The requests are not handled yet. Bug: 652400 Change-Id: I6a3dc3ce59304dca20b2d8d828a97e98a3388b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430443 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#810879}
-
Ben Joyce authored
This reduces test execution time from about 14756ms to 6030ms Bug: 989569 Change-Id: Ib7e83e97f4a9814ba964d455d82a40857d698e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429253Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#810878}
-
Lukasz Anforowicz authored
1. In navigation-related cases //chrome layer is able to focus the Omnibox itself, without relying on the //content layer. In particular, //chrome layer can trigger focus changes from Browser::UpdateUIForNavigationInTab or FocusTabAfterNavigationHelper. This assertion is reinforced by extra tests added in this CL, where both of the new test cases provide secondary verification that pressing the Home button ends up focusing the omnibox. 2. Controlling the focus from within the //content layer might lead to incorrectly focusing the Omnibox. In particular, when (before this CL) content::RenderFrameHostManager::CommitPending used to call SetFocusToLocationBar it might get incorrect result from RenderFrameHostManager::FocusLocationBarByDefault because of A) unfortunate timing (last committed entry is not yet updated at the time of RFHM::CommitPending) B) fact that pending entry is missing in navigations initiated via RenderFrameProxyHost See https://crbug.com/1127220#c1 (and c2) for more details. Based on 1+2 above, this CL removes the call to SetFocusToLocationBar from content::RenderFrameHostManager::CommitPending. In the future CLs we might want to explore whether the 2 other remaining calls of WebContentsDelegate::SetFocusToLocationBar are necessary and whether WebContentsDelegate::FocusLocationBarByDefault is necessary. This exploration is not needed for fixing the immediate bug at hand. Fixed: 1127220 Change-Id: I25793ee7eaaa409274c568c35de06c15cd3ad343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425189 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#810877}
-
Eugene Zemtsov authored
1. media::OpenH264VideoEncoder hidden behind the build flag 2. webcodecs/VideoEncoder using it when accelerated implementation is not available. 3. webtests exercising it TBR=ssilken Using TBR here, because neither Sergey nor Erik are apparently Chromium committers and can't give an official +1. (even though they're OpenH264 owners). Sergey already left LGTM in the CL comments. Bug: 1127073 Change-Id: Ida865f5fb8973999a75e15f488fc9df1d9506b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425293 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810876}
-
Findit authored
This reverts commit b01abc31. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810835 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwMWFiYzMxZjNlOWYzMjM4MzlkYjRmN2RmMjM1MjdmY2ZhYTA5ZTQM Sample Failed Build: https://ci.chromium.org/b/8868141438660196432 Sample Failed Step: compile Original change's description: > [Sampling profiler] Factor out platform config 1/4 > > First in a series factoring the ThreadProfiler platform specific > configuration state from the code that takes action on the > state. Defines an IsSupported function that is true if the profiler > is supported on the chrome branding and channel for the platform. > > The end goal is to reduce the configuration complexity, to support > enabling per-thread on Android. > > Bug: 1129939 > Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165 > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810835} Change-Id: Idab7058fe3be31bb32bc88a95a8495a9b8dbf525 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432998 Cr-Commit-Position: refs/heads/master@{#810875}
-
Miguel Casas authored
HDR on ChromeOS seems to be broken on ARM(see bug); this CL disables it temporarily while we investigate it further. Bug: b/168843009 Change-Id: I76ce22548333964ad3894ed80c7e12240e4f2ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432606Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Stéphane Marchesin <marcheu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810874}
-
My Nguyen authored
Strings approved in http://go/cros-lang-settings-ux-writing Section view: http://screen/BQWLKSCr6tudDgb Input page view: http://screen/4N3hdkbaY3VXUfx Add input methods view: http://screen/93hVrNBNmrftn7w Bug: 1113439 Change-Id: I745d637a84f1e1237bf0838d96c6da1f318dcc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430689Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810873}
-
Mark Pearson authored
This was a cut and paste error introduced in https://chromium-review.googlesource.com/c/chromium/src/+/2421823 Bug: 1088801 Change-Id: Ife8239007f1b18b7202e1f7320e1a4dd4558309f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429506 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810872}
-
Ana Salazar authored
Holding space should not show downloads that were created before the first time it was enabled. We cache the time it was first enabled in a pref and we use this to set the time requirement validity only for downloads. We also moved from comparing the file creation time to comparing the download end time. Bug: 1131273 Change-Id: I2b44f4796897aaaf9846a53ea66f9ff36c2392cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426769Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#810871}
-
about://flagsCollin Baker authored
Fixed: 1110660 Change-Id: Ie6cd44d078765f880c645f4bc6d21ca35d5bdc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432745 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810870}
-
Christos Froussios authored
The removal of the migration code will follow: crbug.com/950269 Bug: 1117095 Change-Id: I20e0f926163eb0c47298d448538774b06180219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428326Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#810869}
-
Reilly Grant authored
This reverts commit 35f83455. Reason for revert: This appears to be tickling a udev bug which causes crbug/1121007. Original change's description: > Use UdevWatcher to filter USB, HID and serial devices > > UsbServiceLinux, HidServiceLinux and SerialDeviceEnumeratorLinux each > only care about devices from a particular subsystem. This change avoids > processing other devices which should decrease the time it takes to > perform the initial enumeration. > > Change-Id: I3535b5e6ecbb8c013957197cff151011a19a6097 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227094 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774416} Bug: 1121007 Change-Id: Ic6a69eb2bf3825ecbc9cb310bc71eb37d647d1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429232Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810868}
-
David Grogan authored
When an item with an aspect ratio stretches to the container's cross size causing the item's cross size to be considered definite, the flex base size can be computed differently. Specifically, the flex base size calculation could fall under the purview of https://drafts.csswg.org/css-flexbox/#algo-main-item part B, which requires the item to have a definite cross size. Both chrome 86 and firefox 82b2 get this wrong. Bug: 704294 Change-Id: I8410be91d3006ee9d055562887fc5c3fe7b9aa5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428164Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810867}
-
Robert Ma authored
Stub out _check_that_all_ports_are_available to always return True so that the tests won't fail if some process is already listening on a port used by the server. Note that there might be a deeper issue that something else is listening on these ports. These unit tests themselves use MockHost and would never start the real server. Reduce the numbers of expected log entries by 1 as we no longer have the "DEBUG: all ports are available" message from the real _check_that_all_ports_are_available. Bug: 1114320 Change-Id: I5dfa98cabb5c0bb85a6f304b069240836af60f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428740 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810866}
-
Matthew Denton authored
These wrap the process_vm_writev() and process_vm_readv() syscalls which write to another process's memory (as long the caller has ptrace privileges for the target process). This is necessary for the USER_NOTIF broker to read syscall params and write to syscall outparams. Bug: 1117351 Change-Id: I5b85884eb7f7545598affe91f3e4ec4cb6a569b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407010Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#810865}
-
Moe Ahmadi authored
Canary experiment: cr/329566898 Bug: 1096615 Change-Id: I8d75aec33c254d3aabe8ca8efae360c60e44a3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431462 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#810864}
-
Hidehiko Abe authored
This is preparation to share XkbTracker with wayland IME server. BUG=1123705 TEST=Built locally. Run exo_unittests. Change-Id: I7859c2193578cc5a18fa39a96c3fe86d2f39f4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428505 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#810863}
-
Istiaque Ahmed authored
This CL changes the constructor to take BrowserContext instead of ServiceWorkerContext. Typically, BrowserContext (Profile) is readily available in tests, so it makes the test code using the observer a bit straightforward to read. Bug: None Change-Id: Ife88eaf1d82708c9675f6d917b59a51d8777bdd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432806Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810862}
-
harrisonsean authored
Make the omaha checkNow function static Bug: 1078782 Change-Id: Ia5c5c4e60b145ccb4fa306c64461654455040f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431945Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#810861}
-
Lei Zhang authored
Calculate |kBackoffPolicy| on first use at a local scope instead. Because base::TimeDelta::InMilliseconds() and friends are not constexpr, a global that calls them must do so during process startup. Remove deprecated DISALLOW_IMPLICIT_CONSTRUCTORS() usage along the way. Bug: 537099 Change-Id: If1680816bc18107f7b15e366e205b409c92bf0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430299Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810860}
-
Robert Ma authored
These two fields have long been required and are now enforced in Chromium. Note that in the API these are represented as labels with specific formats. Also add "Test-WebTest" label by the way. Bug: 1132456 Change-Id: If8c226472f62a563a6f25f393e9dda563970de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432055 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Adds unit tests which verify propagation of messages and channel events through FIDL/Blink and Blink/FIDL adapter layers. Fixes a FIDL flow control bug and adds a regression test for it. Add test main.cc for tests which depend on an active Mojo instance. Bug: 1117518 Bug: 1126571 Change-Id: Ied814298b82f9e5eef1e99b158b45bfdd9d1fd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422476Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810858}
-
Xing Liu authored
If stopForeground is called between startForegroundService and startForeground. startForeground will not be called since we clear the cached service object. This will lead to a crash on O_MR1+. Android can reuse the service binder object when this happens. Bug: 1121096 Change-Id: Ic4088af174ca9561714442b29c2e6162995ddc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429635Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810857}
-
nuwanda authored
Change-Id: I199e2094d287748774cdf1f9930e2720ca3a3aa9 Bug: 1119834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390201Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#810856}
-
wutao authored
This patch adds a transform animation to scroll the long text in the media info. Text will stop a few seconds before scrolling. Bug: b/167236615 Test: added new tests Change-Id: I4c79b5e4a150dbe6d02b5d602af8b2d202e0f065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411545 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810855}
-
Daniel Hosseinian authored
Handle messages requesting thumbnails from the PDF plugin. OutOfProcessInstance provides the callbacks for responding to the requests when the thumbnails are ready and passes the request to the PDF engine. Bug: 652400 Change-Id: I2ed5acfa4fcfbb0167a38a6149017756f44c36d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336312 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810854}
-
Nnamdi Theodore Johnson-Kanu authored
- Creates an interface (delagate) which provides alternate UI behaviors for the Cellular Setup flows. - Cellular setup UI is embedded in either OOBE or os-settings, the delegate implements functionality depending on where it is embedded. - Creates a default implementation of delegate interface in os-settings - Updates cellular_setup ui test and adds fake_cellular_setup_ delagate screenshot: https://screenshot.googleplex.com/4qdJyUh4yx52iGa.png Bug: 1093185 Change-Id: Ifd604c8bb57643520ee69f36378053b60e09c822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419631 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810853}
-
Tomasz Wiszkowski authored
Bug: 1106109 Change-Id: I48afdd0a754f11681520e4c8eb581d082102fddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431780 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810852}
-
nuwanda authored
The script runs TBMv3 metric and the corresponding TBMv2 metric on given traces and compare the results. If the metrics are equal than the newly added TBMv3 metric is the same as the old TBMv2 metric. If the results are different the script will output trace files and json files (results of run_metric) so the user is able to debug analyse them. Example usage: tools/perf/validate_tbmv3_metric --tbmv3-name=uma_metrics --tbmv3-histogram=graphics_smoothness_percent_dropped_frames_compositor_thread_universal --tbmv2-name umaMetric --tbmv2-histogram=Graphics.Smoothness.PercentDroppedFrames.CompositorThread.Universal Now a path to a file with trace link is required. We plan to automate the process of getting trace links in the future. Metric units are also ignored in this change. We plan to integrate units support later along with other fancy statistics about metric values. For more information, see https://docs.google.com/document/d/1wI1gk5X2-eQk9-NLHSK_EgmVs-doyyodz0XtP7Pd15M/edit?usp=sharing Change-Id: I4ca068357a9a0c0f9a5cd5267c64aa53acfe8513 Bug: 1128919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413492Reviewed-by:
-
Ben Pastene authored
Bug: 1132373 Change-Id: I2490fcea413a338cd8ecebc19c4ab25680a53e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432127Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#810850}
-
Brian Malcolm authored
This is the UI name of the entity that manages device's domain, which caneither be a domain name (foo.com), or the admin's email address (user@foo.com) BUG=chromium:1081272 Change-Id: I5d1adcf4182bf3beb3dfc05980106efbc88af53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431457Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#810849}
-
