- 17 Sep, 2019 40 commits
-
-
Xianzhu Wang authored
After http://crrev.com/c/1799701, mask layers are managed as normal layers in LayerTreeHost and LayerTreeImpl, so when we want to iterate all layers we can just iterate LayerTreeHost or LayerTreeImpl without needing to deal with mask layers specially. Bug: 994361 Change-Id: Id8d16fd68829aa18f45a774da516ce6da7e9eb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802377 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697345}
-
Adam Ettenberger authored
This change is an optimizaiton for UIAs GetEnclosingElement. The cost was in calling |LowestCommonAncestor| because it would compute multiple parent AXPositions until reaching the common anchor. Creating a parent Text position is expensive because it calls |MaxTextOffset|. GetEnclosingElement didn't need an AXPosition so to reduce that cost a new method |LowestCommonAnchor| has been added which returns the AXNodeType* that we can use to find the relevant AXPlatformNodeDelegate to do our work on. |LowestCommonAnchor| may also be used to optimize other similar APIs which don't necessarily need an AXPosition object. In order to derive the AXTreeID which is necessary to find the correct AXPlatformNodeDelegate, AXNode::OwnerTree now exposes its AXTreeID. This way we can know what the AXTreeID is for an AXNode of an AXNodePosition anchor. This is already easily accessible from the other position type BrowserAccessibilityPosition, since BrowserAccessibility has access to the relevant AXTreeData. Now anchors of both position types can know what the relevant AXTreeID is for creating delegates! I measured the perf difference with std::chrono::high_resolution_clock on an unoptimized debug build. With a document that contains 2 columns of 100 divs each, and a single leaf text child in each column, and a text range that spans between the two columns. Without Patch : 439.006ms With Patch : 0.1371ms Bug: 928948 Change-Id: Ic9648ff34c7c7030c299c8484fb188a873e3af92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790066 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697344}
-
Henrique Nakashima authored
This reverts commit c1d1e24a. Reason for revert: Breaks internal bots, crbug.com/1004913 Original change's description: > Move IntentUtils to chrome/browser/util. > > Bug: 995916 > Change-Id: I0a0a14719546f8468d4a25482b3ea162def9508e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774268 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697276} TBR=dtrainor@chromium.org,twellington@chromium.org,hnakashima@chromium.org Change-Id: Id6e60e9f6e1fd48d57e39bed52f407cd6014cb07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809648Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697343}
-
Theresa Wellington authored
Move classes from chrome/android/.../widget: - animation.* - displaystyle.* - TintedDrawable BUG=951455 Change-Id: I069efffffff38bf26b16cba4eee3b461aca0cb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804221 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#697342}
-
James Cook authored
Many of the tests that load the entire settings page have flaky timeouts on the debug builders. We suspect this is because the main settings page takes a long time to load in debug. Since these tests are primarily exercising JavaScript code, our team decided to just run them in release. This provides most of the value, and means that sheriffs won't accidentally disable the test globally for debug-only flake (which has happened before). Bug: 1003483 Change-Id: Ia8577faa9b2558b2f467ac3ee5cf5cd701fc7e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808183 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#697341}
-
Yann Dago authored
The traffic_annotation_auditor treats the lack of output from the traffic_annotation_extractor as nothing to check. This means some CLs skip the CQ check, if they only remove annotations. It should still check the annotations for removed annotations if the extractor successfully ran. Change-Id: I47536e1b706efd8f391448a599b2e1d1c87a3400 Bug: 1001108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804330Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#697340}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/809198edfff4..9fa8ef1f4f9a git log 809198edfff4..9fa8ef1f4f9a --date=short --no-merges --format='%ad %ae %s' 2019-09-17 mbonadei@webrtc.org absl::make_unique presubmit check. 2019-09-17 mbonadei@webrtc.org Use std::make_unique instead of absl::make_unique. Created with: gclient setdep -r src/third_party/webrtc@9fa8ef1f4f9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I5d67e2749bfb92805ef1b091d6a3a6db81c6bb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697339}
-
Aaron Leventhal authored
We are missing this property. It may help VoiceOver not repeat labels while the user navigates, but this is just a guess. We had the code to support the property, but weren't listing at as supported for anything. Bug: None Change-Id: Iea00480e581e62d8127a24c18da4d4a6d3b7b15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774329 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697338}
-
minch authored
Bug: 1002733 Change-Id: Ia298bce1dd101fbb96af3d066ac4a04f05789013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797462Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#697337}
-
Andrew Xu authored
Fix another two tests which are broken with the flag enabled: (1) ShelfTooltipManagerTest.HideForEvents: The event generator fails to reset the mouse button. (2) ShelfWidgetTest.LauncherInitiallySized: It assumes that the shelf widget's bounds are identical with the bounds of the shelf view. However, it is incorrect with the scrollable shelf enabled. Bug: 1002576 Change-Id: Ia573eef66a25b73e45b9b69e0e435320b2f07eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808459 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697336}
-
chrome://flagsAlexander Timin authored
Add chrome://flags entry to allow pages controlled by a Service Worker to be put into back-forward. This support is highly experimental, so please use with care. In order to make this possible, BackForwardCacheWithServiceWorker feature is replaced with a parameter on BackForwardCache parameter. R=arthursonzogni@chromium.org Change-Id: I741aefed9a54f87a4c6ece2003be0e8664ddd470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807328 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697335}
-
Filip Gorski authored
This reverts commit 3088e438. Reason for revert: Breaks android-archive-rel builder https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/4749 Original change's description: > Move chrome/lib/image_fetcher to chrome/browser. > > Clank HOA Lite specifies features should be in chrome/browser rather > than chrome/lib. > > Bug: 995916 > Change-Id: Ie2b91869a46d5fad8ea6daa92f479cacfeedb53d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801803 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Brandon Wylie <wylieb@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697310} TBR=yfriedman@chromium.org,wnwen@chromium.org,dtrainor@chromium.org,twellington@chromium.org,wylieb@chromium.org,hnakashima@chromium.org Change-Id: Ie6064045085362a7accf7c9d18359467873617bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808487Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#697334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87be585106e6..95dfac5bc324 Created with: gclient setdep -r src-internal@95dfac5bc324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifd3a42a8d51ddaabbe3005e620b7730edeb26813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808375Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697333}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Id6b2e31c1176244a50e718d0fd283ca2fe9403e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809400 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#697332}
-
John Budorick authored
Bug: 922145 Change-Id: If75f7fd57e5331d63c7ced74aa014934bb21d2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796447 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697331}
-
Tomas Popela authored
It's because GCC has problems when mixing the alignas() together with __attribute__() (that is used to export the symbols). The best solution is to use ALIGNAS() macro from //base/compiler_specific.h together with alignof() to have the equal functionality that compiles on GCC as well as on clang. Bug: 819294 Change-Id: Ieb169592a2965f17a18bfc88d28418eb723a4e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806735 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697330}
-
Bill Budge authored
- Implements the move constructor and assignment operator to zero bytes_size_ and storage_type_. Otherwise clients checking for empty BigBuffers by examining the size() may try to use an empty BigBuffer (where data() == nullptr). Bug: chromium:992991 Change-Id: I23c8d8db35de76762606ecd488cbebfe1ac42ae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803136Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#697329}
-
Peter Kotwicz authored
BUG=None Change-Id: I7348eb18a4c93b026222757e9a85503c538378d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808789Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697328}
-
danakj authored
The CreateRenderView IPC comes with a set of VisualProperties for the local main frame, and they should be set on the RenderWidget similar to how we do so for the CreateFrame IPC so that blink reads valid things off the RenderWidget while it exists and is not undead. However when the RenderWidget is undead, there is no local frame, so stop calling OnSynchronizeVisualProperties. The VisualProperties will be passed along in the future with CreateFrame in that case and set when the RenderWidget is reanimated. We must not call UpdateWebViewWithDeviceScaleFactor() after calling OnSynchronizeVisualProperties() as it dirties the compositor state, and Android WebView expects the compositor state to be clean when it sends an IPC to set the base background colour. The OnSynchronizeVisualProperties() does a Resize of the WebView which runs the document lifecycle and cleans the compositor state. So this also removes the call to that from RenderViewImpl, and places it with the OnSynchronizeVisualProperties call in RenderFrameImpl. The true purpose of UpdateWebViewWithDeviceScaleFactor() is to propagate the page zoom factor down to a new LocalFrame, and so it only needs to be called when the main frame is local as well. R=erikchen@chromium.org Change-Id: Idd06d7af65ebd01ceec03ec9591445eb7805f413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805873 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697327}
-
manuk authored
Bug: 1004857 Change-Id: I79c0507702ce816ea472943b72418273a468de62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808806 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#697326}
-
Chris Palmer authored
Use terminology consistent with the literature. Bug: None Change-Id: I3bcb1a747f23ad9418695926107b57eaa097ad41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808303Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697325}
-
Morten Stenshorne authored
NGPhysicalLineBoxFragment::ScrollableOverflow() compared the computed style passed as container_style to the computed style of each child, and it would calculate the child's relative offset only if they differed. All element nodes have their own computed style, so this only mattered for text nodes. However, if the container was an anonymous block, they'd always differ, since the computed style of a text node is the same as that of the parent DOM node. This is an implementation detail; we save some memory by letting text nodes share computed style objects with their containing DOM node. But that also means that extra care is required when working with ComputedStyle objects associated with text nodes: basically, treat all non-inherited-by-default properties (such as 'position', 'top' and 'left') as if they were set to their initial value. Bug: 1002485 Change-Id: If77d79e45c2aa55ac30dc239c738e2a40f8326f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807813Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#697324}
-
Xida Chen authored
The overflow regression tests was not moved because of this example: https://chromium-review.googlesource.com/c/chromium/src/+/1804695 Firefox falls partially for some cases in perspective interpolation, where the expectation is 'none' and Firefox produces 0px. The spec says the value must be either 'none' or positive values. Bug: 900581 Change-Id: I8562cd51476178919ecf9a393f0d169eb7244461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808585Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697323}
-
Tommy Nyquist authored
Discussed offline with pkasting@ regarding protobuf ownership. Long term owner of protobuf related projects, and we should share the load of protobuf rolls and reviews. BUG=None Change-Id: I36a636bcdb2c2db87e8d20b77524ce54177b813b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808794Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#697322}
-
Min Qin authored
These variables are now redefined in DownloadUtils Change-Id: Id5fe3a276c1ce5f8add8a9b1906ea3573b023565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808795Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#697321}
-
Jenny Zhang authored
Since SearchResultTileItemView will not be destroyed but instead becoming invisible when user closes the suggestion window or launcher, we need to clean up the impression logging timer and other transient objects when the view becomes invisible. Bug: 1004553 Change-Id: I72ae20f8663b50b0bd6c1515c60c71c6f0411369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808791Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697320}
-
Tommy Nyquist authored
The experiment is only now slowly reaching stable channel, so we need to keep these metrics around for a bit longer. Since this is related to updates and users are only told when they are out of date, this experiment takes longer than usual to get numbers for. When the next expiry timeline approaches, we should take stock and figure out whether there are any of the metrics that should be kept for longer, or if they should all be removed. Bug: 1004477, 1004478, 1004481 Change-Id: I2a93d6a678186585adb0060c5370c26b7d73e2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807523 Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697319}
-
Findit authored
This reverts commit 75273409. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 697311 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc1MjczNDA5MjdmNjdmYTM2NDg0ODU3MjZmMTc2ZGVmNWJlOWU1NjIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-archive-rel/9086 Sample Failed Step: compile Original change's description: > Remove DRP Pingbacks > > Removes all the pingback code. There's still some stale code left but > that's all related to v1 HTTPS Server Previews which will be removed > soon. > > Bug: 957753 > Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697311} Change-Id: I9ff1cc1eaa35fc63e0c4b5528b5d7d7ddbbaca27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 957753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809453 Cr-Commit-Position: refs/heads/master@{#697318}
-
Lucas Furukawa Gadani authored
This CL Converts the SimpleURLLoader to use the mojom URLResponseHead struct instead of the native ResourceResponseHead struct. Change-Id: I016b0731930b4589ba6169aa2e24ad45dc6675cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790273Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697317}
-
Zhenyao Mo authored
This reverts commit a4dd23fd. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1004879 Original change's description: > [base] Ensure that tests don't change the thread priority. > > This CL verifies that the thread priority is normal when a test process > is launched and before/after each test. The goal is to avoid having > tests that assume they run at normal priority be disabled because of > other misbehaving tests (e.g. https://crbug.com/931706). > > Bug: 931706 > Change-Id: I5ca18b87720b5305285be481f7b60ff5c941a324 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804786 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697261} TBR=sky@chromium.org,gab@chromium.org,thakis@chromium.org,fdoray@chromium.org,michaelpg@chromium.org,eseckler@chromium.org Change-Id: I900562585a34cd92a4f49a215d7c323706ce468d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931706,1004879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808814Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697316}
-
Xianzhu Wang authored
In layer list mode, we treat a mask layer as a normal layer, except that the masked layer is forced to create render surface, and the mask layer blend on the masked layer in kDstIn blending mode. Now we treat mask layer in layer tree mode in the same way. Bug: 1003414 Change-Id: Ieb67009f4f2ae8faf9b7adf8195499649413238c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799701 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#697315}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/818d963727de..142664633e0b git log 818d963727de..142664633e0b --date=short --no-merges --format='%ad %ae %s' 2019-09-17 seanabraham@chromium.org chromeos_config: mark samus-kernelnext as non critical 2019-09-17 saklein@chromium.org Build API: Cleanup compile script output. Created with: gclient setdep -r src/third_party/chromite@142664633e0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia6be428d1b274d6f7dc15f176a1abbb41e28113c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697314}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2c210a490857..6f9a0238ce40 git log 2c210a490857..6f9a0238ce40 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6f9a0238ce40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I0bf84caff08c4a5031440ffbf4655d9387255934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697313}
-
Matt Mueller authored
Bug: 973650 Change-Id: I44a49aa98ba3e35a5f4edff9e60fa16d7948d5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674443 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697312}
-
Robert Ogden authored
Removes all the pingback code. There's still some stale code left but that's all related to v1 HTTPS Server Previews which will be removed soon. Bug: 957753 Change-Id: I4d5cccd5e402a786c49b8ea1c5b1d95a396f8850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807962Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#697311}
-
Henrique Nakashima authored
Clank HOA Lite specifies features should be in chrome/browser rather than chrome/lib. Bug: 995916 Change-Id: Ie2b91869a46d5fad8ea6daa92f479cacfeedb53d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801803Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697310}
-
Dan Beam authored
R=mahmadi@chromium.org BUG=969062 Change-Id: Ib07f2a73193cd72f5703315a886c222b7ec7a56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808322 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#697309}
-
evliu authored
This CL contains the following changes to the a11y_page: * Updating the Captions button icon to use the external icon for MacOS and Windows. * Rearrange code so that there is only one default route path and place everything except for templates with their own route path in the default route. * Move the Captions button inside the settings-animated-pages. This fixes a focus glimpse when tapping on the Captions button using a touch screen device. * Move the Captions subpage template below all of the buttons. Bug: 971264 Change-Id: I354373f5715153fb3a89745dc88e12dedde80020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799304Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#697308}
-
Bo Liu authored
Allow WebLayer to switch between SurfaceView and TextureView at run time. Add a separate demo shell to host an apk with some fancy animations. Also add a smoke test that does not actually verify anything. Change-Id: I4544b675cec04d01fd60b3c27fac603a0b6a0f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807577Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697307}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e7a75776335a..0d73796b0f7d git log e7a75776335a..0d73796b0f7d --date=short --no-merges --format='%ad %ae %s' 2019-09-17 cferris@google.com Merge "Use bionic platform headers." Created with: gclient setdep -r src/third_party/perfetto@0d73796b0f7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ief9104d3429a19ad1c0b3670a62f810f06ec5709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697306}
-