GitLab

The tests are similar enough that differences can reasonably be
handled by build flags.

Change-Id: I257fb4aebf47cc7e5c67a2965e64dbb90d8a7007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097557
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749194}

TBR=hkamila@chromium.org

Bug: 856601
Change-Id: I516f5039cb227c098977a8645dbe0bebe2d57cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098112Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749193}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55e502897c6e..6a14c8da7c4d

git log 55e502897c6e..6a14c8da7c4d --date=short --first-parent --format='%ad %ae %s'
2020-03-11 jacktfranklin@chromium.org Allow third_party DEPs to be exempt from import rules
2020-03-11 tvanderlippe@chromium.org Add e2etest to verify removal of pseudo states works

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@6a14c8da7c4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0d060848de576d4344c0ffb6262163d133091183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749192}

ExternalNavigationHandler currently directly calls into
IntentWithGesturesHandler when launching an external intent with a user
gesture to record that fact in case the intent ends up coming back into
Chrome. This is //chrome-level behavior, as it is relevant only in the
case where the app handles incoming intents. In addition,
IntentWithGesturesHandler would not be straightforword to componentize.

This CL abstracts this dependence through ExternalNavigationDelegate,
similar to how we have done for other such dependences.

Bug: 1031465
Change-Id: I2138400f7a62d1911073b1fd7b31ef484e7fbc17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095130
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749191}

`_framework_headers_config` is needed by `_framework_public_config` for
the `framework_dirs` variable, even if no `public_headers` defined.

Introduced by https://crrev.com/c/2061194.

Change-Id: I82964f1266aa7c1764f33912b02b48ddf7677ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098155
Commit-Queue: Bang Lee <banl@microsoft.com>
Auto-Submit: Bang Lee <banl@microsoft.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749190}

This CL records a user action when the user navigates to
chrome://settings/syncSetup/Advanced. This metric is needed for sync
setup friendly settings.

Bug: 1050070
Change-Id: I6206807fd8038385f8cd9d8b9fe1d7e0077c9a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096441Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749189}

TBR=hkamila@chromium.org

Bug: 1060175
Change-Id: I14d9e16673932cf153998d388109d37d898a1720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098106Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749188}

https://crrev.com/c/2087623 wasn't rebased properly which caused
browser_test failures. This CL uses the new testing helpers which
fixes these issues.

Bug: 1047726
Change-Id: If1cccf27566019753b200e63966e2d756f40d745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093442Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749187}

BUG=None

Change-Id: I91ef942b5349e1682660b3040a89d3fc7ecfe425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094000Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749186}

This reverts commit 21285304.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Make the coverage config reusable for generic profiling."
>
> This reverts commit c7695f63.
>
> Reason for revert: Possible reason for win10_chromium_x64_rel_ng failing builds with error:
>
> lld-link: error: undefined symbol: __llvm_profile_dump
> >>> referenced by .\..\..\base\test\clang_profiling.cc:23
> >>>               obj/base\base/clang_profiling.obj:(void __cdecl base::WriteClangProfilingProfile(void))
>
> Original change's description:
> > Make the coverage config reusable for generic profiling.
> >
> > Most of the coverage configuration can be re-used for general
> > Clang-based profiling (e.g. the profiling step of a PGO build).
> > This changes most of the |use_clang_coverage| checks to
> > |use_clang_profiling|.
> >
> > The toolchain opt-out option is still limited to the coverage
> > builds (grep for "toolchain_use_clang_coverage" in CodeSearch).
> > I.e. targets built simply with |use_clang_profiling=true| won't
> > be opted out by the clang_code_coverage_wrapper.py script.
> >
> > This CL is a pure refactoring with no functional change.
> > Getting profiling information from the sandboxed renderers work
> > this way:
> > - After creating a new child process the browser will open a
> >   profiling file for this process and pass the handle to the
> >   child via the SetProfilingProfile Mojo call (see change in
> >   content/browser/renderer_host/render_process_host_impl.cc).
> > - This process will used by the LLVM instrumentation to record
> >   profiling information.
> > - When terminating, child processes will call
> >   WriteClangProfilingProfile to write the data to the profiling
> >   data file.
> > - Once all the raw profile data files have been collected,
> >   they'll be merged (via the "llvm-profdata" tool) and used.
> >
> > Note that this isn't meant to be enabled into any build that
> > will be shipped to users (a profiling build is usually 10x
> > bigger than a normal build anyway, not really shippable).
> >
> > The goal of this refactoring is to make it possible to reuse
> > this mechanism for the instrumentation step of PGO builds.
> >
> > Bug: 1058979
> > Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> > Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#749015}
>
> TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org
>
> Change-Id: I6aaf638f6385afe35c488575aac84e3e952b76a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1058979
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096332
> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749040}

TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org,jshikaram@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058979
Change-Id: I5492c81b707e5741bd7c494893e3bc7953221263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097305Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749185}

Adds tests to ensure that about:policy loads properly and that policies
are parsed properly out of NSUserDefaults.

Adds EG2 helpers to retrieve policy settings from the current platform
policy provider.

BUG=1024115,1027249

Change-Id: I9835d106c873efa020293bfff4d59f0feb47abe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088532
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749184}

Start using FileSourceRequest for download deep scanning, since it
achieves most of the same functionality. This CL moves the encryption
checks into the FileSourceRequest, since those are needed by both upload
and download deep scanning.

Bug: 102710
Change-Id: I5b4e1983bd108c6454908586e52f8f2ad2dadcb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095775Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749183}

Change-Id: Id71c80eb058ddd35ecda8156a2faf742d25faf24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095536Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749182}

This directory may not exist for a user. PathService's contract is that
it either returns an empty path or it returns the path to a dir that
exists, so it must enforce that.

BUG=1053446

Change-Id: I56a187039363f1b76306a3914e7dc73ad3c2737d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096681Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749181}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ea855dea97e..6ad2153566cc


Created with:
  gclient setdep -r src-internal@6ad2153566cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ie86bfbf1e2e8800c671ca911a0a11d34396d20ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098062Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749180}

ServiceWorkerDevTools agent host has a way to update loader factories
when network requests need to be intercepted by DevTools. This CL plumbs
the COEP value which is available after the main script is loaded if the
worker is new.

Bug: 1039613
Change-Id: I6c197855e7659508d799a40041c5300dd4067bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089542
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749179}

The iOS flag enable-autofill-prune-suggestions is the same
as autofill-prune-suggestions.

Since autofill-prune-suggestions flag name is already in
flag-metadata.json, this CL just changes the name of
the iOS flag to be the same as the one used in other
platforms.

These flags were added in https://crrev.com/c/1565295.

TBR=caitlinfischer@google.com

Bug: 1058614
Change-Id: I395648693b485d08f85f188b99c64a2a695469ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097123
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749178}

This patch adds a uniform mechanism for controlling the viewport insets
for the application. The general approach is such that a feature using
the inset system doesn't have to worry about the specific tab it is
on, only whether there should currently be an inset. In more detail,
this patch does the following:

- The WindowAndroid owns the new ApplicationViewportInsetSupplier.
  - This object hosts basic logic to determine what the window inset
    should be given multiple providers. Currently this is just the
    max(...).
- Tabs register themselves as observers of the AVIS from the
  TabViewAndroidDelegate associated with their web contents.
- The TabViewAndroidDelegate hosts the actual inset functionality
  and reparenting and visibility logic. The tab is ignorant to this.
- The previously public insetViewportBottom has been made private and
  its only user converted to use the new system.

Bug: 1048183
Change-Id: I4e6b63e0e9faf29694dd8957bddd757db5b1f005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064597Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749177}

This CL wires the Insertable Streams underlying sources and sinks
to RTCRtpSender and RTCRtpReceiver.
It also adds a test that checks that:
 1. Frames flow correctly between sender and receiver.
 2. Manipulation of the frame data field is propagated between sender and
    receiver.

Bug: 1052765
Change-Id: Ibd539d5b3795ca06f2bf90843c52942311e236a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083187
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749176}

|total_allocations_| is used after the mutex guarding it is released.
This CL reads its value before releasing the mutex, removing the race
condition.

Bug: 881875
Change-Id: Iba1539eb75012bb69bf2bd6631345fa9518a62cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098017
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749175}

Minor code cleanup; no behavior change.

Bug: 1049161
Change-Id: Ic5306bf949074a4bc102aac1e667e233a1604d27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095883Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749174}

https://skia.googlesource.com/skia.git/+log/21beacccb930..fdf94044ffea

git log 21beacccb930..fdf94044ffea --date=short --first-parent --format='%ad %ae %s'
2020-03-11 reed@google.com Remove exotic legacy bitmap drawing entry points: Nine, Lattice

Created with:
  gclient setdep -r src/third_party/skia@fdf94044ffea

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC brianosman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: brianosman@google.com
Change-Id: I340a749a8d2411a24cfb8a6e3f01bad8247639ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098063Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749173}

We're adopting Chrome Flag Ownership in iOS. See announcement here:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

This is one of several CLs that adds iOS flag ownership information into
flag-metadata.json.

The owner of these flags was identified via git blame. A placeholder
expiry milestone of M86 was added. Please either LGTM, or suggest a new
owner and/or expiry.

Bug: 1058614
Change-Id: I76c553958e137f6d389433a5e96cb566a1a17f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097460Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749172}

Bug: 949839
Change-Id: Ie6a8fe29ff2adedc08910834cebe831050e14b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097247Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749171}

Previous to this CL, if a) HistoryUiFaviconRequestHandler could not
find an icon in the local favicon database and b) Chrome was not allowed
to query the Google Favicon Server, then the layer would make a fallback
request to FaviconCache, the in-memory cache for synced icons.

Favicon sync has been stopped (https://crrev.com/c/1917173), which means
a) FaviconCache is no longer populated with remote data.
b) It is still populated with local data, however that data never gets
synced up.

This CL removes the fallback code to FaviconCache, under the assumption
that, except for rare cases, an icon would not be found in the in-memory
cache that was not found in the local database.

Bug: 978775
Change-Id: I9d4f92b19eb6a31ebd06b3579ffe1794b9737b00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085375
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749170}

There are no external sources of these IDs, so this switches the factory
to generate the IDs itself and removes the parameters.

FrameTreeTest needs to be updated because the root's ID becomes 1
instead of 3 with this change.

This is a pre-factor for https://crrev.com/c/2084038

Change-Id: Ia9dbd792af09edd681de96b11a07de2a7bca9289
Bug: 1059678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094417
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749169}

The CL https://crrev.com/c/2096712 removes side-effect checking of
JavaScript snippets from the DevTools frontend and lets V8 handle the
side-effect checking.

This CL disables a test that incorrectly allows completion suggestions
for iframes, which is actually not guaranteed to be side-effect free
at the moment. After the above CL landed, this test needs to be
rebaselined and re-enabled.

R=petermarshall@chromium.org

Bug: chromium:1031243
Change-Id: I9de94a78f717ce54530b0e43f8121a30303554a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096683
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749168}

This patch removes a redundant attribute/value pair from the
internal blurredVision filter definition.

`in="SourceGraphic"` is the implicit default per [1] and [2]:

> If no value is provided and this is the first filter primitive,
> then this filter primitive will use SourceGraphic as its input.

[1]: https://www.w3.org/TR/SVG11/filters.html#CommonAttributes
[2]: https://drafts.fxtf.org/filter-effects-1/#CommonAttributes

Bug: chromium:1003700
Change-Id: Idc2aaaf435e5ef57e00cfc0341d53214812001c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094667Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749167}

This functionality is now being tested in the devtools e2e test suite.
Furthermore the existing test tests against incorrect behavior, so it
would block fixing the behavior in dev tools.

Bug: chromium:670180
Change-Id: I677de297f8494bbb334c0df58eebd493e9648fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096590Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749166}

A previous CL https://crrev.com/748972 records metrics for toggling
two-up view mode in the PDF viewer.

This is a follow-up CL, which adds the enumerations used for two-up
view actions' metrics.

Bug: 51472
Change-Id: Iae03eaea36d07ebdbe4eb52df5e50709b2e13d1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097495
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749165}

There was only one site populating these and it was not necessary (it
was already skipping population if this was a new browsing instance).

This is a pre-factor for https://crrev.com/c/2084038

Change-Id: I585160d2533fc5adfbe317a1ace2166b8a378915
Bug: 1059678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094579Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Auto-Submit: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749164}

TBR=bling-p10-rolls@google.com

Change-Id: Ib12f5472b9f9becf1bb30f4fdc966d3c06576fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097506Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749163}

This is a temporary CHECK() to help diagnose an existing crash.

The goal is to turn it into a dcheck once the issue is solved.

Bug: 1058705
Change-Id: I985d38759dcbfdd00ccdea896c1630fa925cf35f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097175
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749162}

New metrics are similar to policy invalidations metrics.
But, unlike the latter, remote commands invalidations use
only user and device scopes because device local account
scope does not exists for remote commands.

BUG=chromium:1045008
TEST=Manual testing

Cq-Depend: chromium:2078213
Change-Id: I7bd7cbe6c0403ab39548761f39003b07811c8443
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023834Reviewed-by: Askar Aitzhan <askaraitzhan@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/heads/master@{#749161}

(pure refactor)

Before this patch, the BrowsingInterfaceBinder collected all the
attributes needed to bind the CacheStorage:
 - process,
 - origin
 - COEP
 - COEP_reporter (in the next patch)
and binded it.

After this patch, this work is done by the classes representing the
context on which the CacheStorage is requested:
 - RenderFrameHostImpl,
 - DedicatedWorker,
 - SharedWorker,
 - ServiceWorker

The code is slightly shorter and simpler. It will allow all theses
classes to provide their own COEP and COEP_reporter. This will be used
by the following patch in the branch.

Bug: 1059727, 1031542
Change-Id: Ic142da4f023b20c3ae25e98a179203c8d2bdfc6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096453
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749160}

https://chromium.googlesource.com/angle/angle.git/+log/45c5398037c4..d0748eb038be

git log 45c5398037c4..d0748eb038be --date=short --first-parent --format='%ad %ae %s'
2020-03-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 014968c3b6b3..2ff8b6a6f4d5 (4 commits)

Created with:
  gclient setdep -r src/third_party/angle@d0748eb038be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jmadill@google.com
Change-Id: Ia8f328db44e12fa93303c182754ac26ade219a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098061Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749159}

Bug: 1055483
Change-Id: Ic4a205e0c801bbd1ccc4e4cbf80cfd7aff099f95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087616
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749158}

This reverts commit 8a27ec89.

Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/158215?

Original change's description:
> Safe Browsing: Add UMA to measure time since last database update
> 
> This adds UMA to record whether the Safe Browsing local database has
> received an update, and if so, how much time elapsed since the last update
> was received. These metrics are recorded whenever the local database is
> queried.
> 
> While these metrics do not distinguish between a successful update and
> an unsuccessful update, an existing metric (SafeBrowsing.V4Update.Result)
> already records whether updates are successful or not.
> 
> These metrics will allow us to compare database freshness on iOS to freshness
> on desktop, to evaluate changes we can make to update the database more
> frequently on iOS.
> 
> Bug: 1055863
> Change-Id: I12d6b672e3d274b40fa71fc99d44419380d340a0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087415
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Commit-Queue: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749150}

TBR=ajuma@chromium.org,isherman@chromium.org,kkhorimoto@chromium.org,vakh@chromium.org

Change-Id: Idcb6347f6b5181b1530952671ffdd68feb2266c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1055863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096592Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749157}

Using wpt-import in Chromium ddebab41.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"
2594f643 "Fix timeout in update-and-send-events-replacment.html"
6cf14026 "webrtc: add more BUNDLE assertions"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I225b33e00568a0bba20c74fede40a110255a1e52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093541Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749156}

In build/util/version.gni, `public_android_sdk` is used when
`target_os == "android"`.
But in build/config/android/config.gni, it's defined only when
`is_android || is_chromeos`.

This PR fixes `public_android_sdk` not defined error when
`target_os == "android"` and host toolchain (linux) used.

Change-Id: I41f75ac629ea5009a5e1e404918d256be0cbe77d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096799Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Richard He <linyhe@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#749155}