- 13 Oct, 2020 40 commits
-
-
Jazz Xu authored
Remove media controls chip view since they're implemented in ash/system/media/. Change-Id: I3b91ca767f5cbae1e14937a0c6a7f327b1ff6aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466351Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816706}
-
dpapad authored
Currently the contents of the generated grd file do not depend on the contents of each individiual |input_files| member, so such files should not be declared as |inputs|. Bug: 1132403 Change-Id: I6ccdcee19fae5304454561fa2cbf19eb770e6865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468377Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816705}
-
Anthony Cui authored
URLs with a file scheme ("file://") are not translated, change 2444549 moves this check from Android into shared code. As such, browser tests that load a local file to test translation should be updated to use the embedded test server instead. Bug: 1127094 Change-Id: Ib02a33844da02dff205e8acf9cc233c53cdcaa1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454692 Commit-Queue: Anthony Cui <cuianthony@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#816704}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/0265cd7a10d1..e67f9369d50e $ git log 0265cd7a1..e67f9369d --date=short --no-merges --format='%ad %ae %s' 2020-10-12 wtc Change avifDecoderSetIO() to return void 2020-10-12 wtc Change 'size' param of avifIOReadFunc to size_t Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1136922 Change-Id: Ice8f31a64fecf3ac19a68ba636632ea1b738c3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466842Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#816703}
-
Charlene Yan authored
Feedback from users are that they want their collapsed groups to remain collapsed when reopening their windows. Also cleaning up kCommandSetTabGroupMetadata which was replaced in M81 for backwards compatibility for color. Bug: 1127622 Change-Id: Idce8be561c2d060f4c2613bf358502becc70db1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458876Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#816702}
-
Daniel Cheng authored
If a WeakPtr references an already-destroyed object, operator-> and operator* end up simply dereferencing nullptr. However, dereferencing nullptr is undefined behavior and can be optimized in surprising ways by compilers. To prevent this from happening, add a defence of last resort and CHECK that the WeakPtr is still valid. Bug: 817982 Change-Id: Ib3a025c18fbd9d5db88770fced2063135086847b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463857 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#816701}
-
Ryan Heise authored
Consume skip_wpr_archives_download and skip_render_test_goldens_download in DEPS. Bug: chromium:1135819 Change-Id: Iab3bd5e301f5b37913688b9aa893a79dc61522c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466486Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#816700}
-
Brandon Jones authored
This is a reland of e94960c9 Original change's description: > Use a single, consistent path to update stage parameters. > > Removes stage_parameters from VRDisplayInfo and updates the XR frame > request loop to exchange an stage_parameters_id to indicate what version > of the parameters the session has so that only updates need to be sent. > > Part of an ongoing process to remove VRDisplayInfo entirely. > > Bug: 998146 > Change-Id: I6f41dc2426b529694903d1e46cdadc16841b2b37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460976 > Commit-Queue: Brandon Jones <bajones@chromium.org> > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815903} Bug: 998146 Change-Id: I433914ca4db3adfa939032946a2095e03c13eed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466932Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#816699}
-
Bettina Dea authored
If the Safe Browsing settings was reached to from the Enhanced Protection promo from the new tab page on Android, then the enhanced protection radio button section should be highlighted in Blue50. Screenshot: http://screen/5MRDafWDYScPBac Dark Mode: http://screen/AznVfBwK8AD8rN3 Bug: 1135808 Change-Id: Id9cdf2a42cf0c12bf1ee46c80cfdf79a288600ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454490Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#816698}
-
Adlai Holler authored
Just a rename to latest API. No functional change. Change-Id: I0073320d0467b9d516f4dcdb0de3476940573be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466523 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816697}
-
Sorin Jianu authored
Also, define ostream<< for enum types, to remove some more casts. This is a mechanical change. Bug: 1135349 Change-Id: I9d11fb2d7d69b99871acd282484df086fdadc498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467695Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#816696}
-
Rakesh Soma authored
new account creation irrespective of whether both those user mappings exist on the device. We should instead fallback to new user creation only if we have multiple valid user mappings on the device. Bug: 1137547 Change-Id: I9924a3b07235a05472f35998fb5be869c43d83c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465584 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#816695}
-
Zhaoyang Li authored
The wrapper currently removes only one set of the flags for code coverage partial instrumentation. But there can be situation where multiple sets of same flags are in compile command and all of these need to be removed. Bug: 1137569 Change-Id: I32c48710fd9c0c66d7c218f329efcd222704607e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466976 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#816694}
-
Shakti Sahu authored
This CL 1 - Changes Tutorial not to be a subclass of ImageTile. 2 - Handled additional feature type enum types. 3 - Added some unittests 4 - Fixed a CSS bug Change-Id: Iceca0057f7e0d9b549af5481a12c7f1565e21441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464855Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816693}
-
Daniel Classon authored
Adds a new helper function that converts a (pref, prefValue) pair to a (setting, settingChangeValue) pair that can be used to log metrics. Uses this helper function to automatically capture setting changes for all pref based settings. As a first example, implements metrics for the kKeyboardFunctionKeys on the Device page. Bug: 1133553 Change-Id: Ia1f0118e27bb7e0f610bfe1d75ba0ef324260f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459846 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#816692}
-
Chris Hamilton authored
This add context counts and surfaces them in the description. BUG=1085129 Change-Id: Ifd07af7d08e512fc213d19f4656835243b6b079c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446095 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#816691}
-
Regan Hsu authored
Add a new URL parameter to the multidevice settings page which, when detected, starts up the opt-in flow (the same one that is triggered with the notification toggle is toggled). Bug: 1106937 Change-Id: I642ef174b9ec0a4c14bd9cfce7c87c0e891efd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465515 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#816690}
-
Joe Mason authored
Also augments util::IdType to allow starting generators at different values. R=fdoray Bug: 1136350 Change-Id: I48673d90e754371892f25021607d2986db8f0bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461597 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#816689}
-
Joey Arhar authored
The mime types for xls and xlsx are listed on MDN[1] and on iana.org[2]. [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types [2] https://www.iana.org/assignments/media-types/media-types.xhtml Although the OS mime type <-> file extension mapping usually gets xls/xlsx for us, it appears that in some cases and on some users machines it doesn't happen. The reporter of this bug had it happen on their mac, and the windows cq+1 trybot fails the test without the patch. Bug: 1132791 Change-Id: I4fc35bc3387d98b5967d0a476788b32bf6e2c6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462664Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816688}
-
Zentaro Kavanagh authored
- -Wfinal-dtor-non-final-class warns on classes with final dtors but not final classes. - Error messages are better when the class is marked final. - Fix existing issues in code base and remove warning exemption Bug: 999886 Test: no errors building Change-Id: I85c8b03f3dab773e5fb017acdcf0b6682f1c9e01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466978 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#816687}
-
Adam Langley authored
The default tunnel server domain is switched to ua5v.com and, as a protocol change, "cable." is prepended. The latter makes using a CNAME easier because CNAMEs can't exist at a zone cut. (I.e. ua5v.com itself cannot be a CNAME because it must have an SOA record, but cable.ua5v.com could be a CNAME.) BUG=1002262 Change-Id: Ia2a69ffab82f0ef065b813ffee58f16ca02bcf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463808 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#816686}
-
Andrew Xu authored
This CL adds the border for images shown on the multipaste menu. Bug: 1131728 Change-Id: I45b25d3b4a790b52c46c035da956e7efc8e78e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468376Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816685}
-
Dave Tapuska authored
Simple move of this test closer to where the code to send the metadata is. BUG=1097816 Change-Id: Ifc0d2acd28e3d119c3a1d6e9f42d49d32b5207d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461988 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816684}
-
Sigurd Schneider authored
This uses the new accessors from https://crrev.com/c/2467837 instead of accessing a deprecated static field. Bug: chromium:1011811, chromium:1135143 Change-Id: If615dfc86603ca841b63c0760b7fe7615681859a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467936Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#816683}
-
James Cook authored
This allows us to filter UMA data by managed vs. unmanaged status on the UMA dashboards for Chrome OS Lacros browser builds. Information about Lacros is available at //docs/lacros.md or internally at go/lacros Bug: 1134341 Test: UMA.EnrollmentStatus appears in about:histograms Change-Id: I2a7e7198b5ebb051231ecb070bc72fe32691ed2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464028 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816682}
-
Bill Budge authored
This is a reland of acfed35e Original change's description: > [Flash] Remove PPP_Flash_BrowserOperations API > > This also removes plugin data and settings persistence, which isn't > needed if the Flash plugin doesn't exist (it used to persist its own > data on command from the browser.) > > Adds a TODO to figure out how we will remove plugin data now that > Flash is deprecated. > > Bug: chromium:1064652,chromium:1135773,chromium:1135779 > Change-Id: I2eb1e30856071190cba29cea98cdd86a37722f95 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450057 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Anthony LaForge <laforge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816370} TBR=sky@chromium.org,tsepez@chromium.org,laforge@chromium.org Bug: chromium:1064652 Bug: chromium:1135773 Bug: chromium:1135779 Change-Id: I3e602eb6915d84becc9e104eb273c924f3cec87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468179 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#816681}
-
Dylan Cutler authored
identifiability study. These interfaces are already instrumented, this change only affects their IDL. Instrumentation CLs: - getParameter: http://crrev.com/c/2364953 - getRenderbufferParameter: http://crrev.com/c/2437024 - getShaderPrecisionFormat: http://crrev.com/c/2431782 - getInternalformatParameter: http://crrev.com/c/2441021 Bug: 973801 Change-Id: I610a2675768a7cc7f616a13a2812a7eace59e6f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461593Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#816680}
-
Clark DuVall authored
This is a reland of 022292aa Changes from original are from Patchset 1 on. I added a java_group which contains both the services dep and the original java dep so this doesn't break //clank. After this lands I'll fix up clank to point to the right deps and remove the java_group. Original change's description: > Split out minimal target for PaymentDetailsUpdateService > > We are investigated using isolated splits for Chrome, and splitting > //chrome code into a DFM. Due to b/169196314, all service classes must > be present in the base module. See go/isolated-splits-clank for more > details. > > This change creates a new minimal target for PaymentDetailsUpdateService > which the base module will depend on. > > Bug: 1126301 > Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815649} Bug: 1126301 Change-Id: If5077fa7d6a03f893aa0057be8a26cf5863230b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463649Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#816679}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 126802 Test: none Change-Id: I851f765ea02d92bf1adbc36e591cff2301b1ceff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462624Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#816678}
-
Sasha McIntosh authored
This flag is used to specify cases where YUV should not be used. Rather than relying on the client to pass in this flag we specify that YUV decoding happens only when DecodeToYUV is called. Calling Decode(size_t), as in DecodeFrameBufferAtIndex(size_t), will prevent YUV decoding. Additionally remove JPEGImageDecoder::SetDecodeToYuvForTesting method. Bug: 1090949, 1062187 Change-Id: I389a20729f56facd49acf6cf670408001f5ed076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240249 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#816677}
-
Mikel Astiz authored
All datatypes (except proxy types) are non-blocking, so there is little point in maintaining code that keeps track of which precise "group" each datatype maps to. In this patch, most code is deleted except for the internals of SyncBackendRegistrar, which is more complicated. Change-Id: I4ad2d219e8032cbb0dca16125958c6e66c117cf6 Bug: 1102835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467918 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816676}
-
Alex Turner authored
Currently, such lookups are accidentally recorded under kLocalFontLookupByUniqueOrFamilyName due to a typo. This affects the metrics recording for the identifiability study Bug: 1136921 Change-Id: Ibf4a28a6edfabff0a570bd35c09686b5b020957d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463702Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#816675}
-
Haiyang Pan authored
This uses the same test configs as android-pie-x86-rel. Bug: 1099916 Change-Id: I05a018f56d0121d69c2384644e41b8e2f5539b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454729Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#816674}
-
Nicolas Ouellet-Payeur authored
When the ForceEphemeralProfiles policy is enabled, Chrome tries to clean up sensitive files when the last window in a profile is closed. However, the Custom Dictionary.txt file is still populated, and it can contain sensitive (e.g., a customer's name that was added to spellcheck). With this patch, the Custom Dictionary.txt file is properly cleared when the last window in an ephemeral profile closes. TESTED=Created a new profile in epehemeral mode, added some dictionary words, then closed it. Checked that Custom Dictionary.txt{,.backup} didn't contain the words. Also tested with Sync turned on, to make sure the words were not cleared from synced data. Bug: 1132950 Change-Id: If50f0f78fc89a7bbdbc1b563856bc36288c53c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441947Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#816673}
-
Joe DeBlasio authored
Fixed: 1137858 Change-Id: I7eefc389cce69d1cd5fd271ab1009ab4faade4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468336 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#816672}
-
Antonio Gomes authored
This is a reland of 7ea4118e The reland fixes the wrong `defines` declaration in //chromeos/ui/frame/BUILD.gn : - defines = [ "IS_CHROMEOS_UI_FRAME" ] + defines = [ "IS_CHROMEOS_UI_FRAME_IMPL" ] which was causing the wrong symbols being loaded. Original change's description: > Move //ash/public/cpp/caption_buttons to //chromeos/ui > > This is step 1.2 on the design document [1]. > > [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/edit > > BUG=1113900 > R=jamescook@chromium.org, sky@chromium.org > > Change-Id: Ic625b887b00538d758260a3f35426c346bcdbabf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458768 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816200} TBR=jamescook@chromium.org Bug: 1113900 Change-Id: I332e087c0eadd333aef96e2acb7d9f0c9a259f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466739Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#816671}
-
Nicolas Ouellet-Payeur authored
This recent CL [1] and made the `ice_config_fetcher' network traffic annotation ChromeOS-only. Because it only changed a BUILD file, and not the actual source code, CQ did not catch the change. This CL updates annotations.xml to reflect the change in supported platforms. [1] https://crrev.com/c/2441025 TBR=rhalavati@chromium.org Change-Id: If1b728c0ace48351e39e4b5294ab47c982a67bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468637Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#816670}
-
Xianzhu Wang authored
Previously when there is composited foreground layer, the outline was painted on both the main graphics layer and the foreground layer. Change-Id: I9c0bcf14ce4acb1f41a732e480b9c1a4126f69bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466620Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816669}
-
Zhenyao Mo authored
BUG=1136972 TEST=bots R=kbr@chromium.org Change-Id: Ib0c769e88bae1d3a5a092610bc49896d8ccfe040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464102Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#816668}
-
mark a. foltz authored
Ensure that queued read tasks don't make use of a null MojoDataPipeReader. Also ensure that error_callback_ is invoked at most once per RemotingSender. Bug: 1081111 Change-Id: I75d808bf2c7e747d6306543aedcac5ce26acfa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446992 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816667}
-