- 27 Oct, 2020 40 commits
-
-
arthursonzogni authored
Check an url::Origin always survives the conversion through a blink::SecurityOrigin. This is typically what is done during some browser process <-> renderer process IPC. For instance, in https://crbug.com/901489, the origin sent from the browser process didn't survived the conversion. The host in url::Origin is percent encoded, while in the blink::SecurityOrigin, it used not to. SecurityOrigin::CreateFromString(...) is called with untrusted input by several components. This patch is mostly added by curiosity, to make me comfortable with: https://chromium-review.googlesource.com/c/chromium/src/+/2464363 Fixed: 490074 Bug: None Change-Id: Icec738475e888569ad99520f45afa5bcc6a7bbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491360Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821170}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I6f694fa61b8fc8b0c836d2b4c502ab8899097a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501721Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821169}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e353801f6411..f6c1edff2f42 2020-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3aee62b34a8c5e02c916b1ba2a65eed1d592d24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501367Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I92783790da0f2e7a33c289280c64ea26ce32c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500712Reviewed-by:
-
David Roger authored
This reverts commit b227bf9d. Reason for revert: breaks compare_build_artifacts https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17383 Original change's description: > [updater] pass build dir to tests. > > Also changes test case superclass to typ.TestCase. > > Bug: 1141577 > Change-Id: I0d9b4b38543d1cd904808d9f85b6aa27ab973c5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496180 > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Commit-Queue: Anjali Doneria <adoneria@google.com> > Cr-Commit-Position: refs/heads/master@{#820849} TBR=sorin@chromium.org,waffles@chromium.org,adoneria@google.com Change-Id: I81e2ec26e7b68f8de2ac7ceb304dcfbc11e90a97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1141577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502022Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821166}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dfried@chromium.org Bug: 1142671 Change-Id: Id7832e9b11000805ac8a535311254d6dda104d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500491 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#821165}
-
David Roger authored
TBR=qinmin Bug: 1141278 Change-Id: I1c13730e0dea15b9bbbd6cef75a4926c58bcadf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501741Reviewed-by:
-
Lei Zhang authored
Update some tests with modern base::Value API calls, in preparation for changing Results::Create() in generated code to return base::Value instead of std::unique_ptr<base::ListValue>. Bug: 1139221 Change-Id: I0995549e54c06aa11bf0af676442c2ce808eb965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496039Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821163}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=dfried@chromium.org Bug: 1142671 Change-Id: I82eea21d4c053616fcc5434ddecd2d04e6c15026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500570 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
sauski authored
To provide greater insight into user actions w.r.t. site data, the PrivacyElementInteractions enum is extended to include user initiated deletions of site data. Bug: 1101675 Change-Id: I0d125409985fe01a5a9eeef9c7e363fdabd41714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494945 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#821161}
-
Austin Tankiang authored
This banner will be shown the first three times the user runs Files App and navigates to Drive (as opposed to the first three times the user sees the banner). Bug: 1129778 Change-Id: I0073d7dd6b6f1cdf9494e621f0edfccbcc380238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417741Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#821160}
-
Luciano Pacheco authored
Update TestDataSource (chrome://test/) to be able to load chai.js from //third_party/. Change chai_assert.js to import chai.js and add assertArrayEquals() because it used in several tests in WebUI and Files app. Nits addressed for array_data_model_test.js: - Add type check. - Remove "#export" markup. - Use Object.assign() to export test functions to global scope. Bug: 1133198 Change-Id: I816fa4d11365ce1adbe769e2cab6993368821e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497960 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d474b8943c9..7737a5bd2510 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb66fa41a163 to c1839ee3cedd (1 revision) 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 29ca7186a688 to 98c5ff6b49b3 (14 revisions) 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d37162e0 to 6d5913ce (399 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Test: Test: Test: angle_perftests --gtest_filter="*fate_grand_order*" Change-Id: I90194ef70eeb5dfbdf53f65916ce746b808ec184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501264Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e641c3d8..ea929126 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic165d964073fa3ae59e56611cb191b6b6b0c9eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499982Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821157}
-
Dana Fried authored
This reverts commit 91b01545. Reason for revert: called wrong method, enabling arrow key traversal globally instead of locally Bug: 1142343 Original change's description: > Keyboard accessibility for extensions menu. > > This change switches the extensions menu to enable focus traversal at > the focus manager level, allowing both right/left and up/down key > traversal. > > It also removes > BubbleDialogDelegateView::EnableUpDownKeyboardAccelerators() - which is > only used in one other place - in favor of > FocusManager::set_arrow_key_traversal_enabled(), which also supports > left/right arrows and pre-exists the bubble dialog method. > > These changes mean that when the scroll pane is active in either dialog, > up and down will scroll the pane but left and right arrow keys will > still allow the user to traverse the dialog (at least on Windows and > Linux; on Mac, up/down may still work within the pane). > > Bug: 1140632 > Change-Id: I8ea5bc79e9b9ed2595e9503be1221843c50a7b3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487904 > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dana Fried <dfried@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820456} TBR=dmazzoni@chromium.org,sky@chromium.org,pbos@chromium.org,dfried@chromium.org,corising@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140632 Change-Id: I4c1d30602c132bdd3f06ab95f0215e5909373ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501074 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
Bug: 1060940 Change-Id: I922c5711383d340425bab3682f79923b049d8cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497452 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#821155}
-
Daniel Cheng authored
Replace usage with base::UmaHistogramSparse() since I/O should end up dominating on this control path anyway. Bug: 1047547 Change-Id: I28dcf9d323ceff6db26ada6d4fee4c4a76e592e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500263Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821154}
-
Daniel Cheng authored
Historically, LocalFrameClientImpl/WebRemoteFrameImpl lived in the web layer, alongside RemoteFrameClientImpl/WebLocalFrameImpl. When removing the web layer, some frame-related files were moved to core/exported, while the rest were moved to core/frame. This was related to some questions about whether or not it would be appropriate to have a controller layer between Blink core and the Blink embedder. Ultimately, no one pursued the controller layer, and the difference only adds confusion now. Note that this CL does not attempt to address any preexisting presubmit errors to simplify the file move. Bug: none No-Presubmit: true Change-Id: Iadf3e45d2d8c102080c53bc21f9dea70bf6e0992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495610 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821153}
-
Daniel Libby authored
Pre-CAP, there is code that adjusts the transform property nodes of the global root scroller's scrollbars to point to the visual viewport's overscroll elasticity transform node. This ensures that the overscroll elasticity effect and page scale don't affect the root scroller's scrollbars. This adjustment was done at the compositing step in CompositingLayerPropertyUpdater::Update. In CAP, instead of doing this adjustment after the fact, we instead modify the paint chunk's transform node when painting the scrollbars. Additionally, we'll paint them in the overlay overflow controls paint phase, which happens at the end of painting a layer, as otherwise they are painted before child layers, which causes the PaintArtifactCompositor to have them be layered underneath child layer contents. There are many test updates - most of these just reflect the change in ordering. However there are a couple of notable changes. Two tests involving an outline that extends outside the viewport result in root layers that no longer are considered opaque. outline-change-vertical-rl-expected.txt outline-change-scrollable-expected.txt The root scrollbar used to be painted between the background and foreground paint phases, which caused the outline to be in a separate chunk. Since content outside the drawable rect is not considered for detecting opaque content, PaintChunker::IncrementDisplayItem set the last_chunk_known_to_be_opaque_region_ to the viewport size, but that does not match the chunk bounds in PaintChunker::FinalizeLastChunkProperties. Invalidation rects now match the non-CAP expectations for the following tests: invalidation-after-opacity-change-subtree-expected.txt window-resize-vertical-writing-mode-expected.txt Additionally, abspos-shift-image-incorrect-repaint-expected.txt has changed, but I haven't yet got to the bottom of why there are invalidation changes (probably related to how paint chunks are produced). R=pdr@chromium.org, wangxianzhu@chromium.org Bug: 1106550 Change-Id: I00ff0538d02d42adc3d26c849aafbbe2ca8e6d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395078 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821152}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/abe2eff36f3c..34ae8a475754 2020-10-26 greg@lunarg.com Fix bounds check instrumentation to handle 16-bit values (#3983) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,geofflang@google.com Change-Id: I8d3ec7d16f9dd7b412112ddab48ac03487640b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500709Reviewed-by:
-
Hirokazu Honda authored
This CL enables VideoFrameFileWriter to save 10bits color depth VideoFrame to the disk. Since gfx::PNGCodec doesn't support 10 bits RGBA, YUV format must be specified for 10 bits depth VideoFrame. Bug: 1115112 Test: video_decode_accelerator_tests --use_vd --output_frames=all --output_format=yuv Change-Id: Id06c3d200ac672028be2f36d00f2d434b1e6607d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462911 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#821150}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I28bba1e2e38aa6f870545566262fa3df686a427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501601Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821149}
-
Sylvain Defresne authored
Move ios/chrome/app/resources/Info.plist keys specific to the "device" or "simulator" environments to a separate file, and add a file for "catalyst" specific keys. Update the build rule to merge the correct .plist files. Add a new entitlement file for key that are required for a build targeting the "catalyst" environment and update the build rule to merge it to the generic entitlements. Bug: 1138425 Change-Id: I164aeadf66320885695fb38707f0b10c22e07158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498487 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#821148}
-
Jérémie Boulic authored
Bug: 1133186 Change-Id: Id8fcad0765660cf8ad4c4d57ebd61c70ec3885e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500690Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=jdoerrie@chromium.org Bug: 1142671 Change-Id: If23eef3937c4bb5b45539634a421c57d9e1b580a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500212 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#821146}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 1142671 Change-Id: Iaa2a3bf794e1a8887c62c9c5059f58697ab219dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500488 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821145}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/160e3844d960..e353801f6411 2020-10-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I664701c2e1618007b28c190ea08af42d3d4b65a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501261 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
dpapad authored
Creating an auto-generated webui_generated_resources.grd file to host resources moved over from the non-generated webui_resources.grd. In this CL: - auto-generating entries for third_party/polymer/ - auto-generating entries for third_party/web-animations-js/ - removing aliases from shared_resources_data_source.cc that become obsolete by the auto-generation. - adding webui_generated_resources.grd to the build (currently only for !ios && !android) - delete obsolete tools/polymer/txt_to_polymer_grdp.py script Bug: 1132403 Change-Id: I244ab22b7178771da71e55b5bcaf9f823d291c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489921 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#821143}
-
Hirokazu Honda authored
VideoDecoder outputs GpuMemoryBuffer which is not allowed to map by GpuMemoryBuffer interface. This causes VideoFrameFileWriter cannot save it to the disk. This CL resolves the issue by extracting the dmabuf-fds wrapped by the GpuMemoryBuffer and map them. Bug: 1115112 Test: video_decode_accelerator_tests --output_frames=all --use_vd Change-Id: Ib6328e81aa12bda49a39f155db7e2ce9573fa0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463010 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f6b755916fcf..c7ea56a3ebb3 2020-10-26 thestig@chromium.org Add a pixel test for CFX_ImageTransformer. 2020-10-26 vmiklos@collabora.co.uk FPDFAnnot_GetSubtype: recognize the Redact annotation sub-type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I12d4d6422b115fcdd441b3d24bf7c5ff0e3cb415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500256Reviewed-by:
-
Kenichi Ishibashi authored
crrev.com/c/2467037 added a speculative fix for flakiness but it seems the flakiness still exists. This CL makes further attempt to de-flake ServiceWorkerBrowserTest by adding RunAllTasksUntilIdle() in TearDownOnMainThread(). Bug: 1142544 Change-Id: I166dc33f952c3da09b36e7156ebb19a638247732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500649Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821140}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603756748-67e6d78aa0117f6752ad92f968b3a41dbb1fa16d.profdata to chrome-mac-master-1603777504-1efb0ca1330464e38ca172c34d8ac2b307218a42.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I407907136848c3e4c49829dd1a32746cd4ca91af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501362Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e13db707ff3..9d474b8943c9 2020-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 42103bc2e911 to 41c24933da1e (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I2c38e97b733acae2458691a789b0ac7be2ece9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500870Reviewed-by:
-
Lei Zhang authored
"PDF" should be in uppercase. The one test that failed as a result of this flag flip is ExtensionApiTest.TemporaryAddressSpoof. Update the test with a different click coordinate that is compatible with the flag on or off. Bug: 1048812 Change-Id: I72d0ce0a39f0d0a1d465c307dafe71f15b84dec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499182Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Renjie Tang authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007794 Change-Id: Id473723248de78393f0b2790f518392b86fcedb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500181 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL ports LayoutTextControlSingleLine::AllowsNonVisibleOverflow() to LayoutNGTextControlSingleLine. This CL has no behavior changes now, but it fixes baseline-alignment-and-overflow.tentative.html in WPT with LayoutNGTextField flag. Bug: 1040826 Change-Id: If21b1b150922229a180293dd9f8c1cceb43ab70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501169 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#821135}
-
Elizabeth Popova authored
- Add Russian keywords for street name and house number. - Add additional Russian/Brazilian keywords for city. - Adjust Brazilian street/addr1 keywords to exclude constructions like identificação do endereço, tipo de endereço, nome do endereço etc. - Adjust Brazilian house number keyword to match labels with * (required) and "número da residência". Change-Id: Ib48a921271cacbf30eae21e95d6c82dabe812218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468000Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821134}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac6e1a61d86e..50d43b33bba6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ksakamoto@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ksakamoto@google.com Change-Id: I94ae16231ca76e935b42fe861d2960f88ba0b66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500370Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821133}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603756748-18fcc653ee73e42ac2d8e9952f1488ef428e6efa.profdata to chrome-linux-master-1603777504-e29f505cee8cadd0b5b5127539f147bff09e64be.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If49203d9ec4dc0e7c804afb0d49c005b8fee11b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500579Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1a1dd32df06a5e5617a0c7dcbfbeb5856e9ac439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500374Reviewed-by:
-
