- 28 Oct, 2020 40 commits
-
-
rbpotter authored
With the update of OS settings to generate_grd, this method is no longer used. Bug: 1132403 Change-Id: Id06f6249b05bebcc72eb22b417d0334bc4d5a708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505936Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821828}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bc42696a. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" 0c2d7260 "[scroll-animations] Handle changes to selector(#id) references" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I5b5741b0088f9e9dbf952889330a219529b89a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505455Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f40a48d..3542c2cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibda221d2f77fc4e60b1a0657ecfa9b646deb42fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821826}
-
Dave Tapuska authored
These metrics expired in M81 and they'd need to be re-implemented in blink with RenderWidget's removal. Since they aren't used it is easier to remove them. BUG=1037221,1097816 Change-Id: I2879ce11795b090a4244838579167e61f7d34daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500248Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821825}
-
adoneria authored
Fix broken Windows Deterministic builder issue that caused revert crrev.com/c/2502022. Change test cases to use typ.TestCase instead of unittest.TestCase. Bug: 1141577 Change-Id: I79d6c93dd15c2e3e727c5368a97142d5572c1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503396Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#821824}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/cr/ui/. Bug: 1143194 Change-Id: I128845c864e439cbf262f343cfa77153916d8dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504740 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821823}
-
Ilia Samsonov authored
New baseline are from: https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html Bug: 1130741 Change-Id: I6d5f2bcb820717b6f6053125cfffe5d9e49963d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491982Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#821822}
-
Side Yilmaz authored
This CL adds null check for mTabSwitcherModeToolbar to IncognitoTabModelObserver callback not to cause NPE. In addition to that, this CL introduces |maybeInitializeOnIncognitoTabsExistenceChanged| and |maybeInitializeIncognitoTabModelObserver| functions to perform initialization in both |setTabModelSelector| and |initializeTabSwitcherToolbar| functions. Bug: 1142547 Change-Id: Ib539d70e06b4ebe86464867409e0a736dd7bd4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502373 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#821821}
-
Xinghui Lu authored
One major refactoring in this CL is removing FeedbackCollector's dependency on ScreenshotTask, because ScreenshotTask is not modularizable at the moment. Replace the takeScreenshot parameter in the init function with a ScreenshotSource object(the interface of ScreenshotTask), so FeedbackCollector doesn't need to construct a ScreenshotTask itself. Some outstanding blockers for further modularization: * DataReductionProxyFeedbackSource, blocked on DataReductionProxySettings. * HelpAndFeedbackLauncherImpl, blocked on AppHooks. * ScreenshotTask, blocked on ChromeActivity. * connectivity_checker.cc, blocked on circular dependency of chrome/browser/profiles. Bug: 1117343 Change-Id: I93dd06b4146ad57d53c0cdc082d8ff0c9a32cdc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478108Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821820}
-
Mikel Astiz authored
This patch migrates the helper libraries to avoid using the concept of a 'seed', which was hard to grasp, and instead migrates tests to more directly use keywords. Change-Id: Ibcdae092baade651daca059850ac31f276f47564 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495461Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821819}
-
David Tseng authored
Strategy: - manually edit the Eslinter rule: third_party/node/node_modules/eslint/lib/rules/eqeqeq.js to allow for auto fixing; this was intentionally disabled upstream. - run tools/web_dev_style/eslint.py --fix and git cl format --js on the directory R=akihiroota@chromium.org, josiahk@chromium.org Test: assumed automated test coverage Change-Id: I97913d8d198e2fe049eeeb52473a8c58aebcd94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503851Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821818}
-
Ben Pastene authored
This is the first in a series of changes to make all ToT linux CQ builders builderfull. crrev.com/i/3351753 allocates the machines for this builder, so this shouldn't be submitted before that. Bug: 1140727 Change-Id: I976f419b4be7249534b210e05151694734acbe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503391Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#821817}
-
Rushan Suleymanov authored
The DCHECK could be violated during a sync incremental update when remote updates have entities having different sync ids and the same GUIDs. This is a temporary measure until it is guaranteed that GUIDs are unique across all bookmarks. Bug: 1142790 Change-Id: Ic1279eee89290f4245f5e7f76528e888ff0dec39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506030Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821816}
-
Rune Lillesveen authored
Check the call site instead. There should be no behavioral change. Preparing for making HighlightPaintingUtils::SelectionPaintingStyle HighlightPaintingStyle and share the code with other highlight pseudo elements. Bug: 1136817 Change-Id: I240fdc2689db914862bc4ae64f64969ed3099acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503552Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821815}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I6c47e326364bbe75df8507ba18bb04c4bb07c486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821814}
-
Ben Kelly authored
This CL adds some initial liburlpattern code and tests. The main goal is to stub things out so we can get the build system in place. The CL does this by creating an initial Parse() API, validates that input characters are ASCII, and provides a unit test that checks the case where invalid characters are passed. Bug: 1141510 Change-Id: I7571d278e2e6d3d2b2a81ffe0e2df677c6831cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493246 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#821813}
-
Nate Chapin authored
NavigatorClipboard is mostly boilerplate, and Clipboard can be the Supplement<Navigator> cleanly. Change-Id: Ieb7db5f8172a08c193dff261bcaa43fda7f47dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499367 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#821812}
-
Jeffrey Kardatzke authored
BUG=chromium:1141237,b:153111783 TEST=media_unitests, media_h265_parser_fuzzer Change-Id: I0be4bbb23add3c1a47d66a36cb331ae8776d0d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503432 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#821811}
-
rbpotter authored
Followup from https://chromium-review.googlesource.com/c/chromium/src/+/2493991 Bug: 1132403 Change-Id: Idc2d9473feef2ad9746473a6bd8724a2f15616ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505955Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821810}
-
Liquan (Max) Gu authored
Context: The isWebContentsActive() method used for testing purpose, but it's always set to true in tests, so this CL removes the method. Going forwards, if there's a need to create "inactive" WebContents in tests, we should fabricate an inactive WebContents instead. Bug: 1128658 Change-Id: Idc22ee0471c960781554418ce2035fa25b7c4695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500569Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821809}
-
Jeffrey Cohen authored
https://hsv.googleplex.com/5121556831272960 Bug: 1143294 Change-Id: Iba4cdf6717e090f7041ca43af4ed5153820d89ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505454Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821808}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d81fd3dbd55e..b28ec889c239 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nicolaso@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nicolaso@google.com,drott@google.com Change-Id: Ia69f9cd352b2f4fae5cc387dbc23596d62631b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505094Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821807}
-
Hoch Hochkeppel authored
Adding a class for performing a navigator.share() operation on Windows, and corresponding tests. Originally committed as part of https://crrev.com/c/2443757, but reverted due to test issues. Patchset 1 is a cherry pick of this original change (reduced to the files relevant to this portion) for easy comparison. Bug: 1035527 Change-Id: I82a61739c168b0a2c9aa9f9f9d20572d8a45a2f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503819 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#821806}
-
Kevin Marshall authored
Adds annotations and a check-only js_binary() target to provide static typechecking assurances for NamedMessagePortConnector's JS. Bug: 159646269 Change-Id: I8340e4ef8ca291431a26dccef642745625e36911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458811 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821805}
-
Daniel Cheng authored
All usage has been migrated to use the standard //base/metrics functions. Bug: 1047547 Change-Id: I548b683c758f2251a3af1db8280c9c63e6245bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505932 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b5ba693316fd..47e66f22759a 2020-10-28 jmadill@chromium.org Revert "Re-enable crash testing in angle_unittests." 2020-10-28 geofflang@google.com Expand DrawArraysWithAlignedAndUnalignedBufferOffset supression 2020-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e56348f0 to 80c364fa (530 revisions) 2020-10-28 timvp@google.com Vulkan: Add descriptor set allocation counters 2020-10-28 jmadill@chromium.org Trace Tests: Allow runs against SwiftShader. 2020-10-28 timvp@google.com Create test Texture2DTestES3::ChangeTexSizeWithTexStorage() 2020-10-28 jdarpinian@chromium.org ANGLE_platform_angle_device_context_volatile_* extensions 2020-10-27 ianelliott@google.com Enable debug-util markers with an env var/property 2020-10-27 syoussefi@chromium.org Vulkan: Remove VVL warning suppression for push constants 2020-10-27 jmadill@chromium.org Capture/Replay: Move exported data to start of header. 2020-10-27 jmadill@chromium.org Fix extension requirement for "World of Tanks". 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from abe2eff36f3c to 34ae8a475754 (1 revision) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 91ce213a1d88 to 8e2b7d03ccfd (2 revisions) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bb66fa41a163 to c1839ee3cedd (1 revision) 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 3b334b2b8e1a to 740ae9f60b00 (1 revision) 2020-10-27 xinghua.cao@intel.com Refactor uniform block test cases 2020-10-27 syoussefi@chromium.org Increase MAX_UNIFORM_BUFFER_BINDINGS to 72 2020-10-27 syoussefi@chromium.org Vulkan: Initial emulated prerotation support 2020-10-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5f7e3cf2 to e56348f0 (434 revisions) 2020-10-27 syoussefi@chromium.org Use 4 colors in Checkered test shader 2020-10-26 jmadill@chromium.org BinaryStream: Preserve 64-bit integer data. 2020-10-26 m.maiya@samsung.com Vulkan: Fix exposure requirements for EXT_texture_format_sRGB_override 2020-10-26 jmadill@chromium.org Capture/Replay Tests: Expand suppressions. 2020-10-26 m.maiya@samsung.com Vulkan: Add OES_shader_multisample_interpolation support 2020-10-26 jmadill@chromium.org Capture/Replay: Test improvements. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7d11021098f2 to 03f6ffd1dc46 (27 revisions) 2020-10-26 geofflang@google.com GL: Use ANGLE_GL_TRY for draw calls. 2020-10-26 jmadill@chromium.org Output nullptr pointer parameters correctly. 2020-10-26 jmadill@chromium.org Re-enable crash testing in angle_unittests. 2020-10-26 jmadill@chromium.org Fix uninitialize state in ProgramState. 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 69f07da41b3b to abe2eff36f3c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Manual verification with angle_perftestsTest: Test: Texture2DTestES3::ChangeTexSizeWithTexStorage Change-Id: I1dd6158a2e0fc49e438cba50edf03b75000b4e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505093Reviewed-by:
-
Matt Menard authored
Bug: b:168650771 Change-Id: Ied905968e428857f3890e4355db65c25b2dde282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496000Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#821802}
-
Bettina Dea authored
SafeBrowsingTabObserver was not being constructed on Android which meant that client side detection was also not enabled. In addition, the current experiment name is wrong for client side detection on Android. Bug: 1142983 Change-Id: I71778cb3d2a76283f130bc9636ab89f9485a53b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503338Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Auto-Submit: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#821801}
-
Yuki Shiino authored
SpinLock class is missing LOCKABLE annotation, so adds it. Also adds other lock function annotations. Change-Id: I9c75b6bd41aa63bd3a0350342ed4476c92174ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505690Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#821800}
-
Chong Gu authored
Add flag to allow generate_buildbot_json.py script to accept multiple gn isolate map files. Bug: 1080853 Change-Id: I756cbce16923839ba1ca8fc00f8d67a8df04edbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504210 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Frédéric Wang authored
This CL adds an security levels for registerProtocolHandler, for use in more highly privileged contexts such as extensions. They address some use cases described in the proposal of crbug.com/64100#c19 and follow-up discussions. Current levels are as follows and could be refined in the future: Level 0: Strictly follow the HTML5 specification (*). Level 1: Allow registration from cross-origin. Currently, the permission prompt does not work well in all extension contexts and requires user gesture. See crbug.com/1079333. Tests: - web_contents_impl_unittest.cc: Browser process same origin validation. - protocol_handler_apitest.cc: Web process validation and error messages, registration in extensions, browser process security level. (*) https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers Bug: 64100 Change-Id: I4e19300b313b1fe39b08d9e240981d08b71c5cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287304Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#821798}
-
Kramer Ge authored
Buffers can be released out of order by viz due to surface sync, so it is not safe to expect unreleased buffers are unused by the Wayland compositor. Right now the feature is off on Mutter so we can remove this code and figure out a different fix for mutter (e.g. a refactor). Change-Id: Ie3a9dd4c42bef79adca4d9a4a8b7e67fab59c852 Bug: 1133195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503331Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#821797}
-
Sebastien Lalancette authored
Added an AlertCoordinator to the BrowserContainerCoordinator, which will be used to handle link-generation failures coming from the LinkToTextMediator. Added a UserAction for when the user presses on the Share Page button of that alert. Bug: 1136043 Change-Id: I7e4e6c84000a7c760e46b8b7d5251c2de7e9c79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495262 Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#821796}
-
Ted Choc authored
After (ms) - 14238 Before (ms) - 59160 BUG=989569 Change-Id: Idc6372fcab314f13cbfd63b471ac916b932a16d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504634 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#821795}
-
Eric Orth authored
*Allow optionally enforcing that the name ends with a zero-length label (the root label). *Add additional validation that the name doesn't use DNS name compression, and that the name is within the max DNS name length. *Add an overload that takes a BigEndianReader as input. Better supports parsing within a DNS message when the name needs to be parsed to know its total length and where the next data starts after the name. These improvements should be useful in parsing HTTPS records. Bug: 1138620 Change-Id: Ice66aa880a8c5407af3bfd9a14d720d518ae2136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493153 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#821794}
-
dpapad authored
Specifically disabling: - LeaveSiteStillWarnsAfter - TimeOpenHistogram These tests seem to rely on subtle timing of the NewTabPage initial loading and are flaking on multiple platforms. Bug: 1142769,1139955 Change-Id: I848acd8ac9c4bd65945cb5070a87ecea46b27885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502771 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#821793}
-
Takumi Fujimoto authored
Sample failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9457 TBR=dtrainor@chromium.org Bug: 1128033 Change-Id: Ib7696c28e273f5762fe5718c429d8b1ec82e3444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505793Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#821792}
-
Ben Kelly authored
This creates an empty directory to be used to write the liburlpattern code. This library will be the URL pattern matching engine for the URLPattern web API being developed in: https://github.com/wicg/urlpattern The pattern syntax is based on the populat path-to-regexp library: https://github.com/pillarjs/path-to-regexp This is being developed as a separate library so that it can be a derivitive work of path-to-regexp using an MIT license. No code from path-to-regexp will be directly included here. Bug: 1141510 Change-Id: Ia695bf927c40723b3d5adc171fd2b8d3bb879772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486388Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#821791}
-
Shubham Aggarwal authored
This change makes it so that all tests in database_unittest.cc now run both with WAL mode on and off. Better test coverage will help us transition to using WAL mode by default in the future. Bug: 78507 Change-Id: I116a8151c1ab4919a78657e46df98b26eddb7f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490664 Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821790}
-
Matt Menke authored
And update all consumers to pass one in. Bug: 1082280 Change-Id: I97e2559616f01d600848025a16b916d583759504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497463Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
