GitLab

This was mystifyingly introduced by:
https://codereview.chromium.org/2014433002

It turns out that previously, this relied on calls to setStatusBarColor
based on theme color notifications when nothing changed.  This was
triggering a root level relayout, which hid this issue.

For now, force a root level relayout when attaching the recent
tabs page to the window.

BUG=623515

Review-Url: https://codereview.chromium.org/2109943002
Cr-Commit-Position: refs/heads/master@{#402681}

Create an async interface LoaderDelegate to delegate from c/b/loader to
the rest of content. This allows decoupling of loader so that it can
eventually be moved to a separate service.

Start by using it to remove the dependency on RenderViewHostImpl.

R=jam
BUG=622050

Review-Url: https://codereview.chromium.org/2098923002
Cr-Commit-Position: refs/heads/master@{#402680}

https://chromium.googlesource.com/chromium/src/+/188d4f93b

BUG=596060
TBR=skobes@chromium.org

Review URL: https://codereview.chromium.org/2109963002 .

Cr-Commit-Position: refs/heads/master@{#402679}

This change increases the timeout in
WebappActivityTestBase.waitUntilIdle and re-enables one test
that was failing on M testers due to a too short timeout.

BUG=614338

Review-Url: https://codereview.chromium.org/2108913002
Cr-Commit-Position: refs/heads/master@{#402678}

Removed the toggle between Presentation Mode and Fullscreen.
Renamed UpdateFullscreenWithToolbar to UpdateUIForTabFullscreen.
Fixed the fullscreen toolbar logic in BWC so that the toolbar state is
correct when we exit tab fullscreen.

BUG=579259

Review-Url: https://codereview.chromium.org/2089323002
Cr-Commit-Position: refs/heads/master@{#402677}

When getting screensize for powerwash reset, making sure the currentScreen is 'reset', not 'account-picker'.

BUG=615088
TEST=Multiple tests on M52, the corrupted powerwash proposal UI doesn't happen any more.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2109763003
Cr-Commit-Position: refs/heads/master@{#402676}

These might be useful to track as well.

BUG=none

Review-Url: https://codereview.chromium.org/2100703002
Cr-Commit-Position: refs/heads/master@{#402675}

For Cast builds, only cast desktop and cast audio-only products should use_alsa=true
by default.

BUG= internal b/29770818
TEST= Build several Cast platforms

Review-Url: https://codereview.chromium.org/2109753002
Cr-Commit-Position: refs/heads/master@{#402674}

Current generator's functions are not virtual and doesn't allow the subclass to have polymorphism for the mocks in the test. This CL makes those functions virtual and overridable.

BUG=617238

Review-Url: https://codereview.chromium.org/2105103002
Cr-Commit-Position: refs/heads/master@{#402673}

This CL does two things.
1. Introduce CancelAwareAnimatorListener to Chrome. For vanilla
AnimationListener in Android, onAnimationCancel() and onAnimationEnd()
will both be called if Animator is canclled. This is a confusing
behavior and it caused problems in various places.
2. Change the way security icon animation works in custom tab, making
it able to refresh its theme when the color of the toolbar changes.

Credit of this CL goes to tedchoc@.

BUG=604520
R=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2104053005
Cr-Commit-Position: refs/heads/master@{#402672}

BUG=623763
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2102453003
Cr-Commit-Position: refs/heads/master@{#402671}

Prior to this change it was possible for the AcceleratorRegistrarImpl
to outlive the WindowManager and then attempt to use it. This patch
ensures any AcceleratorRegistrarImpl are destroyed when the
WindowManager loses its connection.

BUG=none
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2105653003
Cr-Commit-Position: refs/heads/master@{#402670}

Change QuicBufferedPacketStore to store QuicReceivedPackets instead of QuicEncrypterPackets, since that is what the Dispatcher uses. Also to take a const clock. Add a method for checking if packets are buffered for a connection ID.

Also clang-format these files since they appear to be incorrectly
styled.

Merge internal change: 125777729
https://codereview.chromium.org/2099313003

Stop using next_packet_sequence_number_length in QuicPacketCreator.  No functional change.  Protected by FLAGS_quic_simple_packet_number_length.

Merge internal change: 125727775
https://codereview.chromium.org2101623003

Add QuicConnectionCloseDelegateInterface. No functional change expected. Not protected.

Merge internal change: 125703498
https://codereview.chromium.org/2099403002

Replace QUIC's PathMtuAckListener with a non-AckListener approach. Protected by FLAGS_quic_no_mtu_discovery_ack_listener.

Merge internal change: 125678921
https://codereview.chromium.org/2100763003

Change users of NextPacketNumberLength to GetPacketNumberLength in QuicPacketCreatorTest when GetPacketNumberLength is equivalent or better.

Merge internal change: 125674835
https://codereview.chromium.org/2104503003

Remove two tests from QuicConnectionTest because they were duplicates of those in QuicPacketCreatorTest.

Merge internal change: 125640116
http://crrev.com/2102713002

Deprecate FLAGS_quic_detect_memory_corrpution.

Merge internal change: 125572214
https://codereview.chromium.org/2107473002

Deprecate FLAGS_quic_disallow_multi_packet_chlo.

Merge internal change: 125572148
https://codereview.chromium.org/2102733002

Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

Merge internal change: 125563155
https://codereview.chromium.org/2102723002

Add functionality to explicitly set SNI in the QUIC test client

The QUIC test client currently sets SNI based on the request URL which
triggers the client to connect.  This is problematic for tests which
want to set the SNI to something else (in this
case: SSL compartments tests).  This change makes it possible for such
tests to explicitly override this setting.

Merge internal change: 125561343
https://codereview.chromium.org/2101003002

Deleting blank lines from argument list of HandshakeWithFakeClient

Merge internal change: 125459408
https://codereview.chromium.org/2099123003

Let QUIC respect HTTP2 Settings frame. Currently, only SETTINGS_HEADER_TABLE_SIZE is supported. Protected by FLAGS_quic_respect_http2_settings_frame, default true.

Merge internal change: 125448073
https://codereview.chromium.org/2102703002]

Make QuicSpdyStream::ParseHeaderStatusCode() inparam const.

No functional change.

* Use SpdyHeaderBlock::find() instead of operator[] so that |header| is
  not
  modified.
* Make |header| const (and pass by reference instead of pointer).
* Eliminate SpdyHeaderBlock copy in
  QuicSimpleServerStream::SendResponse().

Merge internal change: 125445090
https://codereview.chromium.org/2100213002

Add a new kMIDS (Max Incoming Dynamic Streams) config option, to eventually replace kMSPC.

Adds QUIC_VERSION_35 which allows endpoints to independently set max
open streams. Protected by FLAGS_quic_enable_version_35

Merge internal change: 125773608
https://codereview.chromium.org/2101353003

Flip recent QUIC flags.
https://codereview.chromium.org/2107943002/

Review-Url: https://codereview.chromium.org/2104633002
Cr-Commit-Position: refs/heads/master@{#402669}

This patch updates the code to prevent auto deducing to a raw pointer.

R=sky, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2110643002
Cr-Commit-Position: refs/heads/master@{#402668}

The pending demuxer read state is overwritten in too many cases to
be reliable, instead always use the flag instead of trying to have
it both ways.

The main issue this fixes is where there are parallel decodes and a
demuxer read outstanding, one decode completes with an error, and
the new decoder is initialized before the demuxer read completes.

Previously this would stomp the pending read state and we'd try to
issue a new demuxer read when the decoder initialization completed,
blowing up the demuxer in the process.

BUG=597605
TEST=new unittest

Review-Url: https://codereview.chromium.org/2110463003
Cr-Commit-Position: refs/heads/master@{#402667}

BUG=31519

Review-Url: https://codereview.chromium.org/2107893004
Cr-Commit-Position: refs/heads/master@{#402666}

This adds a 'required' entry to the exe:content_browser manifest
for content::mojom::ProcessControl in exe:content_gpu, allowing
the browser to connect to the ProcessControl interface in the GPU
process.

Also fixes a bug in InterfaceRegistry which was causing useful
log errors to be omitted when capability filters would block
interface connection and registration.

BUG=624112
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2102353002
Cr-Commit-Position: refs/heads/master@{#402665}

https://chromium.googlesource.com/skia.git/+log/3f0753d3ecce..26726d1ca7ed

$ git log 3f0753d3e..26726d1ca --date=short --no-merges --format='%ad %ae %s'
2016-06-28 robertphillips Spruce up batch info printouts GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2107013002
2016-06-28 fmenozzi Changes to Lua gradient scraping
2016-06-28 egdaniel Fix vulkan onGetWritePixelsInfo
2016-06-28 bsalomon Make lines a special case in GrShape
2016-06-28 bsalomon Revert of Make lines a special case in GrShape (patchset #5 id:120001 of https://codereview.chromium.org/2108523002/ )
2016-06-28 robertphillips Tighten up masking of colorType & alphaType in SkImageInfo serialization (for fuzzer bug)
2016-06-28 rmistry Update CT documentation on skia.org
2016-06-28 bsalomon Make lines a special case in GrShape
2016-06-28 rmistry Add blacklist for the Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_IMG_DECODE_100k_SKPs bot

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=benjaminwagner@google.com

Review-Url: https://codereview.chromium.org/2103403002
Cr-Commit-Position: refs/heads/master@{#402664}

Currently, the RenderWidgetHostViewChildFrame's do not implement this method.
This CL implements the method for RenderWidgetHostViewBase where the view will
forward the call to the TextInputManager. The TextInputManager will then call
its observers about the change. The tab's view in aura is an observer of the
TextInputManager which will in turn cancel any ongoing composition.

BUG=578168
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2098353005
Cr-Commit-Position: refs/heads/master@{#402663}

I will revert this CL once we have a build or two for data.

R=rsesek@chromium.org
BUG=622406

Review-Url: https://codereview.chromium.org/2104223002
Cr-Commit-Position: refs/heads/master@{#402662}

This patch updates the code to prevent auto deducing to a raw pointer.

R=agl, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2101863004
Cr-Commit-Position: refs/heads/master@{#402661}

This patch updates the code to prevent auto deducing to a raw pointer.

R=danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2101263003
Cr-Commit-Position: refs/heads/master@{#402660}

This CL removes style spans to follow the styles of the block
element(li, pre, td, and h1~6) when the text of the pasted
or merged element becomes a part of the block element.

BUG=226941
TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html

Review-Url: https://codereview.chromium.org/2102913002
Cr-Commit-Position: refs/heads/master@{#402659}

BUG=622030

Review-Url: https://codereview.chromium.org/2101153003
Cr-Commit-Position: refs/heads/master@{#402658}

fprintf(stderr) goes into a black hole when debugging on Windows.
Switch to WTFLogAlways, which has win-specific smarts.

R=eae@chromium.org

Review-Url: https://codereview.chromium.org/2105963002
Cr-Commit-Position: refs/heads/master@{#402657}

And use them when creating a eglImageKHR for a EGL_LINUX_DMA_BUF_EXT target.

BUG=chromium:478339
TEST=none
Signed-off-by: Vince Hsu <vince.h@nvidia.com>
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2039813002
Cr-Commit-Position: refs/heads/master@{#402656}

With WKWebView, there is no longer a trust level associated with the
current URL. This histogram will be used to validate that the WebState's
|lastCommittedURL| is equal to the WebController's
|currentURLWithTrustLevel:| before we remove the latter.

BUG=none

Review-Url: https://codereview.chromium.org/2091913002
Cr-Commit-Position: refs/heads/master@{#402655}

CUPS printers will now be selectable in the print menus.

NOTE: This does not enable printing to said printers.

BUG=607668

TEST=Launch chrome with --enable-native-cups flag, open print preview,
change printers.  See that CUPS printers are listed as available
printers.

Review-Url: https://codereview.chromium.org/1934013002
Cr-Commit-Position: refs/heads/master@{#402654}

The site engagement service decays origins which have not been accessed
in a week. However, if a user isn't using Chrome at all, the decay still
occurs.

This CL addresses this issue by persisting the last recorded time that
any engagement occurred. If too long a period passes (currently 10 days)
without *any* engagement, all scores have their last accessed time
adjusted to be relative to some number of decay periods prior to now
(currently set at 1 decay period), based on their offset to the last known
engagement time.

BUG=575504

Review-Url: https://codereview.chromium.org/2082953002
Cr-Commit-Position: refs/heads/master@{#402653}

Revert of Replace ICU with CED for auto encoding detection (patchset #4 id:120001 of https://codereview.chromium.org/2081653007/ )

Reason for revert:
This seems to have broken compile on Windows 8:

[46/8396] CXX obj\third_party\ced\src\compact_enc_det\ced.compact_enc_det_hint_code.obj
FAILED: obj/third_party/ced/src/compact_enc_det/ced.compact_enc_det_hint_code.obj
ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\ced\src\compact_enc_det\ced.compact_enc_det_hint_code.obj.rsp /c ..\..\third_party\ced\src\compact_enc_det\compact_enc_det_hint_code.cc /Foobj\third_party\ced\src\compact_enc_det\ced.compact_enc_det_hint_code.obj /Fdobj\third_party\ced\ced.cc.pdb
c:\b\build\slave\win8_gyp\build\src\third_party\ced\src\compact_enc_det\compact_enc_det_hint_code.cc(122): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win8_gyp\build\src\third_party\ced\src\compact_enc_det\compact_enc_det_hint_code.cc(122): warning C4018: '<': signed/unsigned mismatch
c:\b\build\slave\win8_gyp\build\src\third_party\ced\src\compact_enc_det\compact_enc_det_hint_code.cc(151): warning C4018: '<': signed/unsigned mismatch
c:\b\build\slave\win8_gyp\build\src\third_party\ced\src\compact_enc_det\compact_enc_det_hint_code.cc(169): warning C4018: '<': signed/unsigned mismatch

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP/builds/89

Original issue's description:
> Replace ICU with CED for auto encoding detection
>
> This is a drop-in replacement of ICU library performing automatic text
> encoding detection with CED (Compact Encdoing Detection).
>
> CED is used extensively in Google for every crawled web page,
> email message, query string, etc., and recently open-sourced for
> public use. (https://github.com/google/compact_enc_det)
>
> Also it is a much better alternative to ICU in terms of speed.
> ICU introduces significant regression in page loading (up to 30%):
>
> = ICU auto-detection vs. TOT =
> page_cycler.typical_25:cold_times.page_load_time 1085.13±9.31% 754.28±12.03% (30.49%)
>
> http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_21-20-58
>
> while CED adds virtually no additional loading time (delta < sigma):
>
> = CED auto-detection vs. TOT =
> page_cycler.typical_25:cold_times.page_load_time ms 705.70±9.49% vs. 760.31±11.90% (-7.74%)
>
> http://storage.googleapis.com/chromium-telemetry/html-results/results-2016-05-08_20-37-54
>
> With CED, it is feasible to turn on auto encoding detection by default
> so that web pages without encoding label can be taken care of. It will be
> done in a follow-up CL.
>
> BUG=597488
>
> Committed: https://crrev.com/13510755ac11e6e1f58c34ef8c9bd4cf925c8d70
> Cr-Commit-Position: refs/heads/master@{#402622}

TBR=tkent@chromium.org,jshin@chromium.org,jinsukkim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=597488

Review-Url: https://codereview.chromium.org/2109633003
Cr-Commit-Position: refs/heads/master@{#402652}

Revert of MD Settings: make chrome://[md-]settings/clearBrowserData URL work (patchset #7 id:120001 of https://codereview.chromium.org/2094223004/ )

Reason for revert:
Looks like this is causing CrSettingsPrivacyPageTest.PrivacyPage to fail on Mac10.9 and Mac ASAN

Original issue's description:
> MD Settings: make chrome://[md-]settings/clearBrowserData URL work
>
> R=michaelpg@chromium.org
> BUG=622037
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/a6ecac07f74cf819dc164bb91f721e596c261cd2
> Cr-Commit-Position: refs/heads/master@{#402614}

TBR=michaelpg@chromium.org,dbeam@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622037

Review-Url: https://codereview.chromium.org/2103653004
Cr-Commit-Position: refs/heads/master@{#402651}

If a DSO is linked against with --as-needed and the program contains no
strong references to any symbols in the DSO, the documented behaviour
is that the linker should not create a DT_NEEDED entry for that
DSO. However, if the program contains weak references to symbols in
the DSO, this results in an incorrect resolution for that symbol. In
Chromium this happens in particular for the symbol __pthread_key_create
(as a result of code inlined from a pthread header), which causes
the program to segfault. For more details, see the associated bug
and the related LLVM bug: http://llvm.org/pr28335

Work around this by linking against libpthread with --no-as-needed.

Because the problem only affects glibc, only do this when not
targeting NaCl or Android, neither of which normally uses glibc
as the C runtime library (NaCl can use glibc, but we haven't
observed this problem there).

BUG=623236
R=thakis@chromium.org,engedy@chromium.org

Review-Url: https://codereview.chromium.org/2094273003
Cr-Commit-Position: refs/heads/master@{#402650}

TEST=<new pipeline integration test>

Review-Url: https://codereview.chromium.org/2096813002
Cr-Commit-Position: refs/heads/master@{#402649}

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781

Review-Url: https://codereview.chromium.org/2101453002
Cr-Commit-Position: refs/heads/master@{#402648}

Currently chooser bubble and chooser dialog have different ChooserController
ownership models. For chooser bubble, the ChooserController is owned by
ChooserBubbleDelegate, which is a subclass of BubbleDelegate and BubbleManager
owns it. For chooser dialog, ChromeExtensionBluetoothChooser owns it, which
is a subclass of BluetoothChooser.

Since the ChooserController is only used by view classes, a better way is to
let ChooserContentView (for non-Mac) and ChooserContentViewCocoa (for Mac)
own it.

BUG=621216

Review-Url: https://codereview.chromium.org/2086663003
Cr-Commit-Position: refs/heads/master@{#402647}

BUG=609731
TBR=tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2109663004
Cr-Commit-Position: refs/heads/master@{#402646}

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2101263004
Cr-Commit-Position: refs/heads/master@{#402645}

  In order to roll GN 520de0f3..cadaad43 (r400967:r402556) and pick up
  the following changes:

  c0ff8864 Add GN split_list function.
  db530b15 Reland of actor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2104083002/ )
  74af4d66 Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ )
  9f1375ea Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
  01c8157e Remove calls to deprecated MessageLoop methods in tools.
  d6fd033c [Mac/iOS/GN] Document enable_stripping and enable_dsyms vs their GYP equivalents.
  120e860e Add documentation about no sources for GN guide.

TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2102313002
Cr-Commit-Position: refs/heads/master@{#402644}

In Material Design we display a white tab spinner for Incognito mode
tabs, but we need to also do so for dark themes.

R=avi@chromium.org
BUG=624106

Review-Url: https://codereview.chromium.org/2103073003
Cr-Commit-Position: refs/heads/master@{#402643}

When creating a new contact, the AutofillContact object is created with
both null phone number and null email address. Therefore, asserts that
one of them should be not null are not correct. This patch removes these
asserts.

BUG=624211

Review-Url: https://codereview.chromium.org/2101983004
Cr-Commit-Position: refs/heads/master@{#402642}