GitLab

Should be safe to reland after this build fix:
https://codereview.chromium.org/325483002/

BUG=350394
TBR=peter@chromium.org,dominicc@chromium.org,jochen@chromium.org,michaeln@chromium.org,kinuko@chromium.org

Review URL: https://codereview.chromium.org/318413002

git-svn-id: svn://svn.chromium.org/blink/trunk@175804 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/317413003

git-svn-id: svn://svn.chromium.org/blink/trunk@175803 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the master CL that contains the whole remaining Blink side.  It turns on Blob support in IDB, so it has to wait until the Chromium side has completely landed.

See https://codereview.chromium.org/18023022/ for the Chromium side.
See https://docs.google.com/a/chromium.org/document/d/1Kdr4pcFt4QBDLLQn-fY4kZgw6ptmK23lthGZdQMVh2Y/edit for the big picture document [chromium.org account required].
Read-only view at https://docs.google.com/document/d/1Kdr4pcFt4QBDLLQn-fY4kZgw6ptmK23lthGZdQMVh2Y/pub [no account required].

BUG=108012

Review URL: https://codereview.chromium.org/18590006

git-svn-id: svn://svn.chromium.org/blink/trunk@175802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This simplifies many boundary time computations all around the code.

BUG=361045

Review URL: https://codereview.chromium.org/322783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175801 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175793

BUG=380686
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/320923002

git-svn-id: svn://svn.chromium.org/blink/trunk@175799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With the three sides of the patch needed for 343327 landed, these temporary
casts are unnecessary. Removed.

BUG=343327

Review URL: https://codereview.chromium.org/313263005

git-svn-id: svn://svn.chromium.org/blink/trunk@175797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebInspector.TimelineModel.Events.RecordingStopped is sufficient.

BUG=361045

Review URL: https://codereview.chromium.org/324683002

git-svn-id: svn://svn.chromium.org/blink/trunk@175796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NotificationController has maintained NotificationClient with OwnPtr since r173468. And, NotificationClient should not be a null. We can return a reference on NotificationController::clientFrom().

BUG=none

Review URL: https://codereview.chromium.org/268353004

git-svn-id: svn://svn.chromium.org/blink/trunk@175795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add Debugger.ExceptionDetails to protocol. Use ExceptionDetails for pass error when exception in snippet (run or compile).

Console show the position of exception when exception happens in snippet.

BUG=346013

Review URL: https://codereview.chromium.org/290633009

git-svn-id: svn://svn.chromium.org/blink/trunk@175794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380686
TBR=humper@google.com

Review URL: https://codereview.chromium.org/327513003

git-svn-id: svn://svn.chromium.org/blink/trunk@175793 bbb929c8-8fbe-4397-9dbb-9b2b20218538

multi-event type targets.

This patch performs a significant refactoring of the
DeviceSensorEvent{Controller,Dispatcher} and related classes.
It provides new Base classes to allow simple implementation of
APIs involving multi-event type non-window targets (e.g. Battery
Status API). Additionally it makes the implementation of existing
event-based APIs (device_orientation, device_light) simpler and
more compact.

In particular the following new classes have been added:
* DeviceEventControllerBase and DeviceEventDispatcherBase
(derived from by the Battery Status API).
* DeviceSingleWindowEventController is more specific and
contains functionality necessary for single-event type window
target APIs (used by Device Motion/Orientation and Device Light
APIs).

BUG=122593, 360068

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175686

Review URL: https://codereview.chromium.org/315573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/322763002

git-svn-id: svn://svn.chromium.org/blink/trunk@175791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045

Review URL: https://codereview.chromium.org/318343003

git-svn-id: svn://svn.chromium.org/blink/trunk@175790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380312
R=yurys, pfeldman@chromium.org, amikhaylova@google.com

Review URL: https://codereview.chromium.org/317703003

git-svn-id: svn://svn.chromium.org/blink/trunk@175789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Using VisiblePosition has some not required performance implications.

BUG=None

Review URL: https://codereview.chromium.org/307353002

git-svn-id: svn://svn.chromium.org/blink/trunk@175788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The old color generator had the dependency from line number too and it was a bad idea because
after a change in the source file the entry would change the color.

Also the entry colors had implicit dependency from the order of processing.

BUG=382116
R=alph@chromium.org

Review URL: https://codereview.chromium.org/319363002

git-svn-id: svn://svn.chromium.org/blink/trunk@175787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo, vsevik

Review URL: https://codereview.chromium.org/311193002

git-svn-id: svn://svn.chromium.org/blink/trunk@175786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<integer>, <angle>, <number>, <length> and <percentage>.

BUG=377503,339899

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175574

Review URL: https://codereview.chromium.org/302643004

git-svn-id: svn://svn.chromium.org/blink/trunk@175785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an SVG has either intrinsic width or height but not both, and a
intrinsic ratio, the missing intrinsic width or height can be
calculated. Doing so enables us to return correct intrinsic width and
height for SVG images in more cases when the image has no renderer.

Also, this patch removes the unspecified use of the viewBox attribute
as the source of intrinsic size. A small number of tests depended on
this and has been updated. The reasoning to make this change is
because we don't use the viewBox for intrinsic size in any other
context than SVGImage. And we only use it until the renderer has a
containerSize() anyway.

http://www.whatwg.org/specs/web-apps/current-work/multipage/edits.html#dom-img-width
http://www.whatwg.org/specs/web-apps/current-work/multipage/edits.html#dom-img-height

BUG=376895

Review URL: https://codereview.chromium.org/308643002

git-svn-id: svn://svn.chromium.org/blink/trunk@175784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Should check whether document.settings() is available or not when updating GenericFontFamilySettings.

Looking at crash reports - WebCore::StyleEngine::updateGenericFontFamilySettings, document().settings() is probably null. In the case, we should not update GenericFontSettings.

BUG=376525
TEST=It is very hard to reproduce crashes reported in crbug.com/376525. Will check # of crash reports to see whether the bug is really fixed or not.

Review URL: https://codereview.chromium.org/304033005

git-svn-id: svn://svn.chromium.org/blink/trunk@175783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a preparation for moving WebSocketChannelClient to the heap.

This CL adds a template specialization to CrossThreadCopier.h so that ThreadableWebSocketChannelClientWrapper* can be passed to createCallbackTask().

BUG=340522

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174956

Review URL: https://codereview.chromium.org/267323004

git-svn-id: svn://svn.chromium.org/blink/trunk@175782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add test for frame model. Note there are still discrepancies wrt
how time per category is computed for timeline records -- these will
be the subject of a separate patch.

BUG=361045

Review URL: https://codereview.chromium.org/320523004

git-svn-id: svn://svn.chromium.org/blink/trunk@175781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/319603007

Review URL: https://codereview.chromium.org/319603007

git-svn-id: svn://svn.chromium.org/blink/trunk@175780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes a long-standing editing bug that a Range object returned by
Selection.getRangeAt() may not be equivalent to the Range used to set selection
with Selection.collapse().

FrameSelection.setSelectedRange sets a Range without canonicalization:
https://src.chromium.org/viewvc/blink?revision=169100&view=revision
Hence this patch adopts it.

Following is the implementation detail.
DOMSelection.cpp:
- When selection.collapse(node, offset) is called, we create a caret Range corresponding to node and offset and pass it to FrameSelection.setSelectedRange.

FrameSelection.cpp:
- If new Selection is collapsed, use old isDirectional. This is following the current behavior.

LayoutTests:
editing/selection/no-range-canonicalization.html
- The main test added to current setRange test.

fast/css/counters/counter-before-content-not-incremented.html
- Some tests expect the collapse method to canonicalize Selection so we need to set a exact DOM position.

editing/editing.js
- Some tests expect the collapse method to canonicalize Selection at start so I canonicalize that as the old Blink collapse implementation.

editing/selection/DOMSelection-DocumentType.html
- The current HTML spec says that if Range is set DocumentType node, we should throw type exception. 

editing/selection/selection-invalid-offset.html
- We should throw exception when the method is called with a offset larger than length of a node.
- Remove a redundant case.


BUG=346613

Review URL: https://codereview.chromium.org/225303002

git-svn-id: svn://svn.chromium.org/blink/trunk@175779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The workaround seems specific to JSC, and thus not needed in Blink.

BUG=None

Review URL: https://codereview.chromium.org/293983020

git-svn-id: svn://svn.chromium.org/blink/trunk@175778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The following chromium commits fixed chromium code to use  new
public web methods which take creation context and isolate:

WebBlob
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275420

WebDOMError
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275396

WebDOMFileSystem:
- https://src.chromium.org/viewvc/chrome?view=rev&revision=275291

BUG=369451

Review URL: https://codereview.chromium.org/326573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We don't have to hold the FormData instance to be used by createRequest()
as a class member. It's instantiated right before createRequest() call.
We can just allocate it on stack.

BUG=none
R=ricea,tkent

Review URL: https://codereview.chromium.org/314283005

git-svn-id: svn://svn.chromium.org/blink/trunk@175776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To apply XSLStyleSheet, we only need the first one. We don't need
to have all XSL stylesheets if the XML document has more than two
XSL stylesheets. So modified not to add XSLStyleSheet to
StyleSheetCandidateNodes. Instead, modified to make StyleEngine have
the first XSLStyleSheet.

BUG=367689
TEST=No new test, because this patch is just for refactoring.

Review URL: https://codereview.chromium.org/257363002

git-svn-id: svn://svn.chromium.org/blink/trunk@175775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before this patch, |Heap::findGCInfo()|'s iteration on
AttachedThreadStateSet was not guarded. This triggered "modification
while iteration" assert when |Heap::findGCInfo()| was called from
non-safepoint.

This patch exposes |ThreadState::threadAttachMutex()| and
|Heap::findGCInfo()| will acquire lock on it when we are not in safepoint.

Unfortunately there are no trybot which has an ENABLE(GC_TRACING) flag.
NOTRY=true
TEST=content_shell --dump-render-tree http/tests/workers/terminate-during-sync-operation-websql.html wont crash.
BUG=380474

Review URL: https://codereview.chromium.org/311263008

git-svn-id: svn://svn.chromium.org/blink/trunk@175774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: mark the test as flaky.

BUG=338794, 192172
TBR=dcheng@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/318343002

git-svn-id: svn://svn.chromium.org/blink/trunk@175773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There seems to be some cases where a SVGSVGElement wrapper is gc-ed while the SVGSVGElement is alive.
However, |m_transform| and other properties held by SVGViewSpec manage its lifetime via the SVGSVGElement v8 wrapper.

This patch avoids the situation by keeping the context SVGSVGElement wrapper alive from SVGViewSpec wrapper.

BUG=379998

Review URL: https://codereview.chromium.org/315893002

git-svn-id: svn://svn.chromium.org/blink/trunk@175772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Scheme has been compared in case-sensitive manner. However, according to spec, scheme must be compared in an ASCII case-insensitive manner by user agents.

Merge from WebKit : http://trac.webkit.org/changeset/169670

BUG=none

Review URL: https://codereview.chromium.org/323493003

git-svn-id: svn://svn.chromium.org/blink/trunk@175771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380075

Review URL: https://codereview.chromium.org/312253002

git-svn-id: svn://svn.chromium.org/blink/trunk@175770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=340522

Review URL: https://codereview.chromium.org/319863003

git-svn-id: svn://svn.chromium.org/blink/trunk@175769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=isherman@chromium.org, tkent@chromium.org
BUG=380603

Review URL: https://codereview.chromium.org/319443003

git-svn-id: svn://svn.chromium.org/blink/trunk@175768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

loadRequest() was calling load() before
http://trac.webkit.org/changeset/129462 but no longer calling it. The
same about revalidateResource(). Give them new names describing what's
done in them.

Also, this CL makes some style fix in them.

BUG=none
R=japhet

Review URL: https://codereview.chromium.org/318003002

git-svn-id: svn://svn.chromium.org/blink/trunk@175767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixed the failure.
https://codereview.chromium.org/319083003/

BUG=347109
R=ricea

Review URL: https://codereview.chromium.org/319873004

git-svn-id: svn://svn.chromium.org/blink/trunk@175766 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/316123003

git-svn-id: svn://svn.chromium.org/blink/trunk@175764 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Objects in XMLDocumentParser::m_currentNodeStack are correctly traces in
Oilpan. We don't need ref/deref.

Also, this CL replace one instance of Vector<Element*> with
HeapVector<Member<Elemenet>>.

BUG=357163

Review URL: https://codereview.chromium.org/320773002

git-svn-id: svn://svn.chromium.org/blink/trunk@175763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357163

Review URL: https://codereview.chromium.org/320233002

git-svn-id: svn://svn.chromium.org/blink/trunk@175762 bbb929c8-8fbe-4397-9dbb-9b2b20218538