- 04 Sep, 2019 40 commits
-
-
David Roger authored
As measured by the histogram Signin.TokenServiceDiceCompatible, we see that ~1% of the users on Canary are not migrating their tokens correctly for Dice. This CL removes the edge cases in ShouldMigrateToDice(), so that all users should now migrate their token service for Dice. The edge cases were: 1) account tracker service migration not completed 2) hosted domain information missing The migration will now have the following behavior for these cases: 1) Dice migration will happen even if the account tracker migration is not done 2) if the hosted domain information is missing, we use IsNonEnterpriseUser(). This parses the email of the user and matches the domain with a list of known non-enterprise domains. If the domain is known to be non-enterprise, the token won't be revoked. Otherwise, the token is likely to be enterprise and should be revoked. Change-Id: I1d7fb12874e274edd8aea8af27fb5f77fa9f8b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782617Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#693075}
-
Matthieu Rigolot authored
Entering those strings in a <input type=number> leads to validation messages not being displayed in certain cases: - rangeUnderflow (bug985330) - rangeOverflow - stepMisMatch This is due to Decimal::FromString not recognizing it as valid, hence returning NaN incorrectly. decimal.h and the spec: https://html.spec.whatwg.org/#valid-floating-point-number say it should be supported. Fixes it and adds appropriate tests in wtf_unittests and in web_tests. Bug: 985330 Change-Id: Ic3a3bb1ca855ebcc13f96aac16c31937a2cba0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773262 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#693074}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a1bf69967a32..1f6f69209ec2 git log a1bf69967a32..1f6f69209ec2 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 2c5ed16ba97d..9b3cc3e05337 (5 commits) Created with: gclient setdep -r src/third_party/angle@1f6f69209ec2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: Ie95392236b897780b413f6b2b2864438e6354957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784383Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693073}
-
David Roger authored
Bug: 975524 Change-Id: Iafd0d275778777146af7c1cd47389facb127af31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778873 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#693072}
-
Maksim Sisov authored
After https://crrev.com/c/1726051, the software compositing path became broken. The reason is that WaylandCanvasSurface used to be sending pending buffers without waiting for the last submitted buffer to be processed. This resulted in hitting the DCHECK(!pending_buffer_) on the host side. This CL fixes the issue by implementing a queue of pending buffers and limiting the possible number of buffers that can be created. Basically, it does the same job as GbmSurfacelessWayland now. Bug: 930664 Change-Id: Ia3af20e8dbfc74f672ffbf8fb2a3661182a9723e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780825 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#693071}
-
David Roger authored
Bug: 975588 Change-Id: I6915f7bd49909b3bdec9e0ed61d8c1938d7c9bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782159 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e7c719c3e85f..decbf9926c9c git log e7c719c3e85f..decbf9926c9c --date=short --no-merges --format='%ad %ae %s' 2019-09-04 perezju@chromium.org [Telemetry] Write intermediate results during results.Finalize Created with: gclient setdep -r src/third_party/catapult@decbf9926c9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:981349 Change-Id: Id28cd97bbb4454e50f1687487e789f632958626c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784382Reviewed-by:
-
Carlos Caballero authored
Remove references in /base/test/launcher MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor for main functions and SingleThreadTaskEnvironment for tests instead. Both are no op changes. This CL was uploaded by git cl split. R=erikchen@chromium.org Bug: 891670 Change-Id: Ic8ca95716f8679b687f586893f7033802f022432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780827 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#693068}
-
Carlos Caballero authored
MessagePumpType should be used instead. Bug: 891670 Change-Id: I6e73c7d3197beca3885aefbf71a7a64a26e42efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777868 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#693067}
-
Miyoung Shin authored
This CL converts DocumentInterfaceBroker{Ptr, Request} in content, blink, extension and media to the new Mojo types and uses pending_remote<blink.mojom.DocumentInterfaceBroker> in document_scoped_interface_bundle.mojom and pending_receiver<blink.mojom.DocumentInterfaceBroker> in frame_messages.mojom. Bug: 955171, 978694 Change-Id: Ic0ccabb445febbf8b2bd81aa754fc0abecfb77b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781900 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693066}
-
Sigurd Schneider authored
This CL fixes a race-condition in CoverageView, and makes CSSModel remember whether it was covering CSS data after suspension. Bug: chromium:1000155 Change-Id: I5a454fbb10090e3f0bcdd69dd416336895a47b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781460 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#693065}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/80aa9325dba3..dcb680fa3dff git log 80aa9325dba3..dcb680fa3dff --date=short --no-merges --format='%ad %ae %s' 2019-09-04 vapier@chromium.org cros_run_unit_tests: sanity check --packages 2019-09-04 vapier@chromium.org cros_run_unit_tests: do not reraise final failure Created with: gclient setdep -r src/third_party/chromite@dcb680fa3dff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iea9bc366a8a97e0d6f1eb7c340a27e5c5557ef75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784381Reviewed-by:
-
Stephane Zermatten authored
This change is meant to provide extra information to debug UNEXPECTED_JS_ERROR and UNEXPECTED_ERROR we get from time to time in production. Bug: b/139791239 Change-Id: I74b4d284a70e9a4082ce64b493f1fdd6c0a7488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771910 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693063}
-
Jose Dapena Paz authored
blink::ImageLayerBridge::RegisteredBitmap declares now its move constructor and assignment operator as noexcept with default implementation. This requires all its parts to be move constructible and assignable. SharedBitmapIdRegistration was missing noexcept declarations. Bug: 819294 Change-Id: I1304e4666141355c61780d69d1669b5c49df4baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768616Reviewed-by:
enne <enne@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#693062}
-
Benoît Lizé authored
Adds an option to show the total footprint of an allocator (one of malloc(), partition_alloc and V8) in parse_smaps.py. Example output: $ tools/android/native_lib_memory/parse_smaps.py --pid 12803 \ --show-allocator-footprint partition_alloc [...] Footprint from partition_alloc: 13648 kB Bug: 998048 Change-Id: I9b9b062565e56188979c43380a411bca0f2db282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781645 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#693061}
-
Benoît Lizé authored
Periodic reclaim is enabled by default, remove the feature. As a consequence, remove the no-op DeprecatedReclaim() call, and its call site. Bug: 942512 Change-Id: I916dfa1f1aee17bc3f3ac8a1de16ea2c1d987b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782698Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693060}
-
Alexandre Courbot authored
Add a new VP8 accelerator that supports the upstream UAPI for VP8. This is just a port of the legacy VP8 accelerator to use the upstream headers and request API. It has not been thoroughly tested yet. Bug: 965375 Test: None yet. Change-Id: Ib06b2cc39a32beefa7314ae03d9ea15f8abc90f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761883 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693059}
-
Jan Wilken Dörrie authored
TBR=manucornet@chromium.org Bug: 1000463 Change-Id: I99fbce482a66932c70d0af8dfb911f11bd7242ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782844Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#693058}
-
Michael Hablich authored
The previous owners are no longer working at Google and thus do not have access to UMA. R=yangguo@chromium.org, bmeurer@chromium.org Change-Id: I6b967c831d4ee6ea00de851e50087a5c6a3977c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777866Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Michael Hablich <hablich@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#693057}
-
Benoît Lizé authored
Code pinning was an experiment, which is not supported on mainstream Android platforms. Remove the code for it. Bug: 929926 Change-Id: I5f0cbd8ba90e3c1b3eaa87850b41b16642257025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781148Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#693056}
-
Jan Wilken Dörrie authored
TBR=lanwei@chromium.org Bug: 1000530 Change-Id: I87915513ddc6735bd383d5bd96d703cae79c65a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782842Reviewed-by:
-
Eliot Courtney authored
New ArcPictureInPicture flag set to enabled by default determines whether picture-in-picture is enabled/disabled in ARC. Enabled does not necessarily mean the feature is activated in ARC, but rather that if the Android developer option setting is set to DEFAULT, then this flag can determine whether the feature is activated or not. Android CLs: ag/9303889 ag/9309348 allows PIP to run if "Default" is selected in developer options --disable-features=ArcPictureInPicture in /etc/chrome_dev.conf disallows PIP to run if "Default" is selected in developer options Bug: 140200582 Test: --enable-features=ArcPictureInPicture in /etc/chrome_dev.conf Change-Id: I84ffaf43baf750244f285b705f3ddfd8750b9431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783805Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693054}
-
Jeevan Shikaram authored
This CL changes the height of permission rows to match mocks. Old view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409972&signed_aid=4Um3E86MJiRgjVynZpjLcQ==&inline=1 New view: https://bugs.chromium.org/p/chromium/issues/attachment?aid=409971&signed_aid=IzrDIjCWG_3pVKqgbk0Vxg==&inline=1 Bug: 999929 Change-Id: I8806bc2d585ea6e32e5081120ebe0cfa4461112b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784025 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#693053}
-
Luciano Pacheco authored
Scroll issue introduced CL:1636665, which replaced a call to mergeItems() method in a base class to super, however the immediate parent class |Grid| also has the mergeItems() method, which was interfering with the scroll. This CL reverts back to call this method from |List| base class. Test: manually Bug: 993068 Change-Id: I19d225dcc4277a409e824c7cac580c571ba1f051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783690 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#693052}
-
Jinsuk Kim authored
- If swiped over the peek threshold, fades to 50% opacity. - If items to show in the navigation sheet <= 3, skip peek state and expand fully. Bug: 991765, 991794 Change-Id: I64200e7405c51922c20d08c882036627148b5038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778102Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#693051}
-
Mike Dougherty authored
A JavaScript URL can not be created with an empty string. Attempting to do so will throw an exception, so check if the strings are non empty first. Additionally, postMessage can not be called with an empty string for the targetOrigin parameter. If the iframe element does not have a src attribute, use “*” instead to forward the context menu message to a child frame. Bug: 911899 Change-Id: I866bec11fa48c3a0ef5b95a6a628a64384d9da59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779423 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#693050}
-
Marc Treib authored
With this change, callers have to write new LoginDatabase(path, IsAccountStore(true)) instead of new LoginDatabase(path, /*is_account_store=*/true) which is clearer (no way to forget the comment), especially if any other (boolean) parameters are added at any later point. Bug: 998455 Change-Id: Ieb81b06ec86b628ecb2471a8be83b87b0807070e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782168Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693049}
-
Vadym Doroshenko authored
Bug: 994291 Change-Id: I8b507abd244faa0058c575becf46aae7e6b3bb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780837 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#693048}
-
Eric Willigers authored
The following are now implemented in WebAppRegistrar: - FindAppWithUrlInScope - IsLocallyInstalled This avoid repeated prompts to install a PWA that has already been installed. Bug: 891172,999418 Change-Id: I33343bb23ef022487d8ced1d7584ee4e08a18d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741726 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#693047}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextClientRequest and NetworkContextClientPtr to new Mojo types. It also updates SetClient from network_context.mojom. Bug: 955171, 978694 Change-Id: If2cdeefd51b7989019f78a26b4e3ec066567ffb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781989Reviewed-by:
-
Yuzu Saijo authored
This CL enables OomIntervention purge v8 feature by default. This used to be overridden by Finch and was made true for 100%. bug: Change-Id: I4a10ffa4b128d8d7acfb13bba57c2e2f42843201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784024Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#693045}
-
Andrew Luo authored
Bug: 997267 Change-Id: Icb17aa6d3eb77ba14ca890eb9cc2eecaaf822787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768907 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#693044}
-
Shik Chen authored
The background page might be killed by Chrome when idle. Use onMessageExternal listener to prevent race condition when running test. The companion CL in Tast is CL:1779777. Bug: b:140358697 Test: With a manually added sleep(20), do $ tast run <dut> camera.CCAUIPreviewPerf Change-Id: I3b8b6e9a56f6cf69983f3984a59e9a423ef42d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781924Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#693043}
-
Hitoshi Yoshida authored
This reverts commit 5c872c1a. Reason for revert: Postpone landing the CL to change APIs Original change's description: > IDL: Fix invalid extended attributes > > An invliad extended attribute [Enabled] was used in IDLs of WebRTC, > and some APIs are visible regardless a runtime enabled feature. > This CL fixes the IDL description and hide them behind a flag. > > > Bug: 999690, 986069 > Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923 > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Florent Castelli <orphis@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693038} TBR=peria@chromium.org,hta@chromium.org,haraken@chromium.org,guidou@chromium.org,orphis@chromium.org Change-Id: I9d2ddcdf6de7cb79139c5b6e15eb8920d6a34d98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 999690, 986069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783693Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#693042}
-
Luciano Pacheco authored
Move apps in //ui/file_manager/ to use chrome:// URL in unittest. After moving these apps, js_unit_tests build template and script aren't needed anymore, thus removing it. This is a follow up of CL:1767297. Bug: 991105 Change-Id: I51553b7dda063b35e8f957838e96f7599cd6df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775854 Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#693041}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e054ff2683ba..86c39c71262d git log e054ff2683ba..86c39c71262d --date=short --no-merges --format='%ad %ae %s' 2019-09-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 31b524cf60b7..a1bf69967a32 (8 commits) 2019-09-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 920100cd4246..fbc146e97f30 (6 commits) Created with: gclient setdep -r src/third_party/skia@86c39c71262d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:None,chromium:None Change-Id: I50a988cce59f22843519828cfef87e62552d8ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784054Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ac9e322afcdc..80aa9325dba3 git log ac9e322afcdc..80aa9325dba3 --date=short --no-merges --format='%ad %ae %s' 2019-09-04 vapier@chromium.org cros_run_unit_tests: make disabled test list a little nicer Created with: gclient setdep -r src/third_party/chromite@80aa9325dba3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3806f8bc163cc8c9359fa0f4224e47f173af7a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784198Reviewed-by:
-
Hitoshi Yoshida authored
An invliad extended attribute [Enabled] was used in IDLs of WebRTC, and some APIs are visible regardless a runtime enabled feature. This CL fixes the IDL description and hide them behind a flag. Bug: 999690, 986069 Change-Id: I1214c717706f52dacdc0648aa8d8ddeb951ea888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781923Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#693038}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b931165..f26909d1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I547dd8cdc2e682346bbecaff4f42412087a258a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784197Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693037}
-
Kurt Horimoto authored
Currently, the omnibox gets focused by VoiceOver when an overlay is displayed over the content area. This CL post a notification to focus the overlay UI's view upon completion of its presentation instead. Bug: 999394 Change-Id: I059fc6bf32a3a0e0ba06f94b88cf023e1278fa72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777084Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693036}
-
