- 05 Dec, 2017 40 commits
-
-
Bruce Dawson authored
message_compiler.py checks to make sure its results match those generated by mc.exe, but these checks are only valid for a given version of mc.exe, because the output changes with every new Windows 10 SDK version. The checking is disabled for SDK versions other than 10.0.15063 but only for .man files. This change extends the disabling of checking for .mc files also, due to observed failures. Bug: 774669 Change-Id: I618f68d8926b73621192e7933aea5d264fedd214 Reviewed-on: https://chromium-review.googlesource.com/807205Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521577}
-
Aleks Totic authored
Part 2 of inline containing block patch. Stores inline-cb on NGOutOfFlowPositionedDescendant Bug: 740993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib3ed1dfe654f691f38a2ee0069177bc78fca51ce Reviewed-on: https://chromium-review.googlesource.com/804994 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521576}
-
Ken MacKay authored
Bug: Change-Id: I0c44d05c6b2c94f849621fb6d9073ad4d1faba62 Reviewed-on: https://chromium-review.googlesource.com/807587Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#521575}
-
Shanmuga Pandi M authored
As per the spec[1], Constructing CSSURLImageValue should throw an error, if the URL is invalid. [1] https://drafts.css-houdini.org/css-typed-om-1/#dom-cssurlimagevalue-cssurlimagevalue Bug: 791434 Change-Id: I06ae5dad378ca91ce827f64ff56498a06c9963af Reviewed-on: https://chromium-review.googlesource.com/805635Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#521574}
-
Theresa Wellington authored
BUG=778736 Change-Id: I44217534a8aba3c07d113b687c4065864d6303c0 Reviewed-on: https://chromium-review.googlesource.com/806978Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521573}
-
Theresa Wellington authored
Start closing the bottom sheet before clearing URL focus on backpress to prevent "Search or type URL" from temporarily showing while the bottom sheet is closing. BUG=789775 Change-Id: I79bc1013b5dc91cc4ff94a8df86a7df7996b2d69 Reviewed-on: https://chromium-review.googlesource.com/807345Reviewed-by:
-
Emircan Uysaler authored
This CL adds a fallback for reading canvas content when async callback returns false. It looks like this ReadbackTextureAsync() is not supported for certain Intel CrOS devices, see below bug for more details. Bug: 788386 Change-Id: I691ce745b2703af8dab25b5c703427fe7b9b6f73 Reviewed-on: https://chromium-review.googlesource.com/804831 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521571}
-
Zhongyi Shi authored
Bug: 774622 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iebb15655a503c33d674b1a1cb636ea788ffdecde Reviewed-on: https://chromium-review.googlesource.com/803632Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521570}
-
khmel authored
This fixes the issue when Linux implementation of the assigning app icon for the window does not request image representation and as result icon is not loaded. Bug: 779463 Test: Manually Change-Id: I33ac3733ad1a428c6a448bc3845d2589ff640d09 Reviewed-on: https://chromium-review.googlesource.com/807398Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#521569}
-
Tom Sepez authored
As the syscall_broker process becomes more capable, it is important not to expose all the new capabilities to old clients which do no require them. Introduce a set of flags to track allowed commands. Rename broker_common.{cc,h} to broker_command.{cc,h} since all the contents are related to commands issued to the broker. Consolidate client/host side checks in this new file. Parameterize some tests so we cover both client/host denials. Tidy, brace initialize some vectors for readability. Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.linux:linux_mojo Change-Id: I1ca23543f54e3eb5445bd476c24cf4a1bed06c37 Reviewed-on: https://chromium-review.googlesource.com/801936 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:Antoine Labour <piman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#521568}
-
Yuwei Huang authored
This CL adds a blur view to the HostView when the app becomes inactive (transitioning to background, etc.) and removes it when the app becomes active again. Screenshot: https://drive.google.com/open?id=1UrWMUc-j0rRS-DQJ5zLLZ4_dTGgLohVr Bug: 791112 Change-Id: Ic66c57c939bb607ad7b740cb8112bd449cd20d45 Reviewed-on: https://chromium-review.googlesource.com/807402 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#521567}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/60b1b6e76e98..06ab3836f779 $ git log 60b1b6e76..06ab3836f --date=short --no-merges --format='%ad %ae %s' 2017-12-04 bsalomon Restore ability to dump SKSL in addition to GLSL 2017-12-04 kjlubick Add release_version as dimension for ChromeOS tasks 2017-12-04 reed add util to compare images 2017-12-04 csmartdalton Fix ANGLE build with extended clang warnings Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I266fb711815ff9e0be1d3414106e01913a345faf Reviewed-on: https://chromium-review.googlesource.com/807308Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521566}
-
Jay Civelli authored
If a test produced non valid UTF8 characters, the test runner would fail as it would provide invalid UTF8 to the JSON python library. We now sanitize the output. Bug: 791794 Change-Id: I635d1dbb9fdf2601112bed2953cae0e2c7e9ae92 Reviewed-on: https://chromium-review.googlesource.com/807386Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521565}
-
Ojan Vafai authored
This reverts commit 52dda118. Reason for revert: Broke compile on linux. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/54249 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/80407 https://uberchromegw.corp.google.com/i/chromium.gpu/builders/GPU%20Mac%20Builder/builds/108044 Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277,777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: I437f1c196351de49b83941a905a17a7add698abc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277, 777650 Reviewed-on: https://chromium-review.googlesource.com/807589Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521564}
-
Jay Civelli authored
Made RemovableStorageWriter a chrome service and changed ImageWriterUtilityClient to use the service instead of UtilityProcessMojoClient, which is being deprecated. ImageWriterUtilityClient now requires a service_manager::Connector when created. As a result, extensions::image_writer::Operation which creates an ImageWriterUtilityClient and all its derived classes now also take a connector. This patch was tested manually on Windows and Mac by using the Chrome OS recovery tool [1] and writing a recovery image on a USB stick. [1] http://bit.ly/2jFtsZZ Bug: 790024 Change-Id: Ie31c123e189ccd0134f9fc63a5dd7238011bebca Reviewed-on: https://chromium-review.googlesource.com/786257Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#521563}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b278ddd93923..873be6fd45b7 $ git log b278ddd93..873be6fd4 --date=short --no-merges --format='%ad %ae %s' 2017-12-04 agable Update depot_tools bleeding-edge win git to 2.15.1.2 Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I5ef3cdf1f7fc5dbc1a387cb1346095e6e80a7b62 Reviewed-on: https://chromium-review.googlesource.com/806649Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521562}
-
Thomas Anderson authored
This reverts commit 52dda118. Reason for revert: Breaks Linux x64 build: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F54249%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > [Media Router] Better sink availability tracking > > - When sink availability changes for an MRP, start/stop observing sinks only for that MRP > - Make WiredDisplayMRP report sink availability updates > > Bug: 789277,777650 > Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 > Reviewed-on: https://chromium-review.googlesource.com/794106 > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521550} TBR=imcheng@chromium.org,takumif@chromium.org Change-Id: Id4d13f0b2097ccfe398b05ce239d21c5d3c2b626 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789277, 777650 Reviewed-on: https://chromium-review.googlesource.com/807588Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521561}
-
Derek Cheng authored
TBR=vitalybuka@chromium.org Bug: 791791 Change-Id: Idd34d0e94153505e4bf151df5d8f0e021adea420 Reviewed-on: https://chromium-review.googlesource.com/807385Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521560}
-
Hongchan Choi authored
This patch adds 3 use counters for AudioWorket: - AudioWorkletAddModule - AudioWorkletGlobalScopeRegisterProcessor - AudioWorkletNodeConstructor Note that AudioWorklet.addModule() method is inherited from Worklet class, so we cannot install the tracker via WebIDL. Instead, this CL uses AudioWorklet::NeedsToCreateGlobalScope() check as a counter trigger, which is invoked when Worklet.addModule() gets called. Bug: 785044 Change-Id: I7023b90b538a66003dcba3805592d692b1461eff Reviewed-on: https://chromium-review.googlesource.com/770139Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521559}
-
Yuly Novikov authored
BUG=791656 TBR=eyaich@chromium.org Change-Id: I5cb3a2438db14009a308e3489d7719a53bf4134d Reviewed-on: https://chromium-review.googlesource.com/806445Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#521558}
-
calamity authored
This reverts commit 4a7a6504. Reason for revert: Breaking on https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/46433 Original change's description: > Fix flaky SyntheticMouseEventTest.MouseEventAck > > Devtools was not correctly handling input that is not generated by itself > and invoking callbacks when the input wasn't actually processed. > > Add a modifier indicating content was injected using the debugger so that > we can then query for that to determine if we should release the event. > This is a stop gap solution until we can actually bind callbacks into the > sending of events and devtools wouldn't need its own queues of callbacks. > > BUG=789869 > > Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 > Reviewed-on: https://chromium-review.googlesource.com/804357 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521454} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,dtapuska@chromium.org Change-Id: I526b2c2d4ab644206b1b34126436432a64fd3914 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789869 Reviewed-on: https://chromium-review.googlesource.com/807584Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521557}
-
Darren Shen authored
This patch fixes an issue where an escaped asterisk character is being treated as a universal selector. The problem was that \* and * were represented as g_star_atom (the '*' character) in selector matching. To differentiate between the two, we picked a different way to represent universal selectors. The local name of a universal selector becomes g_null_atom instead of g_star_atom. This way, \* and * will no longer clash. Bug: 682747 Change-Id: Ied14b468c8bfae6ed1022a565f4f46cea4c556a8 Reviewed-on: https://chromium-review.googlesource.com/765626Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#521556}
-
Sky Malice authored
Bug: 788004 Change-Id: I455ac63969e5ab52ef063fbd1b9ba14be833f211 Reviewed-on: https://chromium-review.googlesource.com/806653Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#521555}
-
Derek Cheng authored
TBR=luoe@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 667560 Change-Id: I7e5f7fe0b0691de8ef4b324cc814ac39ae17494f Reviewed-on: https://chromium-review.googlesource.com/807446Reviewed-by:
-
Kurt Horimoto authored
This intermediary object listens to changes from the FullscreenModel and propagates them to FullscreenControllerObservers. Bug: 785671 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I925ad42aec3acb11f6562d591121dad3476a9d2a Reviewed-on: https://chromium-review.googlesource.com/794951 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#521553}
-
Simeon Anfinrud authored
This fixes Java Errorprone warnings for: * deprecation * ReferenceEquality Bug: Internal b/70158727 Test: build cast_shell_java, observe that lint warning is gone. Change-Id: If72602773455c2c1903ca478ecb77baf4624e82a Reviewed-on: https://chromium-review.googlesource.com/807150Reviewed-by: -
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/cef20d4b2ff1..12ec6760afd9 $ git log cef20d4b2..12ec6760a --date=short --no-merges --format='%ad %ae %s' 2017-12-04 thestig Simplify some CFX_FloatRect methods. 2017-12-04 thestig Simplify color calculations in CFX_ImageTransformer. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I00ca55f7035903e7ac9041ba0165fc6bca3e7e76 Reviewed-on: https://chromium-review.googlesource.com/806927 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521551}
-
Takumi Fujimoto authored
- When sink availability changes for an MRP, start/stop observing sinks only for that MRP - Make WiredDisplayMRP report sink availability updates Bug: 789277,777650 Change-Id: I3d1a087ca39a4830403d6d2f0f00bf1411388f33 Reviewed-on: https://chromium-review.googlesource.com/794106Reviewed-by:
-
Alice Boxhall authored
Bug: 514674 Change-Id: I14c13aec3e4ae7a337ba46d762caa487dfab6309 Reviewed-on: https://chromium-review.googlesource.com/668309Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521549}
-
Sam McNally authored
Also remove layout test support's direct use of ManifestFetcher, changing it to use ManifestManager instead. Bug: 704441 Change-Id: I0417baaf6598a8c7d967e3ce1fd32e78bea22aa0 Reviewed-on: https://chromium-review.googlesource.com/774040Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521548}
-
Simeon Anfinrud authored
This allows all users of CastAudioManager to use request/abandonAudioFocus() without a @SuppressWarnings annotation. This paves the way for encapsulating SDK-dependent implementation details for AudioManager in CastAudioManager, reducing the number of SDK version checks that need to be performed throughout the codebase. Bug: Internal b/70158727 Test: build cast_shell_java Run internal junit tests Merge-With: eureka-internal/127089 Change-Id: Iacd88d1d2e298ddd3b9ae6eb2749f0a43b5ede77 Reviewed-on: https://chromium-review.googlesource.com/806929 Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by: -
Paul Meyer authored
Reporting API. A previous patch (https://chromium-review.googlesource.com/c/chromium/src/+/772999) added these new fields. This patch routes them to the Reporting API, and updates the associated test. Bug: 731810 Change-Id: I3a9a3ac71d894f784f18d5fb51898184541e6216 Reviewed-on: https://chromium-review.googlesource.com/775154 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#521546}
-
Derek Cheng authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789111 Change-Id: I7df38ee8bfce5eb135e6c42e2b6e6d7788a38ac7 Reviewed-on: https://chromium-review.googlesource.com/807524Reviewed-by:
-
Thomas Anderson authored
This reverts commit 4a7a6504. Reason for revert: The test fails on the Linux dbg testers. dbg 64: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/68703 dbg 32: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/46433 Original change's description: > Fix flaky SyntheticMouseEventTest.MouseEventAck > > Devtools was not correctly handling input that is not generated by itself > and invoking callbacks when the input wasn't actually processed. > > Add a modifier indicating content was injected using the debugger so that > we can then query for that to determine if we should release the event. > This is a stop gap solution until we can actually bind callbacks into the > sending of events and devtools wouldn't need its own queues of callbacks. > > BUG=789869 > > Change-Id: I2b56e8ebf4921b48bd4d35dee2226d7cb780cb94 > Reviewed-on: https://chromium-review.googlesource.com/804357 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521454} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,dtapuska@chromium.org Change-Id: I6cdd9e13b0df35dac12ade33b4c1a2e5c49525bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789869 Reviewed-on: https://chromium-review.googlesource.com/807504Reviewed-by:
-
Chris Mumford authored
If a file read failed only MOJO_RESULT_ABORTED was returned. This change does a best effort mapping of base::File::Error values to the MojoResult value. Bug: none Change-Id: Iead2b3ce3b790960d5796ceeb15cfa1ff9c80741 Reviewed-on: https://chromium-review.googlesource.com/804615 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
This allows us to simplify how sinks are stored in MediaRouterMojoImpl::MediaSinksQuery. We need to typemap mojom::MediaRouteProvider::Id to a C++ enum because MediaSink is used by Android but the mojo files aren't. A CL to add provider_id to MediaRoute will follow. Bug: 784594 Change-Id: I61fef4b2d2416333b5016313addbc64381aabda1 Reviewed-on: https://chromium-review.googlesource.com/761697Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Becky Zhou authored
setPrivacyDisclaimer() shouldn't call setHeaders() if headers are not set when history query completes. This fix would allow header visibility to rely on the number of history items being shown. Bug: 790921 Change-Id: Ieb65661490fab08fa65507205f5f32bc23b883c4 Reviewed-on: https://chromium-review.googlesource.com/807207 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#521541}
-
Dave Schuyler authored
This CL fixes some typos. There's no functional changes. TBR=stevenjb@chromium.org (code health) Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica19cdf06ade268e24e0aeec0efc66ef20b0e9b5 Reviewed-on: https://chromium-review.googlesource.com/806365 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#521540}
-
Philip Jägenstedt authored
Imported from wpt@50b32f0d4f2b485a184fdc71aae1f99e9d9806d6 using wpt-import in Chromium 419d8078. None of these tests appear to be duplicates of existing tests. All files (outside of wpt) containing the string 'var(' were deleted in a temporary commit, and git diff-filter=R did not find anything that then looked like a rename. Use [ Skip ] instead of [ Timeout ] for crbug.com/791529 to not add much to the total running time, the difference locally is noticeable. Bug: 791525, 791529 Change-Id: I74611048fe1656a14527f04bd88c0e04b286ad41 No-Export: true Reviewed-on: https://chromium-review.googlesource.com/805974 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
-
Karan Bhatia authored
NPAPI plugin support has been removed from chrome and the plugins specified in the "plugins" extension manifest key are not used currently. This CL removes the manifest handler for the "plugins" key, the "plugins" manifest feature and updates the public documentation. After this CL, loading an extension with the plugins manifest key specified should cause an install warning. BUG=732590 TEST=Load an unpacked extension which specifies a plugin as part of the "plugins" manifest key. Ensure that an install warning is raised saying that the "plugins" key is unrecognized. Change-Id: Ic5aa4958af1257cb776508638e3c690fb6a57eb4 Reviewed-on: https://chromium-review.googlesource.com/783517 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#521538}
-
