- 13 May, 2019 40 commits
-
-
Mitsuru Oshima authored
It's regressed in crrev.com/c/1414170. It's just plain wrong but I don't remeber why I changed this way. Bug: 960121 Test: Covered by unittest Change-Id: I0448648c3d661b9a2a9a3b98104d949c2c5a5573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595562Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#658983}
-
Alex Clarke authored
This is the internal promise representation. It implements the machinery needed to marshal and dispatch promises as they become ready for execution. Care has been taken to try and minimize the size of the AbstractPromise class and to keep down the number of heap allocations. The promise result and the executor are both stored in the base::unique_any since they are never needed at the same time. The size of AbstractPromise on x64 is 96 bytes in builds without DCHECKS. In builds with DCHECKS it's larger because there's additional storage used to diagnose and prevent various usage hazards: * Unhandled rejection * Double move of promise results to callbacks * Mixed move and non-move semantics of promise results to callbacks The base::any_internal type has been adjusted so it can store the SmallUniqueObject<> inline, which is used to store the promise executor. The largest anticipated promise executor base::All is the size of 3x sizeof(void*) to hold a vtable and a std::vector. Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit TBR=fdoray@chromium.org, etiennep@chromium.org Bug: 906125 Change-Id: I62cecf23ecc8ea3ef7417d6ad40c0911fac5339c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607643Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#658982}
-
Jan Krcal authored
This CL adds metrics to help investigate an increased number of address conversions in the USS implementation. Bug: 953693 Change-Id: I4085ce5ca11a8354d686ca7ae37f6e1d2dd7cfc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598812 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#658981}
-
Mikel Astiz authored
There's no need to keep this code under sync/base after the last refactorings, so we can shrink base libraries, which many build targets depend on. Bug: 922971 Change-Id: Ib033a694c9bdd732a3e4346fb63121f540235e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564129Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658980}
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 https://github.com/WICG/aom/blob/gh-pages/explainer.md Change-Id: Ia8fd5c6994e97e317a7360739a8a9d0d6d246fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573299Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#658979}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd862e37ea29..42db0b42abad git log cd862e37ea29..42db0b42abad --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@42db0b42abad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id67d8e9fab628829351addd7cc4d3b8c9a636492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658978}
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 Change-Id: Ib4da0a078abc72fb348038dd1d78bb333fb25d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591493Reviewed-by:
-
Koji Ishii authored
This patch fixes use-after-free when memory reallocation occurs by adding BoxData for bidi inline fragmentations. Bug: 925247, 961943 Change-Id: I5c2cd26546b45772fbff7d001d9e98e49ab19461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607719 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#658976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3ab74371c2a..c61db7ff2004 Created with: gclient setdep -r src-internal@c61db7ff2004 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I6c166f97027b8342c976adf204151575c1b255f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608693Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658975}
-
Satoshi Niwa authored
This means using CrOS file selector as default Android file picker go/arc-file-selector Bug: 64281746 Test: atest android.appsecurity.cts.DocumentsTest Change-Id: Ie6f9e5319830b80da1d7a74e164945ef90ece9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608864Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#658974}
-
Gyuyoung Kim authored
As the second step to move the date time picker to Blink, this CL moves all implementations of the date time picker from content/renderer to blink. Major changes are as below, - Rename DateTimePicker to DateTimeChooser. - Rename date_time_picker.mojom to date_time_chooser.mojom. - Make ExternalDateTimeChooser to communicate content::DateTimeChooserAndroid::OpenDateTimeDialog through mojom::DateTimeChooser interface. - Make ExternalDateTimeChooser call ExternalDateTimeChooser::OpenChooser instead of WebViewClient::OpenDateTimeChooser. - Remove struct WebDateTimeChooserParams, enum WebDateTimeInputType, WebDateTimeChooserCompletion, and struct WebDateTimeSuggestion because they're not used anymore. Instead, this CL converts blink::DateTimeSuggestion to blink::mojom::DateTimeSuggestionPtr directly. TEST: WebViewTest.ChooseValueFromDateTimeChooser is updated. Bug: 950157 Change-Id: Ia82454d44da1367f7d8269db88b1181f26ae33b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595203Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/695206d7149a..7bc76b45a4b9 git log 695206d7149a..7bc76b45a4b9 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ebab670cb32d..3dbe480b559e (16 commits) 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 589d8ec2..97d57619 (957 commits) Created with: gclient setdep -r src/third_party/skia@7bc76b45a4b9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Iebc081f0f66a9a9d4516cafd116794f8d3dada2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608831Reviewed-by:
-
Alexey Baskakov authored
Reuse one web contents for all pending synced web apps. This will avoid pathological cases where n renderers for n web apps are spun up on first sign-in to a new machine. - Implement WebAppInstallTask::InstallWebAppFromInfoRetrieveIcons method. - Plumb AppRegistrar to WebAppInstallManager. - Plumb error_on_unsupported_requirements and locally_installed params in InstallFinalizer::FinalizeOptions. - Extract UpdateWebAppIconsWithoutChangingLinks as a standalone util. Bug: 901226 Change-Id: I82c2e925a7f6fcaeca8bdc125b60ece6ee7e68fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591496Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#658971}
-
Yutaka Hirano authored
Now we're using mojo DataPipe and we can remove the class. Bug: 894819 Change-Id: I1d8a48e4b8bc72e795c00a83f12ffd08847bbbb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608862Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#658970}
-
Maggie Cai authored
This CL fixes an issue where the preferred app launched automatically even when not navigating from a link. Currently whenever we query ARC apps, the preferred app is always automatically launched. This CL plumbs a boolean to only automatically launch the preferred app when the app query is from a link navigation. BUG=939205,962356 Change-Id: I1784ee02140f043cba9d61a69d23a2aaceb02b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608863 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
This arg was broken (see the attached image in the linked bug). Explicitly convert KURL to TracedValue to record the url correctly. Bug: 961553 Change-Id: I2abc1410527608c043375a522d5548fb974cb76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604392 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658968}
-
Luciano Pacheco authored
Previously ActionsController would calculate the additional actions for Drive (share, create-shortcut, etc) and FSP [1] like change directory, selection changed, and metadata updated. When these events arrive in FilesApp, they update the <command> and <cr-menu> DOM state. However, that can cause flickering in visible menus and also flakes in browser tests based on menus, since these events can happen while the menu is displayed for an entry or set of entries (selection) or affect entries other than those associated with the menu. This CL changes ActionsController to store state in an internal map, rather than in the DOM, and to only update the menu DOM state when a user-action shows the menu. Change CommandHandler to set the visibility for Drive actions/commands synchronously to avoid flickering the size of the menu - it still can flicker the disabled state and pinned check-mark, but these are softer to human eyes than the change in size. Change ToolbarController to update its refresh button disabled state. The button relied on FileManagerCommands to update the |refresh| state command, which was not correct because the refresh button always acts on the current directory, whereas the command was being evaluated for different entries. Change Action models and derived classes to have a |getEntries| method so that ActionsController can get the entries that it is acting upon to invalidate the state prior to executation. Change ActionsSubMenu.setActionsModel to forward the target element, so the <command> can be updated to the correct target element. Change PluginVM test to use keyaboard shortcut instead of refresh button, because it was failing to refresh speculatively due to the button been disabled when clicked. [1] https://developer.chrome.com/apps/fileSystemProvider#event-onGetActionsRequested Change-Id: I33f322689d083b307e55ec9f045ee253bcde2c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608962 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658967}
-
Satoshi Niwa authored
Fix ConvertPathToArcUrl so DocumentsProvider path doesn't get encoded to a ChromeContentProvider URL. See b/132314050 for details Before: content://org.chromium.arc.chromecontentprovider/externalfile%3Aarc-documents-provider%2Fcom.android.cts.documentprovider%2Fdoc%253Alocal%2FWEB_LINKABLE_FILE After: content://com.android.cts.documentprovider/document/doc%3Aweb-linkable-file I tried to add a new test case for this but found it difficult to create a mock for chromeos::CreateExternalFileURLFromPath Bug: 132314050 Test: unit_tests --gtest_filter="FileManagerPathUtilConvertUrlTest.*" Change-Id: Ief4cc5dca4ad81c883c652efb02ffe64f938328d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605386Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#658966}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/806621b2e0b5..695206d7149a git log 806621b2e0b5..695206d7149a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ecfeede6014c..9e4f690166c1 (28 commits) Created with: gclient setdep -r src/third_party/skia@695206d7149a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I39361ff40e1e8cbfad8f0bdd6b7b5eb2d882cd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608435Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d4e828d2f38..c3ab74371c2a Created with: gclient setdep -r src-internal@c3ab74371c2a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I82d0c247817adf94d7e1b4a95a3a7aaaa83b6171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608920Reviewed-by:
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 915568 Change-Id: I6dfe325473b58aab7e1d6f79f2ab05b5db768da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608870Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#658963}
-
Jia authored
A lot of implementation complexity is caused by this class not copyable. This cl also adds inequality operator. Bug: 881215 Change-Id: Ic638252eb6007d5bac7332621d28d8a78f6aae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608869Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#658962}
-
Kenichi Ishibashi authored
If a worker creates a nested worker, there should be a performance entry on the parent worker because: * The spec specifies that the client of "run a worker"[1] comes from outside settings object. * [2] says that a performance entry should be included in the performance timeline of the client's global context. [1] https://html.spec.whatwg.org/multipage/workers.html#run-a-worker [2] https://w3c.github.io/resource-timing/#resources-included-in-the-performanceresourcetiming-interface Bug: 961552 Change-Id: I979f3f2e89a93545746ddd2124c931f4aa334bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607714Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#658961}
-
Simon Que authored
Apply the Goma RBE Prod usage setting using a mixin. R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 913249 Change-Id: I2d39baf38f3f95f65704c1498d74037ac4d56710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608865Reviewed-by:
-
Jeevan Shikaram authored
Add an icon to represent the Apps section in the settings menu. Bug: 960631, 960667 Change-Id: Ia49e7be5eb3b640d68ab4c7e724359ffbc5dfcb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607713Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#658959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/647366e4c47d..0d4e828d2f38 Created with: gclient setdep -r src-internal@0d4e828d2f38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I220d116b57b350a74aefdfc8fe8b6bba3ce44994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608826Reviewed-by:
-
Koji Ishii authored
"inlineTextBox" in AX tree is a representation of text after layout (line breaking,) and therefore every "staticText" and "lineBreak" should have corresponding "inlineTextBox"es. Sometimes "inlineTextBox" for "lineBreak" in AX tree is missing when the `<br>` is after newline and spaces. This is due to crbug.com/961898 where legacy fails to create `InlineTextBox` for such `<br>`. In order to make the switch to LayoutNG easier, this patch changes the tests and expected files to avoid hitting the condition, so that these tests produce the same results for legacy and NG. Change-Id: I53048fb53a1e9a78473b65556eea18eabc70fccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607000 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658957}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8f111dcdea4e..fa6ebdcd266e git log 8f111dcdea4e..fa6ebdcd266e --date=short --no-merges --format='%ad %ae %s' 2019-05-13 saklein@chromium.org BuildTargetUnitTest: Add empty sysroot option. Created with: gclient setdep -r src/third_party/chromite@fa6ebdcd266e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I47622861e644307546379cdad1059601bf336916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608825Reviewed-by:
-
Rakina Zata Amni authored
We would like to ban calls to UpdateStyleAndLayoutTreeForNode from within lifecycle updates. HTMLMeterElement::CanContainRangeEndPoint in some cases might be called within lifecycle updates. Change-Id: I11657874be40506c3b95ac6910c93aedaf5a1d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605583Reviewed-by:
-
Yu-Hsuan Hsu authored
The change is related to CL:1592896. Add histogram infomation in histograms.xml to make the histogram visible on chromedashboard. BUG=chromium:918462 Change-Id: Ie944d0701005a1c57942d94746496048c89b7fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600928Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658954}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ic33934e5cb99d536b7a09708692b99a09ddf9e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608806Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#658953}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e87c3e7ccb9b..647366e4c47d Created with: gclient setdep -r src-internal@647366e4c47d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: I4aaee344049fedf20a4d0f6af7c8c584cf6aaade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608823Reviewed-by:
-
Donna Wu authored
//device/usb will be moved to //services/device, so break the dependencies on //device/usb outside //device and //services. Bug: 699790 Change-Id: I0cfdccec6d16f54cd4588196e0559cb088990a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600834Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#658951}
-
Koji Ishii authored
This patch adds a new class, LayoutNGListInsideMarker, for the inside-positioned list marker. Before this change, LayoutNG created an anonymous LayoutInline. This was sufficient for layout and paint purposes, but AX needs to distinguish inside markers from other anonymous LayoutInline. Fixes a LayoutNG failure of DumpAccessibilityTreeTest.AccessibilityAriaOwns/blink in content_browsertests. Bug: 725277 Change-Id: Ifa51bf02c9d97b922d4ea2a31a22d48e4e957dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605446 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I4f8fbc977678751240c6ec91c94daa8446b4e588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604391 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#658949}
-
Matt Falkenhagen authored
The listener destroyed itself when OnRegistrationDeleted() was called but it's possible it's never called. This fixes a leak found by LSAN. Bug: 961036 Change-Id: I6d53f2922f26ec104aa178c174de4fc0cd58e14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605587Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658948}
-
Matt Falkenhagen authored
The service worker storage system involves a disk_cache and a leveldb that contains resource ids linking to the disk_cache. When an service worker version is overwritten by a new one, we write its resources ids as "purgeable" to leveldb but keep the disk_cache resources available since the version can run even after deletion, if it remains active version. The problem is we didn't delete the resources from the disk_cache until the next browser session in that case. This CL changes the strategy so that: 1. A version starts purging its resources once it becomes REDUNDANT. 2. If the version is overwritten, and there is no live version at that time (so no chance for 1. to happen), start purging then. Bug: 956463 Change-Id: I2b50f042943c1e4921ed586767288ccb28285144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599057 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14f76a215359..e87c3e7ccb9b Created with: gclient setdep -r src-internal@e87c3e7ccb9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,aboxhall@google.com,battre@google.com Change-Id: Ifeea3a09c1f7bec6db17c20e5e2aaa962b43e292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608822Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I67ee3484a30684bf1020d980b93fce4e8bd9f0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605441Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#658945}
-
Antonio Gomes authored
This is a follow up of [1]. Basically, WebCanvasCaptureHandler is now only referenced within Blink, with its use is scattered between renderer/modules/ and renderer/core/html/canvas. For the of later, we can not simple replace the existing uses of WebCanvasCaptureHandler in CanvasDrawListener by CanvasCaptureHandler because renderer/core/html/canvas can not include renderer/modules/. As per haraken's advice in [2], this CL makes CanvasDrawListener pure virtual, and implements the methods as needed in modules/mediacapturefromelement: - AutoCanvasDrawListener: has the base implementation of the 3 method that used to live in html/canvas/CanvasDrawListener. - OnRequestCanvasDrawListener: inherits from AutoCanvasDrawListener and reimplements SendNewFrame. - TimedCanvasDrawListener: inherits from OnRequestCanvasDrawListener (but does not override any method). This allows us not to duplicate any code among these 3 classes, and eliminate WebCanvasCaptureHandler altogether. [1] https://crrev.com/c/1600898 (Onion soup canvas_capture_handler.cc/h) [2] https://crrev.com/c/1600898/1//COMMIT_MSG#34 BUG=787261,919392 Change-Id: I88113cc9cfe38a453ac028528f34eaea3448ea2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603722Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#658944}
-
