- 20 Jun, 2018 40 commits
-
-
Jérôme Lebel authored
Disabling EarlGrey tests from SigninInteractionControllerTestCase: + testSignInSwitchAccountsAndKeepDataSeparate + testSignInSwitchAccountsAndImportData + testSignInSwitchManagedAccount Those tests seem to trigger an issue in the sync code when doing enable disable enable too fast. Bug: 854446 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75 Reviewed-on: https://chromium-review.googlesource.com/1107881Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568843}
-
Devlin Cronin authored
https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a added support for IPv6 patterns with URLPattern and activeTab, so we can now enable the tests for captureVisibleTab using IPv6 URLs. Bug: 839857 Change-Id: I29eec17b176c54a312cfdf5dc7d11c50b7b245f9 Reviewed-on: https://chromium-review.googlesource.com/1107243Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568842}
-
Peng Huang authored
Implement SkiaRenderer::CopyDrawnRenderPass() by posting a task to GPU main thread to copy output from offscreen SkSurface for render passes or the framebuffer SkSurface for the frame. This CL also enable all existing pixel tests with SkaRenderer + SkDDL code path. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I707d555c2973eb81294b29b813d4538ab671a3c0 Reviewed-on: https://chromium-review.googlesource.com/1089451Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568841}
-
Peter Wen authored
Add convenience link for sheriffs to easily access size bugs. Bug: None Change-Id: I04e9ad3041c49cdfa0e0d0e78ca1f5cd0e7cab66 Reviewed-on: https://chromium-review.googlesource.com/1107848Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568840}
-
Martin Šrámek authored
...as it's currently failing on the Linux MSan bot. Bug: 854599 Change-Id: I36a19408db4bb37ed667ac67f62e05fbf404eb60 TBR: hajimehoshi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1107923Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568839}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a914f7ff310d..66c2f4afe3c2 git log a914f7ff310d..66c2f4afe3c2 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 lucferron@chromium.org Vulkan: Add test and fix clear on RGB8 with color masks Created with: gclient setdep -r src/third_party/angle@66c2f4afe3c2 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I954361c5a4d73f55d6f9fce7f2706fe5c2f3305e Reviewed-on: https://chromium-review.googlesource.com/1107817Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568838}
-
Justin Cohen authored
TBR=eugenebut@chromium.org Bug: 854615 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7cc280c03203696c0fa00081b15736d6245d4ba5 Reviewed-on: https://chromium-review.googlesource.com/1107880Reviewed-by:
-
Takuto Ikuta authored
When building chrome on windows, tool-wrapper for linking is called 794 times. And I found that calling python wrapper is relatively slow than calling link via ninja. This CL replaces python wrapper to ninja wrapper to remove such overhead when we use lld. I compared time of wrapper invocation using following powershell script. for ($i = 0; $i -lt 100; $i++) { # ninja -t msvc -e environment.x64 -- C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # code for FlushFileBuffers is commented out. } * ninja wrapper, 7.451s for 100 invocation * python wrapper, 17.803s for 100 invocation Using ninja as env wrapper is more than 2 times faster. Bug: 787903 Change-Id: I6531b59a6c43085782b0138a264ecfc9a6f65833 Reviewed-on: https://chromium-review.googlesource.com/1107678 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568836}
-
Koji Ishii authored
This patch rebaselines 1px differences in the baseline positioning when the 'vertical-aling' property is used. Legacy computes the baseline position in multiple steps, while NG computes in single function. This difference causes slight rounding differences. TBR=atoti@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2adec046f2ac13dfb4d479e8ffa56cb4a3bd040 Reviewed-on: https://chromium-review.googlesource.com/1107860 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568835}
-
jonross authored
For a while there was work looking into getting telemetry_perf_unittests and telemetry_unittests up and running on linux-chromiumos. However instead there is now a desire to just get an actual ChromeOS device on the CQ. This will resolve our coverage needs. We've been using the Mojo Chromiumos FYI bot to investigate this. But the tests have been broken there for a while. This change removes those configs. TEST=telemetry_perf_unittests, telemetry_unittests Bug: 836447 Change-Id: I8870c69dae811101d4869e3c7ede28771ecbf905 Reviewed-on: https://chromium-review.googlesource.com/1107838Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568834}
-
Koji Ishii authored
This test has a failing baseline baked in the legacy, but passes in NG. Edge and Gecko pass (the same as this rebaseline.) TBR=atotic@chromium.org NOTRY=true Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I77f850b929af26a7e7eec9c3fff851476957985a Reviewed-on: https://chromium-review.googlesource.com/1107859 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Michał Pichliński authored
Bug: 854179 Change-Id: Icee4af543850a30116e811f32a16c38b3498bcf2 Reviewed-on: https://chromium-review.googlesource.com/1106145Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Cr-Commit-Position: refs/heads/master@{#568832}
-
manuk authored
Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. Bug: 830491 Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 Reviewed-on: https://chromium-review.googlesource.com/1103233 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#568831}
-
Roger Tawa authored
Bug: 853848 Change-Id: I82630378262adfdc8ed7f6fafbf56266aa50d15c Reviewed-on: https://chromium-review.googlesource.com/1104961Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#568830}
-
Charlie Harrison authored
Bug: 793053 Change-Id: I0d39cd8e6695b18da47549e632f10abd9919c83e Reviewed-on: https://chromium-review.googlesource.com/1106519Reviewed-by:
-
Jeremy Roman authored
For consistency and efficiency. While here, move the StringBuilder::ReserveCapacity call at the use before the actual usage of the StringBuilder (presently it has no effect). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I197140cc0b77d12bd236e908e844eacf39fa6697 Reviewed-on: https://chromium-review.googlesource.com/1106605Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568828}
-
Mounir Lamouri authored
Bug: 854349 Change-Id: Iba9fa4ccb6001455f9fd925d2d871e591097251f TBR: apacible@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1107840 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#568827}
-
Mikel Astiz authored
The patch inlines the content of the former RegisterAndroidDataTypes() and RegisterDesktopDataTypes() as per TODO promised in earlier code reviews. No behavioral changes. Bug: None Change-Id: I899db974c7782e0bc31fd743702fe41e8293d561 Reviewed-on: https://chromium-review.googlesource.com/1105044 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568826}
-
Martin Šrámek authored
This reverts commit e4f3ef2e. Reason for revert: Seems to be causing test crashes, and timeouts of entire test suites. See crbug.com/854611 for more details. Bug: 598880,854611 Original change's description: > Android: Delete native ContentViewCore > > The only thing the native CVC does now is (as an WebContentsObserver) > adjust renderer view focus/screen info when renderer is updated. > This CL moves that reponsibility to WebContentsAndroid, and deletes > the entire class. There is no functional change. > > Bug: 598880 > Change-Id: I9a1f3a2e0df5457439a27675d3786aa6703e06ac > Reviewed-on: https://chromium-review.googlesource.com/1083911 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568499} TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org Change-Id: I039091e040d468669bd4c5f5b1b42aef9f272d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 598880 Reviewed-on: https://chromium-review.googlesource.com/1107958Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 854562 Change-Id: Id61eee835d304369c9efb19dafbcb29b3b6f4195 Reviewed-on: https://chromium-review.googlesource.com/1107814Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568824}
-
Florian Mayer authored
This includes a rename perfetto::Service to perfetto::TracingService. Do the corresponding changes in Chrome. Bug: 74331089 Change-Id: I73bb3a15a66ad494a3796cdf9f5e4fd275d8c57d Reviewed-on: https://chromium-review.googlesource.com/1107698 Commit-Queue: Florian Mayer <fmayer@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568823}
-
Olga Sharonova authored
This reverts commit ec3716fd. Reason for revert: It broke WebRTC performance tests which capture system audio loopback. The reason is unclear, but looks like tests-specific: audio works with manual testing; and the test only changed event timing at the process startup. Reverting for now to have WebRTC audio quality test coverage. Bug:850936 Original change's description: > Changing AudioService experiment field trial to test service launch on startup > > [1] introduced AudioServiceLaunchOnStartup feature which we want to roll out > with a new experiment group. Updating field trial to run the config on bots > first. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681 > > Bug: 851611,853781 > Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a > Reviewed-on: https://chromium-review.googlesource.com/1105957 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568485} TBR=rkaplow@chromium.org,olka@chromium.org Change-Id: Ic50b37d434bc75fca78585ead8c964815bcd2cf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851611, 853781 Reviewed-on: https://chromium-review.googlesource.com/1107957Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568822}
-
Oskar Sundbom authored
Renaming it to ExperimentalHardwareEchoCancellation2, so that new tokens don't trigger the old behaviour in older versions of Chrome. The runtime flag retains its name, since that's user controlled. Bug: 854577, 846270 Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131 Reviewed-on: https://chromium-review.googlesource.com/1106338Reviewed-by:
-
Scott Violet authored
Into HostContextFactoryPrivate. This also adds a ui::ContextFactory implementation that uses it to services/ui/ws2. I could move the ContextFactory implementation to ui/compositor/host as well, but I kept it where it is used. BUG=837686 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I95f89f9c14ac93560805bf47a9fe074d1ab1c58d Reviewed-on: https://chromium-review.googlesource.com/1105307Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568820}
-
Sylvain Defresne authored
The overload of PrepareMailtoHandling is no longer overridden in the downstream implementation and not called from upstream code so it can be safely removed. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bde07b17f1c5293488b0d65d284fa0e0ecea5f6 Reviewed-on: https://chromium-review.googlesource.com/1106164 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568819}
-
Koji Ishii authored
Blink is the only engine that truncates text inside of an inline block for 'text-overflow: ellipsis', and these two tests are for the behavior. The spec says atomic inline is truncated as a whole or not, and all other 3 impls follow that. LayoutNG matches to it. TBR=atotic@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iae29eaf66f23d3eb120b215606a5b1e5e020bfbf Reviewed-on: https://chromium-review.googlesource.com/1107529 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Marc Treib authored
Turns out the test was completely out of date and only passing by accident. While we're here, also replace a few EXPECT_CALLs with ON_CALLs. Bug: none Change-Id: Ie2250a7ea58332e6bf08b6df80e33b72eb5a0018 Reviewed-on: https://chromium-review.googlesource.com/1107811Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568817}
-
clamy authored
This CL is part of a serie of CL to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I3c2aefded05884333fd3e20830cf4abfabebbdc1 Reviewed-on: https://chromium-review.googlesource.com/1102458Reviewed-by:
-
Mounir Lamouri authored
This will allow the browser tests to run on all platforms. Bug: 845747 Change-Id: I07eb6fbd8240c5f559ef078538ffc047e7ab784c Reviewed-on: https://chromium-review.googlesource.com/1105073Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#568815}
-
Jeremy Roman authored
It's cleaner and more consistent with Chromium. Change-Id: Ib2e4fa6d55f5e85c48673fb48b3cd90de8b11240 Reviewed-on: https://chromium-review.googlesource.com/1106042Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f153b902bec3..a2cee4816d7b git log f153b902bec3..a2cee4816d7b --date=short --no-merges --format='%ad %ae %s' 2018-06-20 perezju@chromium.org [Telemetry] Disable flaky tests on mac10.10 Created with: gclient setdep -r src/third_party/catapult@a2cee4816d7b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853865 TBR=sullivan@chromium.org Change-Id: I658c7b1910c92c4c900861f846404574d1891f85 Reviewed-on: https://chromium-review.googlesource.com/1107599Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568813}
-
Marc Treib authored
Bug: none Change-Id: I25d60383abd1d62124d099bb1e364c32981729af Reviewed-on: https://chromium-review.googlesource.com/1107699 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Martin Šrámek authored
This reverts commit b0314879. Reason for revert: Seems to have broken a number of print browsertests on Win 7 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69834 Original change's description: > Print Preview Componentization: Fix document title > > Set the document title to the title of the tab being printed, so that > the task manager will show the correct task title. > > Bug: 773928 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: If8f7fec12bd81cca71bdccf3fb9f040ac17bc3f0 > Reviewed-on: https://chromium-review.googlesource.com/1104985 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568487} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: Ibafe5312ce179f07a5342cd512342873ab0687f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773928 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1107897Reviewed-by:
-
Bernhard Bauer authored
Move most of the logic out of the RecyclerViewAdapter into its newly introduced delegate (which RecyclerViewModelChangeProcessor now implements). Update RecyclerViewModelChangeProcessor to better handle its most common use case, which is to represent a plain list of items. Other, more complicated use cases can be implemented with a custom RecyclerViewAdapter.Delegate implementation (which could go away in the future as we extend the capabilities). Remove getItemCount() from ListObservable in favor of moving it to a new SimpleList<> interface, to better separate accessing items in a list from observing changes to it. Make the ViewBinder interface functional again, by moving ViewHolder creation to its own functional interface, and update clients to use method references. Bug: 805070 Change-Id: I565b2e9888e9cbaf8eb0f3dfc73df4baf197f30a Reviewed-on: https://chromium-review.googlesource.com/1100831Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#568810}
-
jonross authored
More flaking tests on Android in surface_sync_content_browsertests, and viz_content_browsertests. This disables them. TBR=fsamuel@chromium.org TEST=viz_content_browsertests, surface_sync_content_browsertests Bug: 849746 Change-Id: I753452ea85d342fdb6bfc4408fb38817f8252d19 Reviewed-on: https://chromium-review.googlesource.com/1107839Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#568809}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/e5be80532b..bd40a41cc1 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/e5be80532b..bd40a41cc1 Bug: None Change-Id: I6762301da5d5fd011677026fdf055bdda52450a7 Reviewed-on: https://chromium-review.googlesource.com/1107557Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#568808}
-
Matt Menke authored
This moves logic for this case from ChromeNetworkDelegate to NetworkContext's NetworkDelegate, and adds a Mojo parameter to cause requests with bad referrers to fail (enabled by default). Also removes the action Net.URLRequest_StartJob_InvalidReferrer rather than moving it, as it was unowned. Bug: 852871 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9d6d55157ba28e2b12ca7136b78330100a8673aa Reviewed-on: https://chromium-review.googlesource.com/1103119Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Matt Menke authored
Unfortunately, the old patch to set it up in IOThread is still needed, since the in-process NetworkService is leaked when the OOP network service is disabled. Bug=853211 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic216b2d83d703cff776a77aaea6a2244a9eca367 Reviewed-on: https://chromium-review.googlesource.com/1105068Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568806}
-
Tiger Oakes authored
Removed context#getApplicationContext calls from /chrome/android/java/src/org/chromium/chrome/browser/services/gcm Continuation of work in bug 646094. This CL was uploaded by git cl split. R=peter@chromium.org Bug: 846456 Change-Id: If4634124016982063b17725552585ef08d333a94 Reviewed-on: https://chromium-review.googlesource.com/1095914 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568805}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I0e32bfa8001ceb6be444b99852ca73f38dec8bbc Reviewed-on: https://chromium-review.googlesource.com/1102682Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568804}
-
