GitLab

Bug: 998907, 1013648
Change-Id: I8925f0d1a4cf7a5c58097ecc0a6e2f31bebd8d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874092Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Jonathan Freed <freedjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709154}

This fixes a regression after https://crrev.com/c/1861035 that caused a
web page to require more printed pages due to an inconsistency of rounding
directions.
We used to implicitly round the rect returned by LayoutView::DocumentRect(),
as it used to return a snapped-to-int rect. Now that we've started returning
a PhysicalRect, it gets to ResizePageRectsKeepingRatio() as is and gets
truncated there. So let's round sizes explicitly before passing to
ResizePageRectsKeepingRatio().

BUG=650768, b/142742179

Change-Id: I55a9df6977f464452fc4878517796717761c5b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867126Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709153}

As of r708260 on Catalina these methods return the
SYSTEM_PERMISSION_DENIED rather than PERMISSION_DENIED.

Bug: 998755
Change-Id: I8fa29f08a93ec1b4df5cfd15d2343154f1985f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879774Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709152}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=primiano@chromium.org

Bug: 891670
Change-Id: Ic16025b9521d146818358f5dff16877088872b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878194
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#709151}

JsReplyProxy in testJsReplyProxyReplyToTheCorrectJsObject could be null
sometimes, this is because we didn't use ScopedJavaGlobalRef to
reference the corresponding Java object. If a full GC kicked in, the
Java object will be collected, so native side JavaObjectWeakGlobalRef
will return a null.

Bug: 1015023
Change-Id: I66d0f5a9334f98a65e8fd9c05712b5b492a7f788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873389Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709150}

The patch reintroduces the logic reverted in
51be6f11, now behind a feature toggle.

switches::kMergeBookmarksUsingGUIDs is reused because actually there's
a fundamental coupling (which was overlooked before and the reason for
crashes): using deterministic tmp IDs *requires* that the merge
algorithm is aware of possible ID collisions (GUID equality).

Bug: 978430,1004205
Change-Id: I7babdcebc2d1eae4433c93316abdcbd374ceba19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878148Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709149}

This is now a regular factory method on this class, called from a new override
of BubbleDialogDelegateView::Init().

Bug: 1011446
Change-Id: Ie177b62c237dcb8fe53dcae385bc807977d223f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876550
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709148}

Following up on comment in https://crrev.com/c/1876788.

Change-Id: Ib98809802ac2d1634d8300569c1bed0d165dbedd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879689
Auto-Submit: Mathieu Binette <mbinette@google.com>
Commit-Queue: Mathieu Binette <mbinette@google.com>
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709147}

Support for Rappor metrics is being removed, and WebVr is also being
removed.  This change removes some WebVr Rappor metrics (note that some
instances where these metrics were logged has been previously deleted)

Bug: 1016906,960132
Change-Id: Idd4f8de112de0eb5c714dc616c850bf1e92f2ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879697Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709146}

The LUCI Milo lint check wasn't correctly set up when luci-milo.cfg was
migrated to starlark, so there are some discrepancies between the main
console and the chromium subwaterfall console right now.

Change-Id: Ib27d6d2c5a5ba30e3e7ab52db9ebd01557d48508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879693
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709145}

Need additional time to run the experiments involving this histogram.

This will be used to understand how composition decisions affect text
quality.

Bug: 1016427
Change-Id: I6f6b96b22a65497354286a5a8b395757f308bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879311Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#709144}

Separate request proto fill in logic from the origin function, which
make it easier for unit testing. The test is mainly for url sanitization.

Bug: 1017440
Change-Id: I8626aebb8459972b248330a396e1e23a40dfb474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877813
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709143}

  * Centralizes rounded corner decoration, putting them on the window
    manager and adding a method to enable/disable as needed.

  * Add roundy corners to webviews, enabled on first webview and
    remove on destruction of final.

  * Add notification of color inversion to the window manager -- for
    accessibility to call into -- to invert the color of the rounded
    corners.

Bug: internal b/141369549
Test: manual
Change-Id: Ic0d6de3c718300add6f99b84b47a243bd5c74da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874059Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Randy Rossi <rmrossi@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709142}

This reverts commit 55465550.

Reason for revert: This class is no longer needed. It was initially created to fetch Instance ID tokens for multiple services, namely v2 Enrollment and DeviceSync. However, CryptAuth decided it will only use one Instance ID token corresponding to CryptAuth v2 Enrollment. The Instance ID and token are already fetched in the ClientAppMetadataProvider. In the future, Instance ID handling might be moved to the CryptAuthGCMManager.

Original change's description:
> [DeviceSync v2] Add CryptAuthInstanceIDProvider class
> 
> Add an abstract class (and a fake implementation) for providing an
> Instance ID for use with CryptAuth v2, and also for providing Instance
> ID tokens for each CryptAuth v2 project: Enrollment and DeviceSync.
> 
> The implementation will follow in another CL.
> 
> Bug: 951969, 990430
> Change-Id: I6fd3280bf5a12114a92059a8a84bd0d1749c627b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737951
> Commit-Queue: Josh Nohle <nohle@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684479}

TBR=khorimoto@chromium.org,nohle@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 951969, 990430
Change-Id: Ic05c8033bd092c995050f76b1b5434507c843617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866628Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709141}

Preparation for UMA logging failure reasons on why extracting font file
and name information failed for individual indexed font files.

Bug: 1009402
Change-Id: Ia6133d2646b9f1610edd5f1e8b4a43a3a0143486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875106Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709140}

Change-Id: I95df3ea154bb0a73b8842bd485129c4269d1eff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879707Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709139}

Using wpt-import in Chromium 2c37032b.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
guidou@chromium.org, armax@chromium.org:
  external/wpt/mediacapture-streams
rego@igalia.com:
  external/wpt/css/css-grid

NOAUTOREVERT=true
TBR=smcgruer

No-Export: true
Change-Id: Iaaad527fbb79df9ea9d0f299baab29ce297dd418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878948Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709138}

We want to start running tidy as a part of Tricium. In order to do so,
we need to figure out the set of clang-tidy checks we want to run.

The checks here are sourced from the 'Y' column of:
https://docs.google.com/spreadsheets/d/16_z3pQFvTEzQocfWpch54GSykziTxVJMEcaDb5xW0YA/comment#gid=0

Ignoring google-explicit-constructor and modernize-use-auto (since the
former has code that relies on it, and the latter requires changes to
clang-tidy to meet Chromium's style guidelines).

We can add more (bugprone-*, ...) as time goes on, but those appear to
be the defaults that Chromium wants initially.

Please note that subdirectories can override all of this whenever they
want (e.g., v8 has a .clang-tidy file already, so any files inside of
v8/ will entirely obey that), so this is meant to be a generally
valuable and applicable set of checks.

Teaching `gn` about all of this might have some value eventually, but
for now, the goal is to see how far we can get with the simpler
solution.

Bug: 633856
Change-Id: I7b52e6a313ace8a91e9041313b222da737ef47fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808532Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709137}

This CL is adding more unittests for the first round of text split
of the RenderTextHarfBuzz::ItemizeTextToRuns(..) algorithm.
There is no behavior changes, no new bugs found.

Adding more unittests to have coverage for recent change:
  https://chromium-review.googlesource.com/c/chromium/src/+/1865673

Bug: 1014119
Change-Id: I30a09e0576063b123a1ae0abd917e49a7c053a5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877666Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709136}

Changes in this cl:
1. Update the arrow color while COMPLETEING from SK_ColorWhite to
   gfx::kGoogleGrey100.
2. Add shadow for the circle background. The shadow is the same as
   overscroll affordance.
3. Add burst ripple animation on drag release. The radius of the ripple
   will grow from 40dips to 48dips on this process.

See recorded video:
https://drive.google.com/file/d/0B5I0jFeLxqIiY1JWREN4aW1hSWlocktCOVlwdDV4ZHZyNERN/view?usp=sharing

Bug: 1002733
Change-Id: I96e7836a315c83cbcae415bbd4b359cf6d607501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876797
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709135}

Edge case for "have aspect ratio, but no intrinsic size"
If there was no intrinsic size, we treated it as no size at all.
But, if there is a css size, we should use that instead.

Bug: 1015311
Change-Id: Ia8f12bd23cda5c18b9aae318eee91906840475d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877595
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709134}

The ToolbarActionsBar should never be constructed, at all, with the
kExtensionsToolbarMenu feature enabled. Make the DCHECK in the
ToolbarActionsBar constructor stricter to make this clear, and catch any
cases where we erroneously construct one.

Bug: None

Change-Id: I5ddef89f249435b0fcfe97459b5c09bd88936075
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877449Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709133}

There was quite a bit of code duplication related to copying
OpenURLParams into LoadURLParams.  Some callsites didn't copy all the
navigation properties (leading to the DCHECK reported in
https://crbug.com/1007041 and possibly also to some of renderer
kills reported in https://crbug.com/1014483).

This CL tries to improve the situation, by moving the copying code into
a new constructor of LoadURLParams and reusing the constructor from as
many places as possible.

Bug: 1007041, 1014483
Change-Id: Ibeefd97118a78f5a2b3779e51d83731c546fd113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853910
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709132}

Renderer4.renderPassCount is the number without any flattening at all.
Soon GLRenderer and SkiaRenderer will flatten differently. We want to
instrument this so that we can measure the difference.

Renderer4.renderPassCount is still useful to measure the effectiveness
of SkiaRenderer flattening. It can be removed post launch.

Bug: 1013735
Change-Id: I9abf94c62ab5172230ebf223dbb672629d42356e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874193Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709131}

TBR=dmurph@chromium.org

Bug: 925325
Change-Id: I7cbc37cbcc0134a6204781e66b137f4b537832c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879147Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709130}

Add thread check to all embedder to implementation calls.

Change-Id: Ifac0c0de5b2ea365313d151451cbff8ade7ab818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879428Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709129}

This CL applies the new Mojo types to the callback of OnStart
in Service interface.

  - Convert FooRequest to mojo::PendingReceiver.
  - Convert FooAssociatedPtr to AssocitedRemote.
  - Convert FooAssociatedRequest to PendingAssociatedReceiver.
  - Convert AssociatedBindingSet to AssociatedReceiverSet.

Bug: 955171
Change-Id: I7e3efc212a5272ef8c29977e150126c75ea0fc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875009Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709128}

Bug: 998625
Change-Id: Ic2b813a6197b20ed8c4c962fcd6757055cac6f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857599Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709127}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8943e033650..151f5fbf383d

git log b8943e033650..151f5fbf383d --date=short --no-merges --format='%ad %ae %s'
2019-10-24 vapier@chromium.org cros_install_debug_syms: switch to outcap
2019-10-24 vapier@chromium.org run_tests: invert python3 support logic

Created with:
  gclient setdep -r src/third_party/chromite@151f5fbf383d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I7555a4dd5bb57a760ded98314955849133fca6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879508Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709126}

Default search provider maybe null when it's disabled by policy. Make
sure the touch bar search button can handle this case with an empty button.
User is still able to press the button to enter URL.

Screenshot: https://drive.google.com/file/d/1Sw8xd2bl4MGfF2p2qrT7PKF4bQ2jczRC/view?usp=sharing

Bug: 1011260
Change-Id: Iba221a4d65baff7cc5485de43f4b145481c2d1f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841837
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709125}

TBR=estade@chromium.org

Bug: 1017819
Change-Id: I8d5f2acbe8c30c5998e8c5a4ebd83c95a555a8a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879692Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709124}

The option "Always open with system viewer" should be following the
option "Open with system viewer".

Bug: 574090
Change-Id: I3c75924ef9878b4ea3aa299af14a6c03330141b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879429Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709123}

Change-Id: I730f54915f7a4f219d6b970ff4651fa20eb07b11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866928
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709122}

MetricsWebViewContentObserver assumed WillStartNavigationRequest()
and DidFinishNavigation() is sequencially called for main frame, it
isn't true, since both callbacks are post task, calling sequence
isn't guaranteed.

Bug: 1010034
Bug: 937528
Change-Id: Ia7fc892a599f789aa56b613409815f45d36e4223
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865268Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709121}

DragDownloadFile is used on UI thread, no need to use scoped_refptr.
This CL also cleans up the unused DataObjectImpl::Observer class

BUG=1008188

Change-Id: I9ba7596c69450df23e3dbe7b5bf7e56fb80ecc3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825890Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709120}

For browser installed WebAPKs, v109 has adaptive icon support

Bug: 977173
Change-Id: Ic3b5e1b118dbe5ddb05fdaa662ae1ed9e81c6340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879547Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Henry Jian <hzjian@google.com>
Cr-Commit-Position: refs/heads/master@{#709119}

Before this CL, the touch to fill sheet was intially shown in a very
high PEEK state (which provides pixel-exact height control).
The PEEK state had the side effect that the scrim view wasn't brought up
reliably (see linked bug). Therefore, it is skipped now and instead, the
half state is invoked right away. To the user, this looks and behaves
exaclty the same but triggers the scrim view more reliably.

Additionally, there is a small fail-safe that would have fixed the issue
on its own (just not as clean). The fail-safe ensures the sheet is
dismissed as soon as there the BottomSheet enters the HIDDEN state, even
if the observer wasn't notified that is was closed beforehand.

Minifix: the bottom sheet vertical size seems to align with Chrome now,
so set the margin of the "Manage Passwords" button back to 8dp.

Bug: 1017727
Change-Id: I66ddef169a96d43a059bd7f065195c03783d595f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879447Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709118}

This CL replace mojo::Binding with mojo::Receiver in |binding_|.
Then, renames |binding_| with |receiver_|.

Bug: 955171
Change-Id: I24a49f57e58397c74beed9105ac8eb0347e5f3a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875349Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709117}

The funciton UpdateAppProfileMenu should only be hit when in
multi-profile mode.

TBR=dominickn

Bug: 1017755
Change-Id: Ib35aeb8ed4da2ff2af669c01d4996e4c278adfff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879687Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709116}

https://skia.googlesource.com/skia.git/+log/4ab4e641f151..4a4400d9e9fa

git log 4ab4e641f151..4a4400d9e9fa --date=short --no-merges --format='%ad %ae %s'
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 herb@google.com Fix fuzzer bug in SkDescriptor::isValid
2019-10-24 fmalita@chromium.org Slightly faster hsl_to_rgb stage
2019-10-24 robertphillips@google.com Revert "Allow direct readback for formats in non-ES OpenGL"
2019-10-24 csmartdalton@google.com Don't keep "outResultsFile" open in nanobench
2019-10-24 mtklein@google.com restore _DXDY image shader on ARM
2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2019-10-24 bsalomon@google.com Allow direct readback for formats in non-ES OpenGL

Created with:
  gclient setdep -r src/third_party/skia@4a4400d9e9fa

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=michaelludwig@google.com

Bug: chromium:b/143074513
Change-Id: Iebc12a2367684d181b48c642cd64595de72bb997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879310Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709115}