- 15 Apr, 2020 40 commits
-
-
Xiaocheng Hu authored
Currently, there are two different invalidation code paths for font-face related changes: 1. Via FontSelector::FontFaceInvalidated(). This is called when: - The loading status of a font changes - A FontFace is changed via the JavaScript API This code path also allows partial style invalidation when the feature CSSReducedFontLoadingInvalidations is enabled; Otherwise, it marks the full document's style as dirty. 2. Via StyleEngine::InvalidateForRuleSetChanges(). This is called when StyleEngine identifies changes in the active @font-face rules. It marks the full document's style as dirty. This patch makes (2) to also use FontSelector::FontFaceInvalidated() to update style and layout, instead of directly marking full document style dirty. As a result: - When the feature is enabled, @font-face rule changes don't need full document style recalc - We no longer need to compare FontSelector versions in style diff. This is required by partial layout recalc for font loading - There is no essential behavioral change when the feature is disabled, since in that case both code paths mark style dirty on the full doc Note: there's also a renaming to certain variables & functions to make code more readable, since what they actually rebuild is FontFaceCache instead of FontCache. Bug: 441925 Change-Id: I5207e99fdb7e610bcdedc4c7b3615b0c13b69c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147687Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759124}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/05dc1d6cad93..b2bcf0eb3a4d git log 05dc1d6cad93..b2bcf0eb3a4d --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com Discovery: Multi Network Interface part 2 Created with: gclient setdep -r src/third_party/openscreen/src@b2bcf0eb3a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0e0b1579dfb116e9bba757387789c4aede94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759123}
-
Anne Lim authored
Temporarily cache the result of unmask calls on a page. The card can be filled again later without attempting to auth. This is cleared upon page navigation. Bug: 152444825 Change-Id: I5d6706a488a2c50694d481e1ea07e051d68ef4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134610 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#759122}
-
Justin Cohen authored
This reverts commit 79d88adc. Reason for revert: Fix test. Original change's description: > [ios] Disables failing tests in RestoreTestCase. > > These tests are attempting to load an invalid URL that happen to no > longer be invalid. > > TBR=justincohen@chromium.org > BUG=1070790 > > Change-Id: I03df3f99989b70013e4a047c3636f7e0b5d45fc4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148029 > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759036} TBR=rohitrao@chromium.org,justincohen@chromium.org Change-Id: I31bc8c06a54f2d106e5b040ced6730c8bf4fc121 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150010Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759121}
-
John Z Wu authored
Change-Id: I1d59001345830e59a0e57834490f9f5afbaa0247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150126 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759120}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ib75716cf8070b3e2b0a91b818fa8317696076c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150186Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759119}
-
Jeevan Shikaram authored
Fixes a bug that did not show the correct web apps in App Management when BMO is turned on. Fixed: 1064877 Change-Id: I38dcd7485c59cd6b9a821b15b14f04c08e7590bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147127Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#759118}
-
Shakti Sahu authored
This CL refactors query tiles into a generalized component 1 - Moved to components/browser_ui/widget 2 - Subclassed generic Tile to QueryTile for query tile usage 3 - Moved XML layouts, drawables, dimensions etc to components as well. 4 - Future clients will have to add their layout resources and specific java classes in the same directory. Bug: 1068687 Change-Id: I48646b8d2f2160cdfbec74cfaa1ebc74ed7dbaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140921 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759117}
-
Rohit Rao authored
RestoreIOSLiveTab is not compiled with ARC and therefore is not properly retaining the CRWSessionStorage* which it is passed. Temporarily work around this bug by keeping a strong pointer to the CRWSessionStorage* in ClosingWebStateObserver, until RestoreIOSLiveTab can be fixed properly. BUG=1070852 Change-Id: Ic3d8a4d0cc3c29bfae4f657de06b98aa869b3bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150035Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759116}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e0950f3cd2c6..81d176721689 git log e0950f3cd2c6..81d176721689 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 apolito@google.com upgrade git to 2.26.1 2020-04-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-04-14 iannucci@chromium.org Fix recipe autoroller account. 2020-04-14 ehmaldonado@google.com metrics: Use vpython3 instead of sys.executable Created with: gclient setdep -r src/third_party/depot_tools@81d176721689 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068263,chromium:1070694 Tbr: agable@chromium.org Change-Id: I9257ae3b42eeedf414af29a5b4cced28f2e16d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759115}
-
David Black authored
On creation, AssistantSearchProvider will sync its results with the cache of Assistant conversation starters. It will also observe changes to the conversation starters cache to keep itself in sync. Bug: b:153165835 Change-Id: I678bb6c8b8d80148c18c4970107872089d02dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140210 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#759114}
-
nancy authored
If the app is unpaused before the user responses to the pause app dialog, remove the app from pending_pause_requests_, and not pause the app, when the user click the pause app dialog. Because the app has been unpaused, and the user can still use the app. BUG=1068799 Change-Id: I4beef6959bc01746388dcfc0a3d282859e16cd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147481Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759113}
-
Martin Šrámek authored
The steady state button uses the aria label "Run safety check now". Per feedback from the accessibility review, when we swap that button with a reload button, we should also update the aria label. We will use the label "Check again". This string already exists in settings_strings.grdp, with a reasonably matching strings description, so we will reuse it in order to be able to merge this change into M83. We will introduce a dedicated string resource in a follow-up CL (that will not be merged into M83): https://chromium-review.googlesource.com/c/chromium/src/+/2149418 Bug: 1070841 Change-Id: I9b9ee80a53ce0efc591d78fe384ce29748f183d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149647Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759112}
-
John Z Wu authored
- Use more mocks - Remove old autoreleasepool work around Bug: 1070657 Change-Id: Ic234ddb2e9be28048a39c365ec8c2e09eaf38d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147882 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#759111}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: If006fe91be7c37d81fea2088c42a8bdb920938a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150029 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759110}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/39fd800d2c43..05dc1d6cad93 git log 39fd800d2c43..05dc1d6cad93 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com mDNS: Multi-Packet Known Answer Suppression Created with: gclient setdep -r src/third_party/openscreen/src@05dc1d6cad93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I48dd1b14f82e9130ee65aef86249b1aa19c44112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150085Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759109}
-
Klaus Weidner authored
By default, this is a no-op, but test API implementations can override it to do console logging or similar. This is intended to help investigate flaky tests on Windows that are currently just being reported as "timed out" with no indication what's going wrong. Includes a fix for ar_dom_overlay_hit_test.https.html, the logs had shown that the test wasn't waiting for the test body to execute, and an unexpectedly failing assertion wasn't being reached. Bug: 1054750 Change-Id: I878c6ea56ebb8e0752027ea13de7106d7f9e7bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132784 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#759108}
-
edchin authored
This reverts commit c977b051. Reason for revert: EG swipe is not working properly on iOS 12. Disabled swipe test for iOS 12. Original change's description: > Revert "[ios] Add eg2 tests for managed bookmarks" > > This reverts commit db19268d. > > Reason for revert: test failure, see crbug.com/1070676 > > Original change's description: > > [ios] Add eg2 tests for managed bookmarks > > > > This CL adds eg2 tests for changes in crrev.com/c/2140953. > > > > The test fixture in this CL must enable certain command-line flags > > to be able to run the managed bookmarks enterprise policy. > > > > The eg2 tests for managed bookmarks include testing: > > - disabling long-press for managed items (URLs and folders) > > - disabling swipe-to-delete for managed items (URLs and folders) > > - disabling new folder context menu button when inside a managed folder > > - disabling edit context menu button when inside a managed folder > > > > Bug: 1065187 > > Change-Id: Ide92b87f03585d186b133f192d1e39a4fbbaa1cd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145260 > > Reviewed-by: Sergio Collazos <sczs@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#758848} > > TBR=edchin@chromium.org,sczs@chromium.org > > Change-Id: Ie6b374a26d85cd99d52417ee52aabee8ff2d2683 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1065187, 1070676 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149287 > Reviewed-by: Xiaohan Wang <xhwang@chromium.org> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758903} TBR=xhwang@chromium.org,sczs@chromium.org Change-Id: Idbdbab707e239b9abdae0c19a10979af9abfef06 Bug: 1065187, 1070676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149507Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759107}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/b86cd3f5fb91..5abb89b35e3c $ git log b86cd3f5f..5abb89b35 --date=short --no-merges --format='%ad %ae %s' 2020-04-13 ianswett gfe-relnote: Rename QuicHttp3ErrorCode::NO_ERROR to HTTP3_NO_ERROR to avoid colliding with the Windows NO_ERROR error code. No functional change, not flag protected. 2020-04-13 ianswett gfe-relnote: Change a string to a char[16] to avoid using data() in string, which is sometimes const. Fixes a Chrome merge failure of cr/305944808. Protected by existing flags gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-13 bnc gfe-relnote: Convert IETF RESET_STREAM error codes to and from QuicRstStreamErrorCode. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-10 dschinazi Add QuicheDataReader::ReadStringPiece8 2020-04-10 dschinazi Improve logging of QuicCryptoFrame 2020-04-10 dschinazi Apply GREASE to QUIC transport parameters 2020-04-10 fayang Change a WARNING log to DLOG in QuicStreamIdManager. 2020-04-10 renjietang Initialize values in tests to avoid MSAN failure. 2020-04-10 renjietang Move incoming SETTINGS handling from QuicReceiveControlStream to QuicSpdySession. 2020-04-10 ianswett Internal QUICHE change 2020-04-10 bnc Return INTERNAL_ERROR if QuicErrorCodeToTransportErrorCode() is called with invalid QuicErrorCode. This should never happen, because QuicErrorCodeToTransportErrorCode is only called for serializing locally initiated CONNECTION_CLOSE frames, with locally specified QuicErrorCodes. 2020-04-10 bnc gfe-relnote: Use PushId instead of QuicStreamId argument type where appropriate. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-10 bnc gfe-relnote: Change QuicRstStream::ietf_error_code to 64 bits and move it out of the union with error_code. Behavior change in IETF QUIC only, protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-09 bnc Do not use union in QuicErrorCodeToIetfMapping. Also do not end public member names with underscore. 2020-04-09 bnc Shorten QuicHttp3ErrorCode and QuicHttpQpackErrorCode member names; make QuicHttpQpackErrorCode enum class. Enum class members are always scoped, therefore they do not have to be long or unique. 2020-04-09 bnc gfe-relnote: Do not increment QuicSimpleServerSession::highest_promised_stream_id_ if push cannot be created. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-09 nharper Use all encryption levels in quic_crypto_stream.cc 2020-04-09 renjietang store received TransportParamters in TlsClientHandshaker so that it could later be stored into the session cache. 2020-04-09 dschinazi Introduce quic::AllSupportedVersionsWithTls() 2020-04-09 dschinazi Add operator!= to QUIC TransportParameters 2020-04-09 bnc Move QuicIetfTransportErrorCodes, QuicErrorCodeToIetfMapping, and QuicErrorCodeToTransportErrorCode from quic_types to quic_error_codes, next to closely related QuicHttp3ErrorCode. 2020-04-09 renjietang Implement comparator for TransportParameters. 2020-04-08 renjietang Modify QuicResumptionState and SessionCache to support multiple TLS sessions. 2020-04-08 dschinazi Remove QuicDispatcher workaround for Android Conformance Test 2020-04-08 renjietang Allow copy constructor of TransportParameters. 2020-04-08 renjietang Remove QuicStreamIdManager::IsIncomingStream() as it's hard coded. Also QuicSession doesn't need the indirectness. 2020-04-08 bnc gfe-relnote: Use indexed name if possible when sending Literal Header Field without Indexing instruction. Protected by gfe2_reloadable_flag_spdy_hpack_use_indexed_name. 2020-04-08 bnc gfe-relnote: Consolidate constants with the same value. No functional change. Not protected. 2020-04-08 wub gfe-relnote: (n/a) Change 2 QUIC_BUG to QUIC_LOG_EVERY_N_SEC(ERROR) to reduce alert spam. Logging only, not protected. 2020-04-08 quiche-dev gfe-relnote: Reject chlo packets with unacceptable uaid/sni in quic dispatcher. Protected by --gfe2_restart_flag_reject_unacceptable_packet_early_in_dispatcher. 2020-04-07 renjietang Clean up QuicStreamIdManager comments and remove unnecessary methods. 2020-04-07 nharper gfe-relnote: test-only change: De-parameterize QuicCryptoServerStreamTest 2020-04-07 dschinazi Reorder QUIC TLS versions before QUIC_CRYPTO 2020-04-07 fayang gfe-relnote: Neuter handshake data when 1-RTT packet gets decrypted in quic_loas_server_stream. Affecting QBONE, not protected. 2020-04-07 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_bbr2_avoid_unnecessary_probe_rtt. 2020-04-07 bnc gfe-relnote: Do not include PUSH_PROMISE header block length when calling QuicSpdyStream::OnStreamHeaderList(). Not protected. 2020-04-07 dschinazi Disable TLS in YperfChannelTest 2020-04-07 wub gfe-relnote: For better experimentation, add QUIC connection option ELDT to enable loss detection tuning. No behavior change, not protected. 2020-04-07 renjietang Use Quic protocol flags to control QuicStreamIdManager's max_streams_window. 2020-04-06 renjietang Remove max_streams_window_ in QuicStreamIdManager to make the code more readable. 2020-04-06 fayang gfe-relnote: Calling OnConfigNegotiated() after OverrideQuicConfigDefaults in tls_server_handshaker. No functional change expected. Protected by existing gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-04-06 dschinazi Add operator<< overrides for QUIC version vectors 2020-04-06 ianswett gfe-relnote: Deprecate gfe2_reloadable_flag_quic_bundle_retransmittable_with_pto_ack. 2020-04-06 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_arm_pto_with_earliest_sent_time. 2020-04-06 ianswett gfe-relnote: Support the BBQ2 connection option in QUIC BBRv2 to lower the CWND gain to 2 in STARTUP. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src You forgot to pass -r, make sure to insert a R=foo@example.com line to the commit description before emailing. Run: git cl upload --send-mail R=bnc@chromium.org Change-Id: I2822bd93938fcc537a4fb74a9df13b22bd3a6783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146297 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759106}
-
Yuzu Saijo authored
This is a reland of 9caea10d This CL contains the part of the original change which only adds the blocklisting mechanism. The flaky test is to be fixed and added in the next CL. Bug:1070511, 1068949 Original change's description: > [bfcache] Blocklist Printing > > This CL disables BackForwardCache when window.print API is used. > > Change-Id: I52a1b350c70246344487f00b19682579cbceec58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121638 > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757348} Change-Id: I3fee79ea7332b6c61ba538017bd83d14b0b49719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145542Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#759105}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/37193aa3b306..beaaa5a60140 git log 37193aa3b306..beaaa5a60140 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 rharrison@chromium.org Rolling 5 dependencies 2020-04-14 cwallez@chromium.org Make a static const variable constexpr in BitSetIterator 2020-04-14 cwallez@chromium.org Remove temporary GN proxy groups. 2020-04-14 yunchao.he@intel.com Add more resource binding related validation tests Created with: gclient setdep -r src/third_party/dawn@beaaa5a60140 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: I366e662bac9abdbce524eee280f7f7e1c83f1725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759104}
-
Tsuyoshi Horo authored
Currently if the logic for recursive prefetch of as=document is executed, the logic for subresource signed exchange prefetch is not correctly executed in PreloadHelper::LoadLinksFromHeader(). This CL fix this, and make subresource SXG prefetch work with as=document link prefetch. Bug: 1069699 Change-Id: I8201a9ae003568fe7d3424eb6189527d992dcb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143068 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759103}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69510cd61f1a..4f451f046dab Created with: gclient setdep -r src-internal@4f451f046dab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1054179,chromium:1067607,chromium:1068308,chromium:1068818,chromium:1070424 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I77877d96f4748a529c513addae2ef1e7c4a411bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759102}
-
John Z Wu authored
Change-Id: I415c47e055985d2d9ef55e6d73fec70fad6a2944 Bug: 1070657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148097Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759101}
-
Yann Dago authored
BYPASS_POLICY_COMPATIBILITY_CHECK=<M82 skipped> Bug: 1070628 Change-Id: I26fde58b7cf27ab6732da6300333705b7f8993e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147774 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759100}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a79a2f646d24..4b4e87913242 git log a79a2f646d24..4b4e87913242 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 dberris@chromium.org Dashboard: Reduce estimator function overhead Created with: gclient setdep -r src/third_party/catapult@4b4e87913242 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1070268 Tbr: sadrul@google.com Change-Id: I2ffc97b914d37459d62421a5e60c7e17199a048d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759099}
-
Tsuyoshi Horo authored
These sycalls are used in libpthread. https://opensource.apple.com/source/libpthread/libpthread-416.40.3/src/internal.h.auto.html Bug: 1050158 Change-Id: I41537612736122d6a7a9c1c129ecfc13ef01b419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149476Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#759098}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: I984a360ff6dfe0e27dc6d583d87ff5b848ff031c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146935 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#759097}
-
Annie Sullivan authored
This is a diagnostic to the heartbeat metric PageLoad.InteractiveTiming.InputDelay3 which also never expires. Bug: 1070240 Change-Id: I8ace010bb7cdd56416fe2a902e347d3aa92e2401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147854Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759096}
-
John Z Wu authored
This API was only able to delete local-only data and because ios/web_view will no longer save local-only data, this API is now obsolete. Change-Id: I9e919d84ac9651d72a82eb656bb9678d3d60e05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148459Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759095}
-
Kyle Horimoto authored
This CL migrates Bluetooth UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I3ab1680691b10bf1b41f01e4bbee7974106700b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146287 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#759094}
-
rbpotter authored
Bug: 1026426 Change-Id: I283187f2b4797e2ce88fe7b68c23795971e7cba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148481 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759093}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1b30886d6dd3..6e0d718a48d8 git log 1b30886d6dd3..6e0d718a48d8 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 hckim.kim@samsung.com Vulkan: Implement device memory sub-allocation 2020-04-14 shrekshao@google.com Add DrawBaseVertexVariants Tests Created with: gclient setdep -r src/third_party/angle@6e0d718a48d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Iad28e18bebb9125db0252ddaf63cc129d61ddbea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759092}
-
Khushal authored
This reverts commit d4260731 and commit e3b5d5ac. This extension was suspected to be responsible for some driver crashes but this did not turn out to be the case. TBR=zmo@chromium.org Bug: 1042615 Change-Id: I1195e2f05c2e45d7476c2403873da0a44859144b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148848Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#759091}
-
Robbie McElrath authored
This CL renames FaviconFallbackGenerator to RoundedIconGenerator and moves it from org.chromium.components.favicon to org.chromium.components.browser_ui.widget since it's not used exclusively for favicons. See crrev.com/c/2136278 for context. Bug: 1058597 Change-Id: Ia0efe40b4d6e7e137bbadb4e964ee229424e3c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149695Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#759090}
-
Garrett Beaty authored
There are some configurations that we do not have the capacity to run on CQ and/or do not catch enough errors to justify running on CQ but still want to roll back breaking changes. This adds those builders back to the main console. Change-Id: I9c8059fdda5f181521c85037c2d4c57bc54aba94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147873Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#759089}
-
Piotr Bialecki authored
Bug: 1070494 Change-Id: I0c828ed291c53dfeb238fce1de47c7d7aa76602a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146289 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759088}
-
Mason Freed authored
Prior to this CL, the setsize and selected attributes were incorrectly linked. There are now two separate attributes with their own reflected properties. Bug: 914469 Change-Id: I73c26e3685fc758537cbe0eb9e3bb98becc75bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148112 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#759087}
-
Mike Dougherty authored
Bug: 1066029 Change-Id: Iaecc6e60782b686e3bd4d0f3ae76f320939bc659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145555Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#759086}
-
David Black authored
This controller and its model are needing to be exposed to the new AssistantSearchProvider. This will be used to provide a chip from conversation starters in the launcher. With the addition of this new interface, we no longer need to expose the controller model through the AssistantViewDelegate. Moving forward, this pattern can be used for other Assistant sub-controllers as well. Bug: b:146074655, b:153165835 Change-Id: I7016bd9ae8d6cbe07dc9afe3ee01b99588127fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135838 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759085}
-