- 09 May, 2019 40 commits
-
-
Alex Leung authored
The buffer passed to CmaBackend::PushBuffer may be stored in the backend decoder for some time before actual playout. It should not be modified since it could corrupt audio that is yet to play out. Bug: b/124402185, b/126295803 Test: Tested multizone on Android Change-Id: Ie31d3b8f9d831597e00f2f5b72b3e2694b38406b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603762 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#658303}
-
Devlin Cronin authored
Extend the expiry of Extensions.Messaging.IncludeChannelIdBehavior to December 2019. It will be useful to audit whether we can remove support for the includeTlsChannelId property in runtime.sendMessage since channel ID is no longer supported. Bug: 902099 Change-Id: Ieb129cef4960da1c0cb257e3d1ac03bb906d1c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601690Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658302}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/136b57f5f7ce..cb68382c9842 Created with: gclient setdep -r src-internal@cb68382c9842 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: I433bf8f494f199a5a318b79f35a3acce5c9fd40d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603328Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658301}
-
Kurt Horimoto authored
Bug: 961449 Change-Id: Ia45b11b8976f4fa7fb98bb4cd7451d2737027365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603525Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658300}
-
Bret Sepulveda authored
This is a reland of 133ed70b TabStripModelObserver was updated in a separate patch to remove the union which caused the original reversion. Original change's description: > [Tab Groups] Stop using TabGroupData pointers as group IDs. > > Tab groups are currently identified using TabGroupData pointers. However, > this is fragile because those pointers may not be valid forever and > because memory address may be reused. It makes more sense to use an > opaque int ID for this purpose instead. This also allows the API to > explicitly define when a group may be null or not, by using > base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be > able to operate using that ID and continue to avoid knowledge of any > particular View type. > > This patch also includes some miscellaneous refactoring in > tab_strip_model_unittest.cc. > > Bug: 905491 > Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652391} Bug: 905491 Change-Id: Ic1d02267c81c03b2da12ed502d4f4d736c1cad9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577922 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#658299}
-
Sébastien Séguin-Gagnon authored
Adds the last_updated_timestamp field to DeviceInfo and populate it with the already existing field of the same name in the sync proto. Use that value instead of using the change processor in the SendTabToSelfBridge. Bug: 959487 Change-Id: If84605055988c2d5deb4f5f0be373cc7d4368f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598550 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658298}
-
Toni Barzic authored
Taking over rsorokin's patch at CL:1578742, given that he is OOO. DeviceStateMixin now initialized device state values in local state during setup. Add support for setting device policy and device local account policies in in-memory fake session manager client, in a way similar to UserPolicyMixin. Later this functionality can be moved to a separate mixin, which might make sense if/when we add functionality for setting up policy served by local test policy server to this mixin (this should already be possible using LocalPolicyTestServerMixin). Uses AutoLaunchedKioskTest as an example of new usage. Also fixes a number of tests to wirk with the new device state setup. Bug: 952855 Change-Id: I1c0314a51581137d0f5a0907a09a4ef5b0bccda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600857Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#658297}
-
PKH authored
This CL cancels the fade animation in the unlikely case that the user swipes away the activity during the splash screen fade animation. The Android framework does not cancel in progress animations automatically when an activity is destroyed. Change-Id: I0db89c148388358933b37b4a9ae33e76af5b6784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602443Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658296}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/064b1625059a..cd078c339256 git log 064b1625059a..cd078c339256 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 timvp@google.com Allow mis-matched Android Context versions 2019-05-09 tobine@google.com Remove dontRemoveInvariantForFragmentInput WA 2019-05-09 jmadill@chromium.org Print current file in ASSERT macro failures. Created with: gclient setdep -r src/third_party/angle@cd078c339256 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I3689bb3d0813ed3222b9df443dd882423500cab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658295}
-
Sammie Quon authored
This is a reland of 963bfd6e Could not reproduce locally with the new changes. Suspected causes for flakiness before. 1) Rounding down because of int means we never waited for browser to startup. 2) Disabling animations too early means the creation of the browser window has an animation which may have interfered with the tablet window animation. Original change's description: > cros: Add tablet <-> clamshell performance test. > > Test: interactive_ui_tests TabletModeTransitionTest.EnterExit > Bug: 953896 > Change-Id: Ie2332df2bea2f7d2a63b39d8b390fcf4b28999f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1580583 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656911} Bug: 953896 Change-Id: I214d12fc24f16423f323c87fa7a182eebb0ee745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598784 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#658294}
-
Kristi Park authored
Attempting to convert an non-existent 'index' attribute to a number returns 0. Since 'index' is not set on the add button, this will cause it to be moved in a weird direction. Ignore the add button when shifting tiles, and throw an error if no index is found. Screencast: https://drive.google.com/open?id=1zDpvi34Ng4kte8vHYcKCPne0OEmfRctf Bug: 961200 Change-Id: I78bf0b803ad6cc90b3913a3ca382b891320c95b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601647Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658293}
-
Eugene Girard authored
Bug: 935526 Change-Id: I0fa7f6a887cebf56fb4e1a955a99891d2331f0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491766 Commit-Queue: Eugene Girard <girard@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#658292}
-
Xiyuan Xia authored
The hack is needed because session state was sent to ash via mojo asynchrounously and this is no longer the case. Bug: 958214 Change-Id: I61ace0a6293dff480a0fceae66ac8344c22e17fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603484Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658291}
-
Steve Anton authored
Bug: None Change-Id: I07578f0d424764fed0ce93a88b40e0046f1e1527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603343 Auto-Submit: Steve Anton <steveanton@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Reviewed-by:
Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658290}
-
Kyle Horimoto authored
This CL adds some clarifying comments and makes some functions const. These ideas were suggested as part of a similar CL: https://chromium-review.googlesource.com/c/chromium/src/+/1602072 Bug: 961084 Change-Id: Id34b3b960d8f1a86eaa930df2836e0f836ea9d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603489 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#658289}
-
Liquan(Max) Gu authored
Now that we already have the image time and size in PaintTimingDetector, we should deprecate largest_image_paint_ which stores duplicate information. Correct the order of DidChangePerformanceTiming() and NotifyLargestImage(). NotifyLargestImage() is about changing the data that PerformanceTiming should fetch. This is why DidChangePerformanceTiming() should come after NotifyLargestImage(). Bug:949974 Change-Id: I2b0801ce56cf327a8187273ac537e71d0e352533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596622 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#658288}
-
Kyle Horimoto authored
Bug: 961084 Change-Id: I1bf005fc4fd9b2e78ae36a90c606080139ee627c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602072 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#658287}
-
Kristi Park authored
Add field trial config for next round of alternate fakebox variations on the NTP. This replaces the UseAlternateFakeboxOnNtp experiment. Bug: 956164,956613 Change-Id: I1ae572142dc1d492371c5559838fb1a4bf5b28dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600159Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#658286}
-
Collin Baker authored
This layer can be created and destroyed as needed when an ink drop is installed. Creating it on construction adds a cost to every LabelButton, when there is usually only one ink drop active at a time. InkDropContainerView already manages this upon adding or removing ink drop layers, so no additional changes are needed to LabelButton. Bug: 946738, 960442 Change-Id: If67b443296f85fc296b815d5c61b28683e8d233f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603182Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#658285}
-
Michael Lippautz authored
The reference has been removed a while ago. Bug: 943097 Change-Id: I5e88ccc4f588a9843ccebfe63e53e17d78034499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602730 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#658284}
-
Piotr Bialecki authored
This adds one more AR sample page that relies on incubated plane detection API to implement synchronous hit test purely in JavaScript. Change-Id: I7d98fb5f656eb4068facf83b4de8ac9a7b49f334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597276Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#658283}
-
Justin Cohen authored
Moving from the popstate event to a zero second setInterval shortens session restoration by a few milliseconds, and perhaps works around the iOS12.2+ crash. Bug: 959499 Change-Id: Ic67a3cb146a9b3525efb6baa9dafae8e6bbf4ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602873Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#658282}
-
Sunny Sachanandani authored
Implement a GpuVSyncBeginFrameSource that uses OutputSurface to provide vsync updates. GLOutputSurface implements this by plumbing vsync requests and updates through InProcessCommandBuffer and GLSurface. The vsync updates are posted directly on the display compositor thread to guard against GPU main thread contention and to minimize latency. DirectCompositionSurfaceWin implements support for vsync updates based on DirectCompositionGpuVSync feature flag. Testing shows markedly better alignment of begin frames with GPU vsync than using timer based begin frames in ETW profiles and vastly improved regularity of frame deltas on vsynctester.com. Change-Id: Iaca86b3f15a6cccace168b9ac6b62a6f38c67542 Bug: 953970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558583Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#658281}
-
Lucas Gadani authored
This prevents the white flash when activating a portal. Bug: 956575 Change-Id: I02864de8f4a23a219a61c511a5f268d02c834d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603094Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#658280}
-
Kyle Milka authored
Bug: 960045 Change-Id: Id9ccaf935ca657b8ad064abd444045ebb30eb61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597695Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658279}
-
Matthew Mourgos authored
Bug: 955204 Change-Id: I4e8cf28043c429cb8422809c3d3e1b70a3d351de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602976 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#658278}
-
Xiaocheng Hu authored
This is a follow-up of changing left/right caret movements from visual to logical. As NGCaretNavigator is designed for visual caret movements, it no longer serves any purpose here and hence is also removed. Bug: 958831 Change-Id: I2b18cf81ca9a997851e05617927c608b4831abbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602975Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658277}
-
Kevin Strohbehn authored
Also removes dead code for ProgressBar from search results Bug: 931909 Change-Id: I37633fc95ff01508ce9a4afc8bfa9ed237f874d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600507Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#658276}
-
Devlin Cronin authored
Mark Extensions.ThrottledNetworkRequests as obsolete. It has been expired since 2018-08. We haven't been looking at it lately, and we can always add it back later if we need it again. Bug: 878106 Change-Id: I24fc5e7105976da3cbfbfeb52110e8483edc7c8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600859Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658275}
-
Bailey Berro authored
Introduces the AutomaticUsbPrinterConfigurer class. This class will be owned by CupsPrintersManager. It observes CupsPrintersManager, and when it sees a usb printer in the kAutomatic class, it installs the printer. Eventually, we will wire up a notification to let the user know that their printer is ready for use. Bug: 951135 Change-Id: I79f2a447eef6adfebbbf8d16fb84549870703adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585472 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#658274}
-
Owen Min authored
The timer is a variant of base::RetainingOntshotTimer. It allows different delay for the first task and run with repeat delay every time it's reset. Also creates the enterprise_reporting folder with OWNERS file. Bug: 956237 Change-Id: Ic29e57e69051b71407007a65e68e76f3ce913968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590448Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#658273}
-
Etienne Bergeron authored
This CL is fixing an old bug that keeps spiking in our crash metrics. The TextElide function may produce a text that has more bytes than the original text due to the two codepoint that can be added (e.g. Ellipsis and Direction Marker). see: https://bugs.chromium.org/p/chromium/issues/detail?id=960477#c7 This CL is adding a test that is failing on this corner case. The current fix is to avoid returning a longer text than the original. The main problem is that the BreakList are also represented over input ranges and having an extra character will leads to crash. R=msw@chromium.org CC=ccameron@chromium.org,asvitkine@chromium.org Bug: 960477 Change-Id: I422a12bdd6bde1c785a74c64e1c8c4817cf9b994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602972 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#658272}
-
Sahel Sharify authored
JourneyLogger::IncrementSelection[Adds/Changes/Edits] methods are used to count the number of times that each of the shipping, payment, and contact info sections are added, changed, or edited by the user during a payment process. After calling these methods on desktop payment request code path the following UMA metrics are correctly logged on desktop platforms: PaymentRequest.NumberOfSelection[Adds/Changes/Edits].[ContactInfo/ShippingAddress/PaymentMethod].[Completed/UserAborded/OtherAborted] Bug: 959979 Change-Id: I0d82b1c7dfe90a5dcde364fd4c4d8c4b6bd8e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600448 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658271}
-
Jun Mukai authored
With this CL, I confirmed that some metrics for LauncherAnimationsTest gets worse, which is expected (since previously it only showed an empty layer). Most notably, FullscreenAllApps smoothness becomes 50-75 -> 15-45. Interestingly the smoothness for Close isn't affected and it's mostly 100 when testing on nocturne. Bug: 954521 Test: manually with interactive_ui_tests --enable-pixel-output-in-tests Change-Id: Ia9ba9b70ea55c0e78c0fbfb5f8152771e0b67515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601415Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#658270}
-
Charlie Andrews authored
NOTRY=true TBR=sullivan@chromium.org CC=tdresser@chromium.org,mythria@chromium.org,ulan@chromium.org Bug: 96434 Change-Id: Ic34d4f6221eecd7907273526a11021d57556a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603544 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#658269}
-
Albert J. Wong authored
In a number of cases, the minidumps are lost. Also crash clustering accidentally groups separate CHECKs probably due to inlining. As this is a debug function, speed isn't important so breaking explicit failure functions is a valid way to get better data even when the minidump is lost. Bug: 960470 Change-Id: I6b2d00484d9c9690baef0e9c003a1a7c73749f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600429 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658268}
-
Robert Ogden authored
We've launched and enabled this by default for everybody, so the feature code is no longer needed. Bug: 909915 Change-Id: Ib1bcac2d23a6960155f944f3c11c4cda2e40c440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601977Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#658267}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/370d193c8e46..8a2a5a8d2777 git log 370d193c8e46..8a2a5a8d2777 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8a2a5a8d2777 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I26f7015a93d84745c5cf34f1e8203c2d17f177d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658266}
-
Kyle Milka authored
Add the menu that opens when a collection is clicked. Allow pressing back to return to the main menu. LTR: http://go/scrcast/NTQ4MzI5ODMwNjM5MjA2NHw2MDFhZmIyMi03Yg RTL: http://go/scrcast/NDY3NjE1MDA2ODUxMDcyMHw4OTE3Y2IxMS1iYw Bug: 937570 Change-Id: Idaea005cc212004ec314b720ede63a1d1d51e159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603206Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#658265}
-
Danyao Wang authored
This is a master flag that early-adopter partners can use to toggle all experimental Web Payments API features. New features will be conditioned on a per-feature flag OR this master flag. Bug: 960400 Change-Id: If93d90a1a41e82ddef737fe239e2ca526613ba06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600427 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658264}
-