GitLab

Test NavigatorTestWithBrowserSideNavigation.BeginNavigation was broken
due to the way the subframe used was added to the tree. By directly
calling FrameTree::AddFrame the proper observer notifications were not
being executed and triggered a sanity check. It was replaced with the
already test-tailored TestRenderFrameHost::AppendChild.

BUG=455484

Review URL: https://codereview.chromium.org/904673004

Cr-Commit-Position: refs/heads/master@{#315063}

Downloaded by: https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/util/cloud_storage.py&l=86

BUG=456091
R=sullivan@chromium.org

Review URL: https://codereview.chromium.org/888883004

Cr-Commit-Position: refs/heads/master@{#315062}

Follow up to https://codereview.chromium.org/900613003/.
Make NewTabButton and TabStripBackgroundView adopt ThemedWindowDrawing.

BUG=455955,453996

Review URL: https://codereview.chromium.org/904503003

Cr-Commit-Position: refs/heads/master@{#315061}

BUG=453708
TEST=as in bug

Review URL: https://codereview.chromium.org/902083002

Cr-Commit-Position: refs/heads/master@{#315060}

According to issue 444835 there were at least two problems with debug info on
the swarming bots:
 - the .dSYM bundles for the test binaries and other applications weren't
uploaded to swarming servers;
 - for some binaries (e.g. Chromium Framework) their names were replaced with
SHA-1 hashes that confused llvm-symbolizer and made finding the .dSYM bundles
impossible.

This CL adds the necessary .dSYM paths to .isolate files for the tests
currently being ran on swarming bots (for other tests their .dSYM paths will be
added as needed).
It also extends tools/valgrind/asan/asan_symbolize.py with a binary name filter
that replaces the hashes with the corresponding file names in the product
directory.

BUG=444835
R=earthdok@chromium.org,maruel@chromium.org,csharp@chromium.org

Review URL: https://codereview.chromium.org/859293002

Cr-Commit-Position: refs/heads/master@{#315059}

We needed this flag to fix HostDriven_SearchByImageTest.testSearchByImageTest.

BUG=455653

Review URL: https://codereview.chromium.org/903983002

Cr-Commit-Position: refs/heads/master@{#315058}

Revert of Roll android_tools f6e2370:2a860d8 (patchset #2 id:20001 of https://codereview.chromium.org/900273003/)

Reason for revert:
Some builders apparently don't yet have Google Play Services installed.

Original issue's description:
> Roll android_tools f6e2370:2a860d8
>
> This rolls in an update to android_tools.gyp that provides targets for
> Google Play Sevices libraries.
>
> BUG=450675
>
> Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d
> Cr-Commit-Position: refs/heads/master@{#315037}

TBR=mcilroy@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450675

Review URL: https://codereview.chromium.org/889603009

Cr-Commit-Position: refs/heads/master@{#315057}

This reverts commit 44036d05
From review: https://codereview.chromium.org/899113002

Original issue's description:
> This CL makes "timezone auto update" feature available (but switched off by
> default) to users. And adds flag to disable this feature.
>
> BUG=416494
> TEST=manual
>
> Review URL: https://codereview.chromium.org/898503002

TBR=stevenjb@chromium.org,dpolukhin@chromium.org,isherman@chromium.org
BUG=416494

Review URL: https://codereview.chromium.org/909453002

Cr-Commit-Position: refs/heads/master@{#315056}

The heuristic ensures that the user is not prompted too much, and is only
prompted after showing sustained engagement with a site.

BUG=452825

Review URL: https://codereview.chromium.org/886643003

Cr-Commit-Position: refs/heads/master@{#315055}

Replaced occurrences of [HyperlinkTextView setMessageAndLink:withLink:
atOffset:font:messageColor:linkColor:] with
[HyperLinkTextView setMessage:withFont:messageColor] and
[HyperLinkTextView addLinkRange:withName:linkColor:]. Removed the
[HyperLinkTextView setMessageAndLink:withLink:...] method.

BUG=253755

TEST=it's very difficult to produce test sequences for most of these changes.
Here is the one sequence I do have:

for sad_tab_view_cocoa.mm: Launch Chrome, run
    ps augx | grep “Chrome Helper”
in a Terminal window, create a new tab and go to some page, run the ps...
commands again and figure out the process number of the new Chrome
Helper (the one that wasn’t there before). In a Terminal window type kill -9
<XXX> where <XXX> is the process id of the new Chrome Helper. Confirm
the new tab now shows the sad tab page and that the last line of text reads,
“If you're seeing this frequently, try these suggestions.” with the word
“suggestions” as a clickable link that takes you to the “Aw, Snap!” Chrome
help page.

Review URL: https://codereview.chromium.org/887823002

Cr-Commit-Position: refs/heads/master@{#315054}

1.Parallelizing run of tests
2.All options were moved from command line args to config
3.Introducing possibility to avoid writing to sheet

BUG=435249

Review URL: https://codereview.chromium.org/903763003

Cr-Commit-Position: refs/heads/master@{#315053}

BUG=432398

Review URL: https://codereview.chromium.org/892413007

Cr-Commit-Position: refs/heads/master@{#315052}

detachGLFunctor is called every time the webview is detached (ie when
hardware acceleration is torn down and cleaned up). This can happen many
times since webview can be attached and detached many times.

However the implementation in the glue layer only does something on the
first call.

Also in general, it's a bad pattern for CleanupReference to have strong
java refs.

It's not necessary to call detachGLFunctor on gc; detach is enough. So
move all that code out of the DestroyRunnable of the CleanupReference.

This is a long standing bug since the first release of chromium webview.

BUG=

Review URL: https://codereview.chromium.org/872403006

Cr-Commit-Position: refs/heads/master@{#315051}

This will allow the ResolveFileToken field to be removed from
NaClValidationCache on the NaCl side.

Chromium no longer uses the NaCl side's ability to call back to
ResolveFileToken().  File tokens are handled entirely on the Chromium
side.

Removing this is safe because the NaCl side doesn't call
ResolveFileToken() if the NaClDesc doesn't have a file token
associated with it, or if ResolveFileToken is NULL (and we're setting
it to NULL using memset()).

BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073
TEST=browser_tests

Review URL: https://codereview.chromium.org/897353002

Cr-Commit-Position: refs/heads/master@{#315050}

Use the API that's defined in native_client/src/public/.  That is
already used by nacl_listener.cc, but the code in nacl_ipc_adapter.cc
was written earlier, before the API in public/ was added.

NaClDescCreateWithFilePathMetadata() does the same as the code we're
replacing here.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073
TEST=browser_tests

Review URL: https://codereview.chromium.org/897363002

Cr-Commit-Position: refs/heads/master@{#315049}

Implements a GPU Channel level command buffer barrier, which ensures
ordering between channels, without immediately notifying the GPU service.

Multiple Ordering Barriers can be combined into single IPCs to the GPU
service, thus this API can be used in place of ShallowFlushCHROMIUM, to
reduce IPC count and GPU service overhead.

BUG=454500

Review URL: https://codereview.chromium.org/896723008

Cr-Commit-Position: refs/heads/master@{#315048}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/055aa2d..7e38934

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/909513002

Cr-Commit-Position: refs/heads/master@{#315047}

Ensure that the android_webview_locales_rename_paks
action is not executed when building downstream.

Review URL: https://codereview.chromium.org/881623003

Cr-Commit-Position: refs/heads/master@{#315046}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5245cb4..50785a3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/872893005

Cr-Commit-Position: refs/heads/master@{#315045}

BUG=455796

Review URL: https://codereview.chromium.org/893843005

Cr-Commit-Position: refs/heads/master@{#315044}

BUG=447311
TEST=Start Chrome with --enable-fast-user-switching. In the avatar bubble, any profiles
with default avatar should display the low res, transparent background images
(i.e. not the high res images with the grey background)

Review URL: https://codereview.chromium.org/900223004

Cr-Commit-Position: refs/heads/master@{#315043}

Adds a deadline overrun step to the RendererSchedulerIdlePeriod trace event
to make it obvious when an idle period lasts longer than its deadline.

Also adds a TRACE_EVENT_ASYNC_STEP_INTO_WITH_TIMESTAMP0 which is required
to add the step at the appropriate time.

BUG=455713

Review URL: https://codereview.chromium.org/908473002

Cr-Commit-Position: refs/heads/master@{#315042}

This is to rule out the (unlikely) case that we're sending idle
notifications to a disposed isolate

BUG=425035
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/873723008

Cr-Commit-Position: refs/heads/master@{#315041}

TBR=clamy@chromium.org
BUG=456131
NOTRY=true

Review URL: https://codereview.chromium.org/866043006

Cr-Commit-Position: refs/heads/master@{#315040}

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
TEST=checkdeps

Review URL: https://codereview.chromium.org/901903004

Cr-Commit-Position: refs/heads/master@{#315039}

Change HistoryService::ExpireLocalAndRemoteHistoryBetween() to
receive the history::WebHistoryService instance to use in order
to remove a dependency of HistoryService on Profile.

It is not possible to pass the WebHistoryService instance to the
HistoryService constructor and add a dependency between the two
factories due to http://crbug.com/171406 (as WebHistoryService
depends on a KeyedService calling Profile::GetRequestContext()).

BUG=453790

Review URL: https://codereview.chromium.org/901803005

Cr-Commit-Position: refs/heads/master@{#315038}

This rolls in an update to android_tools.gyp that provides targets for
Google Play Sevices libraries.

BUG=450675

Review URL: https://codereview.chromium.org/900273003

Cr-Commit-Position: refs/heads/master@{#315037}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f5c6006..055aa2d

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/908503002

Cr-Commit-Position: refs/heads/master@{#315036}

Revert of [telemetry] Add a V8GCTimes measurement and benchmarks. (patchset #2 id:20001 of https://codereview.chromium.org/898673005/)

Reason for revert:
Failing on mac:

http://chromegw/i/chromium.perf/builders/Mac%2010.9%20Perf%20%281%29/builds/2017

Original issue's description:
> [telemetry] Add a V8GCTimes measurement and benchmarks.
>
> Replaces the v8_stats metric with a v8_gc_times
> measurement.  This new measurement measures the amount of
> time spent in GC during the whole benchmark rather than
> just during gestures.
>
> The following gc metrics are measured:
>   v8_gc_incremental_marking
>   v8_gc_incremental_marking_idle_deadline_overrun
>   v8_gc_incremental_marking_outside_idle
>   v8_gc_incremental_marking_percentage_idle
>   v8_gc_mark_compactor
>   v8_gc_mark_compactor_idle_deadline_overrun
>   v8_gc_mark_compactor_outside_idle
>   v8_gc_mark_compactor_percentage_idle
>   v8_gc_scavenger
>   v8_gc_scavenger_idle_deadline_overrun
>   v8_gc_scavenger_outside_idle
>   v8_gc_scavenger_percentage_idle
>   v8_gc_total
>   v8_gc_total_idle_deadline_overrun
>   v8_gc_total_outside_idle
>
> It also measures the duration of the measurement and the
> amount of CPU time used.
>
> The v8_garbage_collection_cases benchmark is modified to
> use this new v8_gc_times measurement, and v8.top_25_smooth
> and v8.key_mobile_sites_smooth benchmarks have been added.
>
> Since v8_garbage_collection_cases was the only benchmark to
> use the is_fast metric type, and these measurements are now
> done as part of the v8_gc_times measurement now, this CL
> also removes the fast metric type.
>
> Perf Sherrifs: Since this CL changes he way in which the GC
> measurements are done it may cause a movement in the
> v8_garbage_collection_cases benchmarks.
>
> Committed: https://crrev.com/452de5927e54e1da0d57a4b2df8b447f4d442360
> Cr-Commit-Position: refs/heads/master@{#314868}

TBR=hpayer@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/904903002

Cr-Commit-Position: refs/heads/master@{#315035}

Each profile (regular and incognito) has its own HostContentSettingsMap. This
is modified for example in ContentSettingSingleRadioGroup and also presented in
the content settings exceptions in chrome://settings. However, the values of
the HCSM are not reflected in the CookieSettings of an incognito session
because a single CookieSettings instance is shared between regular and
incognito mode. This CL fixes that.

BUG=432398

Review URL: https://codereview.chromium.org/900803002

Cr-Commit-Position: refs/heads/master@{#315034}

Revert of Temporarily upload minidump to private cloud storage on windows. (patchset #1 id:1 of https://codereview.chromium.org/899293003/)

Reason for revert:
Got a minidump, reverting.

Original issue's description:
> Temporarily upload minidump to private cloud storage on windows.
>
> Should be reverted once we have one from crashing startup.warm.blank_page perf test.
>
> BUG=433966
>
> Committed: https://crrev.com/82a66024f96d8643f42e9ad21fcf3e79e78c8804
> Cr-Commit-Position: refs/heads/master@{#314902}

TBR=sullivan@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433966

Review URL: https://codereview.chromium.org/896303003

Cr-Commit-Position: refs/heads/master@{#315033}

Review URL: https://codereview.chromium.org/907443002

Cr-Commit-Position: refs/heads/master@{#315032}

Speculatively revert https://codereview.chromium.org/791493015
due to multiple browser_tests failures (e.g. see
https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/15751)
They are all due to SystemURLRequestContextGetter-related leaks.

This reverts commit 8fbff4fa.

TBR=megjablon
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456110

Review URL: https://codereview.chromium.org/903073003

Cr-Commit-Position: refs/heads/master@{#315031}

BUG=456109
R=alexclarke@chromium.org

Review URL: https://codereview.chromium.org/880603005

Cr-Commit-Position: refs/heads/master@{#315030}

$ git log e6677c870..94aea8c60 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-02-05 maruel Lower parallelism to 8 threads on 32 bits system.

TBR=vadimsh@chromium.org
BUG=419862

Review URL: https://codereview.chromium.org/901283004

Cr-Commit-Position: refs/heads/master@{#315029}

https://github.com/webrtc/apprtc/issues/48

BUG=455758
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/908483003

Cr-Commit-Position: refs/heads/master@{#315028}

BUG=456095
TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/895753003

Cr-Commit-Position: refs/heads/master@{#315027}

R=primiano@chromium.org

Review URL: https://codereview.chromium.org/875403007

Cr-Commit-Position: refs/heads/master@{#315026}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7a9fd74..f5c6006

TBR=apavlov@chromium.org,dpranke@chromium.org

Review URL: https://codereview.chromium.org/890603003

Cr-Commit-Position: refs/heads/master@{#315025}

This is used for the app banner manager to determine if it should
show a banner for the current page.

BUG=452825

Review URL: https://codereview.chromium.org/893793005

Cr-Commit-Position: refs/heads/master@{#315024}