GitLab

This CL implements a new feature which allows authors to query for
selector support.

Our selector parsing code is a little bit weird, hence we have to check
for no less than *three* fail conditions when parsing the selector
(failed_parsing_, AtEnd() and a nullptr-check).

Unknown -webkit- pseudo elements are never supported by spec. This CL
re-uses existing code for detecting support for these pseudo elements,
although that code was originally intended for use-counting.

Spec: https://drafts.csswg.org/css-conditional-4/#at-supports-ext
Bug: 979041
Change-Id: I9dfcce27ee00bbdf1932a6761b68eb82b110ca06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059408Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742578}

A recent WebRTC CL makes two more tests pass.
Re-enable WPT for RTCPeerConnection-mandatory-getStats
with updated expectations.

Bug: webrtc:7061
Change-Id: Id2891963e19b0cbfa90db6a35b9a7dcfe853434c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056466
Commit-Queue: Johannes Kron <kron@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742577}

Since we always create a new Vector<float> when creating a
FEColorMatrix, by moving |values| we can avoid unnecessary copying.

Also remove some unused static function declarations on FEColorMatrix.

Change-Id: I6d26635a5da514128ad42de932cc3f75333a94bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062397Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#742576}

When posting tasks with base::PostDelayedTask(), explicitly specify whether the
tasks should run on the thread pool on a specific named thread. This is in
preparation for making it always mandatory to specify the destination for posted
tasks.

This patch has no functional changes.

This CL was uploaded by git cl split.

Bug: 968047
Change-Id: I25230a83101d68c44929f19434d38e0620ee0b95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063009
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742575}

In the following call chain, a periodic timer invokes the callback,
therefore, it must be a repeating callback:
* https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=289
* https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=286
* https://cs.chromium.org/chromium/src/media/blink/video_decode_stats_reporter.cc?rcl=26a281f509fa5217972a45cae8fff0a32e5a1f44&l=126

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 714018
Change-Id: I234f6bdf2144e9b25665356873f606693563c996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035956Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#742574}

This reverts commit ace0df39.

Reason for revert: [sheriff]:
Consistent failures on MSan builds:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests
First failure:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17840

Original change's description:
> Fix default page break for Krane devices.
> 
> Adding default page break too early will cause the default page break
> gets deleted immediately.
> 
> Now move the installation of default page break after ChromeOS settings
> app is installed.
> 
> Bug: 1031410
> Test: Manual
> 
> Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Long Cheng <lgcheng@google.com>
> Cr-Commit-Position: refs/heads/master@{#742304}

TBR=xiyuan@chromium.org,lgcheng@google.com

Change-Id: I056ec39290ce8cdf889d3ad8ad017e787e29d4ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1031410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064210Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742573}

- Ensure that call actually uses H264 by checking codec type in
video track stats.

- Enable CanSetupH264VideoCallOnSupportedDevice test.

Bug: webrtc:11244, 1047994
Change-Id: I5ba241828500de9e465d5200e651640394d2ce6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033511Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Sergey Silkin <ssilkin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742572}

This class will shortly be shared by WebLayer's SSL interstitial
embedding so that the logic on when to allow users bypass SSL
interstitials is shared between WebLayer and Chrome.

As part of the componentization, also componentizes a pref that is used
by this class.

Bug: 1030692
Change-Id: I0d4e8a84b8b14637ad6380a99c7fec94310c01c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062433Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742571}

https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3306

TBR=rsorokin@chromium.org

Bug: 1052603
Change-Id: I7a6c3542fac98c27814f016a3b65ddefac3d42bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063171Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742570}

This CL removes the hard dependency WebAppAudioFocusBrowserTest had on
Extensions in favour of using WebAppControllerBrowserTest to switch
between Extensions/BMO backends via parameterisation.
This ensures the functionality is still testing when BMO is enabled.

Bug: 876576
Change-Id: Id1756b35568c50b4b0b5087e4d60b65a2f4cefb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063189
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742569}

Bug: 1053522

Change-Id: Ie1c851e25d323f0252ec7503ecd02aba5c5daba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062268
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742568}

This will make it easier to check for new issues when running `git cl
lint`.

Bug: 1053888
Change-Id: I782fba51ca915f31eb47f82f245967570bfc0dca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062992Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742567}

This is a reland of bf17bc25

Original change's description:
> [Extensions] Enable content verification for new policy non-webstore installs
>
> After this commit:
>  * For non-webstore policy force-installed extensions, write
>  computed_hashes.json on installation.
>  * If (according to computed_hashes.json) extension's resource is
>  detected corrupted, this extension will be disabled and  reinstalled.
>  This applies only for policy force-installed extensions, and for
>  webstore extensions it worked before this commit.
>
> This commit will NOT change behavior for already-installed extension.
> So, if some (non-webstore) extension was already corrupted, it will not
> be detected. The reason for this is that there is no source of truth for
> resources of already-installed non-webstore extension. It's possible to
> reinstall all previously-installed non-webstore extensions, but it's out
> of scope of this commit. See the bug for more details.
>
> Bug: 958794
> Change-Id: Ie9c014e7fd998f4eae6e852a59bd692d57ff7d8c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012964
> Commit-Queue: Oleg Davydov <burunduk@chromium.org>
> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737034}

This CL was reverted for the second time in https://crrev.com/c/2050686.
After investigation we've found two problems, which are not problems of
the original one CL itself, but imperfections revealed by it. These
imperfections were fixed in https://crrev.com/c/2051931 and
https://crrev.com/c/2049855. More info in https://crbug.com/1051513.

Bug: 958794, 1051513
Change-Id: I8e64a1023dee8f7a7e8f9781fb22434799de12e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061154
Commit-Queue: Oleg Davydov <burunduk@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742566}

This CL adds a test to check whether
ChromePasswordManagerClient::HideFillingUI
was called on navigating away.

Here
https://chromium-review.googlesource.com/c/chromium/src/+/1995173 we
added the functionality.


Change-Id: I8b99f879ab73fe63280c276b3db682eddfb9fa89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056547
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742565}

A couple of smaller changes that shouldn't affect the runtime behavior
of these classes. Primarily:

1) PerfettoProducer no longer inherits from ProducerEndpoint. There's
   no need for this anymore, since all TraceWriters now talk directly
   to a SharedMemoryArbiter.
2) ProducerClient continues to inherit from ProducerEndpoint, because
   it acts as a ProducerEndpoint to its SharedMemoryArbiter.
3) "Abuse" of methods in the ProducerEndpoint interface in ways that
   wasn't intended by the interface have been removed. For example,
   data sources no longer call ProducerEndpoint's NotifyFlushComplete(),
   and instead use a separate helper (similarly, tests now use
   ProducerClient::shared_memory_for_testing()).
4) Method order in XXX.cc is updated to reflect the order in the
   corresponding XXX.h.
5) Adds a lock around off-sequence access & modifications to
   PosixSystemProducer's |services_| list.

Change-Id: Ie3c8892fab52dc9a65bdb337621ceb1ce196518f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059019
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742564}

This is a reland of 139567ba

Original change's description:
> content/renderer/media: Query GPU process HW encoder capabilities
> 
> Originally GpuVideoAcceleratorFactoriesImpl get HW encoder
> capabilities by referencing values stored GpuInfo instance.
> However, the values are not updated after GPU process boots up.
> Even if a new hw encoder is available after GPU process is
> initialized, the hw encoder is not detected.
> 
> This fixes the problem by querying GPU process the hw encoder
> capabilities when a render process is created. e.g. open the
> page.
> 
> Bug: b:147404923
> Test: HW encoder is used at appr.tc
> Test: tast run webrtc.* on krane
> Change-Id: Ibca82b6e54e9b5d585037c8e63f4c663d085db0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994849
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735339}

Bug: b:147404923
Change-Id: Ia5535e0d316c0418f15e1139d475af67f226ed14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035481
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742563}

Change the structure of these pair of functions such that the former
handles the cache lookup and calls the latter to mint a new PatternData.

Remove the redundant check for an empty 'viewBox'.

LayoutSVGResourcePattern::PatternForClient is removed, because the issue
mentioned in the FIXME should no longer be present.

Bug: 109212
Change-Id: I5514dce39c20e07adbf45ea46c2dd472a4c71303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061752
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742562}

This reverts commit b51be283.

Reason for revert: Breaks builds.

Original change's description:
> Revert "Allow mixed-security content in promoted PWA windows"
> 
> This reverts commit ef364481.
> 
> Reason for revert: [sheriff]:
> Consistent failures on linux-chromeos-chrome
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
> First failed run:
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315
> 
> Original change's description:
> > Allow mixed-security content in promoted PWA windows
> > 
> > Prior to this CL, mixed-security content was blocked entirely in
> > standalone PWA windows with scopes. This CL allows those PWAs to display
> > mixed-security content, but when this happens, the window will show the
> > CustomTabBarView with the URL and a "Not Secure" indicator to indicate
> > the presence of mixed content.
> > 
> > Screenshot:
> > https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1
> > 
> > This removes a behavioural difference between promoted PWAs and "create
> > shortcut" apps without manifest scopes.
> > 
> > 
> > Bug: 910016
> > Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380
> > Commit-Queue: Alan Cutter <alancutter@chromium.org>
> > Reviewed-by: Evan Stade <estade@chromium.org>
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Reviewed-by: Peter Boström <pbos@chromium.org>
> > Reviewed-by: Glen Robertson <glenrob@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#742515}
> 
> TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org
> 
> Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 910016
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015
> Reviewed-by: Sergey Poromov <poromov@chromium.org>
> Commit-Queue: Sergey Poromov <poromov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742557}

TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,poromov@chromium.org,dominickn@chromium.org,glenrob@chromium.org

Change-Id: Ifef5a3c6a34563999506f4c5946273533ad0063d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063016Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742561}

https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests
https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31990

TBR=alcooper@chromium.org

Bug: 1053903
Change-Id: Idbd00ecfe63d58649969714912fffa8d083fefe4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062275
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742560}

- Push expiration of some cleanup histograms out by a few milestones
  since the related cleanup code is still being used.
- Remove the legacy multi-install Chrome Frame cleanup and its related
  histogram since it is now very rarely used.
- Remove the legacy app_host.exe cleanup and its related histogram since
  it is nearly never used.
- Mark Setup.Install.StrandedChromeIsUsed as obsolete since it was
  removed from the codebase years ago (oops).
- Mark Setup.Install.Result as never expiring since it is a fundamental
  metric.

BUG=1053134,1053138
R=bcwhite@chromium.org

Change-Id: Icc89877e442abc5953ba3a2deb9788487da60569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060951
Commit-Queue: Greg Thompson <grt@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742559}

I only recently realized that the generic ui framework is actually much
more simple if we remove this requirement. Now, callbacks have to be
fully specified in proto, which is easier to read and understand (and
also less code).

This is a refactoring and does not contain user-facing changes.

Bug: b/145043394
Change-Id: I96b66af316a4b4c205c0d0234f841075e96f8be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038653
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#742558}

This reverts commit ef364481.

Reason for revert: [sheriff]:
Consistent failures on linux-chromeos-chrome
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
First failed run:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3315

Original change's description:
> Allow mixed-security content in promoted PWA windows
> 
> Prior to this CL, mixed-security content was blocked entirely in
> standalone PWA windows with scopes. This CL allows those PWAs to display
> mixed-security content, but when this happens, the window will show the
> CustomTabBarView with the URL and a "Not Secure" indicator to indicate
> the presence of mixed content.
> 
> Screenshot:
> https://bugs.chromium.org/p/chromium/issues/attachment?aid=432401&signed_aid=JeW6cXlVCQ3bSebdZ-FoJg==&inline=1
> 
> This removes a behavioural difference between promoted PWAs and "create
> shortcut" apps without manifest scopes.
> 
> 
> Bug: 910016
> Change-Id: Ic9b3bbdba14218bb1ad8fd4f2ca8cf47cd4e3a37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041380
> Commit-Queue: Alan Cutter <alancutter@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Dominick Ng <dominickn@chromium.org>
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Reviewed-by: Glen Robertson <glenrob@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742515}

TBR=alancutter@chromium.org,estade@chromium.org,pbos@chromium.org,dominickn@chromium.org,glenrob@chromium.org

Change-Id: Ibb71d71f13f3fea753b5cb80a4a98c733a093c12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 910016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063015Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742557}

This change modifies chrome.passwordsPrivate.requestPlaintextPassword
to take an extra PlaintextReason parameter. This parameter will be used
for logging, as well as performing different actions, such as copying
the password to the clipboard in the browser process.

Furthermore, it modifies the existing implementation to use
chrome.runtime.lastError to signal errors and renames a few methods
for consistency.

Bug: 1047726
Change-Id: I962081a22f0947e64523289ca4e4933fa02b0137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050489
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742556}

This CL injects dependencies into ChromeSSLHostStateDelegate directly
rather than getting these dependencies internally from the Profile. The
motivation is to componentize this class for sharing with WebLayer,
replacing WebLayer's custom implementation of
content::SSLHostStateDelegate.

Bug: 1030692
Change-Id: I6ecd95e76ffa01a57a3f3a9fcb8fb827ac960364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060669Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742555}

Some observers call their regular shutdown methods from ContextDisposed(), and they end up calling RemoveObserver while HeapObserverList is being iterated over.
To support this natively this CL adds removal while iteration support by sacrificing stable iteration order.

Bug: 1052319
Change-Id: I83ece3b5596550b9016c911e433f6f9e1a5fdc34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060348Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742554}

This flag already exists and is used for this purpose on Android and
Desktop. This adds the flag to iOS.

Bug: 1048193
Change-Id: Ia50dbcc3994cc74592f821a3fbc6c3f74ff785a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056776Reviewed-by: Ender <ender@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#742553}

This reverts commit 9be2d95a.

Reason for revert: Does not fix the issue. The actual timeout detection should be elsewhere.

Original change's description:
> [getUserMedia] Introduce timeout for video format queries.
> 
> This CL causes getUserMedia() to fail if requesting video formats
> exceeds a timeout.
> This is suspect of causing getUserMedia() hangs in some environments
> such as virtual machines.
> 
> Drive-by: Add some comments, a thread check, and some extra WebRTC
> logging.
> 
> Bug: 1044974
> Change-Id: I87f7687c491b4a502f4dba57d2c57bc53cb81390
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015249
> Reviewed-by: Armando Miraglia <armax@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#734493}

TBR=guidou@chromium.org,armax@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1044974
Change-Id: I21c0ba8ab734b2e4b132f7f6409631e81660d375
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062969Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742552}

This reverts commit a4abe593.

Reason for revert: [sheriff]:
Consistent failures on linux-chromeos-chrome:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome
First failed run:
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3306

Original change's description:
> Reland "Enable passive mixed content warning by default"
> 
> This reverts commit 562af1be.
> 
> Reason for revert: Failing test was disabled since it should run with autoupgrades disabled, will investigate and fix why InitAndDisableFeatures is not doing that separately
> 
> Original change's description:
> > Revert "Enable passive mixed content warning by default"
> >
> > This reverts commit 0a37869a.
> >
> > Reason for revert: Causing failure of DidChangeVisibleSecurityStateTestWithAutoupgradesDisabled.DidChangeVisibleSecurityStateObserver in browser_tests on linux-chromeos-chrome
> > Example failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/3194
> >
> > Original change's description:
> > > Enable passive mixed content warning by default
> > >
> > > Sets the feature to enabled by default and removes the config from
> > > fieldtrial_testing_config.json in preparation for launch.
> > >
> > > Bug: 1025276
> > > Change-Id: Iffcdd2153491de25b7038a609776255bbdacf2ac
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053024
> > > Commit-Queue: Carlos IL <carlosil@chromium.org>
> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > > Reviewed-by: Emily Stark <estark@chromium.org>
> > > Auto-Submit: Carlos IL <carlosil@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#741506}
> >
> > TBR=rkaplow@chromium.org,estark@chromium.org,carlosil@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 1025276
> > Change-Id: I20e9dc38d83036c7b17d91de24c23ebae3049de9
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058970
> > Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> > Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#741860}
> 
> TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1025276
> Change-Id: I9e2043fc150b9225bc32537b0cee669f1836802a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062671
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742366}

TBR=rkaplow@chromium.org,estark@chromium.org,bsep@chromium.org,carlosil@chromium.org

Change-Id: I554708d53c87488e8f199c52b32dd2d62471bb1d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1025276
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062416Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742551}

This reverts commit 653f075d.

Reason for revert: Consistent failures on Linux:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests
The first failure:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/87279

Original change's description:
> Clear the subresource redirect hints when navigation is started
> 
> RenderFrames could be reused for same-origin navigations. This causes
> the hints from previous navigations to be used in next navigation
> until the new hints fetch finishes and updates the hints. This CL clears
> the hints.
> 
> Unfortunately this causes race conditions between the image fetch and
> the hints update, which causes images to not redirected to compressed
> versions. So the image fetches are delayed a bit to circumvent this.
> 
> Bug: 1051283
> Change-Id: Ie9e5351e68c0081ab9dbfe23faed2c3c5e8e4d42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056207
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Michael Crouse <mcrouse@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742326}

TBR=tbansal@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org

Change-Id: I74441c0600ab5fe5de3016c813590a5d3d21e447
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1051283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063170Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742550}

This reverts commit e490a00a.

Reason for revert: Sheriff here:
Consistent failure of Linux MSan Tests:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests
First failed run:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/22357

Original change's description:
> Reland "Make PWA titlebar and icons flex and animate properly."
> 
> This reverts commit de7cd485.
> 
> Reason for revert: Fixing issue with Mac tests.
> 
> Original change's description:
> > Revert "Make PWA titlebar and icons flex and animate properly."
> > 
> > This reverts commit 8f2f4243.
> > 
> > Reason for revert: speculative revert for test failures on Mac
> > for WebAppFrameToolbarBrowserTest.SpaceConstrained, see e.g.
> > https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/31700
> > 
> > Original change's description:
> > > Make PWA titlebar and icons flex and animate properly.
> > > 
> > > Nested layouts now allocate available space properly to their
> > > descendents. Also, we consistently use flex layout in the PWA titlebar.
> > > 
> > > Removed a couple of invalid assumptions that were encoded as DCHECKs.
> > > 
> > > There are still some inkdrop issues but they are purely cosmetic, see
> > > crbug.com/1006162 for more detail.
> > > 
> > > Bug: 1048061
> > > Change-Id: I403b71b5e2bbcb2d461e1ed6c543c76f91d4c652
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036264
> > > Commit-Queue: Dana Fried <dfried@chromium.org>
> > > Reviewed-by: Peter Boström <pbos@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#738874}
> > 
> > TBR=pbos@chromium.org,dfried@chromium.org
> > 
> > Change-Id: I731bad118043652a6dbd082c6099ebbd0c697835
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 1048061
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041615
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#738907}
> 
> TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org
> 
> Change-Id: Idb9712d1ffe45bf374af846278e26d61983a44f0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1048061
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042326
> Reviewed-by: Dana Fried <dfried@chromium.org>
> Commit-Queue: Dana Fried <dfried@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742203}

TBR=pbos@chromium.org,mastiz@chromium.org,dfried@chromium.org

Change-Id: If65099915ea0efa01de8cc9b0df0a7e9bf03a60b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1048061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062996Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742549}

Bug: 1046181
Change-Id: I371ad290e454e55c0f8133b4397b26a9b902e3f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024176
Auto-Submit: bttk <bttk@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#742548}

This is a follow-up CL of https://crrev.com/c.2043181, and remove
IconType by directly using mojom::blink::FaviconIconType in Blink.

Bug: 1040099
Change-Id: If2d589ca5579f5fbba45f13e4fb9cda450ccf121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053908
Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742547}

The methods to check and set the visual overflow recalc flags
were both doing similar checks, so we were duplicating those calls.
In this change we somehow inline the code of that methods
so we avoid repeating those operations.

This is intended to improve performance in
perf_tests/shadow_dom/v1-small-deep-distribution.html.

BUG=1051342,941180

Change-Id: Ica18dd6d07b9f8bca9c35c9db438fbc09bb4a53c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062430
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742546}

Bug: 996785
Change-Id: Icfce332a4cc763bdabed6a235224a6cea014c203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015040Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742545}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/333b29e11603..53bc9c82f33f


Created with:
  gclient setdep -r src-internal@53bc9c82f33f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: Ic040b66cffb1b667df8dd46c12f7147619df3c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063817Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742544}

Using wpt-import in Chromium 4af84fff.
With Chromium commits locally applied on WPT:
ec83d167 "Update performance.measureMemory to the latest proposal"
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hbos@chromium.org, hta@chromium.org:
  external/wpt/webrtc
meade@chromium.org:
  external/wpt/web-animations

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: I96fef74d2fd31792ad7a61a6d2917d69654a284c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063451Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742543}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/77fefe765c06..79f8caf9154a

git log 77fefe765c06..79f8caf9154a --date=short --first-parent --format='%ad %ae %s'
2020-02-18 bclayton@google.com vscode: Add missing fields to schema.Opcode (#3169)
2020-02-18 siglesias@igalia.com spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186)

Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@79f8caf9154a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64
Bug: None
Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com
Change-Id: I93668639b207123df68ca91e88586e7db4eee031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064055Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#742542}

fragmentation/auto-overflow.html now starts to fail, but that test is
invalid, so removing it. A block with overflow:auto is potentially
scrollable, and treating it as monolithic therefore makes sense. All
other browsers do this as well. Note that we did actually "always" treat
it as monolithic, as far as LayoutBox::GetPaginationBreakability() was
concerned, but since our legacy engine doesn't really understand
fragmentation, we ended up slicing it, making the test pass. LayoutNG
will now let such tall objects overflow the column instead, which
wouldn't match the expectation.

Bug: 829028
Change-Id: Id2ca5488049ef8e768a363e4dbe8767c7bc4d645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062351Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742541}

Deprecate the policy schema SCHEMA_ALLOW_INVALID since it only has a different value from SCHEMA_ALLOW_UNKNOWN on Mac OS and Android and in a low percentage of its use cases.

Bug: 969706
Change-Id: Ie5251e1ceaa6a4bc8472e6bb1477b7a6de45fc2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018946
Commit-Queue: Anina Koehler <aninak@google.com>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742540}

Bug: 1053171
Change-Id: I197a7fda2e2f2521fe2cafc556749bf4fd1a424c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751786Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#742539}