- 03 Jan, 2018 40 commits
-
-
Jaebaek Seo authored
Enabling --use-zoom-for-dsf needs a conversions between integer values and float values for Android WebView contents size (See AwContents::OnWebLayoutContentsSizeChanged()). The previous code adopted ceiling for those conversions, which resulted in test failures of AndroidViewIntegrationTest. This CL adopts rounding for those conversions instead. Bug: 737777 Change-Id: I8b22981c0d94ff983e4d8d4254b0c4155892d5d8 Reviewed-on: https://chromium-review.googlesource.com/832326Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Cr-Commit-Position: refs/heads/master@{#526625}
-
Pavel Feldman authored
We added logic to block cross-site documents from renderer processes when Site Isolation modes are enabled. This helps prevent sensitive information from leaking to a process that doesn't need access to it. It would be helpful to web developers to have a console message when a blocking event occurs explaining what happened and why. Bug: 793937 Change-Id: Ia6e4b8095a925b8580a044421021810565ea66d8 Reviewed-on: https://chromium-review.googlesource.com/833218 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526624}
-
Jennifer Apacible authored
This adds a button in the media controls for the picture in picture feature. This is currently behind a flag and currently doesn't do anything. Bug: 726619 Change-Id: I2cb3151769016ff4e5c26fb6eb2319bdeab2fcae Reviewed-on: https://chromium-review.googlesource.com/832949 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526623}
-
Pramod B S authored
Required [Exposed] to get rid of [PrimaryGlobal] Spec: https://github.com/heycam/webidl/issues/365 Bug: 792432 Change-Id: I4ed66ed7116eaf4ded7d07d991c81c01e827ca1c Reviewed-on: https://chromium-review.googlesource.com/847393Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#526622}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/57c2b8b16ab9..ecdadd98e0ae $ git log 57c2b8b16..ecdadd98e --date=short --no-merges --format='%ad %ae %s' 2018-01-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ c8c9a24a1..910a3dafd (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ia6791719a0a64297bc2816f1474647320def1808 Reviewed-on: https://chromium-review.googlesource.com/848325Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526621}
-
Tarun Bansal authored
Also increase the network quality store size from 10 to 20 to match the maximum prefs size. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Bug: 798568 Change-Id: I5c0957adbd201e3ef52102032ec5c0f207132367 Reviewed-on: https://chromium-review.googlesource.com/846252 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526620}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/94dc17710fd7..fa2260d08dcf $ git log 94dc17710..fa2260d08 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,b/69623057 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id152074370c9b206ea55eab4ed889fa124df69ad Reviewed-on: https://chromium-review.googlesource.com/848235Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#526619}
-
Qiang Xu authored
changes: Implement WindowState::OnWindowAddedToRootWindow to handle MoveAllTransientChildrenToNewRoot. Bug: 789249, 778438 Test: emulator tests and added test coverage Change-Id: I9c4633902aaaca9da094c6398a4957f680a430df Reviewed-on: https://chromium-review.googlesource.com/804918 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#526618}
-
danakj authored
The IOSurface textures for RenderPasses do this, citing bug 146070. We can do the same for the RenderPass textures. This affects any pixel tests that have anti-aliasing, as the float value of texcoords is changed. So we have to add anti-aliased versions of a few pixel tests, and rebase a number. R=ccameron@chromium.org Bug: 146070 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I41628534048b526afb2ac02378d71c329cc02344 Reviewed-on: https://chromium-review.googlesource.com/841284 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#526617}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: If609357050a82bcc3f8e1e8dda3595b35c93c0e4 Reviewed-on: https://chromium-review.googlesource.com/848073Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#526616}
-
Eric Lawrence authored
The security interstitial bypass keyword hasn't changed in two years and awareness of the bypass has been increased in blogs and social media. Rotate the keyword to help prevent misuse. Change-Id: Id3250926afbc98241e9390420ccb68765e618ce6 Bug: 797344 Reviewed-on: https://chromium-review.googlesource.com/843085 Commit-Queue: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#526615}
-
Yafei Duan authored
This CL is depending on the CL of switching OfflinePageModel, and trying to address the issue of perf regression and increased crash rate during CreateArchiveTask. After code review, this CL will merge with 845261 as reland of 833495. This CL contains: - Removing CreateArchiveTask and moving all its logic into OPMTaskified. - Changed when ClearCachedPages is called in OPMTaskified, to make it exactly same with OPMImpl to see if this will fix perf regression. If not, it might be the issue of database closing. Bug: 797628, 797423 Change-Id: Ib810d48637802c82713dfc506d05a14b69110170 Reviewed-on: https://chromium-review.googlesource.com/847684 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#526614}
-
chrome://flagsLeo Zhang authored
Bug: 727436 Change-Id: I2ca1864627998febcae1cbd68c5a4308481fd5ad Reviewed-on: https://chromium-review.googlesource.com/838800Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#526613}
-
David Bokan authored
When an element is position: fixed to the bottom of the screen, hiding the URL bar produces a transform in the compositor so that the Element appears to stay fixed to the viewport bottom. This is because, as the URL bar is hidden, the viewport height is expanded. However, this expansion happens entirely in the compositor. Until the user releases their finger, Blink will not get a resize so the Element won't get be repositioned with the updated viewport height. With root-layer-scrolling, the root scroller becomes the root PaintLayer. We previously carved out exceptions for the root layer since its scrolling was delegated to special "frame scrolling" layers in the compositor. This patch removes these exceptions and marks the LayoutView's scrolling layer as being a "position fixed container" so that position: fixed Elements use it as their container. It also marks this layer as being affected by URL bar resizes so that we apply the above-mentioned URl bar transform. Bug: 798434 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I69623c619471ced826aa61340d946a0eeb0110ae Reviewed-on: https://chromium-review.googlesource.com/847458Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526612}
-
Ryan Landay authored
We currently don't allow grapheme clusters to be split after Indic virama characters (this seems to be a custom deviation from the grapheme cluster rules in UAX #29). According to a Googler familiar with Indic languages, this behavior is correct for other Indic languages, but not for Tamil ("Tamil is an exception because it doesn't compound glyphs to form a single glyph when combining a pure consonant with a vowel+consonant combo.") This is causing at least two problems: 1. It's not possible to put the insertion point between certain pairs of Tamil characters when typing (crbug.com/693687). 2. Inputting Tamil with phonetic keyboard IMEs is super broken (crbug.com/675477). This CL fixes both of these problems by treating the Tamil virama character differently from other Indic viramas. Note: this does *not* address the issue in crbug.com/792713 where the Tamil handwriting IME on Android inserting lone SpacingMark characters triggers odd behavior. Bug: 675477, 693687 Change-Id: Iae95e70418aeadcbab5296245ad7253cf3c31cde Reviewed-on: https://chromium-review.googlesource.com/843461Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#526611}
-
Will Chen authored
This test is quite flaky because it was unintentionally dumping an internal object property that's unstable between runs instead of the actual object contents. Drive-by: removes extraneous method definition for ApplicationTestRunner.addIDBValueAsync Bug: none Change-Id: I749bb2d1379aa0658e590caeb9cd6d6773c59021 Reviewed-on: https://chromium-review.googlesource.com/846253Reviewed-by:
Eugene Ostroukhov <eostroukhov@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#526610}
-
Jonathan authored
Updating the filter file for new failures that have been found. TBR=kylechar@chromium.org Bug: 794961 Change-Id: Idd96cb7029e2c16038cb3e1d43dd3a4f2573c244 Reviewed-on: https://chromium-review.googlesource.com/847422Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#526609}
-
Matt Reynolds authored
Haptics on Dualshock4 devices are typically not supported by OS-level haptics APIs, so in order to support vibration effects on these devices we issue device-specific reports using the raw HID protocol. Dualshock4ControllerBase implements the common logic for creating the report buffer from the vibration intensity values. Users should implement WriteOutputReport to provide the OS-specific logic for sending the report to the device. BUG=749295 Change-Id: I742316f385235b44c0658dd9e571fa73cf4f496e Reviewed-on: https://chromium-review.googlesource.com/810053 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#526608}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/bd319d25b886..7365f0261183 $ git log bd319d25b..7365f0261 --date=short --no-merges --format='%ad %ae %s' 2018-01-02 dtu [pinpoint] Add subdirectories for job-page and jobs-page elements. 2017-12-22 dtu [pinpoint] Shorten pinpoint element paths. 2017-12-27 erikchen Add explicit --is-local-build flag. 2018-01-02 mheikal Catapult: Manifest parsing now works with xml namespaces stripped 2018-01-02 eakuefner [TBMv2] Smoke test diagnostic equality in JS 2018-01-02 bokan Remove gesturesExpectedInViewportCoordinates branches 2018-01-02 eakuefner Stop merging by tags in add_reserved_diagnostics 2018-01-02 perezju [Telemetry] Fix binding to devtools agent on CrOS after login Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie1097cf9cdf898208274b57bf1d998e4369bef43 Reviewed-on: https://chromium-review.googlesource.com/848023 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#526607}
-
Vladimir Levin authored
This patch removes at raster decode flag, which is only used in tests. R=enne@chromium.org, chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1f8f81856c12c8f521a6e57268d35430dc3135c7 Reviewed-on: https://chromium-review.googlesource.com/848302Reviewed-by:
enne <enne@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#526606}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/e8bb6da08dc6..57c2b8b16ab9 $ git log e8bb6da08..57c2b8b16 --date=short --no-merges --format='%ad %ae %s' 2017-12-31 reed remove unused declarations Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I747c70ab678ea9e324c1b794d44d9a71140a6f25 Reviewed-on: https://chromium-review.googlesource.com/848310Reviewed-by:
-
Jonathan authored
The gn_isolate_map to telemetry_perf_unittestes_viz doesn't work as there is no associated build target. Providing an executable override doesn't seem to resolve this. I'm removing the config to get the Linux Viz bot back up and running until the error can be sorted out. TBR=dpranke@chromium.org Bug: 795760 Change-Id: I28dd3bc515aaa16bae59258ba0b1bb0b42ac4676 Reviewed-on: https://chromium-review.googlesource.com/846231Reviewed-by:
-
Jiaquan He authored
Bug: 733662 Change-Id: I218c5eb20ea029303d53b269197afe61c65353c7 Reviewed-on: https://chromium-review.googlesource.com/845879Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Toni Barzic authored
Makes chromeos::ExternalCache an interface, and introduces a test external cache implementation. The test implementation is currently not used, but the plan is to eventually inject it into KioskAppManager in unittests where needed (immediate plan is to use it in unittests for chromeos::StartupAppLauncher). BUG=686901 Change-Id: I711221e57358c535f3bc34750a5c59521b805be6 Reviewed-on: https://chromium-review.googlesource.com/845059 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
-
Eric Karl authored
This reverts commit 74522773. Reason for revert: Have fixes for the original issues. Will land those after un-reverting. Original change's description: > Revert "Remove use of DeferredTextureImageData APIs and Support Decode to Scale" > > This reverts commit 86c790e6. > > Reason for revert: This is causing performance / memory regressions that are trickier to address than expected. Reverting this for now. > > Original change's description: > > Remove use of DeferredTextureImageData APIs and Support Decode to Scale > > > > We aren't benefitting from the complexity added by the > > DeferredTextureImageData APIs, and this API blocks us from using > > PaintImage::Decode's decode-to-scale functionality. > > > > This change removes our usage of DeferredTextureImageData APIs, > > instead using SkImage::makeTextureImage to handle upload. Additionally, > > we now use the PaintImage::Decode API, adding decode-to-scale support. > > > > Bug: 773799 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: Ia5f480213c3a5c8225ccd289aa2c081056840f94 > > Reviewed-on: https://chromium-review.googlesource.com/713593 > > Reviewed-by: vmpstr <vmpstr@chromium.org> > > Commit-Queue: Eric Karl <ericrk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#517206} > > TBR=vmpstr@chromium.org,ericrk@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 773799 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: Ie4493559e334100f03dfed1dfb7a408fc26a33e0 > Reviewed-on: https://chromium-review.googlesource.com/830587 > Commit-Queue: Eric Karl <ericrk@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524613} TBR=vmpstr@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773799 Change-Id: Ic4492707672b8652bd3b102d3918399afb5321b4 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/847030 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526601}
-
liberato@chromium.org authored
Remove the build-time flag for MCVD, and replace it with a runtime flag media::kMojoVideoDecoder. When enabled, chrome will consider using MojoVideoDecoder but not GpuVideoDecoder. Regardless of the flag, WebRTC can still use the VDAs directly. that the correct decoder was used. Bug: 765542 Test: Manually set feature, tried WebRTC and H264 playback. Verified Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ibf4fe584507f7d426a75c53e8fd07033f6c4900e Reviewed-on: https://chromium-review.googlesource.com/786148 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#526600}
-
Ted Choc authored
This moves the existing iOS histogram/enum to a shared component and logs the same information in Android. BUG=790783 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id9a9391834d55581f498493a7bcfacb7e0416a94 Reviewed-on: https://chromium-review.googlesource.com/818469 Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#526599}
-
Dave Schuyler authored
This Cl converts the internal page to display power usage information from the old i18n-content to the new $i18n{} localization. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7983c7d01d993b81cf2dd4111712425f63db7ca5 Reviewed-on: https://chromium-review.googlesource.com/846424Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#526598}
-
erikchen authored
A uint32_t was being multiplied by 1024, and then implicitly cast to uint64_t. Instead, first explicitly cast to uint64_t, then multiply by 1024. Bug: 798234 Change-Id: I93188aca5b1169eeed2e91ef68f9d1a007a6e48b Reviewed-on: https://chromium-review.googlesource.com/848233Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526597}
-
Leo Zhang authored
This CL removes legacy translate infobar code which includes: * Old UI entry on Android and its sub panels * Native for the old Android UI * Tests for the old UI Bug: 727436 Change-Id: I9e98fcc763c110ea07832abbfa06a7a9dbd7a200 Reviewed-on: https://chromium-review.googlesource.com/838760 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Ted Choc (back but slow, ping me) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#526596}
-
Sergey Ulanov authored
With this CL it's possible to build webkit_layout_tests target for Fuchsia. The tests don't run yet. Bug: 778467 Change-Id: Ib869f6f98c52d99f069f9aa431c0c1cafcc7a1d1 Reviewed-on: https://chromium-review.googlesource.com/843013 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#526595}
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:432444 Change-Id: I4e703013cc1c0ddb243bf18e95eda199da618859 Reviewed-on: https://chromium-review.googlesource.com/847673Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#526594}
-
Shimi Zhang authored
This cl introduces SelectionInsertionHandleObserver interface which deals with following events in SelectionPopupController#onSelectionEvent(): SELECTION_HANDLES_MOVED SELECTION_HANDLE_DRAG_STARTED SELECTION_HANDLE_DRAG_STOPPED INSERTION_HANDLE_MOVED INSERTION_HANDLE_DRAG_STARTED INSERTION_HANDLE_DRAG_STOPPED Bug: 798017 Change-Id: Iff08d5cb0a32528523b0fcc606c9c617e6c4fb48 Reviewed-on: https://chromium-review.googlesource.com/846339 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
Max Moroz authored
-fsanitize=fuzzer and -fsanitize=fuzzer-no-link are two compilation flags that enable coverage instrumentation needed for libFuzzer. The instrumentation has more stuff under the hood compared to -fsanitize=trace-pc-guard. Also, it can be changing over time without a need to update GN flags again and again (e.g. move from edge to trace-pc-guard or something like that). Bug: 764514 Change-Id: I53bf5a3355335f4f627e9024b7ed7fe601c9ecfd > Revert "Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true." > > This reverts commit c1406d52. > > Reason for revert: The builds are failing on linking of some fuzzers: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FLibfuzzer_Upload_Linux_ASan%2F7088%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout > > Original change's description: > > Migrate to -fsanitize=fuzzer-no-link when use_fuzzing_engine=true. > > > > -fsanitize=fuzzer and -fsanitize=fuzzer-no-link are two compilation > > flags that enable coverage instrumentation needed for libFuzzer. > > > > The instrumentation has more stuff under the hood compared to > > -fsanitize=trace-pc-guard. Also, it can be changing over time > > without a need to update GN flags again and again (e.g. move from > > edge to trace-pc-guard or something like that). > > > > Bug: 764514 > > Change-Id: I48ef328dee49a9620a1b44bd5cd920f116e1bc1b > > Reviewed-on: https://chromium-review.googlesource.com/802395 > > Commit-Queue: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Oliver Chang <ochang@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#522505} Change-Id: I53bf5a3355335f4f627e9024b7ed7fe601c9ecfd Reviewed-on: https://chromium-review.googlesource.com/846100Reviewed-by:
-
Yuzhu Shen authored
The purpose is to avoid shadowed variable warnings, because some mojom definitions use "buffer" as field names. Bug: None Change-Id: I32b1905d6639c22b10f8979050525e8a06f728de Reviewed-on: https://chromium-review.googlesource.com/847634Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526591}
-
chrome://creditsDavid Benjamin authored
- "BoringSSL" rather than "boringssl" is probably a more suitable stylization for that page. - Sorting uppercase letters above lowercase ones is a little confusing. A case-insensitive sort is a bit more natural. - libaddressinput's name is more a description and kind of odd to show in chrome://credits. Have it appear as libaddressinput instead. Note this does make it more obvious that we have both "BSDiff" and "bsdiff" and "icu" and "ICU", which is a little odd, but reflects the number of copies of them we have. bsdiff, in particular, has a couple of different evolutions. Bug: none Change-Id: I882c924bfe765a27844a007db80653172ed03800 Reviewed-on: https://chromium-review.googlesource.com/842952Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#526590}
-
Sasha Bermeister authored
Remove WebStorageQuotaType and replace users with StorageType in WebKit/common. This is pre-work to change all users of StorageType to use the mojo enum instead. This patch also renames StorageType in StorageArea to StorageArea::StorageType, to prevent name conflicts. There is also a small change in DeprecatedStorageQuota.cpp which was relying on a static cast to WebStorageQuotaType. Bug: 781643 Change-Id: I8f8a4cafa1faf35a8d09dbcafd697af1ffe251d5 Reviewed-on: https://chromium-review.googlesource.com/828640 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#526589}
-
Erik Chen authored
This reverts commit e4d9e6a3. Reason for revert: This CL causes an infinite loop for some users. https://bugs.chromium.org/p/chromium/issues/detail?id=798234#c9 Original change's description: > Expire redirect parents when expiring any history visit. > > This CL fixes an issue with history deletion where Visits that were > the end of redirect chains were not deleting their redirect parents. > In effect, removing a single history entry from chrome://history was > not removing all Visits associated with it, causing similar URLs to > continue to show up in the omnibox autocomplete. > > Bug: 786878 > Change-Id: Id207dd7810629458d19a847d3ff52c0e562f2ce6 > Reviewed-on: https://chromium-review.googlesource.com/795527 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525589} TBR=calamity@chromium.org,brettw@chromium.org,sdefresne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 786878 Change-Id: I5b10eef437b09b8e61c8ca5d025e9b15e1226935 Reviewed-on: https://chromium-review.googlesource.com/848052Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#526588}
-
Nate Chapin authored
When a cache hit occurs for a Resource that supports async cache hits, Resource::AddClient schedules a task to process the cache hit on the process-wide loading task runner, rather than a per-frame loading task runner. This is because a Resource that is fully loaded has no context to determine which frame it should attribute itself to. Having callers provide a WebTaskRunner* to AddClient allows the caller to handle that attribution. Bug: 624696 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic6d00e725cdd9141f83dcb5f8bcd34af3c5ac27d Reviewed-on: https://chromium-review.googlesource.com/723879 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#526587}
-
Fadi Meawad authored
This reverts commit e442ea06. Reason for revert: This CL caused major regressions in android webview performance. See https://crbug.com/798310 Original change's description: > Reland "[PageLifecyle] Move the launch process state to Webkit/common" > > This is a reland of 99a51fca > > The failures described in crbug.com/796940 was result of throttling > the scheduled tasks as a result of the new backgrounding state. > > The fix foregrounds the RendererScheduler before running the tests > to avoid throttling. > > Original change's description: > > [PageLifecyle] Move the launch process state to Webkit/common > > > > This CL introduces Webkit/common/page/launching_process_state.h that > > includes the launch background and launch boosted state. > > > > The reason this file is needed, is because the state is different per > > OS but needs to be consistent between the RenderProcessHostImpl and > > the RendererSchedulerImpl. To prevent future changes in one not > > reflecting in the other, the code is moved to a common place and > > shared. > > > > This CL fixes an issue where the scheduler assumes that it is > > foregrounded while it is actually backgrounded during the initial > > phase on Android. > > > > Bug: chromium:780191 > > Change-Id: Ib8dbfb6447f58c8b998a94ae2c69f8bc906d150f > > Reviewed-on: https://chromium-review.googlesource.com/815678 > > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#525563} > > TBR=haraken@chromium.org,boliu@chromium.org > > Bug: chromium:780191,chromium:796940 > Change-Id: I117afad3b910239656dbc7e9dc3a1447291263a9 > Reviewed-on: https://chromium-review.googlesource.com/840340 > Reviewed-by: Fadi Meawad <fmeawad@chromium.org> > Commit-Queue: Fadi Meawad <fmeawad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525841} TBR=boliu@chromium.org,fmeawad@chromium.org,haraken@chromium.org,oysteine@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:780191, chromium:796940, chromium:798310 Change-Id: I0c8b7e075c29761d2a6f0d02461551b651682748 Reviewed-on: https://chromium-review.googlesource.com/847653Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
-
