- 21 Aug, 2018 40 commits
-
-
Matt Wolenetz authored
With intent-to-ship approved [1], this change undoes the ephemeral origin trial integration previously landed in r581041 and ships SourceBuffer.changeType() (so that its use no longer requires an experimental flag.) This change retains the UseCounter for this new MSE API method that was added in r581041. [1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/K_OFPxA_whE/discussion BUG=605134 Change-Id: Ie10f8ef71513998dc8672786bc8fea12bb0ad150 Reviewed-on: https://chromium-review.googlesource.com/1182292Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584848}
-
Min Qin authored
As we are planning to allow NetworkService creation before g_browser_process creation, CreateDefaultNetworkContextParams() shouldn't be using g_browser_process in it. Since SystemNetworkContextManager will ultimately become a singleton and can be created without g_browser_process, this CL moves CreateDefaultNetworkContextParams() into SystemNetworkContextManager. Classes can use g_browser_process->system_network_context_manager() to access SystemNetworkContextManager for now. Later they could use SystemNetworkContextManager::GetInstance() once https://chromium-review.googlesource.com/c/chromium/src/+/1171798 lands. BUG=866028 Change-Id: I7047682e349a47e9249fece11fc977978ed001b1 Reviewed-on: https://chromium-review.googlesource.com/1180172Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584847}
-
Steven Bennetts authored
Bug: 843332 Change-Id: Iff950164803f31d013a8a80fdded73f1e7f3bd7e Reviewed-on: https://chromium-review.googlesource.com/1182411 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584846}
-
Matthew Cary authored
Extend seccomp_bpf to allow MADV_RANDOM and MADV_NORMAL for the madvise() syscall. These are used to control code page memory footprint, particularly on android. Bug: 758566 Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I9d87af4453d19a1391053ffc56f1eab85a2ad231 Reviewed-on: https://chromium-review.googlesource.com/1150176 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584845}
-
Sergio Villar Senin authored
It's currently using URLFetcher. It should use SimpleURLLoader instead to make it eventually work with the network service. Bug: 872880 Change-Id: Id192f3aee248334e3a40075b0adb190a799eef60 Reviewed-on: https://chromium-review.googlesource.com/1183229Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Jun Mukai authored
Some properties are used to share the status between ash and TabDragController; they are synchronized by crrev.com/584167, but actually it isn't enough. Since ash expects these properties are set on windows backed by Widget -- which is corresponded with the root window in browser, TabDragController needs to set, clear, and get the properties on root-window too instead of the widget. Bug: 867074 Test: manually Change-Id: I501db87283c66a6d5c80f92aa4b333d93d0ae415 Reviewed-on: https://chromium-review.googlesource.com/1182409Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584843}
-
sczs authored
Previously we would only reload the Promo Cell when the identity changed. The problem is that the image takes longer to load, and when it does it triggers a configureSigninPromoWithConfigurator call. Since the identity didn't change the cell wasn't being reloaded and the Image wasn't updated. Bug: 868124 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib3bf5742cecd10119c15983438a8361ebe16f683 Reviewed-on: https://chromium-review.googlesource.com/1179320Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#584842}
-
Lukasz Anforowicz authored
Addresses can be reused and therefore pointers shouldn't be used as container keys (unless the code maintaining the container can guarantee that the old entry will be destroyed before the pointer gets freed). In particular, using |RenderFrameHost*| as a key of BlinkTestController's layout_test_control_map_ was incorrect and led to timeouts described in more details in https://crbug.com/834185#c13 - #c14. This CL replaces std::map<RenderFrameHost*, ...> with std::map<std::pair<int, int>, ...> and uses (process id, frame routing id) as a key. After this CL around ~200 flaky timeouts from FlagExpectations/site-per-process seem to avoided. Before this CL, I could reliably repro a timeout in - http/tests/fetch/window/thorough/redirect-nocors-base-https-other-https.html - http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html when running it 20 iterations. After this CL, I cannot repro any timeouts when running all ~200 tests 20 times: $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests \ -t rel --no-retry --additional-driver-flag=--site-per-process \ --iterations=20 \ --exit-after-n-failures=1 --exit-after-n-crashes-or-timeouts=1 \ --additional-driver-flag=--no-sandbox \ --additional-driver-flag=--isolate-origins=http://www.web-platform.test:8001/,http://www1.web-platform.test:8001/,http://www2.web-platform.test:8001/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8001/,http://xn--lve-6lad.web-platform.test:8001/,http://www.web-platform.test:8081/,http://www1.web-platform.test:8081/,http://www2.web-platform.test:8081/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8081/,http://xn--lve-6lad.web-platform.test:8081/,https://www.web-platform.test:8444/,https://www1.web-platform.test:8444/,https://www2.web-platform.test:8444/,https://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8444/,https://xn--lve-6lad.web-platform.test:8444/ \ --test-list=$HOME/scratch/test-list ... Found 206 tests; running 206 (20 times each: --repeat-each=1 --iterations=20), skipping 0. ... All 4120 tests ran as expected. Bug: 801992, 834185, 711468, 859988 Change-Id: I9f2c1abf87027fcb3824c54e597e561ac72babb9 Reviewed-on: https://chromium-review.googlesource.com/1182316 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584841}
-
Kai Ninomiya authored
PaintCanvasVideoRenderer::CopyVideoFrameTexturesToGLTexture unnecessarily used verified sync tokens to pass textures between Skia's context and WebGL's context. Verification isn't needed because these two clients are being used synchronously from the same process and thread. Changing these sync tokens to be unverified gives us a nice speedup - on a simple mp4-to-WebGL case on Linux, the texImage2D blocking time drops from ~1.25 ms to ~0.70ms (~80% speedup). Bug: 871417 Change-Id: I38c246fdb49588eccc87211fa06a2abf00e55c5c Reviewed-on: https://chromium-review.googlesource.com/1164163Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#584840}
-
Sammie Quon authored
Instead minimize them. UX has some ideas for a nicer looking animation, but for M70 this is a good stop gap because it prevents a maximize animation starting then a minimize animation occuring halfway. Test: added test and manual Bug: 874596 Change-Id: I4a7ddfe31bb76f0d7a636c15baf4be0c04121a46 Reviewed-on: https://chromium-review.googlesource.com/1180075Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#584839}
-
Andrei Pascovici authored
Bug: internal/112284077 Change-Id: I4b61b81fa9ba5c6d97642b78504f56c1d6454738 Reviewed-on: https://chromium-review.googlesource.com/1182869 Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584838}
-
Patrick Monette authored
This is a reland of 12164db3 Original change's description: > Don't warn about modules in the same directory as Chrome > > Bug: 876096 > Change-Id: I85a7d7d5529270a829d9849a8bb638d9d02b7813 > Reviewed-on: https://chromium-review.googlesource.com/1182341 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584586} Bug: 876096 Change-Id: I426a1304af2f6b404a8872493cde32d74774c797 Reviewed-on: https://chromium-review.googlesource.com/1182923Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#584837}
-
Yusuf Ozuysal authored
This adds a non-overlapping specific animation where each card is moving directly back to its place in the stack, rather than doing the slightly curving motion that is needed for an overlapping stack. It gets rid of the final remaining issues aroudn horizontal tab switcher enter/exit animations Change-Id: I3e4ff3adbab67e7e6a970cbd5eac59f1b703a667 Bug: 846166 Reviewed-on: https://chromium-review.googlesource.com/1118751 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584836}
-
Daniel Zhang authored
Removing the completion of an autocomplete suggestion with the arrow keys until further UX input. Also updated tests and current code to reflect this. Bug: 874518 Change-Id: I2d35799b8b50e93b466c82e7fba9c5c523e9bef8 Reviewed-on: https://chromium-review.googlesource.com/1180100 Commit-Queue: Daniel Zhang <oxyflush@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#584835}
-
Christopher Grant authored
By moving the feature source into a component, we won't end up with multiple instances of the feature constants across multiple component build libraries. This should eliminate DCHECK failures that crop up when components check if features are enabled. BUG=872073 Change-Id: Ia82e990596d52076027499fe23b73c870c64b5e1 Reviewed-on: https://chromium-review.googlesource.com/1177895 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584834}
-
Yue Li authored
Bug: b/112564431, b/78190629 Test: Manual Test Change-Id: Ie046c8ab05918d4aabaa931a59a4fcdf0270e4f4 Reviewed-on: https://chromium-review.googlesource.com/1176377 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584833}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic1fec8f6ba567046893d8cc766d29fadba397e02 Reviewed-on: https://chromium-review.googlesource.com/1183697Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584832}
-
David Black authored
We have dependencies on TabletModeController and need to be destroyed before it. Previously we assumed that the view hierarchy would be destroyed before our Assistant controllers. This will not actually be the case since I am moving our reset above destruction of the view hierarchy. As such, we now destroy our view hierarchy at the beginning of our controller destruction sequence. Also fixes some outdated comments. Bug: b:112781572 Change-Id: Iecdce642790c0c8278d489734ea735370e98912c Reviewed-on: https://chromium-review.googlesource.com/1180656 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Weidong Guo authored
Changes: Renable the flag after bug 874619 is fixed. Bug: 871448 Change-Id: I967e82ac1f34fd204dd561010cda5bd19d371cec Reviewed-on: https://chromium-review.googlesource.com/1182671Reviewed-by:
-
Sammie Quon authored
I dont think this fixes the bug, but its nice to have the correct information. Test: manual Bug: 863304 Change-Id: I60198f34e624ef2faae9734faee17441d44d002f Reviewed-on: https://chromium-review.googlesource.com/1182521 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I47903e2b2ce025d809025c57cd6ed85441c46a73 Reviewed-on: https://chromium-review.googlesource.com/1183668 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#584828}
-
Sahel Sharify authored
the scrollbars are attached to the visual viewport but created by (and have space saved by) the frame view. So we need to exclude them from the container rect but also from the contents rect because we don't want to be able to scroll into the region saved for scrollbars. Bug: 855074 Test: All/PaintPropertyTreeUpdateTest.ViewportContentsAndContainerRectsDoNotIncludeScrollbar/* Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4ea231f1a656f35094a2c388076bc2fdd61086da Reviewed-on: https://chromium-review.googlesource.com/1183526 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#584827}
-
Mugdha Lakhani authored
Implement these on BackgroundFetchRegistration, which is, in turn, exposed on all Background Fetch events surfaced to the developers. Bug: 863016 Change-Id: If6406b800b595df285d7304652948063c80ac45b Reviewed-on: https://chromium-review.googlesource.com/1177394 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#584826}
-
Weidong Guo authored
The fix in http://go/cgcl/1171905 causes the folder being clipped in lower resolution. So we should still fit the folder inside AppsContainerView, in the meanwhile, fit the folder under search box. Bug: 875780 Change-Id: I147a10ebc1b10a770a23478d5fd22b084ce1d1dd Reviewed-on: https://chromium-review.googlesource.com/1182620Reviewed-by:
-
Sergio Villar Senin authored
It was using URLFetcher. In order to make it eventually work with the future network service we need to transition it to SimpleURLLoader API. The tests was extensively using the URLFetcher* naming so I decided to replace them all by references to SimpleURLLoader instead. Bug: 844918 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I9f0412bcc4b5731a50e691602fa93d5ef06fba8e Reviewed-on: https://chromium-review.googlesource.com/1177385Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#584824}
-
Kevin McNee authored
We update the lists of webview API functions used in tests to match WEB_VIEW_API_METHODS. Also, we introduce testCustomElementCallbacksInaccessible to test that the custom elements lifecycle callbacks cannot be called from user code. Bug: None Change-Id: If3d2e20fe7d2aa69455628a69d6d4fec30851be2 Reviewed-on: https://chromium-review.googlesource.com/1181508Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#584823}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b2ea4d435aae..465d65ba9903 git log b2ea4d435aae..465d65ba9903 --date=short --no-merges --format='%ad %ae %s' 2018-08-21 primiano@google.com Merge "Docs: add Trace Processor docs" 2018-08-21 primiano@google.com TraceProcessor: Improve error handling Created with: gclient setdep -r src/third_party/perfetto@465d65ba9903 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ibe55335020f12877d3ab27a49172701a2e21993f Reviewed-on: https://chromium-review.googlesource.com/1183741Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584822}
-
Xiaoqian Dai authored
Before the dragged window is added to overview, its bounds might needs to update as the dragged window's bounds might have changed during dragging and as a result its transform might be different with other window's transform in overview. Bug: 873284 Change-Id: I1257f8d4526b62bcf6d3174f611bc4d576818755 Reviewed-on: https://chromium-review.googlesource.com/1180376 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#584821}
-
Brian Sheedy authored
This reverts commit 5b0f3e82. Reason for revert: Causing VR browser test failures https://bugs.chromium.org/p/chromium/issues/detail?id=876375 Original change's description: > Android: Move more methods to test-only targets > > Moved new test-only methods added to WebContents/RenderFrameHost > in https://crrev.com/c/1163831 to targets content*test_support. > > Bug: 862153, 875742 > Change-Id: Id9be5f53b45e2b28861a35401bba71020cf5fc0f > Reviewed-on: https://chromium-review.googlesource.com/1180824 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584660} TBR=mthiesse@chromium.org,boliu@chromium.org,jinsukkim@chromium.org Change-Id: I6bb9126e3870e9381432f828e6e698bdd5b0aec9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862153, 875742 Reviewed-on: https://chromium-review.googlesource.com/1183825Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584820}
-
Thomas Anderson authored
This reverts commit c5126022. Reason for revert: Suspected cause of linux-rel breakage: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-rel/2129 Original change's description: > DevTools: Do not start tracing in renderer process explicitly. > > The tracing is now initiated by the browser process. There's no need > to start it in renderer anymore. TracingStartedInPage event is not > going to be produced anymore. It has been replaced with TracingStartedInBrowser. > > Change-Id: I9e7759f7f792421d3f32fd21e82066e13a4901dc > Reviewed-on: https://chromium-review.googlesource.com/1182287 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584797} TBR=dgozman@chromium.org,alph@chromium.org Change-Id: I16a9138a8ab10ac74e032d02f4d4cbea1b173a30 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1183802Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584819}
-
Fredrik Hubinette authored
You might think that the compiler would be smart enough to optimize two calls to pow() with the same arguments into one call, but you would unfortunately be wrong. This simple change speeds up the PQ transfer function by a few percent. Change-Id: I5837b6255fb2def846f7c9ea6f1bd22d3abbf64a Reviewed-on: https://chromium-review.googlesource.com/1176591Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#584818}
-
Matt Mueller authored
It was accidentally re-disabled in a bad rebase in https://chromium.googlesource.com/chromium/src/+/3787780199f8ef7bfa5e977aab8180766b10ddad Bug: 859594 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2dd6b15dba5639657ddc4deadc4afe6468cd529a Reviewed-on: https://chromium-review.googlesource.com/1182309Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#584817}
-
Brandon Wylie authored
Bug: 875087 Change-Id: I1165ed0c6e65caf377d556de769bec878c0698cd Reviewed-on: https://chromium-review.googlesource.com/1179223 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#584816}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a16d9c72d60f..94822b57c10e git log a16d9c72d60f..94822b57c10e --date=short --no-merges --format='%ad %ae %s' 2018-08-21 rharrison@chromium.org Roll code coverage DEPS ahead Created with: gclient setdep -r src/third_party/pdfium@94822b57c10e The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9014bdb016464c3b8c7bd9995acaea0ee865c0b7 Reviewed-on: https://chromium-review.googlesource.com/1183583Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584815}
-
Robert Sesek authored
Bug: 850878 Change-Id: Id8a8a9546a18671ec8654e8a73156de77a377b26 Reviewed-on: https://chromium-review.googlesource.com/1183621Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#584814}
-
Friedrich Horschig authored
Currently, the keyboard accessory uses the focused view in the activity as view to check for keyboard visibility. This works most of the time, when an input field is focused but it's thinkable that the focus moves away (most likely programmatically) which could lead to the observed crashes. This CL now ensures, that the focused view is exclusively used when a keyboard needs to be shown and the detection (which relies on the content area layout) is always invoked with the content view. Bug: 876231 Change-Id: Ib65c7985987291cd2b85098b920106dbde40753d Reviewed-on: https://chromium-review.googlesource.com/1183423Reviewed-by:
-
Jordy Greenblatt authored
In the course of preparing the Settings UI to interact with feature prefs via the MultiDevice service, it became very cumbersome to pass around data without some utilities common to the components. This CL factors out some such utilities into their own behavior and passes around feature data using the behavior Note that this CL does not change the components' relationships with feature prefs as that is in the next change, but the behavior is a convenient intermediate point and should make the other significantly easier to review/work with. Note also that not all the components yet use the behavior but they almost all will as it becomes more relevant over the next few CLs. Change-Id: Iaeec623bd534287893f6c204a0fdf524ac0bfd77 Reviewed-on: https://chromium-review.googlesource.com/1179820Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#584812}
-
Christopher Cameron authored
Mechanically move the following functions either from BridgedNativeWidget to BridgedNativeWidgetPublic or from direct manipulation in NativeWidgetMac to BridgedNativeWidgetPublic: - SetVisibilityState - SetVisibleOnAllSpaces - SetMiniaturized - SetOpacity - SetContentAspectRatio - SetWindowTitle - MakeFirstResponder Add state tracking for visibility, miniaturization, and window key status to BridgedNativeWidgetHostImpl. Merge the new visibility tracking in with the existing compositor visibility tracking. Bug: 859152 Change-Id: I750986e6732bc54ff12e90a75e9d649a34895682 Reviewed-on: https://chromium-review.googlesource.com/1182962 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584811}
-
Manas Verma authored
Previously there was a single access point for both the sign-in promo and the manage cards prompt, shown after saving a card locally. This change creates a separate access point for the manage cards prompt. Bug: 855186 Change-Id: Ibdf036ac12a9ea7cce27abde41b368b7736ccb63 Reviewed-on: https://chromium-review.googlesource.com/1169630 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584810}
-
Helen Li authored
Cookies setting and getting can be blocked by a NetworkDelegate. This CL adds NetLog events so they can aid in the investigation of cookies bugs. Bug: 875849 Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 Reviewed-on: https://chromium-review.googlesource.com/1181244Reviewed-by:
-
