- 30 Oct, 2019 40 commits
-
-
Alice Wang authored
This CL fixes the bookmark signin promo tests when the promo is dismissed in different scenarios. Bug: 789531 Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Auto-Submit: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710784}
-
Ben Kelly authored
This CL increases the blob DataPipe cap from 512kb to 2MB to improve performance. Trials show a 12% progression at P95 when reading the body from a cache_storage response provided to a subresource service worker FetchEvent. A partner site showed a 5% progression at P95 in core css stylesheet load times. Bug: 1010199 Change-Id: I040cadc1d6d7c081b242f72ad286a2f942b0a53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859839Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#710783}
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 R=joenotcharles@chromium.org Change-Id: I40a4febf2585e0f445790ca99f45f2ef2f3e4b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889975 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710782}
-
Anthony Vallee-Dubois authored
Bug: 1019663 TBR: fbeaufort@chromium.org Change-Id: If58fd2c071cab7e77db76c96b78d6a25c46a7ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890532Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Auto-Submit: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710781}
-
Olivier Robin authored
Tbr: eugenebut Bug: 987646 Change-Id: I5856f970fac3af18be19761d09cf649d953a05b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883717 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710780}
-
Maksim Moskvitin authored
The test was disabled (crrev.com/c/1849426) because it instantiates FeatureLists after the browser threads have been created. The test enables custom passphrase with scrypt key derivation on one client and expects another client to be able to setup decryption without scrypt being enabled. Solution is just setting up encryption in the pre-test. Bug: 1013073 Change-Id: I7c6edf5d2ab7be432835c8fd3a3820bf60fd3ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890416Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#710779}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4778f6ce7a0b..4e19670d3a93 git log 4778f6ce7a0b..4e19670d3a93 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 hbos@webrtc.org [PeerConnection] Implement parameterless SetLocalDescription(). 2019-10-30 sakal@webrtc.org Disable rendering statistics while video is paused. Created with: gclient setdep -r src/third_party/webrtc@4e19670d3a93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:980885,chromium:b/142685093 Change-Id: I82db2bdbddeeed75ae3b57c392e71b2eefd1f4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890616Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710778}
-
Kamila Hasanbega authored
This reverts commit 03e8e9c1. Reason for revert: Not useful revert. Original change's description: > Revert "[ios] Disables CookiesTestCase on iOS 12 under EG2." > > This reverts commit 7c87047e. > > Reason for revert: tree failure. > > Original change's description: > > [ios] Disables CookiesTestCase on iOS 12 under EG2. > > > > BUG=1019670 > > > > Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630 > > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#710769} > > TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com > > Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1019670 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058 > Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> > Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710774} TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com,hkamila@chromium.org Change-Id: I18af80235e3078a1ea5f4bbd7895a64108f53b0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890434Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710777}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07be79e14506..924dad3b22c2 git log 07be79e14506..924dad3b22c2 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 42f885238114..7e2cba6a5241 (1 commits) Created with: gclient setdep -r src/third_party/angle@924dad3b22c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I2344d14e024f24e3cd62ceaa54909df43bb64ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890213Reviewed-by:
-
Omer Katz authored
Up until now, heap snapshot could not handle ephemerons. Since heap snapshot is always called after a GC, we can treat ephemerons as strong hash tables. The visitor interface is extended with a method that get a KeyValuePair. This is needed so that heap snapshot can determine the correct parent for the value. The default visitor implementation ignores the key and only traces the value. The DevTools visitor sets the key as the parent and then traces the value. Since DOM worlds are ephemeron-based since r705062 this allows users to debug those using DevTools as well. Drive-by: remove redundant trace in Node::Trace. Bug: 986235, 993415 Change-Id: Ifaf453b2d7c2883a929577825991a11fbb0cf835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834229 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710775}
-
Kamila Hasanbega authored
This reverts commit 7c87047e. Reason for revert: tree failure. Original change's description: > [ios] Disables CookiesTestCase on iOS 12 under EG2. > > BUG=1019670 > > Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630 > Commit-Queue: Rohit Rao <rohitrao@chromium.org> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710769} TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710774}
-
Robbie Gibson authored
Bug: 1019211 Change-Id: I2df1ed99e225bbd6b7e480388828632b7d6ef13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890412 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710773}
-
Monica Basta authored
On the first click on the profile menu we show the local avatar instead of GAIA avatar for signed in accounts. To fix that, we load the GAIA image from disk on startup if needed. Bug: 1017445 Change-Id: I43739a4da1f3dd2729c5aa6082fa23be0512038c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888030Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#710772}
-
anthonyvd authored
This reverts commit fa7708ed. Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/12814 Original change's description: > Move sharing messages to sync protocol directory. > > Bug: 1018129 > Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710768} TBR=mvanouwerkerk@chromium.org,mastiz@chromium.org,knollr@chromium.org Change-Id: Ic9cc83a44b50f18af9e806bd7a74a318761a385b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1018129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890533Reviewed-by:
-
Rune Lillesveen authored
The three last tests time out because handleEvent exceptions are not passed on. Bug: 1014421 Change-Id: I2349cb92968e375e5af2befaeea49abd1ec584d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889972Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#710770}
-
Rohit Rao authored
BUG=1019670 Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1018129 Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710768}
-
Leonard Grey authored
This was added in r422176 as a bug fix, but the original author doesn't recall specifically what it fixed, speculating that it might be related to a bug that caused searches not to terminate in some cases. This interacts poorly with last year's refactor to use idle tasks for find, causing a great deal of "final" updates per frame. I think it's likely that the original bug was addressed by the same refactor, but if not, removing this code will smoke it out so we can document *why* we need it. Bug: 1015818 Change-Id: I8234aa3788b24ce54ae75120c8d1e00c6ed31d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888090Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#710767}
-
Etienne Bergeron authored
This is a reland of b40da6df TBR=asvitkine@chromium.org Original change's description: > Lift fallback font unittests to share them across platforms > > This CL is lifting the parameterized unittests originally > wrote for windows to a common file to be available to > other platforms. > > Test from KnownExpectedFonts will now also run on Linux. > * Added the test cases for linux. > Test from Glyphs are now running on every platforms. > > Adding a matching_glyphs count to font_fallback_linux.cc. > Previously, a default font was returned for a single character > even if it was not matching the character, it was still the > best match. If no codepoints are found, the font is considered > a no match. > > Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569 > Fixed: 3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710364} Change-Id: Ie05d48f95834913b859d46e452965df00351649c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888185Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710766}
-
Alexander Timin authored
Remove kInternalIPC task type. - If it's used to bind associated interface, use kInternalNavigationAssociated instead. - If it's used to bind non-associated interface, use the task source mentioned in the spec or kInternalDefault if it's not speced. R=haraken@chromium.org Change-Id: I2ddb25f5b65874c32ba3f54a41dc4494927043cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887614Reviewed-by:
-
Hajime Hoshi authored
This CL adds a new histogram BackForwardCache.HistoryNavigationOutcome. BLocklistedFeature to record blocklisted features when a page cannot be put into the cache due to them. Bug: 1004676 Change-Id: I96f9789cdeb7f176c802ede764124cd5ac177880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871493 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL implements phase 8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ It moves from content/renderer/media/webrtc to Blink the following files: - rtc_peer_connection_handler.cc | h | test - webrtc_set_description_observer.cc | h | test - peer_connection_tracker.cc | h | test - media_stream_track_metrics.cc | h | test The following unit tests are also moved to Blink, although not accompained of their respective source and header files (already in Blink). - peer_connection_dependency_factory_unittest.cc - rtc_peer_connection_test.cc It is also worth it to mention that testing_platform_support_with_web_rtc.cc and .h (both in renderer/platform/testing/) got adapted now that the blink::Platform method they relied on got removed: instead of overriding Platform::CreateRTCPeerConnectionHandler(), RTCPeerConnection gets a static factory setter method that tests can use to override how RTCPeerConnectionHandler is created. The method is named SetRtcPeerConnectionFactoryForTesting() and is used in scheduler_affecting_features_test.cc and rtc_peer_connection_test.cc (twice). For completeness, this CL has a series of predecessor CLs, being the following ones below the most relevant: - crrev.com/c/1845802 - Lazy initialize PeerConnectionTracker - crrev.com/c/1831197 - Migrate PeerConnectionTracker and PeerConnectionTrackerHost to Mojo Note that the CL opens the door for various follow up, including: - Migration of base::Bind to WTF::Bind. - Migration from std::string to WTF::String. - Migration for stl structs (eg vector, map) by their WTF's counterparts. - Reduce the API footprint - Clean up if content/tests/BUILD WebRTC dependencies. - ... Bug: 787254 Change-Id: I49d6f84c747eb944ec55665722fc4046d14f66cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842414Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
arthursonzogni authored
The patch: https://chromium-review.googlesource.com/c/chromium/src/+/1854901 was reenabling the tests: - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverDedicatedWorker - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverNavigate - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverServiceWorker - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverSingleConnection - IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverTwoLocks - LockManagerBrowserTest.ObserverDedicatedWorker - LockManagerBrowserTest.ObserverNavigate - LockManagerBrowserTest.ObserverServiceWorker - LockManagerBrowserTest.ObserverSingleLock - LockManagerBrowserTest.ObserverStealLock - LockManagerBrowserTest.ObserverTwoLocks on Android KitKat. They are still failing => disabling them again. https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/18113 TBR=fdoray@chromium.org CC=ahemery@chromium.org,fergal@chromium.org,altimin@chromium.org R=arthursonzogni@chromium.org Bug: 1019659,1011765,1014015 Change-Id: I5be59757f1f37d58150700c331c22cbd8343187f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890071Reviewed-by:
-
Maks Orlovich authored
We are going to be asking cookies accessible in 3rd party contexts to be marked as samesite=none and secure, so make tests that want such cookies (if only to test them being blocked by preferences) set those attributes and use HTTPS. Bug: 1006816 Change-Id: I3c4b58de2b75736b85ce87b694c57fd8db04cbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873154Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#710761}
-
Roman Sorokin authored
Supposed to be fixed TBR=antrim@chromium.org Bug: 1003772 Change-Id: If9f00577aced44ddf0de36c89e5961a3d152a300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890037Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710760}
-
Marc Treib authored
The ARTICLES ModelType was never launched and all the code has been removed. Bug: 965503 Change-Id: Ifb1841d875ff6ee5f6d8d0a001efb6e69c83c281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872587 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
WontFix along with the other tests for the unimplemented feature. Bug: 246571 Change-Id: Ia3da325693993eba36c1a5685c547631f7f628e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889971Reviewed-by:
-
Marc Treib authored
InvalidatorRegistrarWithMemory is the main "real" implementation of a registrar, so it's important to run any tests on this one. Previously, the tests were only instantiated for DeprecatedInvalidatorRegistrar (which is deprecated and will hopefull be removed soon) and for InvalidatorRegistrar (which is a base class of InvalidatorRegistrarWithMemory that is never used directly). Bug: none Change-Id: I591442c0cff1b10d8e17cf6d7f63f3d470154545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890034 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#710757}
-
Jeevan Shikaram authored
This CL checks that the apps have been loaded before checking if an app exists in the apps list. It also handles a race condition where the dom-switch element's onRouteChanged is called before the dom-switch has a child loaded. Bug: 1014919 Change-Id: Id0712b74b006580bfbed2c701a3e61320094a036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889274 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710756}
-
Yi Gu authored
virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html is still flaky on Mac [1]. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html TBR=yigu@chromium.org NOTRY=true Bug: 1014810, 1014812 Change-Id: Ib6811c0f14fbfcecff0d5d151ae446afbda5e98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890615Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#710755}
-
Yi Su authored
Remove the extra space at bottom of NTP article cells if no image is displayed. Screenshots: normal-font-top: https://drive.google.com/open?id=11r17WFEdLeN2nr5lXAbidq0d6Pfa-2g4 normal-font-bottom: https://drive.google.com/open?id=1Ss-R_HLKEN5I8HpP4vdWDl3FeCm47CyK a11y-font-top: https://drive.google.com/open?id=1IS1_NoZKGBDEmU2jsVNWY6e6VBD4jkkr a11y-font-bottom: https://drive.google.com/open?id=1bTPAeXJPjR8qHpeP5Z_5MAaziUypbj8J Bug: 1003693 Change-Id: I3e38560a28636850b41400a5099f3f2ad320b11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889652Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710754}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46994599..f752e377 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f53cd18fbb8af769885bb3c90bf8bd358d41ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890230Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710753}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/470b2d5144a3..4778f6ce7a0b git log 470b2d5144a3..4778f6ce7a0b --date=short --no-merges --format='%ad %ae %s' 2019-10-30 titovartem@webrtc.org Revert "Refactoring of the noise suppressor and adding true multichannel support" 2019-10-30 sakal@webrtc.org Fix invalid @Nullable handling in TextureBufferImpl. 2019-10-30 srte@webrtc.org Cleanup of feedback observer interface Created with: gclient setdep -r src/third_party/webrtc@4778f6ce7a0b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/143344262,chromium:None Change-Id: Ic24032eacfc8b8c4765051190e7bcde50566ca74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890212Reviewed-by:
-
Donn Denman authored
Changes the length of the caption to depend on whether we're showing the new or old layout. This doesn't automatically adjust the length as the panel opens but the caption is either fixed length or scrolls away when the panel is expanded, so this is not a significant problem (see bug 1016973). BUG=1019007 Change-Id: Iccb13eac1ca297d87c2a64cf682ac87cc341d535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887749 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#710751}
-
Mark Cogan authored
The hardware keyboard utils aren't chrome- or EG-specific, so this CL moves them to the more general //ios/testing directory. Change-Id: Idae0307e618117e987304fc6a89097735b41f937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889875 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Henrique Ferreiro authored
blink::WebFloatPoint3D is defined in public/platform but it has no users outside of //third_party/blink. Replace it with blink::FloatPoint3D. Bug: 919392 Change-Id: Ie637185f1aa81c7793f724b7afe94dce1edf8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886812Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#710749}
-
ckitagawa authored
This is a reland of ba5c7d6f Reverted as PaintPreviewTest.TestInvalidProto broke on the Win7 Test dbg and Linux Test dbg waterfall bots. Fix: modify the test to avoid serializing an invalid proto and instead just serialize a string. The point of the test was to see that the invalid proto wouldn't deserialize and that state would be handled properly. Using TBR as lots of reviewers (some OOO) and there is minimal change from original CL aside from one test. Revert: 29b91f26 Original change's description: > [Paint Preview] Compositing Service > > Adds a paint preview compositor service for compositing collections of > SkPictures representing frames into bitmaps. This is very similar > in principle to the PDF compositor service, but produces tileable > bitmaps rather than a PDF. > > A client to this service should start the compositing collection > portion of the service in a utility process. The client can then > create and delete dedicated compositor instances for each group of > SkPictures. Realistically only one compositor will be actively > communicating at a time. However, multiple compositors can be > "warm" (data is deserialized and in memory for fast switching). > > Bug: 1011430 > Change-Id: I21cb594cd94982f8d4fc5800d9ae4d74b5d9973b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842273 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709946} TBR=kenrb@chromium.org,jochen@chromium.org,blundell@chromium.org Bug: 1011430 Change-Id: Ieafd0d2e197feb8b1d1711e05dd4acc6f185655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886986Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#710748}
-
Michael Achenbach authored
This adds a missing explicit include of jumbo.gni. It is included indirectly through V8, which blocks removing jumbo support on the V8 side: https://crrev.com/c/1890090 Bug: 994387 Change-Id: Ib5d3310d57c9bc50c11d4a4339e062dba298e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890311Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#710747}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11a79e755c5e..d85805a32efe git log 11a79e755c5e..d85805a32efe --date=short --no-merges --format='%ad %ae %s' 2019-10-30 eseckler@google.com protozero: Make generated cpp enum/class order stable Created with: gclient setdep -r src/third_party/perfetto@d85805a32efe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:1017699 Change-Id: Id713a876b3355636bd267a39bc629d3dfe5a02b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889994Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a660eacc675c..6d56bdc1447a Created with: gclient setdep -r src-internal@6d56bdc1447a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9dbaf55e6b35444edf4bf1ad569b6db9bd39b822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710745}
-
