GitLab

The test referred to in the bug below has been flaky on multiple
platforms: iOS(1032568) and FuchsiaOS(813631) as well as Win 7 and
MacOS on Edge. This PR includes a short change which should fix this.

It seems like the QuicServer running asynchronously hasn't had time to
process all requests which is causing a race condition when the check
in line 421 is made. So we wait until the server is finished processing
the requests before making the expect check.

Bug: 1032568
Change-Id: I52dc909b7167d811126fab99cf2b7ad334b2d96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008627Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736150}

Bug: 1046580
TBR: michaeldo@chromium.org
Change-Id: Id8424c65cf9f0827ddee02d59dce656184ebcb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026371Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736149}

Change metal_util::TestShader to test either compile or link, and
change the default behavior to link.

Ensure that the Metal calls for the test are invoked on a thread
that has base::TaskPriority::HIGHEST.

Bug: 974219
Change-Id: I6d2db6c40182286a4af3489968a995dca73e7944
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024922Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736148}

This parallels the naming scheme for other parts of Blink's
public interface.

BUG=803242

Change-Id: Ib92a31fa379c184258e1ef41a9397d707220f3bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025991
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736147}

https://pdfium.googlesource.com/pdfium.git/+log/3c63cf70e3b3..e5e522c140a2

git log 3c63cf70e3b3..e5e522c140a2 --date=short --first-parent --format='%ad %ae %s'
2020-01-28 thestig@chromium.org Rename functions in core/ that starts with "FPDF_".
2020-01-28 thestig@chromium.org Assert a cast inside cpdf_imagecacheentry.cpp is safe.
2020-01-28 dhoss@chromium.org Rename Left() and Right() in {Byte,Wide}String{,View} classes
2020-01-28 dhoss@chromium.org Rename First() and Last() {Byte,Wide}String{,View} classes
2020-01-28 tsepez@chromium.org Remove CPDF_ActionFields.

Created with:
  gclient setdep -r src/third_party/pdfium@e5e522c140a2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I3325cc6e65353bdb7ed9f4e05af7f38efbb383e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026010Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736146}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d635962bc78..ea8b58b970c0

git log 9d635962bc78..ea8b58b970c0 --date=short --first-parent --format='%ad %ae %s'
2020-01-28 apolito@google.com add apolito to owners

Created with:
  gclient setdep -r src/third_party/depot_tools@ea8b58b970c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ied7d8ee7cef97f99ec249db11f5a72989fd81f36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026017Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736145}

In order to avoid cutting off the status label
"Scan complete, no issues identified", expand the width of the download
shelf item to the maximum of the file name label, status label, and
the minimum text width (so short filenames aren't shortened by this
change).

New screenshot: https://screenshot.googleplex.com/YMMaw8r1CRd.png

Bug: 1020418
Change-Id: I6ddcf6beb66526b168bf8b826d13d7be394cfc2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023280
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736144}

This test may timeout on CrOS. See bug for details.

TBR=oshima@chromium.org

Bug: 1043465
Change-Id: Id0381426d3e1b93b3ac413d4ab26a0d475e8d393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026148Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736143}

As of https://crrev.com/619964, style & layout containment creates
an isolation boundary which means clip-related subtree updates can be
skipped. PaintLayer::ClippingContainer is used for the clip property
tree state of a squashing layer. This clipping container could be an
ancestor of a style & layout isolation boundary. If a clip changed on
a clipping container ancestor of an isolation boundary, the clip node of
squashing layers below could become stale. This patch ensures
PaintLayer::ClippingContainer stops at style & layout containment
boundaries by making style & layout containment a clip-related property.

Bug: 1044895
Change-Id: I898df21c0f65f79114564938042356b7ef587c19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025313
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736142}

1. Since application context does not work with dark mode,
presubmit check will warn users on using it.
2. Setting text color or size instead of text styles will make it hard
to maintain if there are some future updates on text colors or sizes.
3. Encourage to use ButtonCompat for consistent style.

Bug: 775198, 908651
Change-Id: I3101accd201c3622863fbb45d10abb3d580fcb73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963105
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736141}

This includes all actions from the tab group bubble
(ungroup, close, color selecting, send feedback) as well as logging
when a tab that belongs to a group is closed.

Bug: 1040657
Change-Id: I44cda622d9f8e04adc5c9e76a5e841f821edb88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019861Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736140}

This CL fixes flaky timeout of external/wpt/first-image-child.html by:
* Adding a meta tag to let it take long.
* Adding HTML tags for iframe and img instead of adding the resources on
JS, to make it faster.
* Wrapping the core of the test under window load to ensure that the
resources are loaded by the time the entries are checked. It's possible
that before this CL the iframe was sometimes not ready to receive the
message from the parent, causing the test to timeout.

Bug: 1041709
Change-Id: I135c11f5f3a8a3f8e3f65012843a61bab7c50aa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025909
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736139}

The new presubmit about Windows command line limit fires with
the current tip of tree. This CL attempts to remove more stale
field trial configs to get it to pass.

Removing both configs where the feature is no longer defined
and those where the feature is enabled by default.

Note: Not an exhaustive list, just based on some spot checks.

Bug: 1045530, 1045636
Change-Id: Ie14de78fbfbc80d30cab931dd405cdc97c3120c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025829
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736138}

Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804
doesn't fix the issue entirely. Looking deeper in this issue, it's
actually caused by ClientControlledShellSurface::UpdateBackdrop() can be
called on a dragged window (whose backdrop has been disabled (kDisabled)
when drag starts) to re-enable the backdrop.

This CL makes sure an ARC window with disabled backdrop mode won't be
modified.

Bug: 1027269
Change-Id: Ia3508a92b5c9133b5821d5f9f0a2345eccad382f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#734250}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021283Reviewed-by: Mitsuru Oshima (slow in TOK) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736137}

This CL adds a new UI thread class, ConversionManager, owned by the
StoragePartition. The ConversionManager initializes and owns
a ConversionStorage instance and also implements the
ConversionStorage::StorageDelegate.

Specific API constraints like delaying conversion reports, and setting
the maximum number of conversions are implemented in a separate
composable class ConversionPolicy to allow tests to easily mock certain
functionality, as well as centralize these constraints to a single
include.

Intended functionality of the ConversionManager includes:
  - ownership of the ConversionReporter, and timers for periodically
    fetching reports to send from storage.
  - methods to log new impressions / conversions to storage
  - ownership and usage of Report Cooldown throttling implementations
This functionality is intended to be implemented in follow-up CL's due
to dependencies, and to keep these changes small. A more complete
implementation can be seen on the prototype change below.

The functionality of the API is described on
https://github.com/csharrison/conversion-measurement-api

Design-doc(RVG): https://crbug.com/1039466

Reference prototype change:
https://chromium-review.googlesource.com/c/chromium/src/+/1967220

Bug: 1014604
Change-Id: If432b0046b8c6dcd12ce828aea3917cf887fbe08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994016Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736136}

These tests were disabled on Fuchsia because all DomCodes were mapped
to native_keycodes of zero.

Bug: 829551
Change-Id: I7401117eecfd8e1f4c8af04ad3cc475051699a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025388
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736135}

This is a reland of 31f93aa2

Original change's description:
> heap: Check empty or deleted keys on local copy
> 
> Tracing an HashTable involves checking whether keys are empty or
> deleted. This can result in data races with the mutator if the
> HashTable is modified while it is traced.
> To avoid such data races, we create a local copy of the key on the
> concurrent thread and perform the check on the copy.
> 
> Using the local copy on the mutator thread would result in significant
> regressions. Measured locally on the facebook_infinite_scroll:2018 story
> from v8.browsind_desktop benchmark, showed an increase ranging from 70%
> to 110% in the time it takes to process ephemerons (this measurement
> doesn't cover all HashTables, just the ephemeron HashTable).
> To avoid these regressions, the local copy is used only for concurrent
> visitors.
> 
> For further details see
> https://drive.google.com/open?id=13DTRcF3xfVjJ2QaKzAOYFzqvTfGRNiX6WWL3CCACSoM
> 
> Bug: 986235
> Change-Id: Ie135c1076bd1834ae7f8b97ca6446890fc30a02c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012961
> Commit-Queue: Omer Katz <omerkatz@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#735833}

Bug: 986235
Change-Id: Ib12f495dd24cd3a1b310d46927c2cd13d605e566
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025667
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736134}

We wanted to land crrev.com/c/202225 promptly so that it could be verified prior to stable cut, but it includes a couple temporary changes that will get reverted briefly as part of a follow-up change implementing a riskier but conceptually more coherent fix for the same issue.

Change-Id: I8ebe8dd3d19686446a37754446bf536eda043671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023728
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736133}

Probably fixed by 88094724 but the
tests were never re-enabled. See bug for history.

Bug: 1029568
Change-Id: Iffb9e629c30db1e78be7ab9100e0551f43f7eac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026190
Commit-Queue: Evan Stade <estade@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Evan Stade <estade@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736132}

This CL only modifies comments, pointing them towards the official
video-raf spec.

TBR: mlamouri@chromium.org
Bug: 1022186
Change-Id: I2da26aa139e453ea5547b3bab84e64a2e64c29be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025831Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736131}

This adds a new net error and cert status for when a connection uses an
obsolete version of TLS (i.e., TLS 1.0 or 1.1 in the default
configuration). This also adds support for the SSLVersionMin enterprise
policy setting which version triggers the error (and will thus show an
interstitial warning), allowing enterprises to opt-out of the legacy TLS
interstitial.

A new interstitial for this error will be added in
https://crrev.com/c/1940707. Support for the control site list will be
added in https://crrev.com/c/1906779.

Bug: 896013, 1039756
Change-Id: Ib24d4b3efcfbbad1f37a41bfed3690280d4d2b71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894616
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736130}

Add some documentation on how extension APIs work, and best practices
for writing a new one.

Bug: None
Change-Id: I82e2ca785d474ba533dec244b91e36b9b55178b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024122Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736129}

This patch introduces a new UI section in the collect data view. It can
be used to show a flat, informational string and is independent of other
sections. The info section does support links similarly to what the
terms sections do. Meaning, <link0>text</link0> will be handled the same
way as the latter.

The initial plan was to add an additional state to the terms states to
handle a new use case where only text is shown, no UI elements. This was
deemed to involved and the result is this stand-alone new section that
also supports the same use case even if distinct in the proto.

Bug: b/147580725
Change-Id: Ib1d51b169040dc8981d0565b3faa292bfea1c6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022648
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#736128}

cr.exportPath() is no longer used, and therefore does not need to
be handled by polymer.py.

Bug: 1028829
Change-Id: I6113a4f5feb94f8e17217cad279e2cab214c3c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025868
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736127}

During upgrade transactions, a store or index can be created and
then immediately used from script in operations (e.g. "count"). On the
backend, the creation will not run until the transaction acquires a
lock, and pending tasks are queued. A handful of operations (including
"count()") were synchronously checking to see if the target
store/index had been created before queuing the task, which would fail
if the lock had not yet been acquired. The checks must occur when the
task is run; remove the bogus early checks, which would abort the
transaction.

Bug: 1045585
Change-Id: Ibef191e24916333da4e9b2449dda5ff775a35138
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023521Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736126}

This test may timeout on Linux:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBibGlua19oZWFwX3VuaXR0ZXN0c0BIZWFwVGhyZWFkRGVhdGhUZXN0LlBlcnNpc3RlbnRTYW1lVGhyZWFkQ2hlY2sM

TBR=bikineev@chromium.org

Bug: 1043580
Change-Id: Iba18b7c7f6c57c65ef285397198d2a12e2d19951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025975Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736125}

But tab dragging is still kept enabled. However, it will not be visible
to the user from M81 since they have mohnstrudel (#webui-tab-strip)
enabled. If mohnstrudel is disabled from chrome://flags, then the user
should still be able to do tab dragging.

Bug: 1041928
Change-Id: I2bfd2cc677ee82d9088006614ecb4f0d21b61cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025574
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736124}

The options in an HTML select element are present in the
accessibility tree even when the popup is not visible. As a
result it's possible for AT such as ChromeVox to fire a click
event on an option. However, since the popup is collapsed, the
expected behavior is for the menu to pop open - then clicking it
again should close it.

This wasn't implemented before because most AT only sends the
click event to the <select> element when it's collapsed.

Bug: 1046087
Change-Id: Ic110efc771490035e24041362211dc5c61585248
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025323Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736123}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0a0715c4..390a4513

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id1159011773ad7d987333cb6a4a7475b92dfbe75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025249Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736122}

This policy allows enterprises to disable screen sharing (desktop,
window or tab) via the getDisplayMedia() and extension APIs.

Bug: 1003720
Change-Id: Ie4271e7e6cf29f670f3730cae8119800520e6b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025347Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736121}

This reverts commit 4717f398.

Reason for revert: Broke ios-simulator-xcode-clang bot. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8889981707645765280/+/steps/compile/0/stdout

Original change's description:
> Basic implementation and tests for HangWatcher.
> 
> This class is a successor to ThreadWatcher which aims to be more
> versatile and provide a larger coverage for hang watching.
> 
> Bug: 1034046
> Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189
> Commit-Queue: Oliver Li <olivierli@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736080}

TBR=fdoray@chromium.org,olivierli@chromium.org

Change-Id: I88af4ad3baf02af94adcc0770168ce7adc7ede45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1034046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026174Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736120}

Bug: None
Change-Id: I90a426425fd15b06ea935b17be00094dcd0a5d01
Tbr: agrieve@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025788
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736119}

Also calculate the new hotseat state as part of calculating new target
bounds instead of passing it in.

Bug: 1042911, 1040177
Change-Id: Ie3471df435ba9ce49130e528811c17da0e249b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025428
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736118}

Bug: 1045591
Change-Id: I9d9b169f2abc286c84f0906658e9be9b8af31791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020406Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736117}

Currently, the on-focus configuration in fieldtrial_testing_config.json
is in the "NTPZeroPrefixSuggestions" trial.

The problem is that about_flags.cc configures on-focus suggestions with
the "OmniboxBundledExperimentV1" field trial. This mismatch between
fieldtrial_testing_config.json and about_flags.cc causes a crash.

It's most proper to match what's in fieldtrial_testing_config.json
and about_flags.cc.

We won't be able to match the server-side config all the time, since
Dev/Canary uses the "unbundled" experiment format, and Beta and Stable
use the "bundled" experiment format.

But so long as fieldtrial_testing_config.json and about_flags.cc match,
the client-side code is correct.

Bug: 1015174
Change-Id: I93fd6cf6392f3de2a0e326bbdfe736bb9a10acc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019329Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736116}

https://webrtc.googlesource.com/src.git/+log/8c52e8a2efb0..ed9a401f277b

git log 8c52e8a2efb0..ed9a401f277b --date=short --first-parent --format='%ad %ae %s'
2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01683979..5146474c (735581:735951)

Created with:
  gclient setdep -r src/third_party/webrtc@ed9a401f277b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I66916bf3af6ef66fee2b3c40007163be6ddf7d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025699Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736115}

This fixes libgtkui-based file dialogs support on Ozone X11 and prepares X11
event source implementations for the upcoming PlatformEvent migration CLs.

Further details:

CL standardizes the X11EventSource interface (i.e: Support XEvent => ui::Event
translation, XEvent specific dispatchers and observers, etc), moving most of
the code out of the default delegate implementation into X11EventSource itself.
2 reasons motivate this change:

1. Gtk-based file dialogs do not work in Ozone X11 with FdWatch-based source.
So, as an initial fix, this CL makes it possible to use the pure glib-based
implementation (i.e: uses glib API, GSource directly, etc) in Ozone builds with
use_glib=true. FdWatch-based impl, originally used in ozone-based products,
misses some events because it does not use the XPending() function to check for
new events (instead it only watches for X11 connection FD changes).  Thus, with
this change, pure glib-based X11 event source is used in Ozone when use_glib GN
arg is set explicitly, otherwise the fdwatch-based one is used (e.g: CrOS on
Linux).

2. It is a preliminary and required step for the upcoming PlatformEvent
migration CLs [1]. As one of the first speps of the migration, event source
must support the same API and logic as the one originally used in ozone, as
described above. As, at this point, it still must support the non-Ozone path
(where PlatformEvent is still defined as XEvent*), Ozone specific code is
guarded under USE_OZONE build flag.

As a side effect, this simplifies a lot of X11EventSourceDelegate impls so that
they turn into XEvent "watchers" instead, so this CL also renames them
accordingly.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=965991

Bug: 1008755, 963419
Change-Id: I060ec0dab519590e485e5baa96b5e84a7afad5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863940Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#736114}

R=harringtond@chromium.org

Bug: 1044242
Change-Id: I05b9eb75f8d1ae507492fbdb987e44719e9b2bca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016188Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736113}

 - Modify Settings data source to serve generated files.
 - Add top-level JS/HTML files that will host the V3 version.
 - Use a JS import for the generated
   chrome://settings/search_settings.m.js as a proof of concept.
 - Update BUILD.gn files as needed.

Note that the dummy page is currently only available for
optimized_webui=false builds.

This is in preparation of migrating to Polymer 3.

Bug: 1026426
Change-Id: I53dc831bfad3cf4645fa91c643bd5e34d14190de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024161
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736112}

- Creates SaveCardInfobarMetricsRecorder inline with other Infobars,
to record Save Card infobar specific metrics.
- Creates Mobile.Messages.Save.Card.Modal.Event and its enum
to record when a user starts editing any of the editable fields

Bug: 1029067
Change-Id: Icc2588dad0578d8c232baa720b74585a15f5ef4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024282Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736111}