GitLab

Bug: 1014959
Change-Id: I3504b83034008c12bd66a02b01154395484e919d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888100
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710792}

This reverts commit 5bb59abc.

Reason for revert: CL passed webview_instrumentation_test_apk

Original change's description:
> Revert "printing: Mojofy PrintMsg_* in PrintViewManagerBase"
> 
> This reverts commit 10d377be.
> 
> Reason for revert: Speculative revert for webview_instrumentation_test_apk failing on https://ci.chromium.org/p/chromium/builders/ci/Android%20CFI/6755?blamelist=1#blamelist-tab
> 
> Original change's description:
> > printing: Mojofy PrintMsg_* in PrintViewManagerBase
> > 
> > Replace PrintMsg_PrintingDone, PrintMsg_PrintPages, and
> > PrintMsg_SetPrintingEnabled IPC messages with new Mojo methods. Update
> > AwPrintManager and HeadlessPrintManager to also use these new methods.
> > 
> > Bug: 1008939
> > Test: Print a webpage and PDF
> > Change-Id: I3a403dd47ffc9c4debe819d26b00eccbd24b1180
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876473
> > Commit-Queue: Jesse Schettler <jschettler@chromium.org>
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Changwan Ryu <changwan@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710576}
> 
> TBR=sky@chromium.org,dcheng@chromium.org,thestig@chromium.org,changwan@chromium.org,jschettler@chromium.org
> 
> Change-Id: Id6c6676aafab9e6abeb8d99bc18613a6ba5a2c60
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1008939
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890070
> Reviewed-by: Kamila Hasanbega <hkamila@google.com>
> Commit-Queue: Kamila Hasanbega <hkamila@google.com>
> Cr-Commit-Position: refs/heads/master@{#710719}

TBR=sky@chromium.org,dcheng@chromium.org,thestig@chromium.org,changwan@chromium.org,hkamila@google.com,jschettler@chromium.org

Change-Id: I31a05cdcda5790cb925205d95da48ade2bd41e64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890712Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710791}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c47ee16c44c1..fda994c63075

git log c47ee16c44c1..fda994c63075 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 digit@google.com [vulkan] Implement external semaphore support for Fuchsia

Created with:
  gclient setdep -r src/third_party/swiftshader@fda994c63075

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Bug: chromium:b/140421726
Change-Id: I508f42eda5f31a7750f726ea462ec512f6c9d461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890617Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710790}

This revert:
https://chromium-review.googlesource.com/c/chromium/src/+/1877250
https://chromium-review.googlesource.com/c/chromium/src/+/1881814

Reason for revert: https://crbug.com/1019623
Causing build failure for clank official.

Original change's description:
> Add lib placeholders when packaging modules to make bundle multi ABI
>
> This fixes a bug where modules can miss an ABI and fail the bundle
> packaging step. This is due to two factors:
>
> 1. crrev.com/c/1876975 added an allotment step to each bundle that
>    determined in which module native libs are packaged into. If a module
>    only depends on libs that are also depended on by other modules this
>    module will package no libs even though libs are specified when
>    instantiating the module target.
>
> 2. Bundletool requires that all modules support the same set of ABIs.
>    To make modules appear to support the WebView ABI for Monochrome and
>    Trichrome we add placeholder libs for the WebView ABI. We do this in
>    the chrome_feature_module template if we specify real libs for the
>    browser ABI.
>
> Given 1. and 2. it can happen that a module is only left with the
> placeholder lib and appear single ABI, failing packaging. This CL fixes
> that by telling the packaging step that the module should be multi ABI
> and the packaging step will add a placeholder lib if necessary. This
> makes placeholder logic in chrome_feature_module obsolete and therefore
> it is removed.
>
> This new multi ABI logic can likely be reused for other APKs that use
> lib placeholders simply to make the APK multi ABI.
>
> Bug: 870055
> Change-Id: I25cf4edd56bf253cff2aef54d1857cbe9167cae3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881814
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Eric Stevenson <estevenson@chromium.org>
> Reviewed-by: Christopher Grant <cjgrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710204}

TBR=cjgrant@chromium.org,estevenson@chromium.org,tiborg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870055, 1019623
Change-Id: I3e3acdbfe062c3b360c284811506dfd11900b4b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888656
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710789}

Both WebView's and Chrome's cache clearing APIs do the following:
1) Clear the GL shader cache, which corresponds to DATA_TYPE_CACHE in
the language of browser_data_remover.h.
2) Clear the Blink cache of the renderers.

This CL implements the first part in WebLayer.

Change-Id: Ib29edf65bf36bd85c912f02b2e2bce918d7084ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883655
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710788}

Bug: 1019662,1019663
Change-Id: Ib9af219a8e386954260d10db852da1761b2366ac
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890074Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710787}

This CL populates the network isolation key for custom tabs detached
resource requests. It is computed using the |site_for_cookies_| since
that represents the origin of the app. The origin is verified using
digital asset links verification and so should be fine to use here.
The existing tests impacted by this change are:
org.chromium.chrome.browser.customtabs.DetachedResourceRequestTest
#testSafeBrowsingMainResource
and
org.chromium.chrome.browser.customtabs.DetachedResourceRequestTest
#testSafeBrowsingMainResourceBeforeNative

Change-Id: Ia05916f1da39ec4628c51dd4de5eeb42da78d820
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854685
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710786}

Bug: 949069
Change-Id: I3d7dcddbbcfeeafee5ac7e89c45fccb2e3b86c3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889974
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710785}

This CL fixes the bookmark signin promo tests when the promo is
dismissed in different scenarios.

Bug: 789531
Change-Id: I852e60cb3e56f9db737cb0e03073d36373908f68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883628Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Auto-Submit: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710784}

This CL increases the blob DataPipe cap from 512kb to 2MB to improve
performance.

Trials show a 12% progression at P95 when reading the body from a
cache_storage response provided to a subresource service worker
FetchEvent.  A partner site showed a 5% progression at P95 in core
css stylesheet load times.

Bug: 1010199
Change-Id: I040cadc1d6d7c081b242f72ad286a2f942b0a53f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859839Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710783}

The ScopedTempDir must outlive anything that holds file(s) open within
it; otherwise, it is unable to delete itself.

BUG=546640
R=joenotcharles@chromium.org

Change-Id: I40a4febf2585e0f445790ca99f45f2ef2f3e4b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889975
Auto-Submit: Greg Thompson <grt@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710782}

Bug: 1019663
TBR: fbeaufort@chromium.org
Change-Id: If58fd2c071cab7e77db76c96b78d6a25c46a7ccd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890532Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Auto-Submit: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710781}

Tbr: eugenebut
Bug: 987646
Change-Id: I5856f970fac3af18be19761d09cf649d953a05b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883717
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710780}

The test was disabled (crrev.com/c/1849426) because it instantiates
FeatureLists after the browser threads have been created.

The test enables custom passphrase with scrypt key derivation on one
client and expects another client to be able to setup decryption
without scrypt being enabled. Solution is just setting up encryption
in the pre-test.

Bug: 1013073
Change-Id: I7c6edf5d2ab7be432835c8fd3a3820bf60fd3ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890416Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#710779}

https://webrtc.googlesource.com/src.git/+log/4778f6ce7a0b..4e19670d3a93

git log 4778f6ce7a0b..4e19670d3a93 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 hbos@webrtc.org [PeerConnection] Implement parameterless SetLocalDescription().
2019-10-30 sakal@webrtc.org Disable rendering statistics while video is paused.

Created with:
  gclient setdep -r src/third_party/webrtc@4e19670d3a93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:980885,chromium:b/142685093
Change-Id: I82db2bdbddeeed75ae3b57c392e71b2eefd1f4e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890616Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710778}

This reverts commit 03e8e9c1.

Reason for revert: Not useful revert. 

Original change's description:
> Revert "[ios] Disables CookiesTestCase on iOS 12 under EG2."
> 
> This reverts commit 7c87047e.
> 
> Reason for revert: tree failure.
> 
> Original change's description:
> > [ios] Disables CookiesTestCase on iOS 12 under EG2.
> > 
> > BUG=1019670
> > 
> > Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
> > Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#710769}
> 
> TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com
> 
> Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1019670
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058
> Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710774}

TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com,hkamila@chromium.org

Change-Id: I18af80235e3078a1ea5f4bbd7895a64108f53b0b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890434Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710777}

https://chromium.googlesource.com/angle/angle.git/+log/07be79e14506..924dad3b22c2

git log 07be79e14506..924dad3b22c2 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 42f885238114..7e2cba6a5241 (1 commits)

Created with:
  gclient setdep -r src/third_party/angle@924dad3b22c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: I2344d14e024f24e3cd62ceaa54909df43bb64ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890213Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710776}

Up until now, heap snapshot could not handle ephemerons. Since heap snapshot
is always called after a GC, we can treat ephemerons as strong hash tables.
The visitor interface is extended with a method that get a KeyValuePair. This
is needed so that heap snapshot can determine the correct parent for the
value. The default visitor implementation ignores the key and only traces the
value. The DevTools visitor sets the key as the parent and then traces the
value. Since DOM worlds are ephemeron-based since r705062 this allows users to
debug those using DevTools as well.

Drive-by: remove redundant trace in Node::Trace.

Bug: 986235, 993415
Change-Id: Ifaf453b2d7c2883a929577825991a11fbb0cf835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834229
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710775}

This reverts commit 7c87047e.

Reason for revert: tree failure.

Original change's description:
> [ios] Disables CookiesTestCase on iOS 12 under EG2.
> 
> BUG=1019670
> 
> Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
> Commit-Queue: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710769}

TBR=rohitrao@chromium.org,olivierrobin@chromium.org,rkgibson@google.com

Change-Id: Iee07c30e9f08de1ad2457a300e809b173c03df56
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019670
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890058Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710774}

Bug: 1019211
Change-Id: I2df1ed99e225bbd6b7e480388828632b7d6ef13d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890412
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710773}

On the first click on the profile menu we show the local avatar instead
of GAIA avatar for signed in accounts. To fix that, we load the GAIA
image from disk on startup if needed.

Bug: 1017445
Change-Id: I43739a4da1f3dd2729c5aa6082fa23be0512038c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888030Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710772}

This reverts commit fa7708ed.

Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/12814

Original change's description:
> Move sharing messages to sync protocol directory.
> 
> Bug: 1018129
> Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Richard Knoll <knollr@chromium.org>
> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710768}

TBR=mvanouwerkerk@chromium.org,mastiz@chromium.org,knollr@chromium.org

Change-Id: Ic9cc83a44b50f18af9e806bd7a74a318761a385b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1018129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890533Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710771}

The three last tests time out because handleEvent exceptions are not
passed on.

Bug: 1014421
Change-Id: I2349cb92968e375e5af2befaeea49abd1ec584d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889972Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710770}

BUG=1019670

Change-Id: I9a30133e4438819bb418b880feb07488cd3a4aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890630
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710769}

Bug: 1018129
Change-Id: I1aa4d71364fd9324770807ec5c0edb11a5939e0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890410Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710768}

This was added in r422176 as a bug fix, but the original author doesn't
recall specifically what it fixed, speculating that it might be related to
a bug that caused searches not to terminate in some cases.

This interacts poorly with last year's refactor to use idle tasks for find,
causing a great deal of "final" updates per frame. I think it's likely that
the original bug was addressed by the same refactor, but if not, removing this
code will smoke it out so we can document *why* we need it.

Bug: 1015818
Change-Id: I8234aa3788b24ce54ae75120c8d1e00c6ed31d3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888090Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710767}

This is a reland of b40da6df

TBR=asvitkine@chromium.org

Original change's description:
> Lift fallback font unittests to share them across platforms
>
> This CL is lifting the parameterized unittests originally
> wrote for windows to a common file to be available to
> other platforms.
>
> Test from KnownExpectedFonts will now also run on Linux.
>   * Added the test cases for linux.
> Test from Glyphs are now running on every platforms.
>
> Adding a matching_glyphs count to font_fallback_linux.cc.
> Previously, a default font was returned for a single character
> even if it was not matching the character, it was still the
> best match. If no codepoints are found, the font is considered
> a no match.
>
> Change-Id: Ie4f871281737e254bbdbea9e04f8e527f1049569
> Fixed: 3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879956
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710364}

Change-Id: Ie05d48f95834913b859d46e452965df00351649c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888185Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710766}

Remove kInternalIPC task type.
- If it's used to bind associated interface, use
  kInternalNavigationAssociated instead.
- If it's used to bind non-associated interface, use the task source
  mentioned in the spec or kInternalDefault if it's not speced.

R=haraken@chromium.org

Change-Id: I2ddb25f5b65874c32ba3f54a41dc4494927043cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887614Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710765}

This CL adds a new histogram BackForwardCache.HistoryNavigationOutcome.
BLocklistedFeature to record blocklisted features when a page cannot be
put into the cache due to them.

Bug: 1004676
Change-Id: I96f9789cdeb7f176c802ede764124cd5ac177880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871493
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710764}

This CL implements phase 8 on the design document [1].

[1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/

It moves from content/renderer/media/webrtc to Blink the following
files:

- rtc_peer_connection_handler.cc | h | test
- webrtc_set_description_observer.cc | h | test
- peer_connection_tracker.cc | h | test
- media_stream_track_metrics.cc | h | test

The following unit tests are also moved to Blink, although not
accompained of their respective source and header files (already in
Blink).

- peer_connection_dependency_factory_unittest.cc
- rtc_peer_connection_test.cc

It is also worth it to mention that
testing_platform_support_with_web_rtc.cc and .h (both in
renderer/platform/testing/) got adapted now that the
blink::Platform method they relied on got removed:
instead of overriding Platform::CreateRTCPeerConnectionHandler(),
RTCPeerConnection gets a static factory setter method that tests
can use to override how RTCPeerConnectionHandler is created.
The method is named SetRtcPeerConnectionFactoryForTesting() and is used
in scheduler_affecting_features_test.cc and rtc_peer_connection_test.cc
(twice).

For completeness, this CL has a series of predecessor CLs,
being the following ones below the most relevant:

- crrev.com/c/1845802 - Lazy initialize PeerConnectionTracker
- crrev.com/c/1831197 - Migrate PeerConnectionTracker and
                        PeerConnectionTrackerHost to Mojo

Note that the CL opens the door for various follow up, including:

- Migration of base::Bind to WTF::Bind.
- Migration from std::string to WTF::String.
- Migration for stl structs (eg vector, map) by their WTF's counterparts.
- Reduce the API footprint
- Clean up if content/tests/BUILD WebRTC dependencies.
- ...


Bug: 787254

Change-Id: I49d6f84c747eb944ec55665722fc4046d14f66cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842414Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#710763}

The patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1854901

was reenabling the tests:
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverDedicatedWorker
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverNavigate
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverServiceWorker
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverSingleConnection
- IndexedDBExecutionContextConnectionTrackerBrowserTest.ObserverTwoLocks
- LockManagerBrowserTest.ObserverDedicatedWorker
- LockManagerBrowserTest.ObserverNavigate
- LockManagerBrowserTest.ObserverServiceWorker
- LockManagerBrowserTest.ObserverSingleLock
- LockManagerBrowserTest.ObserverStealLock
- LockManagerBrowserTest.ObserverTwoLocks

on Android KitKat.

They are still failing => disabling them again.
https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/18113

TBR=fdoray@chromium.org
CC=ahemery@chromium.org,fergal@chromium.org,altimin@chromium.org
R=arthursonzogni@chromium.org

Bug: 1019659,1011765,1014015
Change-Id: I5be59757f1f37d58150700c331c22cbd8343187f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890071Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710762}

We are going to be asking cookies accessible in 3rd party contexts to be
marked as samesite=none and secure, so make tests that want such cookies
(if only to test them being blocked by preferences) set those attributes
and use HTTPS.

Bug: 1006816
Change-Id: I3c4b58de2b75736b85ce87b694c57fd8db04cbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873154Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710761}

Supposed to be fixed

TBR=antrim@chromium.org

Bug: 1003772
Change-Id: If9f00577aced44ddf0de36c89e5961a3d152a300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890037Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710760}

The ARTICLES ModelType was never launched and all the code has been
removed.

Bug: 965503
Change-Id: Ifb1841d875ff6ee5f6d8d0a001efb6e69c83c281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872587
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710759}

WontFix along with the other tests for the unimplemented feature.

Bug: 246571
Change-Id: Ia3da325693993eba36c1a5685c547631f7f628e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889971Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710758}

InvalidatorRegistrarWithMemory is the main "real" implementation of a
registrar, so it's important to run any tests on this one.

Previously, the tests were only instantiated for
DeprecatedInvalidatorRegistrar (which is deprecated and will hopefull be
removed soon) and for InvalidatorRegistrar (which is a base class of
InvalidatorRegistrarWithMemory that is never used directly).

Bug: none
Change-Id: I591442c0cff1b10d8e17cf6d7f63f3d470154545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890034
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710757}

This CL checks that the apps have been loaded before checking if
an app exists in the apps list. It also handles a race condition
where the dom-switch element's onRouteChanged is called before
the dom-switch has a child loaded.

Bug: 1014919
Change-Id: Id0712b74b006580bfbed2c701a3e61320094a036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889274
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710756}

virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html
is still flaky on Mac [1].
[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual/threaded/external/wpt/animation-worklet/stateful-animator.https.html

TBR=yigu@chromium.org
NOTRY=true

Bug: 1014810, 1014812
Change-Id: Ib6811c0f14fbfcecff0d5d151ae446afbda5e98d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890615Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710755}

Remove the extra space at bottom of NTP article cells if no image is
displayed.

Screenshots:
normal-font-top:
https://drive.google.com/open?id=11r17WFEdLeN2nr5lXAbidq0d6Pfa-2g4
normal-font-bottom:
https://drive.google.com/open?id=1Ss-R_HLKEN5I8HpP4vdWDl3FeCm47CyK
a11y-font-top:
https://drive.google.com/open?id=1IS1_NoZKGBDEmU2jsVNWY6e6VBD4jkkr
a11y-font-bottom:
https://drive.google.com/open?id=1bTPAeXJPjR8qHpeP5Z_5MAaziUypbj8J

Bug: 1003693
Change-Id: I3e38560a28636850b41400a5099f3f2ad320b11d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889652Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710754}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/46994599..f752e377

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8f53cd18fbb8af769885bb3c90bf8bd358d41ad3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890230Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710753}