GitLab

Also fixes a few cpp lint warnings. No functional changes.

Bug: 1010217
Change-Id: If2e666a7b57f92a0f8dce2c1b81957d89adc9122
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416848Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807989}

Bug: 1100728
Change-Id: Idfdd5c7f2e94c0c37665184e21c98ad01c344002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410843
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807988}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Change code in //third_party/libxml to check the platform before
adding plaform-specific source files to "sources" variable and
clear the filter to prevent regressions.

Bug: 1018739
Change-Id: Iba4ae10ec163ce8b7ba3774cd47ebba7ad92f29a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416350
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807987}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009170800_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/NN70vifSGSlhJi3jDlfT0co1BUiUANxx_Let7QT03BUC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: I2856f90f9b259945cf7a0e3f64899c3a3766dae3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416801Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807986}

Hide ambient mode art gallery settings unless they are allowed
by finch params.

BUG=b:167458920

Change-Id: I367ad1d37fab2629ed219721ec2dd4558b7d395f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399578
Commit-Queue: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807985}

set_sources_assignment_filter() is considered as a mis-feature
of gn (as it makes it difficult to reason about the BUILD.gn
files individually).

Change code in //services/network to check the platform before
adding plaform-specific source files to "sources" variable and
clear the filter to prevent regressions.

Bug: 1018739
Change-Id: I37d58eaef7570af3a5af40a2e36cff87a3db54fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416076
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807984}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d340f4f1fe05..6f0602162fdd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC collinbaker@google.com,waffles@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1027613,chromium:1129089
Tbr: collinbaker@google.com,waffles@google.com
Change-Id: I982ea2c774841986e5e814e8503a7b19cfb1eff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416806Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807983}

This change adds new events with disabled-by-default-histogram_samples
category to trace.
No new metrics will be calculated unless --experimental-tbmv3-metrics
flag is supplied.
For the effect of enabling disabled-by-default-histogram_samples
category, see https://crrev.com/c/2363747

TBMv3 UMA metrics: tools/perf/core/tbmv3/metrics/uma_metrics.proto

Pinpoint results (rendering benchmark):
 - lunux-perf:
 - - https://pinpoint-dot-chromeperf.appspot.com/job/17ff0df5920000
 - - (rerun) https://pinpoint-dot-chromeperf.appspot.com/job/133badbd920000
 - - (tbmv3) https://pinpoint-dot-chromeperf.appspot.com/job/1649f905920000
 - win-10_laptop_low_end-perf:
 - - https://pinpoint-dot-chromeperf.appspot.com/job/17c055ed920000
 - - (tbmv3) https://pinpoint-dot-chromeperf.appspot.com/job/150ecc35920000
 - android-pixel2-perf:
 - - https://pinpoint-dot-chromeperf.appspot.com/job/100100dd920000
 - - (tbmv3) https://pinpoint-dot-chromeperf.appspot.com/job/131d55d5920000
 - android-go-perf:
 - - (tbmv3) https://pinpoint-dot-chromeperf.appspot.com/job/17354c30520000

Bug: 1119834
Change-Id: I71379f16430674999bd3615722a1a446b1714f6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388201Reviewed-by: Deep Roy <dproy@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Julia Semavina <nuwanda@google.com>
Cr-Commit-Position: refs/heads/master@{#807982}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll
Please CC bsheedy@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: bsheedy@chromium.org
Change-Id: I9c2ff22d69f74242c88168ffcb1f414a75da6d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416955Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807981}

This reverts commit 82523b39.

Reason for revert: LintTest breaks compile here https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14988

Original change's description:
> Android: Add lint regression test (reland)
> 
> New API related checks are some of our most valuable lint checks, as
> triggering an error causes a crash directly.
> 
> This CL adds compile test targets to ensure that code with API level
> errors trigger lint warnings. This prevents lint being accidentally
> turned off.
> 
> Also delete now obsolete //build/android/lint directory and remove some
> already-fixed suppressions from lint-suppressions.xml.
> 
> This is a reland of 3f2f2acf with
> missing LintTest.java added back.
> 
> Tbr: mheikal@chromium.org
> Bug: 1108309
> Change-Id: Ic5ac63ccd8aac2ebd3193d26294b8e27b233c903
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416575
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807963}

TBR=wnwen@chromium.org,mheikal@chromium.org

Change-Id: I72013a4a8ddc6f15da461674acce98a6afd348f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1108309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416743Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807980}

On Windows, the AlternativeBrowserPath policy can now be set to
"${edge}", to open Microsoft Edge instead of IE.

This will display the browser name as "Microsoft Edge" on the
interstitial before opening it:

https://i.imgur.com/Qr1rPs4.png

Bug: 1124758
Change-Id: Ibe3c24b209c1054510cceb4b0237cf068acb84ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414621
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807979}

The code has moved, so update the includes.

R=avi@chromium.org

Bug: 1091083
Change-Id: I2aebeaf00c033f4038a136e21b1a8d9f630bd816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413559
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807978}

Making a change to the TimeToFirstBitmap to more closely align with
registerFinishNavigation() which should hopefully eliminate some
outliers.

Change-Id: Iddd8ad2b62d8b5344040e130e62910840458c873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416669Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807977}

https://skia.googlesource.com/skia.git/+log/e6467c88b64d..dd16cb59745a

2020-09-17 mtklein@google.com Add SkVx.h to core.gni
2020-09-17 robertphillips@google.com Add plumbing for the GrThreadSafeUniquelyKeyedProxyViewCache
2020-09-17 mtklein@google.com Revert "update skvx scalar-fallback strategy"
2020-09-17 mtklein@google.com Revert "refactor any()/all(), ptest for all()"
2020-09-17 mtklein@google.com slightly simplify skvm interpreter asserts
2020-09-17 mtklein@google.com refactor any()/all(), ptest for all()

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1108408
Tbr: scroggo@google.com
Change-Id: I0cc0de55a032825ff8dc94c9247da257866313ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416807Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807976}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dbc042b1..f10f8691

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2cffaab64fe97e9c340db97ceeaec26f7de219a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416257Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807975}

Remove all unexpected attributes from shortcuts pointing to the current Chrome binary.

Bug: 970253
Change-Id: Idfaf5cadfd8e3641f8c6593fb0f0796dce981e2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410922
Commit-Queue: Veranika Liaukevich <veranika@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807974}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b82a1e239de5..bf3ca769044b

2020-09-17 hcutts@chromium.org cros: add `help` subcommand
2020-09-17 saklein@chromium.org service/test: Check test packages directory exists.
2020-09-17 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-16 yueherngl@google.com chromeos_config_boards: add puff-macrophage into scribe_boards
2020-09-16 chrome-bot@chromium.org Update config settings by config-updater.
2020-09-16 lamontjones@chromium.org Correct config syntax.
2020-09-16 lamontjones@chromium.org luci-scheduler: allow bb-schedulers to trigger.
2020-09-16 sidereal@google.com chromite: Stop uploading debug symbols in tatl/tael-full builders

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I49163dca536d35be6cbcf1596bf076e1c76ef7ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416793Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807973}

Including GPU, GPU.FYI, Dawn and SwANGLE builders for trunk and M85.

This is 2nd CL out of 3 moving GPU Linux, Android, CrOS builders GCEs into
luci.chromium.gpu.ci pool.

1. crrev.com/i/3274057
  Allocate GCEs in luci.chromium.gpu.ci pool and increase chrome-gpu quota
2. This CL:
  Switch GPU Linux, Android, CrOS CI builders to trigger tasks in
  luci.chromium.gpu.ci pool
3. crrev.com/i/3274058
  Remove GCEs from luci.chomium.ci pool and decrease chrome-desktop quota

Bug: 1128643
Change-Id: I26c23ea906d4f6ad4300cc51114debdede42915f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415043Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807972}

Comment in ChromeMetricsServiceClient::Initialize says to remove
cleanup code for kCrashReportingEnabled after M60.

Considering it's now M87, it should be safe to remove

Change-Id: Ic57abb7e439d9d43c154d355c4d00ac1c28f4eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416873
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Joshua Berenhaus <joshber@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#807971}

Bug: 1005651
Change-Id: I0e90b7e5faef550a3dec788a8f83d90362a603b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416290Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807970}

Using wpt-import in Chromium 5a885b23.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=robertma@google.com

No-Export: true
Change-Id: I14cb13a032a9a82c3602f54e5fdc5cc291eca0d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416255Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#807969}

This reverts commit 1c3c18d5.

Reason for revert: No longer needed after getting useful reports.

Original change's description:
> net: DumpWithoutCrashing for invalid header name
>
> Add a temporary DumpWithoutCrashing for when an invalid header key is
> set. This is to debug crbug.com/1028189 where a header key fails to
> deserialize correctly.
>
> Bug: 1028189
> Change-Id: I8848f1b4b78363b56babd787d73f24f8c11dec3c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401278
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Bo <boliu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805369}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1028189
Bug: 1129397
Change-Id: I83a31e47d891937458e7f9a69cdf9ef58704fddf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416868Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807968}

Bug: 1128703
Change-Id: I55ef33e7bd43648204a041bb92fb03cb65b2150e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414782
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807967}

This CL fixes a bug in the StartWeakCheck(). The bug was that we passed
to BindOnce |base::span| of password forms that were read on another
thread. It created a shallow copy of the password forms. Now, we pass to
BindOnce a |base::flat_set| of passwords that are deeply copied.

Bug: 1119752
Change-Id: I59f32a494e27f2ce50f0e615aabcd14c13f893c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414238
Commit-Queue: Irina Fedorova <irfedorova@google.com>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807966}

This reverts commit fd0d170e.

Reason for revert: With crrev.com/c/2410653, the test suite should work fine on "user" build now

Original change's description:
> emulator: Temporarily remove chrome_public_test_apk from Pie
>
> There is an issue with root on "user" build.
>
> Bug: 1126536
> Change-Id: Icac9a9194dc95bd477fe3cf2d3e44e409743f318
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401327
> Auto-Submit: Haiyang Pan <hypan@google.com>
> Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#805446}

TBR=liaoyuke@chromium.org,hypan@google.com

Bug: 1126536
Change-Id: I978d2d13b569dd41b0d5c7cd4105835b6d81cf2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415140Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#807965}

This allows calling these functions when running under roboelectric.
This is necessary as when running under roboelectric the implementation
is not loaded and it doesn't run on a device.

BUG=1128312
TEST=none

Change-Id: Ib96cd68b8ff22f0046d6a96f8b1ca6ba203f418c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414775Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807964}

New API related checks are some of our most valuable lint checks, as
triggering an error causes a crash directly.

This CL adds compile test targets to ensure that code with API level
errors trigger lint warnings. This prevents lint being accidentally
turned off.

Also delete now obsolete //build/android/lint directory and remove some
already-fixed suppressions from lint-suppressions.xml.

This is a reland of 3f2f2acf with
missing LintTest.java added back.

Tbr: mheikal@chromium.org
Bug: 1108309
Change-Id: Ic5ac63ccd8aac2ebd3193d26294b8e27b233c903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416575Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807963}

This patches make sure the set the |in_store| member of the forms
returned in PasswordStoreChange.
Observers can draw the wrong conclusion about the location of those
forms if the field isn't set properly.

Bug: 1119286
Change-Id: I46d6bc7678f1535418c58cb1df3db151bb263bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416077Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807962}

Bug: 1128133
Change-Id: I1d39a7cd2ad407e68a926b0df17864ed456986d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410848Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807961}

Bug: 1128446
Change-Id: I5553441f4d533d516fdb45955e2be5431cb7a621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416893
Auto-Submit: Dan S <danan@chromium.org>
Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807960}

This reverts commit cbf7394d.

Reason for revert: reland with fix

The original CL works fine on Windows and on Mac x86_64 build. But it
fails on Mac ARM64 build. In the test there's also a variable called
"result", which might caused some naming conflict.

Original change's description:
> Revert "media: Trigger Infobar on Mac ARM on EME query failure"
>
> This reverts commit a98a8fa4.
>
> Reason for revert: causing test failure
>
> Original change's description:
> > media: Trigger Infobar on Mac ARM on EME query failure
> >
> > CDM on Mac ARM is not ready yet. When requestMediaKeySystemAccess()
> > fails on Mac ARM, we reject the promise with "Unsupported platform" and
> > trigger an infobar to notify user. The infobar will be triggered at most
> > once per render process.
> >
> > Since the infobar can only be triggered in the browser process, a new
> > mojo service CdmInfobarService is added. Note that even though there
> > already exists KeySystemSupport service, which is also implemented in
> > the browser process, we cannot trigger the infobar there, because the
> > infobar requires a WebContents context, while the KeySystemSupport
> > service is bound to a render process instead of a render frame.
> >
> > Change-Id: Ia85a1f2b097b0c2d26d12cc3e9363c34a25691a3
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404716
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Reviewed-by: John Rummell <jrummell@chromium.org>
> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#807631}
>
> TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org
>
> Change-Id: Ia3e06b8685f70b3e3e000df2bbf24054bcc97ada
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414759
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#807649}

TBR=ellyjones@chromium.org,dcheng@chromium.org,xhwang@chromium.org,jrummell@chromium.org

# Not skipping CQ checks because this is a reland.

Change-Id: I91a251bd5bfc7f5cae2e9e70c380e727f913eaa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415274
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807959}

Video recording in comment 9 of linked bug.

This CL fills in the UpdateAnimation and EndAnimation stubs.
UpdateAnimation is responsible for letting DeskActivationAnimation know
when to request a new screenshot. This is done by checking the bounds
of animation layer after updating, and seeing if it is about to pass
the visible region.

Adds a new method GetIndexOfMostVisibleDeskScreenshot. This checks
which screenshot layer is most overlapped with the root window bounds
which are visible to the user and returns the associated index. This
index is used to determine which desk to animate to in EndAnimation
and which desk to get a new screenshot in UpdateAnimation.

Test: manual
Bug: 1111445
Change-Id: I38fb3a685fd45b326cbbde79ed1af9250ef8cf30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401839
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807958}

This change stops browser_tests from creating "Cached Theme.pak" files
in the Chromium source tree. These generated files frequently cause
confusion when they are accidentally added to CLs, and linger in the
Chromium repo.

Background: "Cached Theme.pak" is a preprocessed version of a Chrome
theme. It is created in the theme's directory when a theme is loaded,
to speed up future loading.

The chrome/test/data directory contains seed data for tests, including
some sample themes. When browser tests load these themes, the "Cached
Theme" files are created in the chrome/test/data directory in the
source tree.

To prevent this, this change adds method
ThemeService::DisableThemePackForTesting() for browser tests to call
before loading themes from chrome/test/data.

Bug: 852623
Change-Id: Idc0ccfee80b9e9c26cc0f4d5467dadf35f8a85e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403588Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#807957}

BUG=b:168615813

Change-Id: Ie4f7f2c13fd050ceeb28d8b70040ef0c34126e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412831Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Gabriel Marin <gmx@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807956}

When computing the bounding box for fixed-pos layers, the resulting
bounding box was stored on AncestorDependentCompositingInputs in
viewport space (absolute space adjusted by scroll offset). The scroll
offset that was used is the current scroll offset during compositing
inputs update time. Call this ScrollOffsetA. Later during compositing
layer assignment, when computing overlap, the fixed layer bounding box
is converted from viewport space to absolute space by adjusting it by
the current scroll offset. The expectation is that this 2nd scroll
offset is also ScrollOfffsetA. However, in some cases, a compositing
update will be requested that will skip compositing inputs update and
only do overlap and assignment. When the scroll offset changes between
computing the fixed layer's viewport space bounds in the previous
compositing inputs update and the later compositing assignment update,
the wrong scroll offset will be used and the fixed layer bounds will
fail to be converted to true absolute space, leading to overlap testing
errors.

This change addresses this issue by storing fixed layer bounds in
absolute space instead. Note that this issue does not happen when the
CompositingOptimizations feature is enabled as it doesn't use the cached
bounds from compositing inputs update.

Bug: 1124753
Change-Id: I85928386fd43ca0b5a86b34877ef2a4afdabd73a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411693
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807955}

In order to reuse ChromeColorsService in non-NTP contexts, we need to
move the 3p NTP check to the code that can be hit by 3p NTPs but not
by non-NTP clients. SearchTabHelper handles requests from the local
NTP renderer, so it's a natural fit.

The observer for NTP-provider changes was actually redundant, so this
CL removes it. Theme changes are reverted when the NTP navigates away
without calling ConfirmThemeChanges. When the user changes the
NTP-provider to third-party, all Google-NTP will be either:
- closed which will trigger the theme revert (old NTP)
- keep the same state so the user can continue modifying the theme
(webUI NTP)

Bug: 1128451
Change-Id: I3a72ce9ffbaccca580b52e1b43f5b348e9bb9feb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411944
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807954}

screenshot: https://imgur.com/VZbftgo

Bug: 1093185
Change-Id: Ib208423df1ab6d06bf7d7042ed14719816c7a772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410918Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Cr-Commit-Position: refs/heads/master@{#807953}

Bug: 1129482, 1129483, 1129484
Change-Id: Ic512a5f00bff81d1210b1a003ab3429dd30318a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416894
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807952}

Bug: b/165356952
Change-Id: Id93c881a4806aceac17435f97324e0fc9e1ed3b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416730
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807951}

This CL extends a few notification related flags.

Bug: NONE
Change-Id: I0e2d0d642215a34e4252c0cd4196ec17448245f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415329Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807950}