- 20 Jan, 2021 40 commits
-
-
Peter Kotwicz authored
If a strict mode violation occurs in an android.app.Service, the stack sent to StrictMode.OnThreadViolationListener#onThreadViolation() only includes stack frames which occurred in android.app.Service. Stack frames for the call into the android.app.Service are truncated. This is problematic when ignoring strict mode violations such as those from android.content.ContentResolver#setSyncAutomatically where the strict mode violation occurs inside the service called by ContentResolver#setSyncAutomatically(). This CL switches to using Thread.currentThread().getStackTrace() to obtain the non-truncated stack trace on Android P+. The CL also switches to using reflection in order to get a callback for the strict mode violation on the thread which triggered the strict mode violation. BUG=1166997 Change-Id: Iab68f1e849b59725082122f93a8a877c27a89717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637267 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#845076}
-
Frédéric Wang authored
This CL replaces the only use of ShouldTreatURLSchemeAsNoAccess() with a direct call to the corresponding url::GetNoAccessSchemes() API. This removes the need to store a copy of the no-access schemes in SchemeRegistry, which is not kept in sync with the one from url_utils. In particular, this improves consistency between SecurityOrigin's ShouldTreatAsOpaqueOrigin and SchemeHostPort's and fixes the following DCHECK failure when running the test SecurityOrigin.StandardNoAccessScheme added in crbug.com/2602402: [FATAL:security_origin.cc(158)] Check failed: url::SchemeHostPort(protocol.Utf8(), host.Utf8(), port, url::SchemeHostPort::CHECK_CANONICALIZATION) .IsValid(). base::debug::CollectStackTrace() base::debug::StackTrace::StackTrace() logging::LogMessage::~LogMessage() logging::LogMessage::~LogMessage() blink::SecurityOrigin::SecurityOrigin() blink::SecurityOrigin::SecurityOrigin() blink::SecurityOrigin::CreateWithReferenceOrigin() blink::SecurityOrigin::CreateFromString() blink::SecurityOriginTest_StandardNoAccessScheme_Test::TestBody() Bug: 888079, 1021779, 1020201 Change-Id: I7d8481389bd64ccc09f60b31ca6d7291ebedaa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637593Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#845075}
-
Jaeyong Bae authored
This patch means implementing AbstractRange according to specification[1]. The bits shared between StaticRange and Range objects are put on a shared superclass named AbstractRange. And, make the failed the web test[2] successful. [1] https://dom.spec.whatwg.org/#interface-abstractrange [2] https://github.com/w3c/web-platform-tests/pull/9967 Bug: 820947 Change-Id: If9ea0b4d9b3f3fa0c30920e0c1972b76da995453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212290 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#845074}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.99. R=tikuta@chromium.org Bug: 1041619 Change-Id: Iadc8d18152d8694dc1ef40673353f144af502a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638493 Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#845073}
-
Yuichiro Hanada authored
ArcImeService implements a TextInputClient interface to support IME operations on a text field on ARC++. Before this CL, it's used only when a text field on ARC++ apps is focused. ArcImeService should be active also when an inline reply on ARC++ notifications are focused. Bug: 1168334 Test: manual - confirm composing works on inline reply Change-Id: Ib374be7c8325aa6edb62712a0317a25ea893b8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639334Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#845072}
-
Keishi Hattori authored
For 32 bit builds, IsManagedByPartitionAllocNormalBuckets() was declared in address_pool_manager.h But simply including it in checked_ptr.h would balloon the amount of dependencies for checked_ptr.h So I moved everything required to implement IsManagedByPartitionAlloc* for 32bit to address_pool_manager_bitmap.h This reduced the amount of files to exclude from the rewriter to just base/synchronization/lock_impl.h Bug: 1080832 Change-Id: I0f07156f7afc90e49f93e90a23d5d20595d44bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637095 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#845071}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611089910-e382f188ebed1bc5635a69a9ec6a180850db4c4f.profdata to chrome-win64-master-1611100586-ad2b04699cdd99176efdb4f40b969e7a8a4a2181.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idd63d29441f76e21e93c707ed7c0a845d4774a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638868Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845070}
-
Chris Hall authored
Change-Id: Id182e246729a71312fb7e2a661aa91243eedb584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638837 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845069}
-
Kenton Lam authored
The rationale is so tests can wait for this event before testing functionality. Otherwise, tests will always fail because the data takes time to load so the requisite elements haven't been created yet. Change-Id: I5561273c9d17e010083615a6de513cd5c1f32184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636011 Commit-Queue: Kenton Lam <kentonlam@google.com> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845068}
-
Kaiyu Chen authored
This is a reland of 02d1e955 Original change's description: > Add GPayAppDynamicUpdate feature flag. > > The feature flag controls the GPay native app integration for dynamic update on Android. > If this feature flag is enabled, the GooglePayPaymentApp would enable a callback service and handle communications between the native GPay app and the browser for dynamic updates on shipping and payment data. > Design doc is go/dynamic-update-mweb. > > Bug: 1074423 > Change-Id: I898199446179d6c314b833c3ecb8f017481fc596 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628745 > Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844274} Bug: 1074423 Change-Id: Ic1cc2e3f4e6e3bff67246f0ce249196882a9b3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637407Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Cr-Commit-Position: refs/heads/master@{#845067}
-
Seokho Song authored
According to the newest version of CSS standard [1], calc function could return an infinity or NaN value when the expression has an infinity keyword without NaN product (like inf-inf) or the division by zero. Therefore, this initial feature implementation evaluate the expression or keywords infinity value to std::numeric_limits<double>::infinity() and NaN value to std::numeric_limits<double>::quiet_NaN(). Also, this patch contains the infinity and NaN value serialization. Design docs: [2] Feature Status: [3] Intent to prototype: [4] [1] https://drafts.csswg.org/css-values/#calc-type-checking [2] https://bit.ly/349gXjq [3] https://chromestatus.com/feature/5657825571241984 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/4cT9dMkzVXE/m/aCT8B6PDAwAJ Bug: 1133390 Change-Id: Id543e9f9af446de623ecee00ba4a3e03100096b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465414Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Seokho Song <0xdevssh@gmail.com> Cr-Commit-Position: refs/heads/master@{#845066}
-
Muyao Xu authored
Bug: b/175888159, 1117673 Change-Id: I1c63edecfee8128e68ba88e56a65fd1c17283d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597742 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845065}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ib4c0e750632f09a571d83e42f58a808c840ef1c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638862Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1684427cdca..05342ef131e7 2021-01-20 zmo@chromium.org Add Intel Power Gadget support to Telemetry: Part I. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1163250 Tbr: skyostil@google.com Change-Id: I049d72bea1ebcfbec88cb5716ee7088f4dcdd422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638776Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3c15a1f6b71..8c43c3f51384 2021-01-20 ehmaldonado@google.com Reland "[git-cl] Use owners client when processing --[tb]r-owners." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I01f0a27e9fcfec30390c4ad0c44d234a08a7ab8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638733Reviewed-by:
-
Takashi Toyoshima authored
Remove unused WebFont related metrics, WebFont.MissedCache.DownloadTime.*. Bug: 1156195 Change-Id: Ic26e5479737534167aeaf85f1c94e302dcadb00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592229Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845061}
-
Jun Mukai authored
The ChromeOS clipboard used to be synchronously written within the browser process, but now it is asynchronously updated (see ui/base/clipboard/clipboard_ozone.cc for the details). Because of that, autotestPrivate.setClipboardTextData may return earlier than the clipboard data is actually set occasionally. To deal with such case, this CL introduces a clipboard observer to ensure that the clipboard is written. Bug: 1167256 Test: the new test cases Change-Id: I167be3aee090465e30951fbb7a9db688429059c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634121 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845060}
-
Alexander Alekseev authored
This CL enables dynamic UiDevTools creation and adds "Create Ui Dev Tools" button to Ash HUD. Bug: 1138734 Change-Id: I4458f355241ce6c4c43494f9ee14956f0253b30f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535010Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#845059}
-
Jonah Chin authored
This is a reland of 4107e01f Original change's description: > Change texture subset logic in PaintCanvasVideoRenderer > > This CL is to simplify how PaintCanvasVideoRenderer::Cache manages > video frames whose |visible_rect| is smaller than their |coded_size|. > By always using SkImage::MakeFromAdoptedTexture, texture lifetime > management is now always handled internally by skia. This will make the > transition to OOPR here much simpler. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I2177b2deeea893fa5331afbe8796761253db2759 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451213 > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818045} Bug: 1115217 Change-Id: I532715126f23735c72d7282bfc47495ac3da24e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634055Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845058}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I44d864f08a04a4eb90710ec1251843246353f9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638860Reviewed-by:
-
Moe Ahmadi authored
Removes fakebox resources/handlers/tests from the NTP since it's been made deprecated by the realbox. Fixed: 1168269 Change-Id: I03b93330f91413a3efd57be92e5ec62e6d89c778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638536Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845056}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 89.0.4389.6. R=sky@chromium.org Bug: 1041619 Change-Id: I994c655a8e71f486d5c55944a2de3c5553e4dbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638243 Commit-Queue: Rakib Hasan <rmhasan@google.com> Auto-Submit: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Mustafa Emre Acer authored
This CL adds a test case where the upgraded HTTPS URL redirects to another HTTPS URL. The test simply checks if an upgraded HTTPS URL that redirects to another good HTTPS URL successfully loads and records a histogram entry. There are additional interesting cases involving redirects, however it's not yet fully clear how the feature should behave in those cases. For example, an upgraded HTTPS URL could redirect to a broken HTTPS URL. It's TBD whether this should fall back to HTTP or not. For that reason, these cases aren't yet tested. Presently, the autocomplete code does the upgrade from HTTP to HTTPS and it only upgrades URLs with default ports. As a result, browser tests need to use URLs with default ports, so they use URLLoaderInterceptor instead of EmbeddedTestServer. (URLLoaderInterceptor can return responses for URLs with a default port (e.g. https://example.com) whereas EmbeddedTestServer can't.) I wasn't able to simulate a redirect using URLLoaderInterceptor, so this CL modifies the autocomplete code to accept a non-default port as well. It also adds a new test class that uses EmbeddedTestServer to serve the http and https URLs. The rest of the browser tests are unchanged and still use URLLoaderInterceptor so that the codepath that uses the default ports is still exercised. Bug: 1141691 Change-Id: Ic0d0638758bf457fad508ef028144681a7034cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621964 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#845054}
-
Raphael Kubo da Costa authored
The comment about passing parameters by value was added in r429564 ("[sensors] Close mock sensor stubs after test is finished") but was made obsolete by r450741 ("[Sensors] Fix error type and message used"). Change-Id: Ic8c07ce6d2f0b481a64dd706339761eca5d6323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631503 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#845053}
-
James Cook authored
For Wayland debugging, it's helpful to add WAYLAND_DEBUG=client to the lacros environment. Introduce --lacros-chrome-additional-env to set arbitrary additional environment variables when launching lacros. Bug: none Change-Id: Ie44f4edd80459d606216cab733e99027d42fc986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636264Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845052}
-
Esmael El-Moslimany authored
Bug: 1139032 Change-Id: Icea07c79fbad8bf34664f1ce7ce53380beaadd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637262 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845051}
-
Jeffrey Young authored
There was a case when |UpdateSettings| could be called the first time a user opened Ambient mode settings, even when Ambient mode was disabled. Now, only update settings if pref is enabled. Additionally, issue an |UpdateSettings| call when the pref is enabled. This ensures that Ambient settings are synced to server even when a user does not edit temperature settings or photo albums. BUG=b:177456397 TEST=unit_tests --gtest_filter=AmbientModeHandlerTest.* TEST=open settings page, personalization, screen saver, toggle ambient Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I924af998954927f0fc38746b34b8fce1ff641509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631305Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845050}
-
Jiewei Qian authored
This is a reland of 62cb2352 The original CL fails when AppBrowserControllerBrowserTest.Shutdown passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK because the use of GetCreationStatusForProfile already makes sure the DCHECK is always successful. Original change's description: > system-web-apps: implements a new LaunchSystemWebAppAsync API > > This CL implements a new LaunchSystemWebAppAsync API, which is for other > chrome components to launch a SWA safely. This new API should be used > for SWA launches. > > The new API uses AppService to record metrics, handle disabled apps, > etc. > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl). > > LaunchSWAImpl is publicly declared because certain browser tests need to > know the browser that hosts the SWA. It shouldn't be used to launch the > App (other than LaunchSWA and Web app implementations). Subsequent CLs > will attempt to migrate these browsertests to work with the new API. > > Bug: 1154540 > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843939} Bug: 1154540 Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Trent Begin authored
The network ONC strings are used both in //chrome and //chromeos. Strings that are required in both locations need to be moved to //chromeos to prevent a layering violation. Screenshots are added in this change as they were not required when these strings were originally added. This change moves the remaining cellular, tether, and EAP strings. Bug: chromium:1159069 Change-Id: Ifa804cea9be794b8d93091cfd286bb87bd1d7314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638221Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Trent Begin <tbegin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845048}
-
Luciano Pacheco authored
When running as JS module which is strict by default, the code fails to assign to `e.target`. Fix this by declaring a local variable `target` with the desired Closure type markup. Bug: 1133186 Change-Id: I5033eae87310e4eebdae2e2b22487df8ffc01a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636904 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#845047}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I766596592c91c3e226df72b99d4cf53d3d67f7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638859Reviewed-by:
-
Alison Huffman authored
Currently on iOS, DOM Distiller cannot guarantee that the data being sent to it comes from the distillation script. This allows arbitrary HTML to be included in the final reader mode version of the page. This combined with a find-replace-style inclusion of arbitrary origin data sourced from image tags, allows the leaking of cross-origin authenticated pages. This change adds a CSP policy for iOS reader mode, enforces paginations belong to the same origins, includes offline images through JavaScript, and performs mime-sniffing on offlined images to ensure they are valid images. Bug: 1111239 Test: Tested changes with cases provided in bug. Change-Id: Idf9c8986c541bcab32fb8d320ebdf75b55dc7839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608284 Commit-Queue: Alison Huffman <ahuffman@microsoft.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845045}
-
Ryan Heise authored
Bug: chromium:1163679 Change-Id: I5bb4d8efe9317caf328fafb818f12abb5d95f5ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629664 Commit-Queue: Ryan Heise <heiserya@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#845044}
-
Dmitry Gozman authored
This is similar to what chrome/browser/renderer_preferences_util does. Bug: none Change-Id: I1b0b73dca22175446c143497a07c1ad2994e72e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637081 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845043}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e0490eedcc8..192a0147c3fe 2021-01-20 vantablack@google.com Multithreading in D3D11 minimum viable product 2021-01-19 syoussefi@chromium.org Add a helper ShaderVariable method to facilitate member rename If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ie6697d64ca00c7304fb61318cc462d925fdc76fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638779Reviewed-by:
-
Alex Gough authored
This enables the CETCOMPAT linker flag for Windows marking binaries as CET compatible. On supporting hardware this will cause Chrome to run with Hardware Enforced Stack Protection for compatible modules. CET will still be disabled for the renderer process as the feature CetForRenderer is default-disabled. x86 is not supported: build/config/compiler/BUILD.gn:2519 Tests: mini_installer on supporting hardware Bug: 1131225 Change-Id: Ic5db6eca0acf4cdfb0eff0f624e4d4f4e5a7da50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602845Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#845041}
-
Jinsuk Kim authored
Removes the dependencies on the following flags. They are now passed from ToolbarManager through ctors/setters: - TabUiFeatureUtilities.isGridTabSwitcherEnabled() - TabUiFeatureUtilities.isTabToGtsAnimationEnabled() - StartSurfaceConfiguration.isStartSurfaceEnabled() - VrModuleProvider.getDelegate().isInVr() This change allows following toolbar classes to be in the modularized target: - NewTabButton - ProgressAnimationSmooth - ToolbarProgressBar/Test - LoadProgressCoordinator MVC/Test - TabSwitcherButtonCoordinator MVC - TopToolbarOverlayCoordinator MVC - TopToolbarSceneLayer Bug: 1127732 Change-Id: I403421191d5634a02a6ea9a5ca8bbc2daa7681d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631394 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#845040}
-
Michael Savigny authored
Change from 'racing' to 'remote_local_fallback'. Racing needs more testing on CQ/CI before making it the default. Bug: 1149386 Change-Id: I737f27bbd1bcca5b29448882108ad8ec642566ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635345Reviewed-by:
-
Wan-Teh Chang authored
Implement mirroring and rotation of AVIF images by converting the 'irot' and 'imir' image item properties to the equivalent Exif orientation value. The Exif metadata, if present in the AVIF image, is ignored. Add several AVIF test images with the 'irot' or 'imir' image item properties. Check the image orientation in avif_image_decoder_test.cc. Update and fix TODO comments in avif_image_decoder_test.cc. Bug: 1087059 Change-Id: I79c4d325407ce373c849c4e91058f98fd3397ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634311Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ie11c7f3111ee176fb257867c81b0134d7b3547cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638780Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845037}
-
