- 31 Jan, 2018 40 commits
-
-
Vaclav Brozek authored
The bug tracked adding viewing of passwords to iOS settings. There were two remaining TODOs: * An outdated comment in a test. * A refactoring suggestion for trading off code complexity for test complexity (add a delegate API to make a particular EG test a unit test). The refactoring suggestion does not seem justified -- the current EG tests are stable and working well. Therefore this CL removes both TODOs. Bug: 159166 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20658b94b4fa190a2ffa442af6f9f7b4ec1aeed4 Reviewed-on: https://chromium-review.googlesource.com/892818Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533251}
-
Kent Tamura authored
Bug: 648828 Change-Id: If19afe0ad2aa29eb5a042306f260d5eac77e0f0e Reviewed-on: https://chromium-review.googlesource.com/895423Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533250}
-
Christos Froussios authored
Bug: 790990,789561 Change-Id: I89dae77899c27ea166ed75c038a82fe0a1278b9a Reviewed-on: https://chromium-review.googlesource.com/893378Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#533249}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/842d424d..70bfb939 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If391a2158ee94d123222f76d608183c2d579149b Reviewed-on: https://chromium-review.googlesource.com/894309Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#533248}
-
Gauthier Ambard authored
This CL updates the location bar container, updating its background color and its height to follow the fullscreen progress. It also updates BVC so the location bar is always displayed. Bug: 804731 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f5b2a750cf1593c8d4c7f12163a9db90dc34090 Reviewed-on: https://chromium-review.googlesource.com/883283Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533247}
-
Raphael Kubo da Costa authored
Since e1c54ad2 ("Update PromiseRejectionEvent IDL to match latest spec") from more than 2 years ago the code is returning undefined instead of null. Make the comment match the code to avoid confusion. TBR=yukishiino,haraken No-Try: True Change-Id: Ie931aef81fbe7510ccbf7b1c0e3753b32a64e948 Reviewed-on: https://chromium-review.googlesource.com/894384 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#533246}
-
Gauthier Ambard authored
This CL adds the standard actions (cancelling omnibox edit and recording metrics) to all the toolbar buttons. Bug: 806274 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifbc108f852ae5f521343f3ea8065a8637c8afb68 Reviewed-on: https://chromium-review.googlesource.com/893266 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL rotates the tools menu button (3 dots) by 90 degrees. It also rotates the animation when an item is added to the reading list. Bug: 807285 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8553993c8e4b9f38579159087480c1adf82d23e8 Reviewed-on: https://chromium-review.googlesource.com/893360 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
With this CL, when a toolbar button associated with a named layout guide is shown, all the constraints on the named layout guide are removed and the layout guide is constrained to the toolbar button. Bug: 802034 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I967729b7cd939fccd5821d4dfc84df8d3055e587 Reviewed-on: https://chromium-review.googlesource.com/883809Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#533243}
-
Gauthier Ambard authored
This CL changes the scroll view of the WKWebView used in CRWWebViewContentView so it doesn't clips to bound its content. It allows the content of the WebView to be fully displayed on the page, including below the toolbar. Bug: 805845 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3591b354a21ebb7b9f29500bc93f697e37547129 Reviewed-on: https://chromium-review.googlesource.com/887041 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes file encoding of "thai-word-at-document-end.html" to UTF-8 from UTF16-LE to make git and tools to recognize it as text file instead of binary for ease of maintenance. There is another instance in WebKit: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/editing/selection/thai-word-at-document-end.html TBR=yosin@chromium.org NOTRY=true Change-Id: I64d9318db55c73a17a6154336e7ac35faee73c52 Reviewed-on: https://chromium-review.googlesource.com/895216 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Christopher Cameron authored
When allocating an anonymous IOSurface-backed GLImage, we have the sequence of calls - IOSurfaceCreate - IOSurfaceCreateMachPort - IOSurfaceRelease (implicitly in ScopedCFTypeRef<IOSurfaceRef>) - IOSurfaceLookupFromMachPort The final call persistently fails on some machines. This adds a CHECK when that call fails, so we can assess how often it occurs in the wild. This also adds a call to IOSurfaceCreateMachPort and IOSurfaceLookupFromMachPort before the implicit IOSurfaceRelease, to see if this may be the result of a reference counting bug. Add lots more LOG(ERROR) spew to help further diagnose this. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie630067759d0bdf096be907986e53afdc632b15d Reviewed-on: https://chromium-review.googlesource.com/895142 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#533240}
-
Katie D authored
This fixes a bug with absolutely positioned webviews in apps such as Hangouts. Note that AutomationApiTest.LocationInWebView fails without the change to AXLayoutObject.cpp. Bug: 801995 Change-Id: I1a3e8e66f3f64b7ec6f619076374438aad901d65 Reviewed-on: https://chromium-review.googlesource.com/894182Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533239}
-
Alexandr Ilin authored
This CL reenables SpeculativePreconnect field trial since the fix https://crrev.com/c/778899 addressing performance regressions was landed. The predictors::kSpeculativePreconnectFeature is explicitly disabled in net::Predictor browser tests because the LoadingPredictor if enabled intercepts all prefetch and preconnect coming from a renderer. Bug: 699080 Change-Id: Id5e4bb785943e1963f2a6a8802f738f491bb7544 Reviewed-on: https://chromium-review.googlesource.com/893459Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533238}
-
Friedrich Horschig authored
This CL completely drops all UI elements that previously popped back in when the results are empty. Reason being, that 1. the link would redirect the user to the same passwords that are synced to the device they are using right now. 2. the "Saved passwords appear here" text would indicate that the user hasn't saved any passwords yet which is not correct. (Another text is not necessary as the interaction with the search field should give enough context for the empty list). Bug: 807300,807302 Change-Id: Ice2dab3a5f6ee280a33ef559d540cc0ca6e082cc Reviewed-on: https://chromium-review.googlesource.com/894002 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#533237}
-
Yuta Kitamura authored
WebTaskRunner is being deprecated. Use SingleThreadTaskRunner instead. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id7550222db748583b9e7fc1449a14964b9a497c3 Reviewed-on: https://chromium-review.googlesource.com/895064Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#533236}
-
Kent Tamura authored
The function contains autonomous custom element processing. It's unexpected in many cases. If it's called with known HTML tags, custom element processing is unnecessary and it should be replaced with Document::CreateRawElement(). If it's called with arbitrary tag names, custom element processing is necessary and it should be replaced with Document::createElement(). This CL is a preparation to remove HTMLElementFactory::createElement(). Bug: 806641 Change-Id: I00dae6c2cdac18eccd1580a72d94862b5cb2d657 Reviewed-on: https://chromium-review.googlesource.com/895203Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#533235}
-
Kent Tamura authored
Add custom built-in element support to <embed>, <object>, and <form>. Bug: 805281, 806184, 806185, 806187 Change-Id: I920ea11ed0b5884c69d3c1aee04e18f7fa62e9f2 Reviewed-on: https://chromium-review.googlesource.com/895234Reviewed-by:
-
arthursonzogni authored
This fixes https://crbug.com/796561 and adds a regression test. The issue was a race between the browser and renderer processes while updating the renderer's history. The renderer's history is updated in * RenderFrameImpl::CommitNavigation and in * RenderFrameImpl::DidCommitProvisionalLoad. ┌────────┐ ┌───────┐ │Renderer│ │Browser│ └───┬────┘ └───┬───┘ │ BeginNavigation │ │ - url=iframe.html │ │ - history_offset = 0 │ │ - history_length = 1 │ 1) │ ──────────────────────────> ┐ │ │ │ │ DidCommitProvisionalLoad │ │ │ - "pushState" │ │ │ - history_offset = 1 │ │ │ - history_length = 2 │ │ 2) │ ──────────────────────────> │ │ │ │ │ CommitNavigation │ │ │ - url=iframe.html │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ │ ┌─│ <───────────────────────────┘ │ │ │ │ │ DidCommitProvisionalLoad │ │ │ - url=iframe.hmtl │ │ │ - history_offset = 0 │ │ │ - history_length = 1 │ └>│ ──────────────────────────> ┌───┴────┐ ┌───┴───┐ │Renderer│ │Browser│ └────────┘ └───────┘ What happens in the bug. 1) An iframe is created: [history.offset = 0, history.size = 1]. 2) history.pushState: history is updated [offset = 1, size = 2]. 3) CommitNavigation is received, history is updated using the old values transmitted in 1) with BeginNavigation. This CL update the values sent in CommitNavigation. This reduce considerably the duration when the race can happen. Before this CL, the race could happen if a history.pushState is sent in between BeginNavigation and CommitNavigation (~300ms <-> severals seconds). After this CL, the race happens if the history.pushState is sent between when the CommitNavigation message is sent and when it is received by the renderer process. Bug: 796561 Change-Id: I7bf72fadbf9f4946da28126a394adddf051f49a8 Reviewed-on: https://chromium-review.googlesource.com/881171Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533233}
-
Donna Wu authored
This will eliminate the observer needing to make an immediate async call back to the MediaTransferProtocolManager to obtain the MtpStorageInfo object from its identifier. This is a preparation work for MTP servicification. BUG=769630 Change-Id: I239ed96d42c4e496f97d311a689704e34c55edda Reviewed-on: https://chromium-review.googlesource.com/882494 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533232}
-
Lutz Justen authored
ADMX files were not loaded into the GPO editor properly for most languages because the directory names were bad, e.g. should be 'it-IT' instead of 'it'. This CL fixes the directory names according to the doc mentioned in the bug below. For a few languages the mapping was not clear: 'am', 'fil', 'ml' - Not in doc; kept the old directory names 'ar' -> 'ar-EG' - Picked EG as the biggest of the ~15 Arabic countries 'bn' -> 'ms-BN' - Is this correct? There's no bn-XX in the doc. 'sr' -> 'Cy-sr-SP' - Is this correct? Translations look cyrillic. BUG=chromium:806577 TEST=Changed components/policy/BUILD.gn to build for all platforms, ran ninja -C out/Release -j 2000 policy_templates Loaded de-DE into GPO editor on Windows Change-Id: I574f6241b152c64943ec39442e2e23f7cae636cf Reviewed-on: https://chromium-review.googlesource.com/893567Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#533231}
-
Kenneth Russell authored
Try to get to the bottom of situations where jobs seem to be going to an oversubscribed configuration. TBR=jmadill@chromium.org, jbudorick@chromium.org Bug: 807340 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2161d42d980c9b5bc8a9acfbe74e11ad7fa037b0 Reviewed-on: https://chromium-review.googlesource.com/894450 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533230}
-
Koji Ishii authored
Following bot results are included. 3397 3408 3410 3411 3417 TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I009607c87ea2be1e3518e9a0d50aef4db2afd3e4 Reviewed-on: https://chromium-review.googlesource.com/892758 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#533229}
-
Darren Shen authored
We change CSSVariableReferenceValue to reject invalid custom property names as per spec. We also remove .tentative extension from related tests. We also remove some unit tests that are replaced by WPTs. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue Bug: 545318 Change-Id: I95cfe1c167a60c94083a1474b384fd584d05cca9 Reviewed-on: https://chromium-review.googlesource.com/895124 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#533228}
-
Gabriel Charette authored
This reverts commit 0aa36d96. Reason for revert: landed prior to receiving LGTM, CL is NOT LGTM to gab@ https://chromium-review.googlesource.com/c/chromium/src/+/892582#message-1f3ca486683a18c2df48642825a99cee199034bc Original change's description: > Simple code cleanup. > > Passed PrefRegistry and PrefRegistrySyncable by raw pointer instead of reference > to scoped_ptr. PrefRegistry and PrefRegistrySyncable have an internal reference > count. There is no need to use a double indirection when passing them around. > > Used base::MakeRefCounted instead of naked 'new' operator. > > Change-Id: I53a0fdfc99b7ef3dd32b191664520659c2585fa5 > Reviewed-on: https://chromium-review.googlesource.com/892582 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: François Degros <fdegros@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533087} TBR=sky@chromium.org,gab@chromium.org,erg@chromium.org,fdegros@chromium.org Change-Id: I082b80ef79afd99f093ac8327381ee1293351cfd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/895362Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#533227}
-
Kenneth Russell authored
From talking with iannucci@, this is the easiest way to use vpython with these tests on the bots. Once the LUCI conversion is done, this will be a no-op, and can be removed. Incorporate the newly deployed pyobjc wheels into Chromium's root .vpython; they are needed by helper scripts in the GPU directory. Bug: 776804, 804174 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c720a9f7992e411aa85bcc7959de95ecc03c1f5 Reviewed-on: https://chromium-review.googlesource.com/869512Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533226}
-
Jaebaek Seo authored
Enabling --use-zoom-for-dsf causes MainThreadEventQueueBrowserTest.TouchMove failure because of a precision issue. We expect that window.lastTouchMoveEvent.touches[0].pageX has 35, but it is 34.6666 when the device scale factor (DSF) is 2.625. It is because LocalFrameView::ConvertFromRootFrame() called by TouchEventManager::CreateDomTouch() (that sets pageX|Y) floors the pageX|Y (i.e., point_in_root_frame). This CL removes the flooring on pageX|Y by adding FloatPoint variants of all co-ordinate space conversion APIs and updating FloatPoint LocalFrameView::ConvertFromRootFrame(const FloatPoint&). TEST=content_browsertests MainThreadEventQueueBrowserTest.TouchMove on NEXUS 5X Bug: 737777 Change-Id: I6c8fb12e4f2fb4c38328ef9f18529e6559f91d43 Reviewed-on: https://chromium-review.googlesource.com/885321 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533225}
-
Bill Orr authored
The issue here was that glBlitFramebufferANGLE fails when the color formats of the source and destination image aren't compatible. The color format for pBufferSurfaces wrapping dxgi textures has changed to report the underlying dxgi format instead of the egl config used to create the surface, so we were sometimes failing to copy the WebGL contents onto our cross-process-sharing texture. The fix is to use CopySubTextureCHROMIUM instead of blitting framebuffers. This API won't create new destination textures, and will convert formats for us. It also has the benefit of handling flipping y-direction for us, so we could avoid a copy. BUG=804628 Change-Id: Ibc55dd092bacbdd1f751adb0b6a854f58e64e22b Reviewed-on: https://chromium-review.googlesource.com/892091Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
-
Christopher Lam authored
Bug: 807216 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2b2d3a0b9c8b3b1f74fae4c38bded90022485f33 Reviewed-on: https://chromium-review.googlesource.com/895223Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#533223}
-
tanvir.rizvi authored
InsertNodeBefore crashes if the passed ref_child is disconnected. Bug: 755808 Change-Id: I4c07836b6d0f055f2cdfd8f94c326fcaaf03d6ca Reviewed-on: https://chromium-review.googlesource.com/893243Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Cr-Commit-Position: refs/heads/master@{#533222}
-
Kent Tamura authored
createElement() should assume the namespace is XHTML only if the document is HTML-like. New behavior matches to the standard and Firefox. Bug: 807514 Change-Id: I1164612b6512c94de96bdefbf053e8f132f8b9f7 Reviewed-on: https://chromium-review.googlesource.com/894749 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominic Cooney <dominicc@chromium.org> Cr-Commit-Position: refs/heads/master@{#533221}
-
Zhuoyu Qian authored
This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Iefb3980ce006b1f69c326c639134fe2b7bf6426e Reviewed-on: https://chromium-review.googlesource.com/895023Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
PopupZoomerTest doesn't need a test ImeAdapter and InputMethodManagerWrapper instance in CVC for its tests to pass. Previously the tests needed a mock instance to avoid NPE, but CVC was refactored not to require it. This CL deletes the code setting the test instance to CVC. Change-Id: I602f475e2b0e5e76883f980564e7e137b185c823 Reviewed-on: https://chromium-review.googlesource.com/894964Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#533219}
-
Ramin Halavati authored
After fixing the following two files, the trybot test on Linux are reactivated: 'tools/clang/pylib/clang/compile_db.py' 'tools/traffic_annotation/scripts/check_annotations.py' Bug: 690323 Bug: 807146 Change-Id: Id769e4bb4e5d416eb04e2436d38cec5af04606ec Reviewed-on: https://chromium-review.googlesource.com/891960 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533218}
-
Tatsuhisa Yamaguchi authored
While 1+ incognito browser windows are opened, it'll have separate Files app extension background and foreground scripts running. The ones in the incognito context should only be visible by the file picker window invoked by the browser, but should not show fullscreen app windows or notifications. This fix prevents opening a new Files app. window in incognito context in these cases: - When mounting a new zip file as a volume - When reopening a zip file already mounted (which navigates the current window to it) Bug: 800543 Test: manually Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3deccef39a9db61e6ff4d035a6de19c7309d113 Reviewed-on: https://chromium-review.googlesource.com/888192Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#533217}
-
Tarun Bansal authored
Bug: 704339 Change-Id: Idce639d844d07252c2618ceb34a589964723ccc4 Reviewed-on: https://chromium-review.googlesource.com/891806Reviewed-by:
-
David Vallet authored
Bug: 805445 Change-Id: I7051f519205e178db57e23320ab979f8fa9ce38b Reviewed-on: https://chromium-review.googlesource.com/894782 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#533215}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27e3a1f6..842d424d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I64c8d498b616f10713d94f18381595001960092d Reviewed-on: https://chromium-review.googlesource.com/894225Reviewed-by:
-
Yixin Wang authored
net_unittest failure on android_cronet due to missing test app dependency should no longer occur after this CL: https://chromium-review.googlesource.com/c/chromium/src/+/893681 First reland: https://chromium-review.googlesource.com/c/chromium/src/+/891302 Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/887970 Bug:807283 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I622f074ad3d3ec89b78d754367285da52850e527 Reviewed-on: https://chromium-review.googlesource.com/893625Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#533213}
-
Erik Luo authored
Some default experiments were removed - Accessibility inspection - Log management - Performance monitor Bug: none Change-Id: I97bc4ac1883cdb0001fb807f56009c54ca7773b3 Reviewed-on: https://chromium-review.googlesource.com/882312 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
