GitLab

This reverts commit fa4a217a.

Reason for revert: failing the following tests on https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13197

HeapCollectorCollectionParamsTest.ParametersOverride_Tcmalloc
HeapCollectorTest.CheckSetup_Tcmalloc
HeapCollectorTest.DumpProfileToTempFile_Tcmalloc
HeapCollectorTest.IncognitoWindowDisablesSamplingOnInit_Tcmalloc
HeapCollectorTest.IncognitoWindowPausesSampling_Tcmalloc

Original change's description:
> Make the new tcmalloc the default for Chrome OS
> 
> The new tcmalloc has been enabled on three Chrome OS boards since R72,
> and on ten additional boards accounting for over 50% of users in the
> wild since R75. It has also been the default on Linux for over one month.
> 
> BUG=chromium:724399,b:70905156
> 
> Change-Id: Id1f49f66a963c9a327edeee3e85d0d128c9de78c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630233
> Commit-Queue: Gabriel Marin <gmx@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664303}

TBR=dpranke@chromium.org,halliwell@chromium.org,gmx@chromium.org,jasonroberts@chromium.org

Change-Id: I1725b05e1c363b801e6ad7dac303ec3c6cb85c39
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:724399, b:70905156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636589Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664489}

With this CL, a task posted with:

base::PostTaskWithTraits(
    FROM_HERE,
    {base::TaskPriority::BEST_EFFORT, ...},
    base::BindOnce(...));

Will not be allowed to run before startup is complete.

The signal used to know that "startup is complete" is the same as
AfterStartupTaskUtils. It is not perfect. It will be improved in a
separate CL.

This CL aims to be the smallest change possible to allow seamless
migration of BrowserThread::PostAfterStartupTask() to
base::PostTaskWithTraits().

Bug: 887407
Change-Id: I83ef387b82496ece3ed10c0c2466f42a6a5b19b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631668
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Carlos Caballero <carlscab@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664488}

We introduced CompatibleAlertDialogBuilder to work around support
library issue at https://crrev/c/1626009

+ Modify the current presubmit check to check
  CompatibleAlertDialogBuilder
+ Add an error that CompatibleAlertDialogBuilder should be used
  instead of the AppCompat AlertDialog.Builder

Bug: 966101
Change-Id: Ic3280f3c2b2ab99d72086eaa26cbe9f6c57c69b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625845Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664487}

It turns out pepper expects a call to fullscreen to synchronously
change the bounds. Recent changes to NativeViewHost meant that
Attach() did not synchronously change the bounds, which broke
pepper fullscreen. This patch makes WebView call Layout() right
after Attach() to ensure the bounds are up to date for pepper.

BUG=959118
TEST=none

Change-Id: I35d4461347557735af9b19dab58c2bd2d71b733d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633830Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664486}

Make the get_sinks API return sink structs instead of sink name strings.

Bug: 963963
Change-Id: Idb6b555544f29aaa308b8d289335073348c653f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615982Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664485}

Fixes the VrBrowserWebInputEditingTest#testTextSelection flakiness on
Nougat devices (for real this time) by further decreasing the rate at
which clicks are sent to the content node.

TBR=billorr@chromium.org

Bug: 953990
Change-Id: I016b3dc845df4d6c7fd461688a222bc16f4e4c7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634724Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664484}

This removes services/ws/public from views DEPs as it's not needed.
This also adds an explicit DEP from views onto ui/latency, and an explicit
include from HWNDMessageHandler (which is using ui/latency). ui/events has a
public_dep on ui/latency, but ui/latency is a source_set. Views was likely
getting ui/latency via services/ws/public/public some how. With the services/ws
dep removed, link errors results. As ui/latency is a source_set and views
is directly dependencing upon ui/latency, views should have an explicit
dep on ui/latency.

BUG=964460
TEST=none

Change-Id: I5bc159b7cfe8dd15089ff88200cad8692a5b1572
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635772Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664483}

Some gpu bugs are related to the monitor refresh rate. Adding this display
information will help us on gpu debugging.

Bug:964095

Change-Id: Ieaea44502c14a0eba7b0f664d402474d3694616e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629176Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664482}

This includes mojo support for:
* ip address
* mac address
* RequestScan()

Bug: 862420
Change-Id: I7070ec82f898ca01f94de72ecfbe608f5e803ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627894Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664481}

This CL:
- Decreases the WebAPK update check interval to 1 day. This makes
testing less frustrating
- Removes WebappDataStorage.RETRY_UPDATE_DURATION now that it is the
same duration as WebappDataStorage.UPDATE_INTERVAL

BUG=968252

Change-Id: I6db0e489427613f15d69b449efa3b3a2573e3014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635860Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664480}

While a tab hover card is animating between tabs the hover cards anchor view is in transition and the tab hover card's data is updated before the anchor is moved. Because of this, GetThemeProvider() was not using the correct tab, this cl gets the theme provider from the correct tab that the hover card is moving to.

Bug: 968055, 910739, 928954
Change-Id: Ide4f109ea66c206da1c6fb9c8c785282694ccadb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635857
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664479}

https://chromium.googlesource.com/webm/libvpx.git/+log/197827edb87e..0308a9a13261

$ git log 197827edb..0308a9a13 --date=short --no-merges --format='%ad %ae %s'
2019-05-24 marpan vp9-rtc: Update overshoot_detection speed feature
2019-05-25 jzern Revert "Fix calculations in GF only group case"
2019-05-08 venkatarama.avadhani Exclude VP9 files from vpx_dsp.mk for VP8 build
2019-05-21 jingning Clamp for min_frame_target
2019-04-22 ravi.chaudhary Increase active best quality linearly
2019-04-26 deepa.kg Fix calculations in GF only group case
2019-05-14 deepa.kg Fix section intra rating for first ARF interval

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: I330a76607a73f6aa4f11598b506b87410be36c50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635829Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#664478}

This is only used for the communication between ash and browser.
It doesn't have to be mojo interface anymore.

Bug: 958193
Test: trybot
Change-Id: Ic250567f37a2d9da7e213b6f96abcdaee449f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633110Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664477}

This reverts commit 8e4ce327.

Reason for revert: flaky failures are still present in 
 external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
 on Linux Tests and WebKit Linux Trusty Leak
 
 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387 https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892


Original change's description:
> Reland "Change ICE connection state on transceiver changes"
> 
> This reverts commit 2229f484.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Change ICE connection state on transceiver changes"
> > 
> > This reverts commit 0882bebe.
> > 
> > Reason for revert: Causing flaky failures of
> > external/wpt/webrtc/RTCPeerConnection-iceConnectionState.https.html
> > on Linux Tests and WebKit Linux Trusty Leak
> > 
> > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/78387
> > https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/34892
> > 
> > Original change's description:
> > > Change ICE connection state on transceiver changes
> > > 
> > > This ensures that if the PC iceConnectionState should change
> > > because unused transports are discarded, the state is updated.
> > > 
> > > Bug: chromium:966798
> > > 
> > > Change-Id: I09d945f5e70eec813f33c3131fbe889825613652
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254
> > > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > > Commit-Queue: Harald Alvestrand <hta@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#664206}
> > 
> > TBR=hta@chromium.org,hbos@chromium.org
> > 
> > Change-Id: I2cbae9f1327e7aacb7022d2a823ce1e954c91b62
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: chromium:966798
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635208
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Aaron Gable <agable@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#664388}
> 
> TBR=agable@chromium.org,hta@chromium.org,hbos@chromium.org
> 
> Change-Id: I894d30a0c585245b095c27cee9d5eadaf4569654
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:966798
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635512
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Commit-Queue: Harald Alvestrand <hta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664422}

TBR=agable@chromium.org,hta@chromium.org,hbos@chromium.org

Change-Id: I548c573eaacc6870df8445e0d67522fbb8d4ece6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:966798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636231Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664476}

Moving node.GetScrollbarSizes to ng_length_utils::ComputeScrollbars.
This aligns scrollbar computation with ComputeBorders and ComputePadding.
It also makes it less error-prone, no need to check for anonymous
constraint space before calling.

Bug: 967361
Change-Id: I97225a54f762a034074f1a5c78332b84986e5aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635850
Commit-Queue: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664475}

This reverts commit e507d09a.

Reason for revert: Causing multiple perf test failures (e.g., https://crbug.com/968176)

Original change's description:
> perfetto: Switch to clearing incremental state periodically
>
> The perfetto service now provides a signal for clearing of incremental
> state. This patch plumbs the signal into our data sources down to the
> event sink.
>
> Bug: 928738
> Change-Id: If4bfb5329eb50e8222cd670ed4a0ece0ad25081e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632213
> Reviewed-by: oysteine <oysteine@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Eric Seckler <eseckler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#664154}

TBR=dcheng@chromium.org,oysteine@chromium.org,eseckler@chromium.org,crouleau@chromium.org

Change-Id: Ic1212ff4ec5e9cf057b39ae03c3e6a828f838309
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 928738
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635834Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664474}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1b71e4533842..3d62cb814853


git log 1b71e4533842..3d62cb814853 --date=short --no-merges --format='%ad %ae %s'
2019-05-29 greg@lunarg.com Instrument: Add version 2 of record formats (#2630)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@3d62cb814853

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng
TBR=radial-bots+chrome-roll@google.com,cwallez@google.com

Change-Id: Ie805a343ca4696a1659d3812695cbb85bc67920f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634614Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664473}

Fix assumption in NGPaintFragment::InkOverflow where it would return the
self ink overflow, rather than the content overflow, if there is a mask.
This is incorrect for line boxes as those only have content ink overflow
causing foreground painting to be skipped, due to the culled rect logic.

Bug: 967567
Test: web_tests/fast/css/webkit-mask-image-painting.html
Change-Id: I5f52d6752fbeae1b25a0397dc4bcff5d8a8de281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633314
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664472}

This change effectively allows presenting Zero Suggestions on a New Tab
Page when the URL field is empty.

PRD: go/clank_zps
DD: http://doc/1z4TLLrHONKcV7zVF3FSWqSYUPhJrHebrkgr8HqYiI0I & go/clank_zps
Bug: 934922
Change-Id: I26e658b3d5b2fc6d8d2263be61ab1e557a0f02b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521947
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664471}

This change added histograms to send tab to self omnibox entry point,
recording whether the icon is shown, clicked and a target device inside
the omnibox bubble is chosen.

Also it records the count of valid devices when user see the device
list.

Histograms changes for other send tab to self entry points (contextual
meuns) will follow this CL.

Change-Id: Ib4863aed84f02a3b3894ec5bc7f5d1c43dae7904
Bug: 967875, 945988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632912
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664470}

Adds newWindow and background params to Target.createTarget, exposing ability
to create a new window or tab, as well as whether to create it in the background
or foreground.

Design doc: http://bit.ly/chromedriver-new-window

Bug: chromium:966010
Change-Id: I5cb5875af668f5c37ecfb778392dd09315091ee0
Tested: Manually using ChromeDriver + WPTs (in a branch with the NewWindow endpoint implemented).
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623131
Commit-Queue: Rohan Pavone <rohpavone@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664469}

BUG=950007

Change-Id: I16148bf58dd006305e375b5ae8ec5aa4551eba80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636032Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664468}

Does the following refactoring/cleanup in the XR browser tests:

1. Standardizes the naming of test classes.
2. Switches any easily-ported OpenVR tests to run with both OpenVR and
   WMR runtimes.
3. Deduplicates some code DirectX adapter enumeration code.
4. Ensures that WMR tests always create a test hook before the test
   starts, to avoid issues with the real Mixed Reality Portal starting
   up if it's installed and a test hook is otherwise not needed for a
   test.
5. Documenation clarification.

Bug: 926048
Change-Id: I2af46b3aa103f5b8d80c676154af451e93384a89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633316
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664467}

Using wpt-import in Chromium 84dbdd78.
With Chromium commits locally applied on WPT:
e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo"
abf2ac5e "webrtc wpt: avoid race conditions"
d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property."
0882bebe "Change ICE connection state on transceiver changes"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
dcheng@chromium.org, palmer@chromium.org:
  external/wpt/domxpath
ericwilligers@chromium.org:
  external/wpt/css/motion
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools
mkwst@chromium.org:
  external/wpt/cookies

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ia2a4e6a55f46adccb279302081c9bfb84668795e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635205Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664466}

Use Polymer data binding in order to compute elements' visibility on the
screen_gaia_signin screen.

This removes most of the imperative manipulation of "hidden" attributes
and other related logic from the JavaScript code.

The only remaining old-style visibility logic is the one for SAML video
recording (saml-notice-recording-indicator) - that one will be
refactored in a follow-up CL.

Bug: 964069
Test: manual
Change-Id: If96b65dd6fb3664b66125b162e09e5d05a7e8dba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627383
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664465}

Bug: 967940
Change-Id: I921dfeadb8780132cef228371395a491c9db264b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633511
Auto-Submit: Kayce Basques <kayce@google.com>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664464}

Per the WebXR Spec, the inputSources attribute is supposed to be a live
array whose input sources are updated in place.  Currently the code
creates a new array on every query.  This changes the internal hash map
of input sources to be an XRInputSourceArray object.

The XRInputSourceArray object is implemented with a backing HeapHashMap
so that the existing logic (i.e. looking up/setting/erasing by id) is
more performant than getting by the index.  This does have a side effect
of meaning that an input source's position in the inputSources array can
change, as it's ordering is based on the ordering of the HeapHashMap's
backing .Values store.

Bug: 966552
Change-Id: I21396ebbbbef6799a6bdd98791706c9159c9e061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632872
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664463}

Previously, support for the "loading" attribute to control lazy image
loading was only used in conjunction with automatic lazy loading. This
CL separates those two concepts, allowing for "loading" attribute
support to be enabled for images without automatically lazily loading
images that have no "loading" attribute set.

A followup CL will hook this up for lazy frame loading as well.

Bug: 937980
Change-Id: I55e5028ac92af61f116486f3c461b0b4fcb6ee1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590859
Commit-Queue: Scott Little <sclittle@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664462}

https://crrev.com/c/1539860 changed child throttling to allow only two
unembedded surfaces. However, this seems to have regressed latency so
revert back to allowing three unemedded surfaces.

Bug: 951992
Change-Id: I49f67d5299642063ef265aed34767f56f1706eb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598419
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664461}

This change also ensures the favicons are rendered in case of race between
LargeIconCache and AutocompleteMediator:
if LIC supplies favicon BEFORE AutocompleteMediator sets the property value
(very narrow time window), favicons would not be shown.

Bug: 961158, 960421

Change-Id: I8983f1aaa9e69ecc9f2b2fb7d0bb4a556d6d86bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630234Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#664460}

This refactor sees D3D11PictureBuffer no longer holding a D3D11Texture2D,
instead it holds a wrapper class which is responsible for creating and
owning gpu resources and mailboxes.

The default wrapper behaves exactly like the old implementation.

Bug: 963742
Change-Id: I49c67517203ef6464a6f0f2d3609bd7e484ac4a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614937
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664459}

According to https://developers.google.com/protocol-buffers/docs/proto#maps
iteration ordering of map values is undefined. This CL sorts the
metadata entries before in the DevTools frontend so
they can be presented in a consistent order.

Also remove redundant test formatting, fix the OWNERS Background Service
regexp to include the handler, and make the row counting start from 1.

Change-Id: I36024f23fbb307b1160cd67120dcf67ca8697aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615251
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664458}

If the javascript callback ends the XRSession, then the input events
should stop being processed.  This check is also needed because ending
the session may have changed the state of other variables that are still
being processed, and access violations could occur.

Bug: 967853
Change-Id: Ia54112cdb806e1ed75c32ac9b202dafb85d9b9cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633749
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664457}

If Window::CreateLayerTreeFrameSink() is called more than once the
DCHECK(!embeds_external_client_) would fail. This is because
SetEmbedFrameSinkIdImpl() would always set |embeds_external_clients_| to
true even when it wasn't called for an external client.

Fix how |embeds_external_client_| is set. Also remove
|frame_sink_id_internally_allocated_| since this seems like just the
inverse of |embeds_external_client_|.

Bug: none
Change-Id: I0109106083206e0aee6743ba0c4d66e5ce15e5c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634386Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664456}

Remove references to mash.

BUG=none
TEST=none

Change-Id: I02c85b4cae87d343bd0adb0cdb7cd00be4884477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635875Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664455}

This protection should fix this crash bug.
Since, it is possible for an ArcNotificationItem
to be deleted before an ArcNotificationContentView.

Bug: 940716
Change-Id: Ie8b926748358308a91ddab4b854ed2ca21deb5c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632918
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664454}

android_webview/docs/prerelease.md links to the a webview bug filing
template using https://goo.gl/9qkbdn. Since goo.gl is being deprecated,
update this link to the full url.

Test: Open prerelease.md in gitiles and check that the link is the full
Test: url and links to the right place.
Change-Id: I2310e0a962cafde66409e324612de6df80c48ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635989Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664453}

This CL fixed an issue that copy link option in the context menu also
records an open url metric.

Bug: 967941
Change-Id: I943f610b4082a9f913e1dd7ed24036747dd94f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633971Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664452}

BUG=none
TEST=none

Change-Id: I0296fdaff20f6826a84acedbb745d5b3bba47c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634561Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664451}

https://swiftshader.googlesource.com/SwiftShader.git/+log/566314b3ea6d..29364a0595bc


git log 566314b3ea6d..29364a0595bc --date=short --no-merges --format='%ad %ae %s'
2019-05-29 srisser@google.com Fix buffer overflow on Mac
2019-05-29 capn@google.com Fix initializing bits after bitfields
2019-05-29 samans@chromium.org Fix build failure


Created with:
  gclient setdep -r src/third_party/swiftshader@29364a0595bc

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:944796,chromium:967704
TBR=swiftshader-team+autoroll@google.com

Change-Id: I9f30a3ee8c6c67e8ab654ee405274ad3f7933962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635220Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#664450}