GitLab

WebLocalFrameImpl sets is_directional_ value to false
explicitly for building SelectionTemplate.
By default the is_directional_ value is false in
SelectionTemplate so we don't need to explicitly set.

Bug: 740804
Change-Id: I8f332d441b0265a230240fec30e892c4d55d4776
Reviewed-on: https://chromium-review.googlesource.com/765751Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516329}

RenderThreadImpl's logic has a fair amount of duplication with ui::Gpu.
In particular, RenderThreadImpl shouldn't need to cache the
GpuChannelHost, since it is available directly from the ui::Gpu.

Bug: 566273
Change-Id: I6cfb9f28b46bce64c4f83aa5f2fcb4263c171018
Reviewed-on: https://chromium-review.googlesource.com/767594Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516328}

This has following two changes.
- Rename ManagedNetworkConfigurationHandlerTest to
  ManagedNetworkConfigurationHandlerMockTest, and then deprecate it.
- Introduce a new ManagedNetworkConfigurationHandlerTest test fixture,
  which uses Fake implementation instead of gmock.
- Migrated four tests using policy/shill_policy_on_unconfigured_wifi1.json
  into new test fixture.

BUG=234463
TEST=Ran bots.

Change-Id: I50114a323605eafd9e67accb1232c72783d3c572
Reviewed-on: https://chromium-review.googlesource.com/766407
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516327}

Reusing kArcIntentHelperPackageName where needed. Also adding a method
to reuse such package name + a custom string appended to it, this is
AppendStringToIntentHelperPackageName.

Bug: None
Test: Build.
Change-Id: I1b9115b808533e1e5ed3339b7f3747496ca2f0c3
Reviewed-on: https://chromium-review.googlesource.com/764396Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: David Jacobo <djacobo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516326}

There is a need to compile V8 using CLANG and gcc-toolchain
option, in order to support CLANG on those targets which
don't have Debian RootFs (Release 6 and MIPS64BE).

This patch enables custom compilation using GN by
removing those flags that are set by the custom compiler.

Bug: 
Change-Id: Ia9b2f0fac1f76a2ad98d190fd307aa60229e8eeb
Reviewed-on: https://chromium-review.googlesource.com/763449Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516325}

https://chromium.googlesource.com/catapult.git/+log/445e9e3fa409..c44654bacfc5

$ git log 445e9e3fa..c44654bac --date=short --no-merges --format='%ad %ae %s'
2017-11-14 perezju [Telemetry] Remove purge_ashmem dependency

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1566d3529ef711b1ed4e1e729249e3575bca3c7d
Reviewed-on: https://chromium-review.googlesource.com/768342
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516324}

This CL introduces a NavigationAndFirstPaintObserver and uses it in
place of content::TestNavigationObserver.

Bug: 778248
Change-Id: I9c42e384c48a4f5b2b85ca02ed931adf0178e086
Reviewed-on: https://chromium-review.googlesource.com/767388
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516323}

A few things are changed in this dialog:
* New browsertests to test permanent and temporary errors
  as well as the progress/success overlay.
* The layout structure has changed to accomodate for a
  better progress overlay (FillLayout with both contents and
  the overlay).
* Various hard-coded constants for distance and inset were replaced
  by common layout constants.
* One extra browsertest on Mac.

I'm not claiming this file is now perfect but it's a step in a
better direction.

Bug: 781581
Test: out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=CardUnmaskPromptViewBrowserTest.InvokeDialog_expired
Change-Id: I43a0a2337c58856abe7574621d70429572ebd87c
Reviewed-on: https://chromium-review.googlesource.com/764647
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516322}

This CL has no functional change. It modifies UiElement::Hittest to take a ray
as input in preperation for keyboard UI element support.

Bug: 780135
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2788ec50ad1b23aea48489e6c6e7034775fc83e6
Reviewed-on: https://chromium-review.googlesource.com/767507Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516321}

Changes the messaging for nonfatal "unused build arg" messages to be
"WARNING" instead of "ERROR" when they are nonfatal and clarify that
the build has continued. Previously it would print "ERROR" and
continue anyway which was confusing.

Add an Err object move constructor and de-inline the assignment
operator (previously implicit).

Bug: 500696
Change-Id: Id6056b7a4d33466485f9e138a890e211f447817f
Reviewed-on: https://chromium-review.googlesource.com/762086
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516320}

Convert ReadingListWebStateObserver to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Remove class ReadingListWebStateObserverUserDataWrapper
and instead convert ReadingListWebStateObserver to be
a WebStateUserData.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I726919cf9c29b7040a907f01c95f462595e30192
Reviewed-on: https://chromium-review.googlesource.com/766751
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516319}

On ATK accessibility model, embedded hyperlinks accessibility nodes should
be exposed as ATK objects implementing AtkHyperlinkImpl interface. This
interface should provide the get_hyperlink method that returns an
AtkHyperlink object with the hyperlink URL and status.

This implementation is equivalent to the one found in Firefox and in
WebKitGTK: it will return always one anchor, that will point to the
link embedding object.

It does not implement the get_start_index and get_end_index yet.

Bug: 783447
Change-Id: I72163b1cce18c7cc3c8f732d5eaa45987b86a420
Reviewed-on: https://chromium-review.googlesource.com/762316Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516318}

serialize value of clip attribute expected as comma-seperated.
So change it from space-separated to comma-seperated.

Bug: 779873
Change-Id: Ia2726bd1fcfa0b5c9e4eca1fcd71a4d4f269c332
Reviewed-on: https://chromium-review.googlesource.com/760178Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516317}

Most data pak files are generated at build time using a
Python script (see tools/grit/grit/format/data_pak.py),
but the C++ data pack writer can also be used at runtime
by the ThemeService (see ThemeService::SetTheme()).

The Python pak writer was recently changed to support
version 5 of the format that introduces a resource
alias table to reduce the size of the final pak files,
in the case of resource data duplication. This is mostly
important for localized strings paks.

While the C++ data pack reader and writer were updated
to support this new format, the WritePack() method didn't
try to find resource duplicates and build an appropriate
alias table.

This CL fixes the C++ writer, to detect resource data
duplication and build an appropriate alias table when
it is detected. After this patch, both the Python and
C++ code should behave identically.

+ Fix slightly misleading comment documenting the header
  formats (using uint instead of int values in the
  description, the code is already correct).

+ Use ScopedFileWriter convenience class to simplify
  error handling and cleanup.

+ Use for '(const auto& item : collection)' to simplify
  scanning over maps.

+ Add a sanity check to fail if there are more than 2^16
  resources to write (since the format only supports up
  to 65536 resources per pak file).

BUG=None
R=agrieve@chromium.org,asvitkine@chromium.org,sadrul@chromium.org

Change-Id: Ic04eb68558026ff48835ed0e9e44ba539b3a52a8
Reviewed-on: https://chromium-review.googlesource.com/737636Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516316}

This didn't show up as slow in any traces (I didn't even look). Just
came upon this micro-optimization when trying to learn what happens
during normal start-up.

Should be faster just by virtue of referencing fewer classes, and
avoiding a reflective call made by isVrEnabled().

Change-Id: I2256be591079917018037bb5881bee1a5c8888da
Reviewed-on: https://chromium-review.googlesource.com/766949Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516315}

The comment refers to code in Browser::ActiveTabChanged, not
BrowserView::OnTabChanged. See code block below

https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?type=cs&q=Browser+ActiveTabChanged&sq=package:chromium&l=1064-1067

This is particularly misleading as one might try to find
the reference in BrowserView::OnActiveTabChanged, which has no
direct reference to the comment in OmniboxViewViews::OnTabChanged.

Change-Id: I71e79e3fe6e874b569e9d4b6da122852eccd3d37
Reviewed-on: https://chromium-review.googlesource.com/767367
Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516314}

It seems like on iOS 11 the autoresize masks don't work well when the
device is rotated. Since suggestions rows don't really need the mask
since the frame of each view is exactly calculated and set every time it
changes the size, remove the use of autoresize masks.

including long and short suggestions, answers; specifically verify that
text is not clipped in unexpected ways even when rotating to landscape
and back.

Bug: 768374
Test: Please test by displaying all possible suggestions in omnibox,
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia00b60187b3d99e7e09dcd82d107c6a809492316
Reviewed-on: https://chromium-review.googlesource.com/760937
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516313}

Convert FaviconWebStateDispatcherTest to directly track
registration with the observed WebState instead of relying
on the deprecated code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I40a70007d5dfab9c13439daf40bf361145bb830c
Reviewed-on: https://chromium-review.googlesource.com/766790
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516312}

This reverts commit a270ee75.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Add aura::WindowOcclusionTracker.
> 
> aura::WindowOcclusionTracker notifies interested windows
> when their occlusion state change.
> 
> This will be used to release resources and throttle execution
> of occluded tabs.
> 
> Time to recompute occlusion on a Samsung Chromebook Pro:
>  100 partially occluded windows*: 108us
>  50 partially occluded windows*: 50us
> * window 0 at position (x=0;y=0), window 1 at position (x=1;y=1),
>   window 2 at position (x=2;y=2), etc.
> Benchmark code:
> https://chromium-review.googlesource.com/c/chromium/src/+/718979
> 
> 
> Bug: 738387
> Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40
> Reviewed-on: https://chromium-review.googlesource.com/679206
> Commit-Queue: François Doray <fdoray@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516293}

TBR=sadrul@chromium.org,fdoray@chromium.org

Change-Id: Ib9d0056b520f8fef13d97f0736dbde197c14882d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 784879
Reviewed-on: https://chromium-review.googlesource.com/768168Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516311}

Test:
  ninja -C out\debug
  python content\shell\tools\breakpad_integration_test.py ^
      --build-dir=out\debug ^
      --binary=out\debug\content_shell.exe

Bug: 466890
Change-Id: I76bf5c3e165d450d401aa3ac689cb0b5b49f3511
Reviewed-on: https://chromium-review.googlesource.com/760549Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516310}

ExtensionEnableFlow tries to re-enable a disabled extension, but did not
account for extensions that cannot be re-enabled by enterprise policy.
This would result in the ExtensionEnableFlow trying to re-enable the
extension (which would fail), and then notifying the delegate that the
re-enable was successful (which it wasn't).

This could lead to an infinite loop in the app list, where an
ExtensionAppItem would try to launch, see the extension needed to be
re-enabled, try to re-enable the extension through the
ExtensionEnableFlow, see that it was successful, and try to launch.

Fix this by checking if the extension must remain disabled in the
ExtensionEnableFlow and responding appropriately. Add a regression test
for the same.

Bug: 783831

Change-Id: I53cddecc895a9602f0884fa022b68ea7a6c2d667
Reviewed-on: https://chromium-review.googlesource.com/764851
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516309}

Any custom View may provide ThemeProvider. TypographyProvider
implementation should have possibility to consult the ThemeProvider in
similar way NativeTheme can be consulted.

Bug: 691891
Change-Id: I4d67dfa870d9c439292f74c96e408bb7a9471059
Reviewed-on: https://chromium-review.googlesource.com/730583
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516308}

MediaRouterMojoImpl::JoinRoute() requires that we find the MediaRouteProvider associated with a presentation ID.
By associating each MediaRoute with a presentation ID, we can look up the associated MRP.
The change to add presentation ID to MediaRoute on the component extension side has landed as cl/173960916.

Bug: 779155, 761493
Change-Id: I4bf7d6fb3a832ef4720bfc1952198fd2036350b2
Reviewed-on: https://chromium-review.googlesource.com/757796Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516307}

https://skia.googlesource.com/skia.git/+log/5b65a84b990e..1662257bdaaa

$ git log 5b65a84b9..1662257bd --date=short --no-merges --format='%ad %ae %s'
2017-11-10 bungeman Alloc glyph image correctly for SkMask::k3D_Format.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I89bd7e88b9f3c4fe934a3bcddfe1c86f661d144c
Reviewed-on: https://chromium-review.googlesource.com/768470Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516306}

This reverts commit 0a8e88e5.

Reason for revert: Broke build.
https://luci-milo.appspot.com/buildbot/internal.client.clank_tot/clang-clankium-tot-builder/52982

Original change's description:
> [Payments] Capability matching for payment handlers on desktop.
> 
> Before this patch, payment handlers for "basic-card" would always be
> shown in desktop payments UI, even if their "capabilities" field did not
> match the merchant's request.
> 
> This patch sends the full PaymentMethodData array to the
> ServiceWorkerPaymentAppFactory, so the factory can compare the
> "capabilities" of payment handlers for "basic-card" to the merchant's
> requested PaymentMethodData. The factory compares the capabilities only
> for "basic-card".
> 
> After this patch, a payment handler for "basic-card" shows up in desktop
> payments UI only if its "capabilities" field matches the merchant
> request.
> 
> Bug: 777470
> Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278
> Reviewed-on: https://chromium-review.googlesource.com/744541
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Commit-Queue: Mathieu Perreault <mathp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516295}

TBR=rouslan@chromium.org,mathp@chromium.org,gogerald@chromium.org

Change-Id: I25260d461ebd180c817c5cf2943faaaee74245f9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 777470
Reviewed-on: https://chromium-review.googlesource.com/768604Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516305}

This CL cleans up code in ChildAccountService and related classes
without any changes to the behavior:
1. Use lambdas instead of anonymous classes.
2. Remove unused parameters.

Bug: None
Change-Id: If6a19bfb8b8cde27d35986325d218740e9337d52
Reviewed-on: https://chromium-review.googlesource.com/766968Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516304}

Is currently failing on the Android WebView L/M bots.

BUG=784868
TBR=wychen@chromium.org
NOTRY=true

Change-Id: I061577724093cae3ab1d3440ffa93757cf556ec5
Reviewed-on: https://chromium-review.googlesource.com/768721Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516303}

R=haraken@chromium.org

Change-Id: Ia88e4aefd42f295a0768dd9ae68e6b2f822d84ed
Reviewed-on: https://chromium-review.googlesource.com/766794
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516302}

This CL doesn't bring any functionality changes. It just aligns
the *Fullscreen word with other code around chromium.

TBR=rjkroege@chromium.org

Bug: 666958
Change-Id: I8c3937a5221641750846738c93f46496c00551b8
Reviewed-on: https://chromium-review.googlesource.com/768741
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#516301}

Ensure we mask on the current keyboard modifer state so that all
modifier keys can be detected.

BUG=783793

Change-Id: I0dd0cfaabc32f6a8df0cbea793bbac43dbe3dcb6
Reviewed-on: https://chromium-review.googlesource.com/766667Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516300}

Convert PasswordTabHelper to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iab720008b6da7df451da230628f3a5c75fb72da0
Reviewed-on: https://chromium-review.googlesource.com/766789
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516299}

The change these were introduced to track was over 1.5 years ago. We
collected the necessary data and the deprecation workaround was removed
a year ago, so its time for these counters to be removed.

Bug: 601672
Change-Id: I64f0e78152068000622421111765678b6ce798d7
Reviewed-on: https://chromium-review.googlesource.com/767056Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516298}

This reverts commit 7860090b.

Reason for revert: Likely cause of ANR / DCHECK

Original change's description:
> [Android O] Clean up notification settings on channel migration
> 
> - Previously when migrating to channels, the content settings were
> simply copied over to the NotificationChannelsProviderAndroid from
> the PrefProvider.
> 
> - Now they are deleted from the PrefProvider as they are copied over
> to the NCPA.
> 
> - This avoids old content settings hanging around and getting
> reinstated on channel deletion.
> 
> Bug: 781524
> Change-Id: Ic00ddd4996e8a17775678193b6ffdb0b4d62d5fa
> Reviewed-on: https://chromium-review.googlesource.com/760936
> Reviewed-by: Raymes Khoury <raymes@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: Anita Woodruff <awdf@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515538}

TBR=raymes@chromium.org,peter@chromium.org,awdf@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 781524,784823
Change-Id: I53d19029118bbd0c907ad1317f744e3e6e0a80c3
Reviewed-on: https://chromium-review.googlesource.com/768787Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516297}

Convert InfoBarManagerImpl to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Remove unused method InfoBarManagerImpl::WebStateFromInfoBar
as it accessed deprecated web_state() method.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I55574e425107a3306bc0ba2085d699d4008c3f44
Reviewed-on: https://chromium-review.googlesource.com/766750
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516296}

Before this patch, payment handlers for "basic-card" would always be
shown in desktop payments UI, even if their "capabilities" field did not
match the merchant's request.

This patch sends the full PaymentMethodData array to the
ServiceWorkerPaymentAppFactory, so the factory can compare the
"capabilities" of payment handlers for "basic-card" to the merchant's
requested PaymentMethodData. The factory compares the capabilities only
for "basic-card".

After this patch, a payment handler for "basic-card" shows up in desktop
payments UI only if its "capabilities" field matches the merchant
request.

Bug: 777470
Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278
Reviewed-on: https://chromium-review.googlesource.com/744541Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516295}

BUG=b/67617383

Change-Id: I0a8308d96e84256e363ce8127da7720b04e2aea6
Reviewed-on: https://chromium-review.googlesource.com/768493Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516294}

aura::WindowOcclusionTracker notifies interested windows
when their occlusion state change.

This will be used to release resources and throttle execution
of occluded tabs.

Time to recompute occlusion on a Samsung Chromebook Pro:
 100 partially occluded windows*: 108us
 50 partially occluded windows*: 50us
* window 0 at position (x=0;y=0), window 1 at position (x=1;y=1),
  window 2 at position (x=2;y=2), etc.
Benchmark code:
https://chromium-review.googlesource.com/c/chromium/src/+/718979


Bug: 738387
Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40
Reviewed-on: https://chromium-review.googlesource.com/679206
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516293}

Convert HistoryTabHelper to directly track registration with
the observed WebState instead of relying on the deprecated
code in WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0b3f3b63e599ad2327df155a75549248b8db9b1b
Reviewed-on: https://chromium-review.googlesource.com/766749
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516292}

Convert FindTabHelper to directly track registration with the
observed WebState instead of relying on the deprecated code in
WebStateObserver.

Bug: 775684
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I69071028a6f8476734d19da1eeaa92e7e9751b6d
Reviewed-on: https://chromium-review.googlesource.com/766748
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516291}

https://skia.googlesource.com/skia.git/+log/74c8436f2c34..5b65a84b990e

$ git log 74c8436f2..5b65a84b9 --date=short --no-merges --format='%ad %ae %s'
2017-11-13 robertphillips Resolve GrSurface/GrSurfaceProxy ref counting issue in GrResourceAllocator

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Iaabd39e651032547bdad75f188c2cabda7139094
Reviewed-on: https://chromium-review.googlesource.com/768548Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516290}