- 01 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/540178c7543f..ab7bec343496 git log 540178c7543f..ab7bec343496 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 danakj@chromium.org Make find_owners_test.py pass consistently. Created with: gclient setdep -r src/third_party/depot_tools@ab7bec343496 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I8182099a591eb07f6dd01b62ec2870da575f6d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711844}
-
Daniel Hosseinian authored
That is the only GN file in the pdf/ subdirectory. Bug: 1020676 Change-Id: I2495ab9b5976957270298b8aed703f4d4c858844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895865Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#711843}
-
Dana Fried authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1880531, we fixed the case where a separator would not properly fill its bounds. However that broke functionality where a spacer was being used as e.g. a vertical separator in a text flow with insets on either side (see attached bug). This solution does both: - when there is no inset on a particular side of the separator, the separator is guaranteed to draw flush with the edge of the view - when there is an inset, the inset is guaranteed to be preserved, with the old behavior of the separator being adjusted to draw only on whole pixels in DPI-scaled environments (minimum of 1px in either dimension) Fixes: 1019503 Bug: 1019503 Change-Id: I97dd487ba2374000dcef76e43665ef44eb93acd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894253 Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711842}
-
Dave Tapuska authored
Move FrameMsg_DispatchLoad to a RemoteFrame mojo interface. BUG=1008432 Change-Id: I295fbd94a719b84ade286d3a19b9422a7d5296a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874204 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711841}
-
gogerald authored
Bug: 1020223 Change-Id: I974a7d8bea365b62134f28ce947c9b2c090bb712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894294 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711840}
-
Anastasia Helfinstein authored
Bug: 897365 Change-Id: I5bec4d7ac57d2873b04f9d7db24b6efd088b9c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880370 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711839}
-
Kevin McNee authored
This reverts commit 91d5b592. Reason for revert: Suspect for fuchsia compile failure https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast/58519 Original change's description: > Add ESNI response-processing glue > > This CL adds logic processing ESNI DNS responses and surfacing the > results via ResolveHostRequest. It contains some nontrivial > functionality and some boilerplate. > > The nontrivial functionality (host_resolver_manager.cc and unittests): > - adds the addresses from ESNI records to the > *address list* contained in the HostCache entry, so that existing > TCP connection logic will be able to connect to ESNI-accompanied addresses > in the same manner as addresses without ESNI keys. Before sorting the > addresses, partition them on whether or not they have accompanying ESNI > keys, so that the stable sort in AddressSorter implicitly breaks ties > in favor of addresses associated with ESNI keys. > > The boilerplate (all changes except HostResolverManager): > - extends all "expect only one field is present" logic in prior > host_resolver_manager unittests to reflect that there's now another > field > - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI > - extends all subclasses of ResolveHostRequest to implement > GetEsniContent() > > Testing: > - Adds a new group of HostResolverManager unittests for ESNI queries. > > R=ericorth > > Bug: 1003494 > Change-Id: I49a18dd4937737c2d22d0fc0357b9e6a3a40e7d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874248 > Reviewed-by: Chris Palmer <palmer@chromium.org> > Reviewed-by: Eric Orth <ericorth@chromium.org> > Commit-Queue: David Van Cleve <davidvc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711827} TBR=palmer@chromium.org,ericorth@chromium.org,davidvc@chromium.org Change-Id: I96ab805e0bcb3a75311652452a6d7d54ab7778d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1003494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895965Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711838}
-
Aaron Leventhal authored
For now, the best decision on pure CSS tables is to keep doing what we're doing, which is to expose them as tables, and provide the possibility to navigate the layout like a table. Enough screen reader users, and the developers of ChromeVox and JAWS, want to keep it the way we have it, even though Firefox no longer exposes CSS tables as tables. Potentially, screen readers may wish to provide less verbose announcements on layout tables. This is already possible. Some useful object attributes for this are display, tag, xml-roles and layout-guess. Bug: 1020180 Change-Id: I2b1e2cbe1d3d7c7443dce1cd30d83bfce905052a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894039 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#711837}
-
Greg Thompson authored
During service teardown, tasks are posted to the TestMockTimeTaskRunner to close open files. These must be run during TearDown so that files can be closed, thereby allowing the ScopedTempDir to clean itself. Bug: 546640 Change-Id: Ibdfa0cc63f79f27237040765777fed344f7ad7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895337 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#711836}
-
Daniel Murphy authored
This CL should remove all of the remaining dependencies of the LevelDBScopes system on content/ and the parent indexed_db/ directory. Bug: 1015212 Change-Id: I3983ced78a5d0c312d3fa443fdf3ab7d06644b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890963 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#711835}
-
Dave Tapuska authored
We don't want to receive messages after we are detached so ensure we reset the receiver on detach. BUG=1020551 Change-Id: Iddc8a8a9e1e8f9e998845c876e544c0b770cdfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894918 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This CL moves all headers from t_p/blink/public/platform/modules/peerconnection to t_p/blink/renderer/platform/peerconnection. This is part of phase 10 as per the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254, 919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I61d588c2645d30476925a5b13cda9671472ea8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881189 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#711833}
-
Lei Zhang authored
Change-Id: I5c0d2fef2be40763babc8bd604df7e160551f645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895318Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#711832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/26452ff7db33..8846c8af8511 git log 26452ff7db33..8846c8af8511 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 alessiob@webrtc.org RNN VAD: cast and scale quantized weights at init Created with: gclient setdep -r src/third_party/webrtc@8846c8af8511 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic885978c1dec1dd4d2cf1c60972a0dae2c07787f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895776Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=cmp@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I16d494598742895af2f080160a5c9a711e4bb79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894881 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#711830}
-
Ken Rockot authored
On Android we can somehow observe utility process crashes without observing process launches. This is a simple fix to avoid memory bugs in that case. Also fixes a related leak in the internal ServiceProcessTracker, where we were never cleaning up ServiceProcessInfo entries after process termination. Bug: 1016027 Change-Id: Ia5a8df891547cb7a2f01c869d16b014a8b249423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894627Reviewed-by:
-
Rodney Ding authored
- New doc explaining how to initialize blink features in content layer - Update feature flag guides to point to the new doc Bug: 832393 Change-Id: Id0cd47a2b926c55e15516242cbf6382e199b1537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873991Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#711828}
-
David Van Cleve authored
This CL adds logic processing ESNI DNS responses and surfacing the results via ResolveHostRequest. It contains some nontrivial functionality and some boilerplate. The nontrivial functionality (host_resolver_manager.cc and unittests): - adds the addresses from ESNI records to the *address list* contained in the HostCache entry, so that existing TCP connection logic will be able to connect to ESNI-accompanied addresses in the same manner as addresses without ESNI keys. Before sorting the addresses, partition them on whether or not they have accompanying ESNI keys, so that the stable sort in AddressSorter implicitly breaks ties in favor of addresses associated with ESNI keys. The boilerplate (all changes except HostResolverManager): - extends all "expect only one field is present" logic in prior host_resolver_manager unittests to reflect that there's now another field - extends all switches on DnsQueryType to accommodate DnsQueryType::ESNI - extends all subclasses of ResolveHostRequest to implement GetEsniContent() Testing: - Adds a new group of HostResolverManager unittests for ESNI queries. R=ericorth Bug: 1003494 Change-Id: I49a18dd4937737c2d22d0fc0357b9e6a3a40e7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874248Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#711827}
-
Ryan Daum authored
rounded_window_corners_default.cc was missing from the build target. Bug: internal b/141369549 Test: unit test Change-Id: Ib25fd665e630f2c115f420bc4f6d5b7e3dfe3a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895868Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#711826}
-
Alexander Timin authored
Use a weak ptr factory instead of a base::Unretained to ensure that we don't get a UAF after deleting BackgroundTaskUpdateScheduler or cancelling a task. R=agrieve@chromium.org,tiborg@chromium.org BUG=880565 Change-Id: Ib6ce448625b3bbb99776dec75d3e8110ab987a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895659Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711825}
-
Henrique Nakashima authored
Use this to add verifications that the expected calls are made to BackgroundTaskSchedulerExternalUma. Bug: 1017130 Change-Id: Ica99e12df6d1d655f1d2fdba8ad20b5065a2170a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884821Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711824}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable this test as it is being run and is flaking. Tbr: reillyg@chromium.org Bug: 1020591 Change-Id: I8dea9bc8f0e3ef23bb733c9912e0011c5ac4253e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895798Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711823}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1ae70fb..5689bf7c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d82f1cd93488c34cdb5c5a6f3888edfb9210e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895394Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711822}
-
Yue Zhang authored
This CL adds TabGroupsContinuation feature flag and hide tab group naming and selection-mode in dialog behind this flag. Also, unit tests are added to make sure the flag setup is properly reflected. Bug: 1018841 Change-Id: I88737144e710b694f3cccf4a1b7a5f0763916a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885016Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#711821}
-
Henrique Nakashima authored
SharedPreferencesManager should be used instead. Bug: 1017800 Change-Id: I49f8a702e456ce636658b233a620066451b26858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893502 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711820}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=torne@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I39d0a74b1bec2148a9dec777ace504bb0a1de4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895642 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711819}
-
Rohit Rao authored
BUG=699306 Change-Id: Ide0eba1f60a766ab0913642921dca725e28e258b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894016Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
The PrefServiceBridge Java caller object is not used on the native side remove it from all calls. Bug: 1016957 Change-Id: I3987dd419723fd9a11f00c93fa45a8e738574a88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894268Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#711817}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: I6f0d29981323617bfbb569ecfd28e1550242039d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895783Reviewed-by:
-
Anastasia Helfinstein authored
This is a pure refactor, with no change in logic or behavior. It groups functions by simplicity, and alphabetizes within those groups. Bug: None Change-Id: I5eda83d75e50a30ed8ae5e7c2c3ef1444d20601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891015 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711815}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05ff793e61e6..41eccb9d43eb Created with: gclient setdep -r src-internal@41eccb9d43eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1018879,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I46c30f94ef3ebf51e1e2694a6f41fa9ce41e2635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894685Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711814}
-
Yun Liu authored
I complied all suites locally with the same gn args as android-code-coverage-native, and these suites in exceptions.pyl failed due to linker errors (crbug in comment). Exclude these suites for now until linker issues are fixed. Bug: 985574 Change-Id: I50cbc195153bc6d93a8c2bd0f8952a72d869e65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893116 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yun Liu <yliuyliu@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Auto-Submit: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#711813}
-
Anastasia Helfinstein authored
Bug: 1018327 Change-Id: I667be3f714fcea00d2238e3f60144d8118c99bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884822Reviewed-by:
-
Abigail Klein authored
Bug: 785493 Change-Id: I4522d70bcf2841dbd554bdae37bcfebbdc55239d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857542 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/48233ad3d45b..7f77b2e8669a git log 48233ad3d45b..7f77b2e8669a --date=short --no-merges --format='%ad %ae %s' 2019-11-01 cepheus@frii.com Bump version. Created with: gclient setdep -r src/third_party/glslang/src@7f77b2e8669a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: Ia89f0ea5a3de8429f9f03f22d406a4ed03a6ba69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894683Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=rsleevi@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Iab984c0c745ec8316f5a7d23f15db4d42d63aae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893542 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711809}
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/e5d3a6655e13..d253f41e17e2 $ git log e5d3a6655..d253f41e1 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/spirv-cross/spirv-cross TBR=dsinclair@chromium.org Bug: angleproject:2634 Change-Id: I51409fe8d8b0521609d0f679c60213b17307f92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895758Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#711808}
-
Kelvin Jiang authored
This CL adds a new "unpacked" value which could be specied under the "location" key for extension features. APIs/events specified as "unpacked" will only be available for unpacked and command line extensions. This change was motivated by the declarativeNetRequest.OnRuleMatchedDebug event which should only be available for unpacked extensions. Bug: 1017934 Change-Id: Iafe0a64160dc4ca083bcf58393aba94a87bfd3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892212 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711807}
-
Torne (Richard Coles) authored
The new implementation of CookieManager::SetAcceptFileSchemeCookies introduced by the network servicification can deadlock when the embedding app is using the CookieManager API in a silly (but not forbidden) way. The deadlock occurs because the calling thread holds accept_file_scheme_cookies_lock_ while waiting synchronously for a task to complete on the CookieManagerClient thread, but it's possible that a task was already queued on that thread which is going to call GetCookieStore() and then attempt to acquire accept_file_scheme_cookies_lock_ to create the cookie store. Avoid this by moving the code which updates accept_file_scheme_cookies_ to run as part of the posted task instead. Also, add thread annotations to CookieManager to clarify which locks protect which state, as the existing comment was not correct. Fixed: 992829 Change-Id: I61aa3a505add2866fdf4317ffa7cf33e684ddc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890953Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711806}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kbr@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I2bfb718aa066e09050197565d36f8f11b34e8a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894882 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711805}
-
