- 06 Mar, 2020 31 commits
-
-
Josh Simmons authored
Treat audio files on DriveFS as if they were local when launching Quick View. This results in auto-play (where the media is decodable) and the display of album artwork in Quick View. DriveFS streams large files so if the user cancels / pauses the playback there will not be unnecessary data transferred. Bug: 877283 Test: browser_tests --gtest_filter="openQuickViewAudioOnDrive" Change-Id: I1eec7eadd0d021b1708798d92d7ed811929681fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090554Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#747513}
-
sauski authored
Previously the Recent Site Permissions display list update needed to be manually triggered (probably by it's parent). This CL extends the element to be a route observer so that it can re-trigger updates when appropriate. Updates are triggered when the route matching that set on the route-path attribute of the element is navigated to. Bug: 1032584 Change-Id: Id29191b6586c138e1e1191aaab218c5f7ff92a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088643Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#747512}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/987ef4825826..45affde3a9c5 git log 987ef4825826..45affde3a9c5 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d9b6439..4ea51a0a (746902:747324) 2020-03-05 titovartem@google.com Add printout of supported codecs in PC test framework 2020-03-05 ilnik@webrtc.org Fix RtpReplayer so what vp9 fuzzer would work Created with: gclient setdep -r src/third_party/webrtc@45affde3a9c5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1030755 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6cf6e1d38553778a87ed73013075e69a65e0aff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747511}
-
Piotr Bialecki authored
This reverts commit 2f69de56. Reason for revert: bisect identified this CL as the reason for crashes on Android - see bug https://crbug.com/1059000. Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: I6eabcf000bcb8092c33aaf5691decf58fe110c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089965Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#747510}
-
Pavel Yatsuk authored
[Modularization] Extract InfoBarContainerLayout#Item into separate file in chrome/browser/ui/messages The interface needs to be accessible to infobar implementation because some info bars override its methods (e.g. getPriority) to affect InfoBarContainerLayout behavior. BUG=1056346 R=mdjones@chromium.org TBR=juncai@chromium.org,benwells@chromium.org Change-Id: I6e79f031fad0d48feafb30fb8ae6064702589789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082874Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#747509}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99df04e8aa24..ee8be8a36862 git log 99df04e8aa24..ee8be8a36862 --date=short --first-parent --format='%ad %ae %s' 2020-03-05 qyearsley@chromium.org git-cl: Don't throw AttributeError in git cl upload --retry-failed Created with: gclient setdep -r src/third_party/depot_tools@ee8be8a36862 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1057745 Tbr: agable@chromium.org Change-Id: I1fe6e17713b3bf12bf39245154a05febb46a69a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090639Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747508}
-
Shakti Sahu authored
This CL contains: 1 - Enabled reduced mode for native task 2 - Added metrics for reschedule, in order to investigate its importance. 3 - Added some documentation to README file 4 - Fixed missing OWNERS file Change-Id: Ia9df91b5f1d8960078f89a1c4504b4704a5187d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069439 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#747507}
-
Robert Ogden authored
Syncs the server-side changes for PrefetchProxy and plumbs it up to the //chrome level, following the same basic pattern as proxy headers. Bug: 1042829 Change-Id: I61355f70df0af557ef781da1262bec763bfbd70b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090310Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#747506}
-
Tomasz Tylenda authored
We still use this metric, so we extend the expiry date by one year. BUG=chromium:1053236 TEST=none Change-Id: I0ebf273a66440fc14f6f443473415370c3571f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087878Reviewed-by:
Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#747505}
-
Brandon Tolsch authored
This reverts commit 9a1ab2ea. Reason for revert: 8.2.264 introduced target with missing build dep that leads to flaky compile failures, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/29415 Original change's description: > Update V8 to version 8.2.264. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/d4ed59c4..4b1eadeb > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Icb829fe71c85f797f309b804f0cb9afa7e9f66f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089397 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747256} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5ce3211ad28119cd154d34509a94f32551a4f5b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090874Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747504}
-
Kent Tamura authored
Property aliases in css_properties_ranking.json5 were ignored while ComputedStyle generation. So, if an alias rank is higher than the rank of the corresponding real one, the generated field could be added to a deeper layer though the field is used frequently. This CL changes make_computed_style_base.py so that it takes into account of alias rankings. - Introduce _best_rank() to determine the best ranking value including aliases. - _evaluate_rare_non_inherited_group() and _evaluate_rare_inherit_group() use _best_rank() instead of properties_ranking[property_['name'].original] This change moves |backface_visibility_| to a shallower layer. This CL is a preparation to add 'appearance' property and make '-webkit-appearance' its alias. Bug: 963551 Change-Id: I120ee0aa250671ef8f86806ca653eb2cec63ba85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086468 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#747503}
-
Evan Stade authored
This API allows embedders to dismiss one active UI element, such as a dialog, fullscreen or a selection popup. Its intended use is to facilitate handling system back presses. The implementation aligns WebLayer Shell with Chrome behavior in that a back press will dismiss the active text selection popup rather than navigating. It also simplifies the shell's onBackPressed somewhat, and allows for future enhancements without involving the embedder. Bug: 1056468 Change-Id: I1124515f2d8498847f19439a8e24ad84b1087ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086323 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#747502}
-
Thomas Lukaszewicz authored
Removed use of the global GetInstanceForNativeUI() from BadgedProfilePhoto. Created a wrapper class to encapsulate the badge ImageView that keeps the badge icon color in sync with the current theme colors. Bug: 1056916 Change-Id: I99a71d9912f16d8102a3a244a6db974ec46c371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090309Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#747501}
-
Brandon Tolsch authored
This reverts commit 3e1332b1. Reason for revert: 8.2.264 introduced target with missing build dep that leads to flaky compile failures, e.g.: https://ci.chromium.org/p/chromium/builders/ci/Android%20Release%20%28Nexus%205X%29/29415 Original change's description: > Update V8 to version 8.2.266. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/4b1eadeb..fbadeeaf > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Iec9ca3c5afbacda564fa9f48919b31667be03f1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089399 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#747325} TBR=hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7df532cb2c70bf994cf8a4288eae013f953a1cd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090498 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747500}
-
Allen Bauer authored
Bug: 1056761 Change-Id: Ib6d53cb2afd4b2c94f91f789dbc73ad268e01051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080589 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#747499}
-
Joe DeBlasio authored
It turns out that there's a *lot* of churn in Page Info right now. This change lets me escape the torrential downpour of such changes. Change-Id: Id1468346eacc6b64afc67946f646e5c1ab48662c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090755 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#747498}
-
Xinghui Lu authored
Add tests for the StartLookup method. Bug: 1050859 Change-Id: Idfc261cdd5fbc75d359cfa40b0be5621e57f8c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086812Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#747497}
-
tby authored
We are enabling a feature under experiment to add file recommenations into the suggestion chips in the launcher, see go/cros-suggested-files for more details. We have exisitng icons to use for most file types, but 5 of them need to be adjusted for the background color of the suggestion chips. This CL adds the tweaked icons. This is a temporary measure until the new SVG icons are ready. jennyz@ suggested /ui/chromeos/resources would be a good home for these, since they're Chrome OS UI-specific but need to be accessed outside of ash. But, let me know if there's a better place for them! Bug: 1034842 Change-Id: I0da77195161e43bd12173e8b48cec151e94ae19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086360Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#747496}
-
Raul Tambre authored
In file included from ../../base/profiler/module_cache.cc:5: In file included from ../..\base/profiler/module_cache.h:14: In file included from ../..\base/containers/flat_set.h:10: ../..\base/containers/flat_tree.h(788,24): error: call to 'as_const' is ambiguous return const_cast_it(as_const(*this).find(key)); ^~~~~~~~ ../../base/profiler/module_cache.cc(36,58): note: in instantiation of function template specialization 'base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>::find<unsigned long long>' requested here const auto non_native_module_loc = non_native_modules_.find(address); ^ C:\Google\chromium\src\out\release\..\..\buildtools\third_party\libc++\trunk\include\utility(275,50): note: candidate function [with _Tp = base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>] template <class _Tp> constexpr add_const_t<_Tp>& as_const(_Tp& __t) noexcept { return __t; } ^ ../..\base/stl_util.h(167,32): note: candidate function [with T = base::internal::flat_tree<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> >, base::internal::GetKeyFromValueIdentity<std::__1::unique_ptr<const base::ModuleCache::Module, std::__1::default_delete<const base::ModuleCache::Module> > >, base::ModuleCache::ModuleAndAddressCompare>] constexpr std::add_const_t<T>& as_const(T& t) noexcept { ^ And others like this... Bug: 752720 Change-Id: I1eeb9c0b1ebaf90a9df503c5b7d9f4629236d8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089821 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747495}
-
Jan Wilken Dörrie authored
This change Simplifies the static_asserts in base::span's fixed subview API first<Count>(), last<Count>() and subspan<Count, Offset>(). These simplifications rely on the fact that dynamic_extent is equal to std::numeric_limits<size_t>::max(), and thus will never be smaller than any other possible value. References: - https://cplusplus.github.io/LWG/issue3103 - https://github.com/cplusplus/draft/commit/6a0aa7 Bug: 828324 Change-Id: I626b7e65b1ae8010485c4387a936704810e43fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089843 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747494}
-
Nate Fischer authored
This shows the dev UI launcher icon by default for: - channel-less builds (to facilitate local development) - dev & canary builds (targeted at users subscribed to those channels) Prior to this change, this was only enabled for Dev & Canary. No change to runtime logic. Bug: 1052017 Test: build with a default `android_channel`, observe icon Change-Id: I050bc8dd3ea78c2c54d3ae783656a7752afc8faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090470Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#747493}
-
Raul Tambre authored
../../base/strings/string_util.cc(930,7): error: call to 'empty' is ambiguous if (empty(parts)) ^~~~~ ../../base/strings/string_util.cc(959,10): note: in instantiation of function template specialization 'base::JoinStringT<std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >, std::__1::basic_string<char> >' requested here return JoinStringT(parts, separator); ^ C:\Google\chromium\src\out\release\..\..\buildtools\third_party\libc++\trunk\include\iterator(1899,16): note: candidate function [with _Cont = std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >] constexpr auto empty(const _Cont& __c) ^ ../..\base/stl_util.h(102,16): note: candidate function [with Container = std::__1::vector<std::__1::basic_string<char>, std::__1::allocator<std::__1::basic_string<char> > >] constexpr auto empty(const Container& c) -> decltype(c.empty()) { ^ Bug: 752720 Change-Id: I4382b78e772743976cd0bd3682f81c64788c9bb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089762 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#747492}
-
chrome://app-management/dpapad authored
The chrome://app-management page has been removed and those files even though included in the ChromeOS build, were not actually used anywhere. Fixed: 1002782 Change-Id: I469ba0b975a396515c5f897859e1f56fc0c4d704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090458 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#747491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59ccb910d003..b26fbdde1b2d Created with: gclient setdep -r src-internal@b26fbdde1b2d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1054351,chromium:1058522,chromium:996148 Tbr: jbudorick@google.com Change-Id: I99844707be7eb7d7f42422e2b761d73ae57da5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747490}
-
Doug Arnett authored
If auto translation is triggered for a site when you navigate to a link, there is code that intentionally stop the Translate info bar from being shown. Unfortunately, that code also stops the Translate info bar from being shown when the overflow menu Translate feature is selected. This change will make that check conditional on it not being a menu selection so it will show from menu action but not automatically on auto trans navigation. Bug: 1056400 Change-Id: I72d09264b170498b27af321e6b879ff249cf63bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082910Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#747489}
-
Natalie Chouinard authored
Move Contextual Search settings alongside Contextual Search code. Bug: 1047357 Change-Id: I0b8bd5e9f666df98efd4ac0b77e6ee118ec35fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086073 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#747488}
-
sczs authored
At the time there were various failures on iOS12. I can't repro locally now I'll re-enable and monitor since I'm sheriffing. Bug: 1049972 Change-Id: I0345fd704dcef24285d461ca07244baafb06c163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090608 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#747487}
-
rbpotter authored
Bug: 1026426 Change-Id: I3f46461373385d91008a5ae9d81498a122eca5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088357 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#747486}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ca48851. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" acf33020 "Add testing for the scrolling attribute" 3e43336a "Update performance.measureMemory to the latest proposal" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I162c685b6370fd47d71ad0e1411c03ec550c5e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089407Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#747485}
-
Robert Ogden authored
Any origin in the chain that is ineligible for the feature stops the chain from being followed any further. Redirects do not count against the max number of prefetches. Bug: 1023485 Change-Id: If00c0620f7f34e3b6db7c8ef52a862c6e7440441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085706 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#747484}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/296d1dc00641..c8aaddeaf3ea $ git log 296d1dc00..c8aaddeaf --date=short --no-merges --format='%ad %ae %s' 2020-03-03 martin arm64: mc: NEON implementation of w_mask for 16 bpc 2020-03-04 janne-vlc CI: run a selection of jobs on a node with avx2 2020-03-04 gramner x86: Fix crash in AVX2 cdef_filter with <32-byte stack alignment 2020-03-03 martin arm64: mc: NEON implementation of blend for 16bpc 2020-03-04 martin arm: mc: Optimize blend_v 2020-03-03 martin arm64: mc: Treat the stride as a full 64 bit (potential signed) value in blend_8bpc_neon 2020-03-03 martin arm64: mc: Fix indentation 2020-03-03 martin arm64: mc: Use more intuitive lane specifications for loads/stores 2020-02-25 jb Update NEWS for 0.6.0 2020-03-03 janne-vlc CI/armv7: use `linux32 meson ...` to allow running on aarch64 2020-02-18 martin arm64: loopfilter: NEON implementation of loopfilter for 16 bpc 2020-02-18 martin arm: loopfilter: Prepare for 16 bpc 2020-02-25 martin arm: loopfilter: Fix a comment 2020-02-17 janne-vlc fuzzing: link the fuzzing binaries as C++ 2020-02-17 janne-vlc fuzzing: split the fuzzing targets to their own meson.build file 2020-02-20 gramner x86: Add mc w_mask 4:4:4 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:2 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc w_mask 4:2:0 AVX-512 (Ice Lake) asm 2020-02-20 gramner x86: Add mc avg/w_avg/mask AVX-512 (Ice Lake) asm 2020-02-14 victorien x86: optimize cdef_filter_{4x{4,8},8x8}_avx2 2020-02-12 victorien x86: add a seperate fully edged case to cdef_filter_avx2 2020-02-19 gramner checkasm: Improve the cdef input randomization algorithm Created with: roll-dep src/third_party/dav1d/libdav1d Fixed: 1057531 TBR=tguilbert Change-Id: I2d240c53ace18092001fe80e930a12f5a93bb328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090615Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#747483}
-
- 05 Mar, 2020 9 commits
-
-
Nico Weber authored
Bug: 1053958 Change-Id: I87b12a7d8d032825c52bf195e1d7114a2ba0aae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088042 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#747482}
-
Avery Musbach authored
When you drag an ARC window from one overview grid and drop into another overview grid, it shall neither cause a crash nor cause overview to end. Test: manual Bug: 961170 Change-Id: Iac895e4f896cf652dc2d522f3f1b8a4c1765416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088507Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#747481}
-
Jarryd authored
Change the default behavior to enabled, update unit tests to match new default behavior, and remove fieldtrial testing config. Bug: 960305 Change-Id: I8f045648c73ab8787dddc2a75d576f23c13dac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090451 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#747480}
-
btolsch authored
TBR=rogerta@chromium.org Bug: 1059060 Change-Id: Ifc21f291edd39fbab294722d3be8d74e4a2f3a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090718Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#747479}
-
Carlos IL authored
Committed interstitials have been launched in non-webview platforms since M80, and will launch in webview in M81. Landing this ahead of the M81 webview launch since flipping the flag unblocks a CTS fix. Bug: 1047527 Change-Id: I0f196669a0d5e80c6d0c674a9eaab574605e04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090611 Commit-Queue: Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#747478}
-
Reilly Grant authored
In r745013 we introduced a case where createPermissionClickCallback() can be called with both a null intentOverride and androidPermissions. This change adds the missing null check. Bug: 1058746 Change-Id: I5971f20b18b193ba664ab8f24a0a03841da32b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090174Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#747477}
-
Toni Barzic authored
Adds support for learn-more-link attribute to settings toggle button - the attribute adds "Learn more" anchor element to the setting sublabel, and triggers an event when the link is clicked (used to record the user action for metrics). Uses the new attribute in manage_a11y_page for show shelf navigation buttons setting - "learn more" will link to a help page article, but the URL has not yet been finalized, so keeping it blank for now. Also, adds a user action for clicking the link to metrics. BUG=1050544, 1055688 Change-Id: I4126a6a85bf54c0039d2a14063f83f1e08db0d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069847Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#747476}
-
Mehran Mahmoudi authored
This CL: 1. Removes Android-specific code from paint_preview_base_service.(cc|h). 2. Replaces the PaintPreviewBaseService Java class with the NativePaintPreviewServiceProvider interface. This enables each implementer of paint_preview_base_service.cc to independently handle its JNI communications. Bug: 1058405 Change-Id: Id629aa95560cb4c0f202079c1437a16c67798d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090592Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#747475}
-
Noel Gordon authored
The iconSet property of most volume types is empty, but we expect that third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System Providers) should provide icons in their respective iconSets. CL:2032469 added a shouldProvideIcons() helper to volume manager so we can detect these volumes. ANDROID_FILES is done (CL:1945958) and noted File System Providers and DOCUMENT_PROVIDERS were still todo. In this change, use the shouldProvideIcons() helper to detect the File System Providers and DOCUMENT_PROVIDERS that provide no icons, and use a generic icon for these volumes instead. files-ng only: this to avoid drawing a dull gray box for these volumes in files-ng if they provide no icons. Bug: 992819 Change-Id: Ia2b4c6caf70d3b8250acc8d9706f476a486199ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089178Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#747474}
-