- 01 Jun, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a411e6d3..0c4c2415 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5a37709fee32895126266e7321239972925d771e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224649Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773802}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/78b3337a10a7f7b3495b6cb8140a74e265290898..2309f645e509507a1cc8f9845771110fcf986fd9 The following commits have update notes: 9701e84ef Remove RAND_set_urandom_fd. Bug: none Change-Id: I491b0f82ef9381e445cc38f19cc8520874b7a6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220279 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#773801}
-
Yuly Novikov authored
test-launcher-batch-limit arg is being ignored by the harness, requiring increasing timeout since all tests run in one batch. TBR=jmadill Bug: 1089265 Change-Id: I7199328fa9f3ad13cd69a12d74066e85fd3cbb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224835Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#773800}
-
Bruno Dal Bo authored
Change-Id: I69b7908d041c85e0265ec8277887ea00ea5cd463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220626 Commit-Queue: Bruno Dal Bo <brunodalbo@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#773799}
-
Samuel Huang authored
SuperSize metadata fields can be specific to containers (e.g., filename) or be common among them (e.g., GN args). This CL changes SuperSize to represent these separately: * Add BaseSizeInfo.build_config to represent common fields, which are: {git_revision, gn_args, linker_name, tool_prefix}. * Keep SizeInfo.metadata (with above fields moved). It will be moved once we introduce the Container class. The change affects internal data structure, but *not* .size files. * Add SizeInfo.metadata_legacy to support this: It fuses build_config with metadata, for the (current) one-container case. Other changes: * Replace describe.DescribeMetadata() with describe.DescribeDict(), to be used for build_config and metadata. * Fix lint warnings in diff_tests.py (assertEquals() -> assertEqual()). Bug: 1040645 Change-Id: I5db9e91a72abf3b7c4a0606adcd85db4afbddd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224637 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773798}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1045266 Change-Id: I7589bed370e5b64cd302e95df83049c211a48953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222889Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#773797}
-
Nina Satragno authored
Disable flaky test ChromeRenderWidgetHostViewMacHistorySwiperTest.InnerScrollersOverscrollBehaviorPreventsNavigation TBR=erikchen@chromium.org Bug: 1070405 Change-Id: I9172489f113de25784c1ca7946a9b707ef797956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225499Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773796}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I307d7afb178dcb588d09e74a1bd98b4b7ef525d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225125Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773795}
-
Peter Kasting authored
Bug: none Change-Id: Iced87f066a842db371a7936ecff0644caac2e7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218680 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773794}
-
Michael Chang authored
There were a few issues with end-to-end testing macOS updates with the new updater. This CL fixes the following issues: 1) When there was a space in the existence checker path, we did not add the arg correctly. We also weren't passing version to the updater script. 2) Network fetcher was not passing the post data from the server. It was instead passing the response description which did not have the response json. Instead we should pass the _downloadedData that we aggregate. 3) Network fetcher was giving status code back to the downloader. When the status code was 200 (Ok), we were still error-ing out as the expected value passed to _downloadToFileCompleteCallback when we are successful is 0. Change-Id: I9e620d4701697403f2e8899cf14c41ce36a653ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220618 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#773793}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/471c120ac92a..6f5ff495681c 2020-06-01 capn@google.com Fix deallocation of uninitialized pointer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idf061087d6c7814ecda3e81c79e5a21485bf7d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225297Reviewed-by:
-
Ella Ge authored
1. Record whether the client app enrolled location delegation 2. Record when the client app's permission state changed. Bug: 1069506 Change-Id: Ib9b6e161205b0a0b9b51c4b3fea169cf4abc3fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216742Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#773791}
-
Andrew Grieve authored
via a custom patch to it that causes it to consider all -keep rules to have implicit ",allowaccessmodification". Causes many more downstream play services methods to be removed. Change-Id: I9532fe9621d9a011202a1b9044cb3467ae207a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223651 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773790}
-
Nina Satragno authored
Mark fast/scrolling/no-hover-during-scroll.html as flaky on all platforms. Previously it was marked as flaky only on linux. TBR=lanwei@chromium.org Bug: 914782 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I2f2333eb21c4f47453718fab706d71a3ba56aeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225501Reviewed-by:
-
Filip Gorski authored
This is a change that will hopefully help us understand the regression and in the long run propose a reasonable trade off between memory cost of view reuse, performance and functionality we get. As an added bonus, this should make the view creation numbers match those of a ListView more closely. Bug: 1087720, 1087691 Change-Id: Iaaccb17f1eaa59058179e476ef303cfdaff68611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225128 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#773788}
-
Jeroen Dhollander authored
This flag |LibAssistantBetaBackend| can be given as a command-line flag, and will tell LibAssistant to use the BETA_DOGFOOD backend. As a practical side-effect, this will show more useful information in the logs, like the actual queries that were submitted. Bug: b/157557676 Change-Id: I580461b649cdbae74f1d658329b1135d73823fdd Tests: Launched Assistant with and without this flag. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225260 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#773787}
-
Maxime Charland authored
This flag will be used to show or hide the new UI in Chrome empty states. Bug: 1086688 Change-Id: I885d642f1f2e87f9b3b3346f3c1c7f8f80f064dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216547 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#773786}
-
Mason Freed authored
This class was previously only (really) used in HTMLViewSourceParser, so this CL folds it into that class. This CL should not change any functionality. Bug: 901056 Change-Id: Ia47e5da05b586c542c4ff93a94dafdb439f22dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225124 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#773785}
-
Stephan Hartmann authored
Defining __has_builtin to 0 for non-clang compilers in base headers can lead to wrong detection of features. For example in base/location.h checking for __has_builtin macros succeeds for non-clang compilers, because base/check_op.h defines __has_builtin to 0 and is included before base/location.h. Instead of defining __has_builtin to 0 for non-clang compilers, define an independent preprocessor symbol that reflects support for requested feature. Undefine the symbol to avoid collision. While we're at it fix base/memory/aligned_memory.h too. Bug: 819294 Change-Id: Iac40dc44e7356b600e7d06aa4ccd1294bb09ebce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224252Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#773784}
-
Bo Liu authored
Android has a browser-side timeout for establish channel which is usually the #1 crash on the stable channel. This CL will try to perform a DumpWithoutCrashing in the gpu process when this timeout happens to gather more data. Bug: 680777 Change-Id: I21e1701c359afc57e31a50403d59ba9a94a2baae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222919Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773783}
-
Chris Lu authored
When FullscreenController is scoped to the Browser, fullscreen viewport inset updates are handled downstream, so BVC no longer has to respond to FullscreenUIElement callbacks by updating the viewport insets. Bug: 790886, 1090044 Change-Id: I52e08694b38d36ae6137b641b2b9be07a7bd4191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222292 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#773782}
-
Mike West authored
Step 13 of https://w3c.github.io/ServiceWorker/#on-fetch-request-algorithm should exclude `embed` and `object` requests from Service Workers. Our implementation handles this correctly for the initial request, but failed to bypass the Service Worker for subsequent navigations. This patch adds a destination check to `ServiceWorkerMainResourceLoaderInterceptor::ShouldCreateForNavigation`, and ensures that the `destination` for a given request is set early enough in the lifecycle to ensure that the check succeeds. See also https://github.com/whatwg/fetch/pull/948. Change-Id: I21a1d37da438e1d0f185696f2b3b4058bc3911fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209456Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#773781}
-
Devlin Cronin authored
A dialog may close through: - The user clicking the "accept" button (-> accepted) - The user clicking the "cancel" button (-> canceled) - The user clicking the 'x' button or escape key (-> closed) - The dialog closing for some other reason, such as the parent window closing (-> ??) This CL adds a separate entry to track those times, as well as adding unit and browser tests to cover the flow. Bug: 1079364 Change-Id: Iad60fd42a0ebbcbbb6fed16f9cedff77ad14eea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225143Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#773780}
-
Kai Ninomiya authored
According to upstream spec changes. Bug: 1069302 Change-Id: I191528911b2d20a23e6438548b2c56be37721059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222298 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#773779}
-
Maggie Chen authored
if DirectCompositionSurfaceWin::Initialize() fails before dcomp_device_ is created. It will cause access violation at dcomp_device_->Commit() in DirectCompositionSurfaceWin::Destroy()/ ~DirectCompositionSurfaceWin(); Bug: 1088408 Change-Id: I57c07599b2bb5f6f42e48128c25d4f74da65ff8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225328Reviewed-by:
-
Jenny Zhang authored
App list sync may have some edge cases that lead to the creation of single item folder which is not legitimate for launcher. When user signs in a new session, app list sync service will download all the sync data from sync backend and merge them with the cached sync data in local storage. We will detect the single item folder sync items and clean them up right after the initial merging completes in AppListSyncableService. Therefore, the single item folder should go away from the launcher UI after user starts a new session. This does not fix the root cause of issues that lead to the creation of the single item folder, but makes it a little better with a remedy. We will also fix root cause of the issue for the cases we can repro in separate changelists. Bug: 1082530 Change-Id: I95098e0c97eb3faaf8d90d6654d9f1ca8a60094c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219176Reviewed-by:
-
Ted Meyer authored
rewrote the TODO as well. Bug: 1088055 Change-Id: If83ceeb3a786a1813e41bd3ac6c7309791e92400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223010 Auto-Submit: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#773776}
-
Chris Hamilton authored
A follow-up CL will cleanup all of the scattered hooks, clean-up unittests, and make the CreatePageNodeForWebContents logic not expect to be called repeatedly. BUG=1085129,1090011 TBR=vasilii@chromium.org Change-Id: Ib257c37e07f8650c10667df25b4aafe8aa172472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220364 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#773775}
-
Jon Mann authored
This was accidentally removed as part of an earlier refactor. Made the check explicit and added unittests. Bug: 966270 Change-Id: I5b41b09623c9de41cbcd29e0b9802be93250a0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222722Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9914459efe8168ebd2acbddc951e5296d0b1afaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224831Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#773773}
-
Xianzhu Wang authored
This reverts commit 64bcb13d. Reason for revert: Tentative for crbug.com/1086968. Original change's description: > Fix layer/phase violation of custom scrollbar painting > > TL;DR, with this CL: > - We no longer update custom scrollbar part position during paint; > - We avoid unnecessary ScheduleAnimation when painting custom > scrollbars; > - CustomScrollbar::*Rect() methods no longer have side effects; > - Some FIXMEs are fixed. > > Details: > > Previously LayoutCustomScrollbarPart::FrameRect() stored different > values at different document lifecycle stages: > > - Before paint, its location was always zero, and the size was not the > actual size for some parts, but the minimum size calculated from the > style, not based on layout, though updated in UpdateLayout(). > UpdateLayout() was called not during layout (as a scrollbar part is > not in the layout tree), but anytime we wanted the minimum size from > const methods of CustomScrollbar. > > - During paint, as the FrameRect() calculated during UpdateLayout was > not the real frame rect, we updated the frame rect to make sure they > would be painted correctly. This caused unnecessary > SetShouldCheckForPaintInvalidation when the FrameRect changed and > unnecessary ScheduleAnimation(). > > This CL contains the following changes: > - Removes LayoutCustomScrollbarPart::UpdateLayout(). > Adds ComputeThickness() and ComputeLength(), and lets Margin*() get > style directly, to replace the original UpdateLayout() (which called > SetSize()/SetMargin*()) + Size()/Margin*() in the const methods of > CustomScrollbar. This removes the dependency of the const methods > on the temporary incorrect FrameRect(). > > - Adds CustomScrollbar::PositionScrollbarParts() to set the correct > FrameRect() for scrollbar parts. It's called from several places that > position of scrollbar parts can change. This replaces the Set* called > from CustomScrollbarTheme::Paint*. > > Bug: 856802 > Change-Id: I5b120294a31a7f91831441cb361adfd27aefa44e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167602 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771890} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 856802, 1086968 Change-Id: If1703dcda1d4cb6a53a132557b34867090f397ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225222Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773772}
-
Matt Menke authored
Fixed: 1088510, 1089026, 1089007, 1089005, 1088996 Bug: 1088998 Change-Id: I5d6f67d711cf2122616d77a2d35b49eaf3c452de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224646Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#773771}
-
Teresa Kang authored
According to the flake portal, these four OffscreenCanvas tests have been marked as flaky. Updated the test expectations accordingly. Bug: 1088007 Change-Id: Ide12f3ef53f05ed7d855ed8924a95a7089a32060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222893 Commit-Queue: Teresa Kang <teresakang@google.com> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#773770}
-
Erik Staab authored
android_cronet_tester is a duplicate of android-cronet-arm-dbg. It appears to have been accidentally duplicated in https://crrev.com/c/1576160. Change-Id: I1e324348a40d8d5cb4015de49c5c9a586f292271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220806Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
Adam Langley authored
The parser called on the changed line demands a Python |str| type, but |contents| here can be a |unicode|. The |str| converter in Python 2 assumes an ASCII encoding and thus throws an exception if any characters are > 127. This means that any changed .mojo files that contain non-ASCII characters cause a presubmit error. One can't remove those characters either because the presubmit parses the previous version of the file too. Thus all changes to .mojo file with non-ASCII characters are blocked without this. Change-Id: I887890590c8ad97a4fac60d19a8bebce439abacc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223973 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#773768}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71a35d49b734..33dbd656112d 2020-06-01 adlai@google.com Pass file and line number when asserting single owner 2020-06-01 johnstiles@google.com Reland "Remove double support from SkSL." 2020-06-01 johnstiles@google.com Fix strict-constraint bleed in strict_constraint_[batch_]no_red_allowed. 2020-06-01 kjlubick@google.com [canvaskit] Use scratch arrays for colors and matrices 2020-06-01 senorblanco@chromium.org Dawn: fix Device leak in DawnTestContext. 2020-06-01 johnstiles@google.com Revert "Remove double support from SkSL." 2020-06-01 ethannicholas@google.com Revert "Omit dead SkSL functions" 2020-06-01 adlai@google.com Make abandonment state of context thread-safe 2020-06-01 brianosman@google.com Convert GrMatrixEffect to pure CPP/H 2020-06-01 ethannicholas@google.com Omit dead SkSL functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: Ice02a1a7bcf8a2c093253d2e6a2e711ddf5f3093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225074Reviewed-by:
-
Jeroen Dhollander authored
The old name, ChromeOsOnDeviceAssistant, is simply too long and the |ChromeOs| doesn't add anything extra. Change-Id: Ie7e742672a7440d22404366ccbe92b35f80da89c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225261Reviewed-by:
-
Kevin Babbitt authored
https://crrev.com/c/2117330 refactored accessibility hit testing to use physical pixel coordinates consistently but overlooked the fact that MacOS passes hit test points in device-independent coordinates. This CL scales the input by device scale factor to compensate. Test will come in a follow-up CL. Bug: 1086819 AX-Relnotes: Fixes an issue with accessibility hit testing on the Mac. Change-Id: I3fcc2cee34082e58d7fd38fdc219672680674095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225334Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#773765}
-
ckitagawa authored
This is a reland of 09cf456a Failures were due to flakiness in FileManagerTest.OldestFileForCleanup Timing of last modified time seems to be racy leading to inconsistent behavior. The fix for this is manually setting the modified time to something longer. Original change's description: > [Paint Preview] Create total size budget > > This CL introduces a mechanism to determine the oldest files and > enforce a total disk size budget for captures. By default this is set to > 25 MB for the tab service. This will ensure we don't use excessive disk > space. > > Bug: 1086963 > Change-Id: I71bd8efa5985214b322a4dc3048afbe4d0b717f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218548 > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#772809} Bug: 1086963, 1087592 Change-Id: Id95442afcdeb55e60cafc4a8bf6cebef84b3fc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220483Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#773764}
-
Sergey Ulanov authored
This is a reland of 92842b6a Original change's description: > [Fuchsia] Add WebEngineIntegrationTests.PlayVideo test > > Previously there were tests that play audio and tests that play video, > but no tests were playing a file with both audio and video. Also video > was not played to the end. Added PlayVideo test that plays > bear-vp9-opus.webm to the end. Also updated SetBlockMediaLoading tests > to share play_video.html and reduce amount of duplicated code. > > Bug: b/153914562 > Change-Id: Iba492ec252f692f7aa3f93c319d858a91bb38278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219404 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773338} TBR=kmarshall@chromium.org Bug: b/153914562 Change-Id: I7f0c0d7040861d03dfd505c594eca1ccd0827ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223260Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773763}
-
