- 21 Oct, 2020 40 commits
-
-
Jesse Schettler authored
Replace the temporary app icon with the finalized app icon. Bug: 1059779 Change-Id: I6105da8922cb0ccc0ac40c9fe061ebdb8ec9a44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486480Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#819387}
-
Elly Fong-Jones authored
It flakily hangs, which is being investigated but is not a blocker since the hang watcher isn't shipped on Mac currently. Bug: 1140207 Change-Id: I47ab3bfc8770c85b0b3de608295ade53a43e7669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486078Reviewed-by:
Oliver Li <olivierli@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#819386}
-
Finnur Thorarinsson authored
It is a much simpler and easier way to load native in the PWA Install test for IPH. Bug: 1135551 Change-Id: I4d20f9ac5a4cfd1cdc00f81bae713c4b514c54d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489902Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#819385}
-
Ramin Halavati authored
Unnecessary code is removed from GuestProfileWindow browser test. Bug: 1125474 Change-Id: Ica812265c273a8cfe041046a44ce65e8c8b0f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490101Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819384}
-
Wei Li authored
Add support for unique_ptr type of properties. Set their type converter to be non-serializable. Convert Combobox's 'model', 'owned_model', and 'callback' into properties. And apply them into the example builder to show the usages. Bug: 938501 Change-Id: I065f35420e266a0641754edf8edfebd8188f4144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477484 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819383}
-
Ramin Halavati authored
Ambient Authentication browser tests are updated to cover both current and ephemeral Guest profiles. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I76a6e4ec9de4dd079377ed3d01a68cfdc3fe6cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488563Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#819382}
-
Olivier Li authored
Change-Id: Ie80616b0071da96a1879f84ba67c0c9fb08af6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490222Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#819381}
-
Nidhi Jaju authored
This is a reland of b52b97cb Original change's description: > Remove NotEnumerable from Transform Streams WebIDL > > According to https://github.com/whatwg/streams/pull/1035, all methods > and accessors are now enumerable, per Web IDL defaults, instead of > non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can > be removed from the Streams WebIDL files. This CL specifically > removes them from transform streams. > > Bug: 1093862 > Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006 > Commit-Queue: Nidhi Jaju <nidhijaju@google.com> > Reviewed-by: Adam Rice <ricea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819230} Bug: 1093862 Change-Id: Ic3d119e1c5d2192a3159fb672a5782fa2af8aedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488946 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#819380}
-
Fernando Serboncini authored
Change-Id: I5eec0c769d43c51078d759f4f9765b8b3d792c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490381Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819379}
-
Paula Vidas authored
Server puts the invalidation payload in message.raw_data, and not in message.data["payload"]. Bug: 1140988 Change-Id: I92a01fc6e7e83cc0065fb464660dd6e25a5cbe27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489888Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Paula Vidas <paulavidas@google.com> Cr-Commit-Position: refs/heads/master@{#819378}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d139f2661939..9606cffa66d0 2020-10-21 fmayer@google.com Support PERFETTO_EINTR in clang-tidy analyzer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4e5dfff37bc9c8d19b0f2edfb4b525ce86ee403c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490066Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819377}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ffad5d3b2d0a..01771c17f1d6 2020-10-21 robertphillips@google.com Increase encapsulation of GrThreadSafeCache::Entry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: egdaniel@google.com Change-Id: Ic4993ef9e30a33a0c446de3a7451b65b90fd329d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490067Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819376}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7854287f1b6c..ee87b994218e 2020-10-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-21 sigurds@chromium.org Increase timeout for long-running test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140926 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6c4167a4cac59311c0366c3534f2a29ecc46e465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489769Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819375}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f176182440e7..7b3ad4f25a17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com,sebsg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com,sebsg@google.com Change-Id: I43740d81653785374ae01b975e2230d9da94371c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489664Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819374}
-
Mugdha Lakhani authored
Deletes three methods that aren't used anymore. Bug: 1106294 Change-Id: Id330a6b8b56d339f3a596fcdefea9d5c21b32f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478947Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#819373}
-
Mihai Sardarescu authored
As is_default_promo_account is always true for the native turn sync on promos, this CL removes this argument from the DiceBubbleSyncPromo and its delegates. Bug: 1140978 Change-Id: I343b9e1a8cab16232f618bd7ca34bcbfdb44748f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489982Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#819372}
-
Sylvain Defresne authored
The parameters of a script invocation needs to be relative to the directory where the script is invoked which is available as the `root_build_dir` variable. Using `root_out_dir` is incorrect as it has a different value for secondary toolchains (i.e. current_toolchain != default_toolchain). Bug: none Change-Id: I3fc329e27657377493c3c7cca6b7ff060531ec87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489624 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#819371}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0a69b07fe85f8ddab1929ee0e8b22a4213d3bda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490160Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819370}
-
Kent Tamura authored
... from LayoutTextControl*Line to HTMLInputElement and HTMLTextAreaElement. Reasons: - The mocking behavior is a matter of DOM, not layout. - Share the logic between the legacy layout and LayoutNG - Avoid a layout-overflow incompatibility described in the bug This CL has no behavior changes. Bug: 1138820 Change-Id: I437efed89e01f50896fa24d41735d2dfe9e0c00b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488963Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#819369}
-
Anatoliy Potapchuk authored
This reverts commit 98e662e4. Reason for revert: this seem to break Win7 builder https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/85993 Original change's description: > [base/allocator] Support mallinfo() for PartitionAlloc-Everywhere. > > mallinfo() is used by MallocDumpProvider, and ProcessMemoryMetrics. The > first one can also use the extended API of PartitionAlloc to report > data, but the second one uses mallinfo(). To support both, implement > mallinfo(). > > Bug: 998048 > Change-Id: I9d71cd3a7bbf5c766cfc3771907c2f51ac17cace > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426708 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819010} TBR=lizeb@chromium.org,wfh@chromium.org Change-Id: Ibfbc278d7057808ce1a66150e2a8f516bdaab230 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 998048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489626Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#819368}
-
Jonathan Backer authored
Tested by hand on gLapstation with GLX and ANGLE backends. GLX works as intended. ANGLE tickles a driver bug that causes a GL_OUT_OF_MEMORY error and followed by a driver crash on glDrawElements. This forces a redraw of everything so is a better user experience than just showing corrupted textures. Bug: 1113040 Change-Id: I404441e1c39541aa925931c15364b4d1ee6761b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456190 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819367}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603259905-a5ed8d755823b45d7d48d45a9bc14c01d1293c89.profdata to chrome-linux-master-1603281470-f96bc0fcebd9344c6ef9fb677ad5905993ab5142.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic349728be5d12468efc1dd0c7d55e83ebf3ac573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819366}
-
Rachel Wong authored
This is a reland of be611a0e. The |selected_action| member variable was sometimes uninitialized before being accessed, causing msan failures. This reland initializes the variable. Original change's description: > Enable Suggested Content by default. > > The Suggested Content toggle has been approved in > https://bugs.chromium.org/p/chromium/issues/detail?id=990279#c148. This > CL enables the feature by default, and updates tests that need to take > this into account. > > Bug: 990279 > Change-Id: Icc2c8bdf72cff8734aa5941f3fbc2774b38e4c98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462752 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Rachel Wong <wrong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818758} Bug: 990279 Change-Id: I17ac908b10fef847ed02c0a08980417c1d1998c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488261Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819365}
-
Evan Shrubsole authored
Two variations for applicable platforms (chromeos and mac). On mac, this feature will only be used in combination with the 0-copy feature AVFoundationCaptureV2. Bug: 1134165 Change-Id: Ic630d292041499d0364bf6d7935d278678595f68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487103Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#819364}
-
Ossama Mahmoud authored
Make the user actions `kDoItLater` and `kShowSensorLocation` obsolete in enums.xml. Bug: 1130482 Change-Id: Ibc4d907862dce5a420970e4e02168799e439b17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489981 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#819363}
-
Michele Mancina authored
Bug: b/170722915 Change-Id: Ide6bebda310e2c361f117988af701f28cc9bc02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485510 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Auto-Submit: Michele Mancina <micantox@google.com> Cr-Commit-Position: refs/heads/master@{#819362}
-
Elly Fong-Jones authored
This test is flaky, I think by design. Bug: 1140651 Change-Id: I4f60d97b8fcc553407b33a260e91f1004615e88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488398 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#819361}
-
Erik Staab authored
Capacity was added for these in https://crrev.com/i/3351717. Bug: 1124829 Change-Id: I8665012f6bad3c2ce8734f51f3e4f6dbf13bbad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488713Reviewed-by:
Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#819360}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/553726a4c5c8..99f9277c5bcb 2020-10-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from df17a76102df to 84f5eeb6dd9b (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I42f0d134542483d778e79d04b52557b4aa5a846c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489750Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819359}
-
Sigurdur Asgeirsson authored
Bug: 1089528 Change-Id: I525693ed054e3c8d33bba6d6ee68ae3c8b82833d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485514 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819358}
-
Rohit Agarwal authored
This CL simplifies the profile usage in ToolbarPhone and also adds instrumentation tests. Bug: 1060940 Change-Id: Id2562d2d935914ccb57ade262d667d7c37234c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488566 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#819357}
-
Ben Goldberger authored
This is to resolve a possible conflict with dogfood on dev channels Bug: 1092713 Change-Id: Ice0fe8a473c04599500a438af7c971a540457256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485575Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#819356}
-
Ramin Halavati authored
To audit incognito clean ups at startup, |Android.ShouldDestroyIncognitoProfileOnStartup| metric is added to collect the call results to |IncognitoUtils.shouldDestroyIncognitoProfileOnStartup|. Bug: 1095548 Change-Id: Ica7aa5228b783a91beb491d6f9aaf07b6cb96bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479466 Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#819355}
-
Illia Klimov authored
GURL was saved as a pointer. That caused a null pointer exception. TBR=engedy@chromium.org Bug: 1140610 Change-Id: Iacfcbb54737e330a161ffe2aabe3c2dfa4790493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490000Reviewed-by:
Illia Klimov <elklm@google.com> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#819354}
-
Natalie Chouinard authored
These histograms will be evaluated as part of the upcoming HaTS-next migration. Bug: 1140012 Change-Id: I4d4e45968c80ec114f2968ed00d8966045a88b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488092Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#819353}
-
Finnur Thorarinsson authored
This CL switches to using SetTestingFactory, thereby removing the need for injecting the wrapper at startup via a command line flag. Bug: 1135551 Change-Id: I29c4c1be56fb9d613b49876cbe6ece4e390c5b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485251 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819352}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b432d0b75765..ffad5d3b2d0a 2020-10-21 kjlubick@google.com [canvaskit] Fix gm test runner on non-tryjobs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Ide1c9986183368886616cb915c682b17ae81a678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489762Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819351}
-
Huanzhong Huang authored
- Make the "You and Google" and "Auto-fill" sections visible, when settings is based on an ephemeral guest profile. - The notion of Ephemeral Guest profiles (go/ephemeral-guest-profiles) is to be replacing the current guest profiles. Bug: 1140419 Change-Id: If10584bb4a8105275c2eac8c581c7abccf545225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483753Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#819350}
-
Alice Wang authored
TBR=sandromaggi@google.com Bug: 1140957 Change-Id: Ibc27ca9632d9bba356fc4c628a49bd51034b3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489623Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819349}
-
Sylvain Defresne authored
The parameters of a script invocation needs to be relative to the directory where the script is invoked which is available as the `root_build_dir` variable. Using `root_out_dir` is incorrect as it has a different value for secondary toolchains (i.e. current_toolchain != default_toolchain). Bug: none Change-Id: I573af8eb46c001fbedc641f5e47022f0424284c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489622 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819348}
-