- 10 Dec, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Bug: 1100887 Change-Id: I000ab80315270109c59f0a80c4fbfac2addc77ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583209Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#835651}
-
Wojciech Dzierżanowski authored
The custom visibility handling was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1443011. The accessibility issue (tooltip shown for an invisible label) does not reproduce anymore. The issue of interfering with dragging is still there, so we keep the workaround for that. Bug: 985303 Change-Id: I2a8380aa68c7bebe837246b672625d21b774cdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575026 Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#835650}
-
Colin Blundell authored
Most of what ChromeSubresourceFilterClient is currently doing is managing interaction between the per-navigation/per-tab objects (i.e., the throttles and throttle manager) and the now-componentized per-profile objects (e.g., content settings). All of this management is relevant for WebLayer as well. While I it would be possible to pull all of this code directly into the ThrottleManager, it lies outside the current core responsibilities of ThrottleManager and risks making that class too fat. This CL introduces a new ProfileInteractionManager class that lives next to the ThrottleManager. All of the places within the component that currently call into the client will call into the profile interaction manager class instead (with the exception of the very few methods that are actually on the client, e.g. actually showing the infobar). As a start, this CL moves the implementation of OnReloadRequested() into ProfileInteractionManager. With respect to unittesting of the new class, my suspicion is that most of the //chrome-level unittests are effectively going to end up being tests of ProfileInteractionManager and will be suitable for componentization as such once the dust has settled. During the process, test coverage will remain via those //chrome-level unittests as well as //chrome's browsertests. Bug: 1116095 Change-Id: Id64ca19cd1844cdc76b959679f5ad6ca0808f2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575077 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#835649}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ed854f3f20b..3c18d56820d2 2020-12-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80526e148e125901fa1ad858cc0071427ac71b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584282Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835648}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22f80a60b17f..2e9a03ec1170 2020-12-10 mtklein@google.com Revert "Cache text blobs computed by TextLine::paintText" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I6e23c295a3d036a5f525c9da288babf614c05430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584285Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607579988-31aafc9e6ecd14c47d53bc6af437bfedef1daa8a.profdata to chrome-linux-master-1607601127-f1e339917d2389833bdc9a06d67f5d834b6fad5c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdced3043409c336dcb2451fe8a8772728193941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584284Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607547301-1c0b0723d82aa4adb619c24bc9fd155c854d2040.profdata to chrome-win32-master-1607568819-6e8c2579a56bcfb40b7d05eda1af5c54e41c853a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If3b9748756e8aeb06904098fed451ea09ee6344c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583866Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607579988-85272d8bbf93007898b77e84b51d31a40000a6a1.profdata to chrome-mac-master-1607601127-39be490f57372d47d2538fb844f282b5fe546632.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib240a5cad0a4b753fffd449d56c11ba4af8f79b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584184Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1243857485fc..2bfd1bbc8538 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: Ied206b90c2191bb3123716cf24a8ad35b1bf6055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584182Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835643}
-
Matt Menke authored
NetworkIsolationKeys include top frame origin and frame origin. The WPT SXG reporting tests load an SXG in a cross-site iframe, but learn reporting information in the top-level browsing context, so it had a different NIK. This CL fixes those tests to learn reporting information in an iframe, so they have the same NetworkIsolationKey as the signed exchange. With this CL, all SXG WPT tests should now pass with reporting data partitioned by NetworkIsolationKey. Bug: 1156951 Change-Id: I0f8aa3bc51a276a71c28e92a056e709721bffb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580587 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835642}
-
Alexander Hendrich authored
With our new handling of the pref that handles the force-installed login screen extensions (https://crrev.com/c/2561847), the LoginScreenStorageCleaner will be created before the policy is mapped to its pref. This causes the LoginScreenStorageCleaner to incorrectly clear all login screen storage entries since it believes that no extensions are installed. Simple fix is to remove the call to ClearPersistentDataForUninstalledExtensions() in its constructor and only apply this logic when the policy was applied. Bug: 1157435 Change-Id: Ie8203204c3706e3ffb4b3c0816e2c31e0f9a3036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584023Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#835641}
-
Ian Kilpatrick authored
Many sites use negative block-end margins to "pull" in the end padding. (This is likely because FF doesn't support this end padding, and "working" around this fact"). For webcompat this change allows negative margins for determining the inflow bounds, but only in the scrollable direction. While manual testing I found also that the simplified layout pass had a issue of not calling AddChild correctly with all the necessary information. Bug: 1157299 Change-Id: I90f24301a7015915b0cd0a4446940ee562876dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582625Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#835640}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 816e65bb. With Chromium commits locally applied on WPT: 01ceb784 "Fix a crash PaintWorkletImageProvider::GetPaintRecordResult" 2becd034 "[AspectRatio] Don't stretch grid items if they have an aspect ratio" e3aa6108 "CSP: Fix asserted violatedDirective in WPT CSP report" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ie9ba04104e0e3e798e164078a31e817b225bfeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583982Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835639}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81356f4bf38c..0443332fe2b9 2020-12-10 fmayer@google.com Document deobfuscation of heapprofd profiles. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I15f432ad0c6bae6eea6b8088d7591524085df056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584183Reviewed-by:
-
Anastasiia N authored
`AccountManagerUI` is used by `AccountManagerFacadeAsh` to show system UI (system dialogs, OS Settings etc.). `AccountManagerFacadeAsh` cannot show system dialogs directly because it is inside chromeos/components/ and can not depend on chrome/browser/. `InlineLoginDialogChromeOS::Show` methods will be private, so no one can call them directly. These methods will be called only by `AccountManagerUIImpl`. Also, `InlineLoginDialogChromeOS` will not send UMA stats anymore (they will be sent by `AccountManagerFacade` instead). Bug: 1140469 Change-Id: I5f204d2dfcae7e8c920af672f1d4d7109ae1c5f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550741 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#835637}
-
Robert Sesek authored
Goma RBE only supports paths that are relative to the build directory, and the system Xcode typically resides outside of that, so all compilation requests fail. The solution is to put a symbolic link to the SDK in the build directory and reference that instead. In addition, any files in the SDK referenced as inputs to a GN action need to be listed as an output of some other GN action, as they are now considered to be build outputs by way of the symlink in the build directory. This creates a new //build/config/mac:sdk_inputs target for those actions to depend on, which lists those files as outputs via a dummy build rule. Bug: 1157103 Change-Id: I5f7a1926fc2714c10a8786e100371d3eb9888a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582409Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835636}
-
Norge Vizcay authored
* Introduces new function insertPasswordEntryForTesting on PasswordManagerHandler that allows storing credentials into the password store for testing purposes. Bug: 1155675 Change-Id: I3cc8bd09d01b810da1ee95ed9fac93f4df63e407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574857Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/master@{#835635}
-
Moritz Firsching authored
Currently, when loading half scans of certain type of progressive jpegs, the last scan is not displayed correctly. We provide a fix and a test. Bug: 1156120 Change-Id: If6ab87bda49fddf28bdf2062fc155ac85f9290c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577498 Commit-Queue: Moritz Firsching <firsching@google.com> Reviewed-by:
Leon Scroggins <scroggo@google.com> Auto-Submit: Moritz Firsching <firsching@google.com> Cr-Commit-Position: refs/heads/master@{#835634}
-
Hiroki Nakagawa authored
Before this CL, there were 2 bugs in the Early Hints UMAs: (1) Calculation order of the time duration is wrongly reversed. (2) The current implementation assumes that `LoadTimingInfo::receive_headers_start` doesn't take informational responses (1xx) into account, but actually it does [1, 2] based on the Resource Timing spec (See the note on [3]). Therefore, `early_hints_for_final_request_time` is always equal to `final_response_start`. This means the duration between them is meaningless. For the issue (1), this CL corrects the calculation order (see changes in uma_page_load_metrics_observer.cc). For the issue (2), this CL introduces `LoadTimingInfo::receive_non_informational_headers_start`. This is similar to `receive_headers_start` but it captures the time only when the response is non-informational. This is propagated up to NavigationHandleTiming and used for calculating the duration instead of `receive_headers_start`. Other notes: - This changes HTTP/1.1 and HTTP/2 but doesn't change HTTP/3. This is because HTTP/3 doesn't support LoadTimingInfo yet. See also https://crbug.com/1096414. - UKMs for the Early Hints use a different calculation logic, so they don't have these issues. However, to measure the effectiveness of the Early Hints precisely, we have to record the new timing for non-informational responses in UKM as well. See the TODO comment in uma_page_load_metrics_observer.cc for details. [1] https://source.chromium.org/chromium/chromium/src/+/master:net/http/http_stream_parser.cc;l=876;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [2] https://source.chromium.org/chromium/chromium/src/+/master:net/spdy/spdy_stream.cc;l=415;drc=1066e389d45dd39f22f2daf582fc56948d5cc480 [3] https://w3c.github.io/resource-timing/#dom-performanceresourcetiming-responsestart Bug: 1093693 Change-Id: Id2f696669804c2763de4c21fe40689e3af05bd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521563Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#835633}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b11fabe60575..5ed854f3f20b 2020-12-10 szuend@chromium.org Move Icon component from 'elements' to 'ui/components' module 2020-12-10 tvanderlippe@chromium.org Use URL-based loading for wasmparser_worker 2020-12-10 mathias@chromium.org Simplify and re-order entrypoint HTML document 2020-12-10 tvanderlippe@chromium.org Move worker integration into entrypoint for wasmparser_worker 2020-12-10 tvanderlippe@chromium.org Move worker integration into entrypoint for heap_snapshot_worker 2020-12-10 tvanderlippe@chromium.org Use FormatterWorker.format in unittests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1009443 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I24300cebca51983b12cafc071ca1357fc44f831f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583221Reviewed-by:
-
Ramin Halavati authored
This reverts commit f354c627. Reason for revert: Ephemeral Guest profiles will have the same UI as old (off-the-record) Guest profiles in M89. Original change's description: > Make two settings sections visible for ephemeral guest profiles > > - Make the "You and Google" and "Auto-fill" sections visible, > when settings is based on an ephemeral guest profile. > - The notion of Ephemeral Guest profiles (go/ephemeral-guest-profiles) > is to be replacing the current guest profiles. > > Bug: 1140419 > Change-Id: If10584bb4a8105275c2eac8c581c7abccf545225 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483753 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#819350} TBR=dpapad@chromium.org,rhalavati@chromium.org,huanzhong@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1140419 Change-Id: I1ec303884ba5a5585225b50e5364197880917f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582084Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#835631}
-
Jérémie Boulic authored
Convert the following JS files in //ui/file_manager/file_manager/common/js: - test_importer_common.js - unittest_util.js - importer_common.js - importer_common_unittest.js Bug: 1133186 Change-Id: I3c4ae19a4d2a5a6b56087f6bc0390b7c1dbd3252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579932 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#835630}
-
Peter E Conn authored
Change-Id: I4bbba28ef64ee3c1b989f43a0878d3f14bd33dfe Bug: 1155373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580883Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#835629}
-
Mario Sanchez Prada authored
This CL migrates MediaPlayerDelegateHostMsg_OnMediaPositionStateChanged to mojo, also adding the plumbing required to allow renderer -> browser mojo messages replacing MediaPlayerDelegateHostMsg* legacy IPC messages from //c/common/media/media_player_delegate_messages.h. More migrations of other MediaPlayerDelegateHostMsg* messages will be implemented in follow-up CLs, following an iterative process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I1bc517ce97acd82f1a05d70b8592ab390f34ae5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526440 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#835628}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6520135abe88..1243857485fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msramek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: msramek@google.com Change-Id: I6238a0a39bd93be613eac06ba692b8a61ae6d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583219Reviewed-by:
-
Colin Blundell authored
ChromeSubresourceFilterClient currently has logic to prevent the ads blocked UI being shown multiple times for a given navigation. However, ContentSubresourceFilterThrottleManager already guarantees that SubresourceFilterClient::ShowNotification() will be shown only once per main-frame navigation, even if multiple subresource loads are blocked. This CL removes the unneeded //chrome-level code to clarify ChromeSubresourceFilterClient in advance of componentizing most of it for sharing functionality with //weblayer. Bug: 1116095 Change-Id: I604498ee12a83d2afdc2cb2289877e211237901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574937Reviewed-by:
-
Richard Knoll authored
Reactivated UMA still shows zero usage of this and the extensions API was the only user. Remove it as this won't be supported in the upcoming FCM API migration anyway. Bug: 1148321 Change-Id: I6382efeba8d98353d46da8915613015c745c2b4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549929 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835625}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: I4507280850563ffdb684e3c41ad51bfd579c95ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583587 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#835624}
-
Mathias Bynens authored
This patch extends the existing `CSS.forcePseudoState` CDP command so that it supports the CSS :target pseudo-class. DevTools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2581544 Bug: chromium:1156628 Change-Id: I06d3bc2c76d78601fd0abd403f621e74d2e2ae03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575668 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#835623}
-
Wolfgang Beyer authored
Frontend CL: https://crrev.com/c/2581542 Re-enable tests CL: https://crrev.com/c/2581839 Bug: 1152082 Design doc: http://doc/1UnwKLgjYPDsLsYCBh9LKiaPN6Aq2XLKvt4Ak3FT7J3k Change-Id: I488a7ef1c88d9ff56080918f0154c22b76ea529b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580885Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835622}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/067a12f05951..55b7f38f9036 2020-12-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 3fc522ff to 2db43e77 (469 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Ic390734f921ced45dc4788e79d274fef62916a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583416Reviewed-by:
-
Elad Alon authored
In this CL, we only apply the display-capture permission policy to getCurrentBrowsingContextMedia, because it's behind a flag and therefore safe to change. As follow-up work, we will introduce UMA histograms to check how many sites would be negatively impacted if this policy were applied to getDisplayMedia. We will then decide how to go about applying this policy to that API as well. Spec: https://w3c.github.io/permissions/#dom-permissionname-display-capture Intent-to-Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/gBpWuawy-Ms Chrome Platform Status: https://chromestatus.com/feature/5144822362931200 Bug: 1150788 Change-Id: I058f84ab6b2e3427e4990b3d01f057c9811f9487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551098Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#835620}
-
Pavol Marko authored
Transform the sequence of ifs to set authentication headers to a switch-case over the token type. Bug: none Change-Id: Id636342873c77f76cf6adb8abe7f5668c448b2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567219 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#835619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607547301-0ddf36656043436fe87b3dfd771fe4fe3bc2c5ce.profdata to chrome-win64-master-1607568819-189005e62ee8b8bdd63cb408a8a785cae17219c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e5e18cc16c0a68c0a7a6df6acf1f7b7afacf8d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583747Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f5478d8ceb7..b11fabe60575 2020-12-10 alcastano@google.com Keep associated IssuesModel in all Issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I965cb0eb5fb80e68be4133b9d0d5db7ca0f85981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583867Reviewed-by:
-
Patrick Brosset authored
With this extra piece of information, the overlay frontend can now show how tall or wide gaps in a flex container are, from DevTools. Corresponding devtools CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2579039/ Bug: 1150832 Change-Id: Ia001a4950658624219bef05f169f2ec11566ec56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582260 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the ContextMenu callback parameters used by the WebKit API to use ContextMenuParams instead of just the URL. This will be necessary to check the new implementation where the interaction is added to the whole view. Bug: 1140387 Change-Id: Iabc574d4e0a88d43b4c2e1b7a9c1caeddda3c701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582041 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#835615}
-
Polina Bondarenko authored
Add OnSnapshotsDisabled() processing to ArcDataSnapshotdManager. All available snapshots must be removed and ongoing flows stopped (except when MGS is already running with loaded snapshot) once the feature is switched off. BUG=b:170187468 TEST=components_unittests Change-Id: I9f2c64817589639407f4294f04b077fea85aefea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558403 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#835614}
-
Marc Treib authored
Reconfiguration can't happen while certain operations (e.g. loading of data types) is ongoing. The member |needs_reconfigure_| indicates that a reconfiguration should be performed as soon as it becomes possible. This CL adds one additional point where a pending reconfiguration may be started, in OnAllDataTypesReadyForConfigure(). Previously, we'd still start the old configuration, and process the reconfigure only after all the previous data types had been downloaded. Bug: 1102837 Change-Id: Icc971f29229665832255baebfc545bfd34d83feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580882 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835613}
-
Mario Sanchez Prada authored
This migrates these legacy IPC messages to the media.mojom.MediaPlayer mojo interface, now implemented by HTMLMediaElement inside of Blink, and updates its callers in the browser process. Relevant design document: https://docs.google.com/document/d/1OLMNxLvGkRO6ju_WfHbRMrgaVnW7bsMnW7XlJQI0A2E Bug: 1039252 Change-Id: I2cb9a39813e3078212e4a1a4a513b4bc0d0770bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537704 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
