- 20 Sep, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0086f7aa8400..713f53360e2e git log 0086f7aa8400..713f53360e2e --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dgarrett@google.com chromeos_config: Allow multiple sharded tests on one board. Created with: gclient setdep -r src/third_party/chromite@713f53360e2e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic33e7ad5529fbd83eb0a3992bf40307feea5737d Reviewed-on: https://chromium-review.googlesource.com/1236479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592917}
-
Scott Violet authored
Before I add more exhaustive information I want to make sure I'm on the right track. This adds the count of the number of outstanding requests to add a page (url and other information) that haven't been processed yet. BUG=807009 TEST=none Change-Id: Ieb18fe74e9e91fe4f99eb1a791b04367c60cfd0d Reviewed-on: https://chromium-review.googlesource.com/1234240 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#592916}
-
Xida Chen authored
This test changes expectation for some frame throttling tests with PaintTouchActionRects enabled. The behavior is slightly different in the unit test and the comments explains why. Bug: 881890 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees Change-Id: I0e6fdeebcbe016675ee082f38d8da66ce30abbeb Reviewed-on: https://chromium-review.googlesource.com/1237056 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592915}
-
James Hawkins authored
When multidevice flags are turned on. This is a stop-gap measure to prevent users from running through the deprecated Smart Lock setup flow when in the new multidevice world. R=khorimoto@chromium.org Bug: 881924 Test: none Change-Id: Ifec2bd324e55592f14a50fe6cb5331496f010eff Reviewed-on: https://chromium-review.googlesource.com/1236840Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592914}
-
Lukasz Anforowicz authored
The test flakily crashes with an unknown callstack (the crash is not reproducible locally). The speculation is that the crash is related to dereferencing a null base::MemoryPressureMonitor::Get(). If this is indeed the case, then the crash should be fixed by using base::test::FakeMemoryPressureMonitor in the test (rather than directly dispatching a memory pressure notification from the test). Bug: 887545 Change-Id: Ib922ebe4c7f85ec028f4bb202f2357c71e20687a Reviewed-on: https://chromium-review.googlesource.com/1236502Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592913}
-
Che-yu Wu authored
Highlight the file name with strong tag, so that users can scan the list easily. Bug: crbug.com/883737 Change-Id: Iaccf05983efe0414ce39fe35c1c89be4b4102d12 Reviewed-on: https://chromium-review.googlesource.com/1231835 Commit-Queue: Che-yu Wu <cheyuw@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#592912}
-
Balazs Engedy authored
Replace "We couldn't verify your identity on this device" with the string “Your identity couldn’t be verified”. Bug: 887390 Change-Id: I4e2885f68964a2706f58a27a3dba3dbe412bbcf3 Reviewed-on: https://chromium-review.googlesource.com/1236002Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592911}
-
Becky Zhou authored
+ Parameterized some more tests in NewTabPageTest + Add some tests for FeedNewTabPage on the header views Bug: 860055 Change-Id: Ie86d67d4e852117eb4074db9c522bbc219d5d4dc Reviewed-on: https://chromium-review.googlesource.com/1227178 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#592910}
-
Ehsan Karamad authored
The fix did not work and the issue turned out to be something else. Cleaning up most of the changes made in master@{#591833}. Bug: 878359 Change-Id: I5432523622a82743d1c67e2768f70b437e580a22 Reviewed-on: https://chromium-review.googlesource.com/1236838Reviewed-by:James MacLean <wjmaclean@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592909}
-
Jordy Greenblatt authored
The settings-multidevice-setup-page listens for the event 'close' as a proxy for the password prompt being confirmed. However, the event type 'close' is ubiquitous to cr-dialog so it also fires when the forget device dialog is closed on the subpage, which causes the assertion "assert(this.featureToBeEnabledOnceAuthenticated_ !== null)" in SettingsMultidevicePageElement.onPasswordPromptDialogClose() to fail. This CL only calls onPasswordPromptDialogClose_ if the close event came from the MultiDevice page's password prompt and stops the event's propagation. Bug: 887160 Change-Id: I5740061c8f9e08ee5ba9e8d99862bcec6b0a6677 Reviewed-on: https://chromium-review.googlesource.com/1235321 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#592908}
-
Samuel Huang authored
Changing 4-indent to 2-indent. Also: - Make <style> and <script> tags indent from start of line. - Fix several missing ';' in JS. Bug: 880671 Change-Id: Iddda84bbdcf5040935d27643925aebb1433580c7 Reviewed-on: https://chromium-review.googlesource.com/1237141 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592907}
-
Steven Bennetts authored
This reverts commit e39c47e5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Install app to first available position in app list > > Changes: > 1. Calculate the first available position in AppListModelUpdater for > newly added item. > 2. Add test coverage. > > Bug: 883939 > Test: AppListSyncableServiceTest.FirstAvailablePosition > Change-Id: Ibdd2f27455ffd0c76f45906adbc025baab1ff319 > Reviewed-on: https://chromium-review.googlesource.com/1231193 > Commit-Queue: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592539} TBR=xiyuan@chromium.org,stevenjb@chromium.org,weidongg@chromium.org Change-Id: I03fc07c2f963eb2e569e170d8175a47c7f174fe1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883939 Reviewed-on: https://chromium-review.googlesource.com/1237144Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592906}
-
Daniel Bratell authored
This is in preparation for jumbo compiling content/shell. IPC headers generate code by being included multiple times with different macros. This requires careful juggling of inclusions and jumbo is not careful with when headers are included. In most of the code this has already been solved by adding include guards but not in content/shell until this patch. Bug: 886902 Change-Id: I84644fba628a827dfd7825d97844aacca3a9cd8e Reviewed-on: https://chromium-review.googlesource.com/1233743 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592905}
-
Tom Anderson authored
BUG=877647 R=pkasting Change-Id: I37b7d06209890a59262b0363c30fc70e809329ed Reviewed-on: https://chromium-review.googlesource.com/1194674 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#592904}
-
Navid Zolghadr authored
This cl follows the new pointerevent spec which uses more common WebIDL specified exception NotFoundError instead of defining new InvalidPointerId exception. Bug: 885321 Change-Id: I28e946ffcb96c9fb4f70c76a4b9c09be620f981d Reviewed-on: https://chromium-review.googlesource.com/1231990Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592903}
-
Paul Miller authored
This is in preparation to enable permanent-consistency and GWS-visible variations experiments in WebView. For experiments which must keep the same group across runs, there are "entropy providers" used to generate deterministic, pseudorandom group assignments. Chrome has 2 providers: the "low entropy provider" is seeded by kMetricsLowEntropySource; the "default entropy provider", seeded by both the low entropy source, and also the UMA client ID, if it's available. (If UMA is disabled, Chrome will have no client ID.) WebView uses GMS to determine whether UMA is enabled, which is very slow. So only use the low entropy provider in WebView, and seed it with the low entropy source. (Before this change, WebView's provider was seeded with the client ID, which has too many random bits, and blocked enabling GWS-visible experiments.) Since WebView no longer uses the client ID as an entropy source, we don't need to load the ID so early in startup, so remove the code for pre-loading the ID. It will only be loaded later, asynchronously, in AwMetricsServiceClient. AwFieldTrialCreator must call into MetricsStateManager to get these entropy providers. But WebView's MetricsStateManager is owned by AwMetricsServiceClient, which was not initialized until after AwFieldTrialCreator. So initialize AwMetricsServiceClient sooner, and within AwMetricsServiceClient, create the MetricsStateManager before the asynchronous call, so that AwFieldTrialCreator can use it immediately. AwFieldTrialCreator is now initialized with a null URLRequestContextGetter. This is fine because this field is unused since commit a5febff9. It will be removed in a separate change. BUG=866722 Change-Id: I31451924e97406db8a9f3efadcab6402a07007ea Reviewed-on: https://chromium-review.googlesource.com/1227531 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592902}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/6f1149defa9e..b64cb7b68093 git log 6f1149defa9e..b64cb7b68093 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 martiniss@chromium.org Whitespace change to kick off jobs Created with: gclient setdep -r src/native_client@b64cb7b68093 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:646142 TBR=mseaborn@chromium.org Change-Id: I0c6dfd24a7afeaa433697cb30527f180e1460a94 Reviewed-on: https://chromium-review.googlesource.com/1236879Reviewed-by:
-
Joel Einbinder authored
This will allow Puppeteer to expose snapshots of the accessibility tree. Bug: 887173 Change-Id: I296e68bb8e8a99f165b1a3356fd0b56c76334a0e Reviewed-on: https://chromium-review.googlesource.com/1235307 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592900}
-
Andrew Luo authored
The isolation target will be used by swarming, the gn-paths arg was not being captured in pydeps files generated with build/print_python_deps.py, but it is needed by the isolation target to properly locate its depenencies. Bug: 803245 Change-Id: I15bf4c8f7d1cd24a6ce1fcb4b44aeeff42786943 Reviewed-on: https://chromium-review.googlesource.com/1234340 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592899}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1605351382db..4bf804086c4f git log 1605351382db..4bf804086c4f --date=short --no-merges --format='%ad %ae %s' 2018-09-20 thestig@chromium.org Roll testing/corpus/ 2ddedb263..19feefee4 (1 commit) 2018-09-20 thestig@chromium.org Validate some image data in CPDF_Image::InitJPEG(). 2018-09-20 thestig@chromium.org Use pdfium::Optional with FPDF_Doc_Save(). 2018-09-20 thestig@chromium.org Change CFX_FixedBufGrow to take a size_t. Created with: gclient setdep -r src/third_party/pdfium@4bf804086c4f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I73411b5d1adbe4914baf64e152077917cd9dd55d Reviewed-on: https://chromium-review.googlesource.com/1236480Reviewed-by:
-
James Cook authored
It was disabled on all Linux platforms due to failures on Chrome OS in SingleProcessMash browser_tests. Instead, disable all MediaEngagement browser_tests via filter file for SingleProcessMash. There's a fix in-flight for renderer embedding in this mode, so I expect to re-enable them shortly. Bug: 884589, 883706, 881574 Change-Id: If6257ea160c7ba83c9bb322941001ce5ab1cc1b7 Reviewed-on: https://chromium-review.googlesource.com/1236836Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592897}
-
David Roger authored
Bug: 882107 Change-Id: Ie36e139d17b03bfd75f3b1cec9d557ec5513b084 Reviewed-on: https://chromium-review.googlesource.com/1236214Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#592896}
-
Fabrice de Gans-Riberi authored
This test fails becasue MSG_PEEK is not implemented. Bug: 887587 Change-Id: I6e1ba04afc1f34a11352ba0280dfc33c4436affa Reviewed-on: https://chromium-review.googlesource.com/1235210 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592895}
-
Nico Weber authored
- mention chromium.clang tot waterfall - linux cfi bot is now on luci Bug: 731417 Change-Id: I01b4b01ac35741f66a63f23af78a09d9c1e83495 Reviewed-on: https://chromium-review.googlesource.com/1237113Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592894}
-
Yuly Novikov authored
deqp/data/gles3/shaders/conversions.html on Win Nvidia GL passthrough TBR=kbr@chromium.org Bug: 887578 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id07d0302853e6f6340e305508098ab756611e28b Reviewed-on: https://chromium-review.googlesource.com/1236507 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592893}
-
Morten Stenshorne authored
It can now constrain the min/max sizes to a value, and also adjust them to be at least as large as some value. Also added an assignment operator for LayoutUnit. There are cases where we want to set min and max to the same value. Updated ComputeMinAndMaxContentContribution() implementation to use this new functionality. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I251c523213539acc9e508efebf701ed8f64e4265 Reviewed-on: https://chromium-review.googlesource.com/1236000Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#592892}
-
Josh Nohle authored
The helper function DeviceReenroller::GetSupportedFeaturesForLocalDevice() is currently storing a local variable as a const ref. This is breaking chromeos_unittests when the following `gn args` are used: ffmpeg_branding = "ChromeOS" is_component_build = false is_debug = false proprietary_codecs = true strip_absolute_paths_from_debug_symbols = true target_os = "chromeos" use_goma = true use_vaapi = true Bug: 887557 Change-Id: Iaa805f645b5cefc2ab93ca46e595886e5e00e6dc Tested: chromeos_unittests with gn args listed above Reviewed-on: https://chromium-review.googlesource.com/1236512 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84df59e3758f..a7a0a5198543 Created with: gclient setdep -r src-internal@a7a0a5198543 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9b9aba6098e3d90973dbff06e8c79fea170ed68a Reviewed-on: https://chromium-review.googlesource.com/1236478Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592890}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f837545214f5..a5ac303c5308 git log f837545214f5..a5ac303c5308 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a5ac303c5308 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If57dd96856740a4bbcbc96f8733961ea938d35c0 Reviewed-on: https://chromium-review.googlesource.com/1236878Reviewed-by:
-
Joey Arhar authored
Bug: 879219 Change-Id: I6cf01b36326a8b7727a870f2f7e2d061774d1c5b Reviewed-on: https://chromium-review.googlesource.com/1226797Reviewed-by:
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /device. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=reillyg@chromium.org Bug: 874080 Change-Id: I1bad5e82040c40aa770c36d3825dfc14dd9aad0f Reviewed-on: https://chromium-review.googlesource.com/1191813Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#592887}
-
Vladimir Levin authored
This patch does two things: 1. Explicitly checks for absolute position object containment where before it was checking for the equivalence of the position attribute. My suspicion is that this is the intent of the check. 2. Makes the paint layer creation or deletion only set the paint property update instead of a subtree update, since it seems that the initial intent was that the local border box properties existence may change. R=pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I9d93020a6f68213b1e4b49731c7b0e0d80c65681 Reviewed-on: https://chromium-review.googlesource.com/1235128 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Michael Spang authored
Vulkan is enabled by default on Linux desktop (X11) builds. Enable it on ozone as well to make sure we have build coverage. Fix chromium.memory/Linux Chromium OS ASan LSan Tests issue by breaking unnecessary dependency on //gpu/vulkan/init. Bug: 887110 Test: compile Change-Id: I298704cf3b199c5c4ecf5173e137293650c5734a Reviewed-on: https://chromium-review.googlesource.com/1235286 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#592885}
-
Fuchsia SDK Autoroller authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I422477c3b77a2c1901728108133d8d5df482f182 Reviewed-on: https://chromium-review.googlesource.com/1236477 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592884}
-
Lucas Gadani authored
Since a RenderWidgetHostView is destroyed when a renderer process crashes, it is necessary to null-check it before de-referencing it. This CL is based on nick@'s CL: https://chromium-review.googlesource.com/c/chromium/src/+/956624 Bug: 859215 Change-Id: I029d3615fee56c9cd2287ee816b269338802937c Reviewed-on: https://chromium-review.googlesource.com/1234873 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592883}
-
Drew Davenport authored
This reverts commit 57af9203. After bisecting the changes between the failing and passing pfq runs, the CL responsible for fixing desktopui_MashLogin was CL:1215947 and not the revert of "Use minigbm mmap for modeset buffers" BUG=b:78892556 Change-Id: I07908ca894d9132073c1846277d3e32fa1e7d4a8 Reviewed-on: https://chromium-review.googlesource.com/1235202Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#592882}
-
Johannes Henkel authored
v8_session_ starts out being a nullptr, and the constructor of InspectorSession initializes it. However, this initialization involves calling inspector->connect which calls the inspector session (this) with sendResponse / flushProtocolNotifications. This PR tries to resolve it by guarding v8_session_ for the V8Inspector::Channel methods. Bug: 873811 Change-Id: I8142eb61f9a8f6fb003b9baa0b6222730234ccae Reviewed-on: https://chromium-review.googlesource.com/1235054Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#592881}
-
Li Lin authored
Bug: b:114302330 Change-Id: I2e295a6ac8b3e78ecc92dd7bfba20b2e673cd04e Reviewed-on: https://chromium-review.googlesource.com/1212094 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592880}
-
Eric Seckler authored
This removes BrowserThread::Post(NonNestable|)(Delayed|)Task and moves GetTaskRunnerForThread into the impl (it's still used to vend TaskRunners in BrowserTaskExecutor). These methods have been replaced by base/post_task.h in conjunction with content/public/browser/browser_task_traits.h Bug: 878356 Change-Id: Ia122dc0921769f43da9271ddd6e1ce2f402df779 Reviewed-on: https://chromium-review.googlesource.com/1235728 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ib0b5ea0ad7e4ff08c9d0ae6b65cfd91d9a468a75 Reviewed-on: https://chromium-review.googlesource.com/1236254 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592878}
-
