GitLab

Also add some comments to describe the various sections

Bug: none
Change-Id: Ifbe892363fc4f6dfdaa730ce6058752540d94a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880577Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710945}

Bug: 996006
Change-Id: I2d819b32177ad10da1ad07b5f266a25f4f25d200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762936
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710944}

The MIME sniffing code used by the Content Directory loading system
has DCHECKs which prevent it from reading the contents of files larger
than 1MB.

Sniffing is now limited to the first 10KB of the file.


Bug: 1018436
Change-Id: I0b6293ef08ebe7cd2bab30fb57ffd481819cf85e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879684
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710943}

Now this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1874670
has landed, fix the test and re-enable it.

Bug: 842488
Change-Id: Ie436c7574de32e387db74697d2d205e296c4af09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890498Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Commit-Queue: Junyi Xiao <juxiao@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#710942}

"alternateSelectedControlTextColor" is a name with non-obvious
meaning, but it is (as per Apple header):

> Foreground color inside emphasized and selected content:
> table views rows, collection views, etc.

Tested by checking non-selected and selected rows from 10.10
through 10.15 in both light and dark mode.

Bug: 1018333
Change-Id: I38881d0e625ecce761f7e079d1346e5225bcc32a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890475
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710941}

Disabling four perf tests that are failing on all desktop platforms:
* rendering.desktop/youtube_2018
* rendering.desktop/youtube_pinch_2018
* system_health.common_desktop/browse_accessibility:media:youtube
* system_health.memory_desktop/browse_accessibility:media:youtube

NOTRY=true
TBR=crouleau@chromium.org

Bug: 1017244
Change-Id: I4949d7db85f558ec0a74d2887428a3724e637d60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891148Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710940}

The code was misusing the gfx::Transform initializer, it was supplying
elements in column-major order but the constructor takes row-major order.

Separately, it was then inverting this matrix to calculate a to_ray_space
matrix. However, the mojo "pointer_offset" field is supposed to be an
input_from_pointer transform. (The mojom comments are misleading, these need to
be updated separately.)

These two mistakes almost canceled each other out. The orientation part was
correct (transpose followed by inverse), but the position component of the
transform was in the wrong part of the matrix. This wasn't very noticeable
since the position corresponded to a point on the near projection plane, so it
was close to the origin, but applying the transform resulted in vectors with
a "w" component that wasn't equal to 1.0.

Change-Id: I73b2cc76a049af0d938f314992cdbf44df83319e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890989
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710939}

Some of the Expect* methods of HistogramTester fail if the queried histogram
has no data. Other methods allow querying empty histograms and treat them as a
collection of empty buckets.

Failing while inspecting empty histograms can make it awkward to verify certain
test cases. For example, to check that a particular test case does not write to
a particular bucket with ExpectBucketCount, a write to a separate bucket would
be required. Alternatively, just asserting that the histogram is empty isn't
quite right either because the test case would fail if an unrelated bucket
happened to be updated.

This CL changes HistogramTester to be consistent about what is queryable by
treating empty histograms as collections of empty buckets.

Change-Id: Id97356edb0bf983ff9487a2b749e028147400a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879608Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710938}

CTI doesn't support fuzzers anymore, so this CL removes the fuzzer bits
from the mb config file.

Bug: 990387
Change-Id: Ie85659e03d4ef5b8c9f1529edf23da750504a78c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890977Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710937}

Bug: 1018327
Change-Id: I902c73eb55ce39dd3e44760848650c249278e97a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881607Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#710936}

Bug: 1018834
Change-Id: I7d2d95afa7baa51aa5305bc3e3f32583773553cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891014
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710935}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f752e377..185ae4c0

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I42a2cb718db91d59d25efe3953f95cb1198daf7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891070Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710934}

This moves the template rules that generate WebView's AndroidManifests
to //aw/apk/BUILD.gn since the templates live in //aw/apk/java.

Test: ninja -C out/aw
Bug: 934152
Change-Id: Ia00432d9bb9d4ae0a34755c40426916e1635d2c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880964Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710933}

This CL just updates enums.xml's definition of ChromeDownloadSource to
match the one in the code.

Change-Id: I0160d8986f6c542f58bac2891b55089d7f6e6a99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891016
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710932}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6d56bdc1447a..e15140656112


Created with:
  gclient setdep -r src-internal@e15140656112

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I7fd0573620afe022d7c511452df1be04136aa114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890839Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710931}

This mirrors the JS SuperSize implementation in supporting two regex
parameters, for whitelisting and blacklisting.

std::regex is two orders of magnitude too slow, so I've brought in RE2
from /third_party/.

The front-end has code to validate input regexes and display a user-facing
error in case of invalid input - this justified squashing any regex-parsing
errors encountered on the WebAssembly side.

Bug: 1011921
Change-Id: I36b73815d4fd72142580b78cf5ff08fc595990bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891113
Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710930}

Change-Id: I300499d16e732092e206abb746146b25c3f224c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891135Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710929}

When scroll snapping occurs, the id(s) of the snapped element(s) will
be recorded. The recorded ids are currently not used, but will be used
in subsequent patches to re-snap to the same elements on layout
changes.

See doc for more information:
https://docs.google.com/document/d/1OFJz43xrOsyeM0lqlhulfTGG_zfRJVQBmis7ZKzKIls/edit?usp=sharing

Bug: 866127
Change-Id: If577e4a8302f98c5f96e246b9cb1410e90262ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845673Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Kaan Alsan <alsan@google.com>
Cr-Commit-Position: refs/heads/master@{#710928}

Parses and properly handles values given to the "Range" HTTP request
header.

Fixes an issue which was preventing the playback of media files, which
stream their input from at least one GET request.

Test: playback of large media file now works well (Big Buck Bunny).
Bug: 1018917
Change-Id: Ie09ab51485114bdb4d82aae6268f4dce4230f201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884574Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710927}

This CL is a re-land of https://crrev.com/c/1786260, which was reverted
due to an increased number of cancelled requests, because requests with
null initiator origins were treated as cross-origin when generating the
referrer string. Parts of Chrome beyond the web platform (e.g., file
downloads) relied on these requests being treated as same-origin. We
reverted the CL to unblock the Dev build release, and this CL is a
re-land with fixes (below).

This CL preserves the old behavior for requests that have null-initiators
(i.e., these are considered same-origin with their referrer), but corrects
the behavior for requests with non-null initiators (i.e., the initiator
origin is correctly used to determine same-origin-ness). This is important
because the initiator origin may not always be same-origin
with a request's referrer. More information on this change can be found
in: https://docs.google.com/document/d/1WO9LpuLHWpRCMCN1obXVX277cDGAohpmsb7nkNCzCyg/.

The original patch description:

> This CL addresses a problem with SecurityPolicy::GenerateReferrer
> when it comes to checking the same-origin-ness of a request. The
> WebAppSec Referrer Policy Standard defines a same-origin request [1] as
> one where the request's origin and current URL are same-origin with
> each other. This comparison is done in "determine a request's referrer"
> algorithm.

> The analogous place in our implementation is
> SecurityPolicy::GenerateReferrer. Before this CL, GenerateReferrer would
> determine a request's same-origin-ness by comparing the origin of the
> request's referrer string and the origin of the request's current URL.
> Most of the time this was sufficient, as the request's referrer string
> is almost always same-origin with the request's origin (initiator
> in Blink). With descendant module scripts and worklets however, the
> origin of the request's referrer string and request's origin (initiator)
> could be different, which breaks the correctness of our GenerateReferrer
> method.

> This CL introduces a blink::SecurityOrigin parameter to the
> GenerateReferrer method, so that correct same-origin comparisons can be
> carried out. In all GenerateReferrer call-sites, an appropriate origin
> is passed in.

> The original CL [2] was reverted because the semantics of
> SecurityPolicy::GenerateReferrer were not kept in sync with the similar
> logic in net::URLRequestJob::ComputeReferrerForPolicy, which caused a
> DumpWithoutCrashing bug seen in https://crbug.com/1000614, and request
> cancellations. This reland updates the ComputeReferrerForPolicy logic
> to match the corresponding Blink logic, and includes documentation
> mentioning that changes to one section should be reflected in the other.
> This CL also includes web platform tests for the scenario in the
> aforementioned bug, which pass with this CL, as well as net unit tests
> for RedirectInfo and URLRequestJob.

> [1]: https://www.w3.org/TR/referrer-policy/#same-origin-request
> [2]: https://crrev.com/c/1768501

TBR=caseq@chromium.org, kinuko@chromium.org, kouhei@chromium.org, lizeb@chromium.org, nhiroki@chromium.org, tbansal@chromium.org, yhirano@chromium.org

Bug: 786862
Change-Id: Ic49d17bb8db923edb99d9ee952a18b0355cdb115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808663Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710926}

This reverts commit 4a486dbc.

Reason for revert: Seeing the pending time high for try builders in the morning (http://shortn/_qkZuxYtEdz). Speculative revert this CL

Original change's description:
> infra: Migrate builders to Goma RBE (Week 14b)
>
> CI builders:
> - Android ASAN (dbg)
> - Android arm Builder (dbg)
> - Android arm64 Builder (dbg)
>
> Try builders:
> - android_clang_dbg_recipe
> - android_compile_dbg
> - android_n5x_swarming_dbg
> - android_arm64_dbg_recipe
> - android-oreo-arm64-dbg
> - android-pie-arm64-dbg
>
> Schedule of migration:
> https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0
>
> Bug: 950413
> Change-Id: Ib7db8b4b6e0712153b05bcc97e7dc82085e44b78
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875857
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Simon Que <sque@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709935}


Bug: 950413
Change-Id: I7e3312624913f7c154e2c14bb72ce8442e1aa239
No-Try: true
No-Tree-Checks: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890997Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710925}

This reverts commit 8229a222.

Reason for revert: Tentatively reverting because it seems like a possible culprit for this tree-closing failure: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-dbg/2029

Original change's description:
> platform_window: Fix component builds
> 
> The platform_window target is used from multiple components and should
> therefore be a component itself. This is needed to avoid ODR violations.
> 
> One ODR problem that currently can happen is the duplication of the
> global boolean backing UseTestConfigForPlatformWindows().
> 
> Bug: 1019015
> 
> Change-Id: I935df9a2fb2c6df1fec887c45c332bc833db91b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889293
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Michael Spang <spang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710905}

TBR=sky@chromium.org,spang@chromium.org

Change-Id: I2c39a3dd1655cd20273ee82778b2421628b6fac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891330Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710924}

This changes the InkDropMode of several buttons in the System Tray from
ON to ON_NO_GESTURE_HANDLER to stop showing the ripple for gesture
events.

Fixed: 1012822
Change-Id: I4a004c7db4d45ce67f25f0f8de4257beb5d51d49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877450Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710923}

Several sites were failing on windows autofill tests. The main issue
seems to be the resolution on windows bot that causes the sites to
sometimes render differently than when they were recorded.

One site needs different behavior for a button click on replay so
added a new action that will first check for a different element's
presence before trying to find the button to click.

Updated site recipes for 5 sites, so cipd version was updated:
sephora (removed a visibility constraint)
indigo (same)
newegg (added extra clicks to reset phone/zip fields to verify)
rue21 (rerecorded site on smaller resolution and used click fallback)
crate_and_barrel (forced payment page load)

Bug: 984664
Change-Id: Ic7d11082a2b4af53779281fcd27dce65753bac37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888742
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710922}

The ScopedTempDir must outlive anything that holds file(s) open within
it; otherwise, it is unable to delete itself.

BUG=546640

Change-Id: Ibf96099cd1e14c165f84759f5b92b0de838a6e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890321
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710921}

Tab freezing will ship on all desktop platforms, so the enterprise
policy to disable it should be available on all desktop platforms.

Bug: 844426
Change-Id: I0e2cfc34a34297ae48fd539d9534d6e11f56fa3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883870Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710920}

Currently, when you enter and exit the preview mode, the list items
(each wallpaper thumbnail in the current collection) lose their tabIndex
and aria-label.  This CL adds these properties back in so that the user
can tab through and the title is read out in chromevox.

Bug: 1005633
Change-Id: I60a2b2b5ea714d37bac440e9327d95b4867bc112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888377Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710919}

This reverts commit e26a5125.

Reason for revert: Breaks this bot: https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/6141

Original change's description:
> [WebLayer] Fix crash when top controls view has 0 height
> 
> This happens because the adapter and layer for the top controls is only
> created once height and width are > 0. We were assuming this had already
> been created in setTopControlsOffset().
> 
> Change-Id: Idf104f9d5c951c1fa8719fa30661dceae59b4887
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890492
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#710897}

TBR=sky@chromium.org,cduvall@chromium.org

Change-Id: I8304cc6583bdd606a4d52e8bd60cdf5957f7d384
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890795Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710918}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I5f48430f8789cfa7fc2d2a677970b5293388ae5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890509Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710917}

TBR=hkamila@chromium.org

Bug: 1018177

Change-Id: I19bd3d7e1ee71899a248c0896a254fb9e2fbeeae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890073Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710916}

Do not support the IAccessibleText, IAccessibleHypertext, AtkText,
and AtkHypertext interfaces for images. This fixes a bug in which
an image inside of a contenteditable was announced as just the
first letter of its alt text.

Bug: 1011837
Change-Id: Ifd128a7cf37a878e350c433f9a5ce96ffdfd3db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876687Reviewed-by: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#710915}

Bug: b/143516594
Test: Manual Test
Change-Id: I42251a3b7c97723c7eeb2f0267dbdc72a8fee66c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888651Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710914}

Bug: 953995
Change-Id: Id0dd9a4c767ad0c83744c5b10e1735be81ccbd55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883293Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710913}

The spinner is currently placed in the LTR location for RTL languages.
This CL places the spinner in the correct location for either.

Bug: 918122
Change-Id: Ie264f0b8e967fdf8abe04573a08c270a32dbc425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888777Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710912}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/27bd4e420d28..b43d98bf6484

git log 27bd4e420d28..b43d98bf6484 --date=short --no-merges --format='%ad %ae %s'
2019-10-30 ehmaldonado@chromium.org auth: Fix has_luci_context_local_auth.

Created with:
  gclient setdep -r src/third_party/depot_tools@b43d98bf6484

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=agable@chromium.org

Bug: chromium:1018069
Change-Id: I4ff7f0d978e901da56c7a3715972f805f17c4fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890505Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#710911}

This fixes a bug where modules can miss an ABI and fail the bundle
packaging step. This is due to two factors:

1. crrev.com/c/1876975 added an allotment step to each bundle that
   determined in which module native libs are packaged into. If a module
   only depends on libs that are also depended on by other modules this
   module will package no libs even though libs are specified when
   instantiating the module target.

2. Bundletool requires that all modules support the same set of ABIs.
   To make modules appear to support the WebView ABI for Monochrome and
   Trichrome we add placeholder libs for the WebView ABI. We do this in
   the chrome_feature_module template if we specify real libs for the
   browser ABI.

Given 1. and 2. it can happen that a module is only left with the
placeholder lib and appear single ABI, failing packaging. This CL fixes
that by telling the packaging step that the module should be multi ABI
and the packaging step will add a placeholder lib if necessary. This
makes placeholder logic in chrome_feature_module obsolete and therefore
it is removed.

This new multi ABI logic can likely be reused for other APKs that use
lib placeholders simply to make the APK multi ABI.

This is a reland of a9dcd64a with a fix
for builds where buid_apk_secondary_api is false. The fix is just
removing an that turned out to be not useful.

TBR: estevenson@chromium.org,cjgrant@chromium.org
Bug: 870055
Change-Id: I89766821459bfe62f292a67252a7ef0a2e99b2d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890979Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710910}

Replaced the previous curly ones.

Change-Id: I46024a0dcd25cf56189edee18d7d1a62f943053f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871608Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710909}

These macros are used in all of 3 files. Instead of all this magic, maybe the components
that need this should define FOO_TEMPLATE_EXPORT_DECLARE and FOO_TEMPLATE_EXPORT_DEFINE
in their foo_export.h file instead, and make it expand to the right thing there.
That seems a lot simpler and easier to understand.

But for now, let's just add a comment.

Bug: none
Change-Id: I5fd56440a07a4c7ba879af6d809c7e1397d05737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890531
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710908}

Change-Id: I0be89fe1fb55a352faeb05989fad1346155a0338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890419Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#710907}

This change avoids a race condition in IndexedDBContextImpl's Shutdown
method. In that method, std::move is used on a variable on the UI,
where that variable is supposed to be only accesed or modified on the
IDB task runner.

Being a race condition, this is really hard to test, and I'm not sure
what I would do to test this. It is also not necessarily the fix for
the given bug.

Bug: 1018741
Change-Id: Ia071e5a053952af8c74aa30e0e5e218c4b97100f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885498Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710906}