- 07 Dec, 2020 28 commits
-
-
Marijn Kruisselbrink authored
This is a reland of 00437792 The main difference is to make sure iterating over a directory doesn't return files we don't want to expose either (and not CHECK failing if such files are found when iterating). Original change's description: > [FSA] Add IsSafePathComponent checks to GetFile/GetDirectoryHandle. > > This isn't directly using net::IsSafePortablePathComponent since what > is safe for the File System Access API is not the same as what is safe > for Downloads. As such currently this duplicates a lot of the > implementation of this method, but in a followup we should attempt to > unify these two implementations as much as possible. > > Bug: 1150810, 1154757 > Change-Id: Iba4c92ef5f1cd924aa22b9dd201762d48b4bbc3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568383 > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833042} Bug: 1150810 Bug: 1154757 Change-Id: I3341b9824a1ac4cbd6f100355960ad55b01f0753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575370 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834118}
-
Harvey Yang authored
As we may retry up to 50 times of the initialization in AccelerometerFileReader, this commit shows only the first log of empty directory of /dev/cros-ec-accel and missing Accelerometer trigger. BUG=none TEST=run on octopus Change-Id: Idac9846b1c022ca4658f73b218f68900f4f633d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569501Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834117}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I42751fa035d3af6e4689ac889fd9151d38ea5908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574605Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834116}
-
adafang@google.com authored
Added a space to the end of a string so when concatenated the words are not directly joined. Change-Id: Ia8d80398ad97fd1c45323faaf3e6b66c29020f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576720Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Ada Fang <adafang@google.com> Cr-Commit-Position: refs/heads/master@{#834115}
-
Eric Willigers authored
We generate a POST request from the share intent. Spec: https://w3c.github.io/web-share-target/level-2/ On Chrome OS, only one file type may be shared at a time. Note that sharing title/text/url is not yet supported. Bug: 1125880 Change-Id: I4aa2a0b887bbb208bf33fdef849b970d72bf1e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560080 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834114}
-
Rakina Zata Amni authored
VerifyThatBrowserAndRendererCalculatedDidCommitParamsMatch currently has DumpWithoutCrashing, which doesn't always fail tests if browser & renderer-calculated DidCommitParams don't match. This CL adds DCHECKS so that tests will fail in that case, and update unit tests to adhere to this (and remove parts we don't need anymore) Bug: 1155414, 1154753, 1131832 Change-Id: I7163bdd691db298c472462c27e6cdd2897a06c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570751Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834113}
-
Nidhi Jaju authored
This CL adds a new WPT for the case that a ReadableStream with a byte source, and hence a ReadableByteStreamController is constructed, with autoAllocateChunkSize: 0. This should throw a Type Error because autoAllocateChunkSize cannot be 0, and should rather be positive. Bug: 614302 Change-Id: Iea15e4730f4965d52ff5c68367ba6212d5eca089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569490 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#834112}
-
John Palmer authored
Will replace right-click-> Emoji for Physical keyboard users with new emoji picker. BUG=1152237 Change-Id: Ife087bba8d4c52d38cc543cf77a93e6e47221301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546342 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834111}
-
Jiewei Qian authored
ChromeLauncherController may be created with a nullptr profile. In this case, the profile is resolved to the current active profile. SettingsWindowManager should wait for profile resolution before checking if the profile uses legacy settings window. Change-Id: Ia8c16f35387a6f328f611a8810e54118ac1a2b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567845Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#834110}
-
Keishi Hattori authored
When Navigate() calls ShowSingletonTabOverwritingNTP(), the std::move(*params) is executed before params->browser is passed as an argument. This becomes a problem when we use BackupRefPtr for NavigateParams::browser. Because BackupRefPtr will clear when moved so ShowSingletonTabOverwritingNTP will receive a nullptr. Bug: 1080832 Change-Id: Id26f41e128b9c79d2506ac82e3655d1fdb58f1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567279Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834109}
-
Keishi Hattori authored
When BackupRefPtr is used for WebUIImpl::web_contents_, the destruction order of the fields causes a null dereference. This is because BackupRefPtr is cleared in the destructor. The destructor of WebUIMessageHandler subclasses are accessing the WebContentsImpl through WebUIImpl::web_contents_. Bug: 1080832 Change-Id: I24570aad42dbd09febd94ef6d25be31c9817c091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564979Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834108}
-
Yoshifumi Inoue authored
This reverts commit 5ab6138e. Reason for revert: Due by http://crbug.com/1154761 Original change's description: > Utilize EphemeralRange::IsCollapsed() in ComputeAdjustedSelection() > > This patch makes |ComputeAdjustedSelection()| to utilize |IsCollapsed()| > of |EphemeralRange|[1] to simplify source code for improving code health. > > Note: This patch doesn't change behavior. > > [1] http://crrev.com/c/2550834: [editing] Ranges with equivalent positions > should be collapsed > > Change-Id: Iab464fafb0f02f90d346bc1cbc0a2734d6744138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567146 > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832722} # Not skipping CQ checks because original CL landed > 1 day ago. TBR=yosin@chromium.org Change-Id: Ifa4fe1a3e27ef78858123b0027cab2f59a1cca48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576063 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834107}
-
Alexey Baskakov authored
This reverts commit f8a44173. Reason for revert: Breaks browser tests here https://ci.chromium.org/ui/p/chromium/builders/ci/Mac10.15%20Tests/6369/overview Original change's description: > Adding more navigation-like fields to search prefetch requests > > This CL adds a few fields to the search prefetch resource request to > make it more similar to a navigation request. Additionally, this adds > capability for URLLoader throttles to defer (in this case cancel) or > change headers on the prefetch request allowing things like variation > headers to be added more similarly to how navigation requests have them > added. > > Client hints CL: > https://chromium-review.googlesource.com/c/chromium/src/+/2551671 > > Bug: 1138648 > Change-Id: Ia868aa624b2f9f573a54432eb0fa62834eacd2f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552723 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833987} TBR=kinuko@chromium.org,robertogden@chromium.org,ryansturm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1138648 Change-Id: I7077c0f73dbc60ddd5541caed7c1a91adf04b208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574640Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#834106}
-
Yuly Novikov authored
With Ubuntu 18.04.5. Also focus Linux FYI Release (Intel UHD 630) on this version. And try re-enabling tab_capture_end2end_tests on this OS version. TBR=bsheedy Bug: 1153159 Change-Id: I255bb6b221278253213c8a4504e387360250661b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575348Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#834105}
-
Alan Cutter authored
This CL adds a DesktopPWAsElideExtensionsMenu flag to Chrome. This is in preparation for moving the Extensions "puzzle piece" icon out of web app window title bars and replace it with an entry in the app menu. Bug: 1155421 Change-Id: Idc780e77334591e1099e00dda51e20ceed488f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573842 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834104}
-
Changwan Ryu authored
Bug: 1094366 Change-Id: I6774cc67767b7decc3aa04cf32a81190a9e3f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392745Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834103}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607274992-2974a9a4282254902cff6a65cece32eb62bb49c4.profdata to chrome-linux-master-1607296838-726b11db44d1999a156b631ebee4ad43068bfed6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie5d52a7165d7d19a76fbd0ee1a3b0db51b403966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576578Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834102}
-
Rakina Zata Amni authored
The RFH accessed in a DCHECK might be null if the navigation never reached the ReadyToCommitNavigation state. This CL updates the check added in https://chromium-review.googlesource.com/c/chromium/src/+/2569637 to be clearer. Bug: 1133115 Change-Id: I9e4fcc6f239a6e69e855f7abd56b74a3b2cad0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574118Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834101}
-
Alexey Baskakov authored
This reverts commit 9771027b. Reason for revert: Breaks ash_unittests on ASAN bots (use after free) https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/39004/overview Original change's description: > desks: Fix crash when touchpad swipe with external monitors. > > The crash was because a new screenshot is requested when the current > screenshot is about to get scrolled out of bounds. It was using a fixed > number threshold, meaning displays that are not the same size could > get out of sync easily, leading to a CHECK failure. > > This CL addresses that by requesting screenshot on all displays if even > one of them needs one. Another approach would be change the spacing and > threshold to be based on the display width instead of fixed number, but > that could be prone to roundoff error which may cause a similar issue. > > Also noticed visible desk metric was double counting when there are > multiple displays. Added a TODO for that one as it is lower priority. > > Bug: 1154868 > Test: manual, added regression test > Change-Id: I48f5ef62d3284b710f44a2808f75c95686bc9b3d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570551 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833993} TBR=afakhry@chromium.org,sammiequon@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1154868 Change-Id: I23cf043d8bc4ae5c9ed8531429b9ffcee43224e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575778Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607274992-5f60b37d32a0de70e3a3f8971d87b0de74f1a94e.profdata to chrome-mac-master-1607296838-983fc71424be447753e5e41dabd44a4fead37886.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1cbac97a3ae2431397dab042982355edaf3bc728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576757Reviewed-by:
-
Jie Jiang authored
The new added metric shows the time diff for detecting an L2 connectivity issue between the two link monitors. CrOS patch to emit the metric: https://crrev.com/c/2439961 BUG=b:162194516 TEST=See the TEST line in CrOS patch Change-Id: I9b1cb421f2d0c0accd3e151d006cad254d4289a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462753 Commit-Queue: Jie Jiang <jiejiang@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Cr-Commit-Position: refs/heads/master@{#834098}
-
Alexey Baskakov authored
This reverts commit 8144dae3. Reason for revert: breaks unit tests in this build: https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10489/overview Original change's description: > Quick Answers: Add page size options for Search request > > Since we only use the first result from search request, set the page > size to 1 to reduce the delay. > > Bug: b/173239982 > Test: None > Change-Id: Ib2abd92e23b430b837f0556c31bcc0d17873256e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574072 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Yue Li <updowndota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833940} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/173239982 Change-Id: I4348e98fcc27160c01ecf4a9c048844861f5c15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576659Reviewed-by:
-
Takuto Ikuta authored
This is tested with $ ./tools/infra/named-cache-clobber.py --pool luci.flex.try --cache \ builder_92e38e4683b296a198f832d7beb78c3cceedbbd43e46b55234be1c386f580943_v2 The following bots will be clobbered: luci-flex-try-xenial-11-ebhi luci-flex-try-xenial-12-kffs luci-flex-try-xenial-15-pkbk Proceed? [Y/n] To collect results use: swarming collect -server https://chromium-swarm.appspot.com -output-dir out -task-summary-json summary.json 5045ab8f8a419b10 You can also see the task status in https://chromium-swarm.appspot.com/task?id=5045ab8f8a419b10 To collect results use: swarming collect -server https://chromium-swarm.appspot.com -output-dir out -task-summary-json summary.json 5045ab92f48b1710 You can also see the task status in https://chromium-swarm.appspot.com/task?id=5045ab92f48b1710 To collect results use: swarming collect -server https://chromium-swarm.appspot.com -output-dir out -task-summary-json summary.json 5045ab9759b16b10 You can also see the task status in https://chromium-swarm.appspot.com/task?id=5045ab9759b16b10 Bug: 1142713 Change-Id: I5be98fe520c592bb59b3f453e544253c517acf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573561 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#834096}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012060600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/1JjkFXZ1s86iBnYJ0jMS5E5alylmWh3-mz4jCYL3szkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138543581,b/138961540,b/147599135,b/157950476,b/168064736,b/168067375,b/168068647,b/173978830,b/174442723,b/174536897,b/174603791,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: Ic2cf5cc3e33cfbdb5b28b23eb1a81a4e0a0b844f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834095}
-
Majid Valipour authored
You should be able to use "--enable-features=WebID" now. Same for webotp backend flag. Change-Id: Ibf3c71bff82f716989af3e01ce1cfe394c785fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576008 Auto-Submit: Majid Valipour <majidvp@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607274992-f909d4cd746e4743e9b9142bc43d00c747f755ba.profdata to chrome-win64-master-1607285417-319fac9cd61d6e3a5b6b6bda38f6eeeb3d5cb0d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia7548640a1678810b4f6863d08ddac3648164aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576848Reviewed-by:
-
Bao-Duy Tran authored
Should've been removed together in https://crrev.com/c/2437720 but was accidentally missed out... Bug: 1134465 Change-Id: I7d338c87cd1081fc1b3ae5629b2a4db5ce4422f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568339 Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
-
Thomas Guilbert authored
This CL converts the paths that read and decompress thumbnails to use base::OnceCallback and base::BindOnce instead of the generic base::Bind and base::Callback. It also notably changes a base::RepeatingCallback that seems to only be called once into a OnceCallback. Bug: 1152271 Change-Id: Ibc9cb6004c6a66c27225ea8ecda210f59f288f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572746Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#834091}
-
- 06 Dec, 2020 12 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/edb22ec49866..d67df01dcf3a 2020-12-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I00d5f5586acce4f2dcb63aa72eebc66ee486fc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576844Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11b84a217824..731e67da3620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I3364c13c0e82b2a531f8bfe16f85c0347a6fa2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576845Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f8bc30f60549..393159147685 2020-12-06 sprang@webrtc.org Reland "Adds experimental libvpx VP9 speed settings." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iefb7471f283eff4d35eaa9589ee8029bfb544647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576843Reviewed-by:
-
Eric Willigers authored
SharesheetClientBrowserTest::ShareTwoFiles uses script to share a file named '../sample.mp4'. We verify that this becomes a filename beginning with 'share', with no directory escape. Change-Id: I731afa6e7e0c071b83eac8b461d382acad6cac93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567869 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#834087}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I704e80def7a61d29d18a041f845e25f6514c1136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576776Reviewed-by:
-
Kyle Horimoto authored
Notification access is not allowed for users using a Work Profile. This CL updates NotificationAccessManager to support this case, and it updates PhoneStatusProcessor to mark access as prohibited if a Work Profile is active. This CL also propagates this value to settings so that the notifications settings UI can be disabled in this case. Bug: 1155151, 1106937 Change-Id: I76cc99e17eca333f695c4786b387e5e419a7350a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573681 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#834085}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607241930-f5b83cf2f1c9491df564851856be44747b1ca52b.profdata to chrome-win64-master-1607274992-f909d4cd746e4743e9b9142bc43d00c747f755ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieaa2c9d70c6544a03b0be6585ede949fc2d0512b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576782Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be1d125a8b06..11b84a217824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iac974a9f94f79af90ec7d152f8697573c4c6b1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576838Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6c80aebd0036..f8bc30f60549 2020-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d1dd90b2..a04842f6 (833763:833885) 2020-12-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 663e2bfe..d1dd90b2 (833628:833763) 2020-12-04 crodbro@webrtc.org Cleanup obsolete filtering of small packets in delay based estimator. 2020-12-04 sprang@webrtc.org Cleans up WebRTC-Pacer-SmallFirstProbePacket flag 2020-12-04 phancke@nvidia.com dump raw rtp packets in text2pcap format If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iad4e635799c11689364e383fc1c6353cbac20449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576836Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f326e4faef66..edb22ec49866 2020-12-06 reed@google.com work on better SkPath::dump If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I2b4daf2fec3fb07017e633a1a2d400bd2a5c67d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576785Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0f1e9236318c9ff3240c75e4f9ca8aa02ba6cfbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576009Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834080}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607252866-c2fa6eaa51da4882fc07c7786de461457a327487.profdata to chrome-linux-master-1607274992-2974a9a4282254902cff6a65cece32eb62bb49c4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I85a2c4ebfa762092d1ae90d902ad546872ae8c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576781Reviewed-by:
-
