GitLab

Simple no-op refactor of this test code, to prepare for more tests that
will exercise the behavior of is_web_secure_context in similar contexts.

Bug: chromium:1126856
Change-Id: I06799e7114dde1b5addc2ee4c58f41f96f730912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587168
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836669}

This reverts commit 314cbf4c.

Reason for revert: Breaks moving tabs to other windows - crbug.com/1158259

Original change's description:
> Create glue-layer TabModelOrchestrators
>
> TabModelSelectorImpl does not create or destroy TabPersistentStore
> anymore. Instead, TabModelOrchestrators manage the lifetime of TabModelSelectorImpl and
> TabPersistentStore.
>
> Give TabModelSelectorImpl a Supplier<TabPersistentStore> instead of
> passing TabPersistentStore directly.
>
> This is a step to break the two-way dependency between
> TabModelSelectorImpl and TabPersistentStore.
>
> Bug: 1138561
> Change-Id: Ie2fa4a2735e509ff816b3e2cf5f8f6fffda7999c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572639
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835819}

TBR=dtrainor@chromium.org,eirage@chromium.org,hnakashima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138561, 1158259
Change-Id: Ie0ee144acde93ec4cc46d188602b39113ce24344
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588640
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836668}

The pulse animation wasn't always centered on the page, sometimes had
the wrong aspect ratio, and left a blue line at the bottom of the page.

I wasn't able to reproduce the off-center behavior, but fixing the
width seems to have solved the aspect ratio and blue line problems. I
believe the cause may have had to do with the dimensions of the
cr-lottie element getting set before the page finishes rendering, and
then not updating because the width isn't set.

The radial gradient is also replaced with a linear gradient for
simplicity, but also because the right side of the page was perceptibly
less blue than the left.

The cr-lottie element is also moved to be the first child of its parent
div. The idea was to push it back in the z-order. It's difficult to see,
but the animation was actually getting rendered on top of the help text
before.

Screenshot: https://screenshot.googleplex.com/3X8u6cmSSsneUQT.png

Bug: 1157999
Change-Id: Id6b35dbfa0f21cd5019da99775a5fe47670de48b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587209Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#836667}

Prior to this CL, the top "Line wrap" row could sometimes not
extend to the edge of the page, which looked odd. This CL makes
the min-width of the table 100vw, to make sure it extends to the
edge of the page.

Fixed: 1158345
Change-Id: I8119f5fe2e3b05183c349a4017ba28bf77d3c451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589361
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836666}

crrev.com/c/2568694 added support for recording selection information
during paint in order to populate layer selection data in the
LayerTreeHost at commit time. This CL adds support for when the
selection is a caret. Note that this is not added directly to PaintCaret
since that is called both for a selection caret and a drag caret, and
we're only interested in recording for the former.

Bug: 1065049
Change-Id: Id22f656080b65c33f71f5caf1177149d0503d0e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589355Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#836665}

This fixes a regression caused in r789502, which removed an apparently-
unnecessary SchedulePaint() call that was in fact necessary in some
cases.

Bug: 1145729
Change-Id: I37585cba537e725e0d34f41628295e5eca94bb91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587652
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836664}

To get a better view of realtime audio processing graph in web apps.

example trace https://drive.google.com/file/d/1C2Ear_pFxDi1SQn7JjSJTt7QxJsCfw0g/view?usp=sharing

Change-Id: I6fbded336757cdcdbea3a755651b98c19ecf67df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587032
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836663}

This reverts commit cbce6f73.

Reason for revert: 

This change has caused skia_renderer_gl_blink_web_tests and vulkan_native_blink_web_tests to consistenly fail on both Nvidia and Intel Vulkan GPU builders.

It could be that the failures are expected/acceptable image diffs, and new baselines are needed. However this should be manually checked in case there are bugs being introduced/uncovered.

Dry runs can be manually triggered vs 'gpu-fyi-try-linux-nvidia-skv' and 'gpu-fyi-try-linux-intel-skv'

As the bots have been failing consistently I'm reverting so we don't mask other failures.

First failing build

https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20FYI%20SkiaRenderer%20Vulkan%20(NVIDIA)/31309/overview




Original change's description:
> gpu: Ensure consistent GrContextOptions between GPU and OOPR.
>
> R=​bsalomon@google.com
>
> Change-Id: I72615b36891e9e5ee568a8332bf0b6344b8188da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545684
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> Cr-Commit-Position: refs/heads/master@{#836396}

TBR=bsalomon@google.com,reed@google.com,khushalsagar@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I7fe40b0bfdac2053b868e0b4bc78218a938d07b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590057Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836662}

TBR: dgrogan@chromium.org
Bug: 1158406
Change-Id: I97f61177ff34e6be46f4304a025ee43693711de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589035Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836661}

Currently a PaintOp is not necessary rejected even if its drawing
canvas has a size of (0, 0). This should not be the case, for
performance purpose, we should just skip this draw op.

In PS#1, I added a test which fails without any code change,
to indicate that we are not reject a PaintOp even if the canvas
has size of 0.

In PS#3, I added code changes to make the test pass. The
code change ensures that if the paint rect is empty, then
it should be skipped.

Bug: 1157152
Change-Id: I28110c26e838c917326df82bf1debdc67ca5b50d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585628
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836660}

firstFailedUploadedRecord indicates that a record was
unprocessable on the server, at this time there is nothing
that the device can do to fix any errors the server might
send. So reupload the SequencingInformation as a gap record,
and note the data loss.

Bug: chromium:169883262
Change-Id: I9de35c24c82dbc33b4360ee8afa73d1d4662ebd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583506
Commit-Queue: Zach Trudo <zatrudo@google.com>
Reviewed-by: Leonid Baraz <lbaraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836659}

Bug: 1148478
Change-Id: Id3ac41a61fa0a16906b848511d337c4278da5c59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586839Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836658}

MessagePort implementations may be deleted during an OnMessage() call to
their MessagePort::Receiver.  Fix the implementations to cope with this
by early-exiting to avoid touching MessagePort fields after deletion.

Bug: b/175356780
Change-Id: Ib23e1b6a56d2ba730b471829d9680d899ff09217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590033
Auto-Submit: Wez <wez@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836657}

This change converts the translate model service to a
SimpleKeyedService and moves it to components which will enable
easier support beyond just browser use cases.

This change also registers the translate model service to
the optimization guide for provided necessary model files.

A future change will add loading and service the model files
to consumers of the translate model service.

Bug: 1151407
Change-Id: I4e903115c82a30757d46d75ed8d733874726d830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580339
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Trevor  Perrier <perrier@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836656}

R=kazinova@google.com

Bug: 1147363
Change-Id: I6f6007b2367c17fa725482a078a9457eb52297a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589857
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Maria Kazinova <kazinova@google.com>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836655}

Bug: 1155403
Change-Id: Ic0180a304fd0b5bcc460834e4914e3a4717b22d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589198
Auto-Submit: Joey Scarr <jsca@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836654}

Move the logic to check the number of scanned images from the scan
preview page to when the scan completes. This fits more with the app
flow and simplifies the show boolean logic for the scan preview page.

Bug: 1059779
Change-Id: Ie742166ddd3d4ff2f79c3461428c0b88bef25544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587105
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836653}

Bug: 1131026
Change-Id: I0d8e53c0d6fd8f8993ec320a68830c962aea53cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584877Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#836652}

Fixed: 1100887
Change-Id: Ib7a1ed5bbdf003e5311ab244730c8411f6b5f4e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584682
Auto-Submit: Javier Flores <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Flores <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836651}

In BrowserAccessibilityAndroid, the function HasFocusableNonOptionChild
is used to determine whether an accessibility node can be treated as a
leaf in IsLeaf. This function can be very costly (on the order of a few
milliseconds) since it traverses the tree.

IsLeaf is eventually called by both RetargetForEvent and CanFireEvents,
which in turn are called in every run of the loop over all events in
BrowserAccessibilityManager::OnAccessibilityEvents. For pages with a
complicated tree (e.g. cs.chromium.org), this can cause complete
unresponsiveness for periods of 10s and more.

This change moves the call to HasFocusableNonOptionChild behind the
individual checks for special situations in which the lack of focusable
children would allow to prune the accessibility tree. This results in
far less calls to the function while preserving the structure of the
tree.

Bug: 1014945
Change-Id: Idfde20271847425996d1f370e0fa1d8b964aa3f3
AX-Relnotes: n/a.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580802Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836650}

Now that the ScrollToExpandPaymentHandler/ExpandablePaymentHandler
feature has been enabled by default, this CL is to clean up the
switch of it.

Highlights in this CL:
* Removed the CCT payment handler support from ServiceTabLauncher. It
  seems reasonable to combine the two branches, but I will leave it
  to follow-up CLs.
* Removed the code to disable the feature from
  payment_handler_exploit_browsertest.cc.
* Removed slide_out_down because CQ warns of unused resources.

Bug: 1157895
Change-Id: I76c96704388c52bdb3ae9c2d17f940cfa29c76b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585809Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836649}

https://dawn.googlesource.com/dawn.git/+log/fb6c21547e6c..12c78cbc820a

2020-12-14 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 2abecbba1670 to 24bbbbb25f7d (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: sarahmashay@google.com
Change-Id: Id690d1e380b9b51b169fb371eeca9166217b7eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590073Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836648}

This rolls up to SHA fa8fd1e513f1e8151b79246a7e0ef3cf3d90a127

Change-Id: Idfbd212eb1280686541100f6b4941249c32e2a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585684
Auto-Submit: Luke Z <lpz@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836647}

Set a |debug_name| when creating the Frame for each web component, for
the Frame's console log output to be tagged with.

Bug: 1088094, 1139396
Change-Id: Ie58a932d68ef225796cf4ae367a7e5c106f0d51a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582319
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836646}

The code previously effectively ignored the auto.

flex-aspect-ratio-024 is now failing in legacy because the
LayoutReplaced code, unlike ComputeLogicalWidthFromAspectRatio,
does not take an override logical height into account.

Bug: 1157740
Change-Id: I593674569bb6d6ae76b957a09908bbade60c8fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585641
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836645}

Use enum to avoid meaningless decision like "kprefValue == 0" and
improve the readability.

Add an util class to help check the value of the incognito pref.

Change-Id: I005891908e261c8d292e2a861c7b5950a4f526d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586104Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836644}

This CL limits the access modifiers of the PaymentUiService methods.

Bug: 1025619
Change-Id: Ie0709c99ee1479336754db27c41c29d215d27da1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585842
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836643}

If there were no @font-face rules in the document, but @font-face rules
in user origin stylesheets, we would collect fonts based on the previous
set of active user sheets. Pass the correct new active sheets.

Bug: 1157821
Change-Id: I19a4578b5cced1568516e586208e37066c7df873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584926Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836642}

Adjust IDS_POWERWASH_REQUEST_MESSAGE_FOR_ARC and
IDS_POWERWASH_REQUEST_MESSAGE_FOR_CROSTINI to support FlexOrgs by
adjusting the domain placeholder names and descriptions to make it
easier for the translators to understand the usage of the texts.

Additionally replace a call to
BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with a call
to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager.

Bug: b:172685729
Test: Manual
Change-Id: I7636b1b9123fa2714cb002d1561e0665628ca8ec
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587029Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Jana Grill <janagrill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836641}

The PageInfo dialog is closed when the activity is restored e.g. due to
screen size changes. Subpage fragments should be removed since they are
not needed anymore.

Bug: 1157410
Change-Id: I1468f5d259e7ba9a1c33b842a4f1fa9d24bdb289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584804Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836640}

http://screen/9giUqca89s2rTHh

Bug: 1156229
Test: browser_tests --gtest_filter=*NearbySh*
Change-Id: Iccf9a78133a5face8c66518659ab1d941ff9a203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587491
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836639}

https://dawn.googlesource.com/tint.git/+log/2abecbba1670..24bbbbb25f7d

2020-12-14 dsinclair@chromium.org Add Symbol to struct type.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/tint-chromium-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: sarahmashay@google.com
Change-Id: I2f7d2e8598450c86c0d66e3cb57ed4fc01ba33d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588617Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836638}

This is a reland of e16309d9

The diff: disable floc event logging for 2 user-event related sync test
suite: SingleClientUserEventsSyncTest & TwoClientUserEventsSyncTest.
Add a wait-for-floc-network-response call at the end of
ProfileSyncServiceHarness::AwaitSyncSetupCompletion, so that the user
event logging behavior now becomes more deterministic and new flaky
test won't be added by accident.

Original change's description:
> [floc] Remove the EventTrigger field in the FlocIdComputed event
>
> Why: That field is never used & not useful for the server side analysis.
>
> This CL also removes a workaround that disables the initial floc
> loggings when permission disallows
> (in FlocIdProviderImpl::LogFlocComputedEvent). We had this workaround
> because otherwise the logging would mess up with the user event
> expectations in SingleClientUserEventsSyncTest, but that workaround is
> not ideal. This CL fixes it by disabling kFlocIdComputedEventLogging for
> the test suite, and adds a new test for the enabled case. The impact
> of this fix is it will cause additional events to be logged.
>
>
> Bug: 1148358
> Change-Id: I70cef531b89b434b5572b419acc8dd2412888498
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572733
> Reviewed-by: Josh Karlin <jkarlin@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Yao Xiao <yaoxia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#835468}

Bug: 1148358
Change-Id: I12c8230ee5edc3de7337e9daa8c07143ae83949d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584607
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836637}

Since the Discover feed uses a diffable data source its not completely
loaded at this time, in order to make this work we need to add a short
delay before scrolling.

Bug: 1108403
Change-Id: Id40dcc0655fe3fe01fdd4966611c475dce44bcca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587474Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836636}

This converter converts "<url> | none", so add DCHECKs to that effect.

Bug: 109212
Change-Id: I35f7629a1d233ed5a6e884af6538441e5a4a8d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587170Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#836635}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f37a8715452c..406249fca52c

2020-12-14 tvanderlippe@chromium.org Split up ESLint rules configurations in sub-folders
2020-12-14 tvanderlippe@chromium.org Enforce specification of return type in function/method declarations
2020-12-14 tvanderlippe@chromium.org Add missing return types to function/method definitions
2020-12-14 patrick.brosset@microsoft.com [Flex] Adding gap support to the flex overlay

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1057042,chromium:1150832
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I633f813acbbf87784976d653cf8306f6ae5046b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588615Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836634}

mSubpage can be null if a storage fetch finishes after the
subpage has been left.

Bug: 1156888
Change-Id: Ib24378750a87606d36032f338486499ef7725819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589873Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836633}

The 'Escape' key is used in multiple keybinds that collide with each other
and thus, the action that is effectively triggered cannot be known
beforehand. This test relied on the usage of such key and on the specific
order in which actions were loaded. Now, with the migration of extensions
out of module.json files, the order for loading actions is altered and this
tests starts failing in consequence.

This change modifies the test so that the tested behaviour is triggered
without relying on the usage of the 'Escape' key.

Bug: 1134103
Change-Id: I508704d4507f24441988a837c06f5c009817a91a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586533Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836632}

According to the ARIA spec, a checkbox must have a name, but in the
history page we are not giving a name to the item with role checkbox
but to its parent instead.

The cr-checkbox component can render its light-DOM children to a hidden
div used by the checkbox as accessible label container, we make use this
feature to fix the problem.

Bug: 1152721
Change-Id: Ia36bab94497caa60832d02876307f844744340a5
AX-relnotes: make checkboxes in history page ARIA-compliant.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584502Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Cr-Commit-Position: refs/heads/master@{#836631}

Bug: 1152263
Change-Id: I6b4db7e7fd955a5016b54775993447a5b21d1580
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585817Reviewed-by: Cait Phillips <caitkp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836630}