- 28 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/95a736bd3347..076f869ce5ac git log 95a736bd3347..076f869ce5ac --date=short --no-merges --format='%ad %ae %s' 2019-10-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b34fa731931b..ec12de913124 (2 commits) Created with: gclient setdep -r src/third_party/angle@076f869ce5ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: I6e247ee432f54a85246564a13c3bd06f8ad75f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883061Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709830}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3132a118c708a85cb193379b147f8f09bf8564e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882247Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#709829}
-
Yoshifumi Inoue authored
This patch chagnes |ComputeNGLocal{Caret,Selection}Rect()| to utilize |NGInlineCursor| instead of |NGPaintFragment| for prepration of migrating |NGFragmentItem|. Bug: 982194 Change-Id: I040c946dd405237e145af4702669304eecfe34ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877505 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709828}
-
Yutaka Hirano authored
This is (1) in https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/. Bug: 1018050 Change-Id: I52536cb0e97ac3c60da30a946a30ee005b1a861d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880892 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#709827}
-
Minggang Wang authored
The case, CreateTasksForOffTheRecordProfile, becomes flaky recently and has been disabled on asan. This patch enables it again by cleaning up the default browser before the test is going to start. Bug: 1016901 Change-Id: I52ddb58956a881409c70bb21132db066d271809f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880536Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#709826}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |ClosestLeafChildForPoint()| in |NGPhysicalLineBoxFragment| for improving code health. This patch is follow-up of the patch[1] which gets rid of clients of |ClosestLeafChildForPoint()|. [1] http://crrev.com/c/1875856 Introduce NGInlineCursor version of ClosestLeafChildForPoint() for AbstractLineBox Change-Id: Ia626b7e77ac415c6d2164072b50f3b34fcbe6b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877874 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01b1f63d641b..428b5de64a08 git log 01b1f63d641b..428b5de64a08 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77fba58c9658..95a736bd3347 (17 commits) Created with: gclient setdep -r src/third_party/skia@428b5de64a08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: Ibe66e17f8c6a4b1175cddd4d4de65a5441b7e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883388Reviewed-by:
-
Alex Danilo authored
Adds an error marker that can be used on summary panel items to indicate that there are error panel items in the collapsed summary view. Note, this is just the implementation of the error marker itself, follow up CL will add usage of them. Includes unit test for the error marker. Bug: 1014771 Tests: browser_tests --gtest_filter=FileManagerJsTest.FilesDisplayPanel Change-Id: I86698cb97fc0f7af19ac2177e8781873e3d21776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882196Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709823}
-
Chinglin Yu authored
During shutdown of JankMonitor, when the monitor timer is fired after MetricSource has shut down, the timer dereferences the null pointer and crashes. Fix the crash by nulling out the pointers after the monitor timer shut down. Bug: 1015425 Test: JankMonitorShutdownTest.ShutdownRace_TimerFired Change-Id: Icd9073e4527e0ac01c373fe486d88aa0985a5841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868772 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709822}
-
Koji Ishii authored
This patch fixes ellipsis by implementing IsHiddenForPaint(). Fixes ~50 failures. Bug: 982194 Change-Id: Icabef1450f9c80132cd56db55d0ab73ad72c8ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880894Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709821}
-
Nicolas Ouellet-payeur authored
Now that the "python_script" backend is stable, there's no huge incentive to keep maintaining the "clang_tool" backend. win-annotator-rel started getting compilation errors with clang_tool recently [1], so we might as well disable it. At the same time, this will make the waterfall bot run much faster, which should reduce the rate of task timeouts on Windows. [1] https://ci.chromium.org/p/chromium/builders/ci/win-annotator-rel/1917 Bug: 909867 Change-Id: Ib52cac4a32a41fe11da13fbee2ce85a2b1947c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881307 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#709820}
-
Meredith Lane authored
This reverts commit 538de13d. Reason for revert: Causing flaky failures (https://crbug.com/1018097) Original change's description: > [PM] Freeze Origin Trial - Remove the unknown state > > Most frames won't set a freeze origin trial policy and so making > kDefault the default state when a frame gets created will reduce the > number of IPC calls. This could cause pages to be frozen before all > their frames have reported their policy, a following CL will unfreeze > frozen pages that receive an opt-out OT token. > > Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708808} TBR=fdoray@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic0208aa6045e0e65aef59f8103688865ddb63de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882203Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709819}
-
Makoto Shimazu authored
I found a setter of block_mixed_plugin_content is not called from anywhere so removed the param as preparation of Loader's Onion Soup. Bug: 860403 Change-Id: I2a47e70f7c551727d918888977548142214b1725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883349Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709818}
-
Fergal Daly authored
These are passing on bot-run: - linux - https://chromium-swarm.appspot.com/task?id=4829cfd28750da10 - android - https://chromium-swarm.appspot.com/task?id=4829d1fa07219910 Bug: 1007276 Change-Id: Id2d577a4bd0d87b89afe767dea0faab7a91e18f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883428Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#709817}
-
Joel Hockey authored
Change-Id: I26af9df08105a4c8d6f8c25baac4cf87f2076d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880498 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709816}
-
Koji Ishii authored
Following bot results are included. 56 58 60 61 63 64 TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I287bb0f0ca8fd6edff21df76771dc57fa8457b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882254 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
gogerald authored
Bug: 1017909 Change-Id: I90dd2cbf84d904cc60ea9bf676a5f255839281ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879951 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709814}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I71ac5f0fcec853cc3d46431c657b359541660800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883387Reviewed-by:
-
Yoshifumi Inoue authored
This patch Introduces |NGInlineCursor| version of |ClosestLeafChildForPoint()| for |AbstractLineBox| to reduce usage of |NGPhysicalLineBoxFragment| and |NGPaintFragment| for prepration of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Id57b707d4a84fec794f275be6dc8a42e9465d3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875856 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Yun Liu authored
Bug: 985574 Change-Id: I1d5f51adbe51d6022c0b74c71267b89da27958d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872770 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709811}
-
Fabrice de Gans-Riberi authored
* Convert internationalized domain names in the provided hosts_filter to Punycode. * Add validation for host names in rules. Bug: 1012954 Change-Id: Ib14d35f764ce8cc17936226ac4cad81385f6ab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857189Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709810}
-
Peter Kasting authored
Bug: 82078 Change-Id: Iaf572972b0285c020621899345f8c1ab7263b2a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881781 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7c5920efc293..e44b5225dbfd git log 7c5920efc293..e44b5225dbfd --date=short --no-merges --format='%ad %ae %s' 2019-10-28 simonhatch@chromium.org Pinpoint - Make story or storyTags required, but not both. Created with: gclient setdep -r src/third_party/catapult@e44b5225dbfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:1016372 Change-Id: I769ecaf78274cec91b16078bff694de65c4e1a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883040Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/62160f2f358a..01b1f63d641b git log 62160f2f358a..01b1f63d641b --date=short --no-merges --format='%ad %ae %s' 2019-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6d69aae0e1ab..1737a30e3e34 (2 commits) Created with: gclient setdep -r src/third_party/skia@01b1f63d641b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: Ie3023be2a0e63a6a8d2ec2e3a0ff32b870496d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883059Reviewed-by:
-
Archie Pusaka authored
Makes the verbose bluetooth option persist across device reboot by adding a new preference flag. Bug: 1004572 Change-Id: Ibdb278c9b4a326368a591463223e0d1241f2b115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810451Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#709806}
-
David Grogan authored
We were including border+padding in a few places where we shouldn't. I still need to figure out whether the max-cross size should include borders when it is influencing content size suggestion in min main size calculations when the item has an aspect ratio. Bug: 845235 Change-Id: Ic25f44f6dbf4da5750acc6b51b2f08f43bb0d983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881774 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709805}
-
Kent Tamura authored
IsShadowHostDelegatesFocus() defined in focus_controller.cc simplifies the code in other files too. This CL makes it Element::DelegatesFocus(). This CL has no behavior changes. Bug: 1014094 Change-Id: Ia72f71578432fd48ccfeb71fb6ecd3370f5e97e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882257 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#709804}
-
Koji Ishii authored
This patch fixes positions of line items when the block is RTL. Because the position of lines maybe decided after children are positioned, this patch applies different transform to children of lines from children of blocks. This patch fixes ~250 failures. Bug: 982194 Change-Id: I35871694ab2cd40f111fb3d338a67cdce2e0982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881006Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7568fa8a28d9..7c5920efc293 git log 7568fa8a28d9..7c5920efc293 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 dberris@google.com Refactor the evaluators module Created with: gclient setdep -r src/third_party/catapult@7c5920efc293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@chromium.org Bug: chromium:988912 Change-Id: I8ef5076e075f6bf1100199def657eaee498a555f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882792Reviewed-by:
-
Hirokazu Honda authored
Bug: 1011281 Test: image_processor_test --save_images on atlas Change-Id: Ia5f6b106a2bbcc86cbb79cffb46a230b06011eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864758 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#709801}
-
Koji Ishii authored
This is a reland of crrev.com/c/1882249 because the path names of some -expected.png were too long on Windows. * 3 crashes in native-file-system. * Mostly image rebaselines where scrollbar buttons became grayed when the scroll position is at begin/end. Probably someone fixed this. * A few pixel differences in rendering fonts, for vertical flow and "AM" in the date picker. TBR=ikilpatrick@chromium.org Change-Id: If1d67fb4a9d496c564bfe6246cc57e46288c565b Bug: 1018587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882259 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Meredith Lane authored
This reverts commit 81487c55. Reason for revert: https://crbug.com/1018627 Original change's description: > Exposing button's children internally and to AT > > The motivation behind this change is that we want text pattern APIs to > access the text content of both native buttons and ARIA role=button. > In order to achieve the above, we need to be able to serialize button > element's children to AXTree. This change enables all children of button > to be exposed in the AXTree. > > Additionally, if the button's children are text only and also exposed > in the Browser Accessibility tree, screen readers may double speak the > button's name. To prevent this, if button's only child is a static text > we mark the button Browser A11y node as leaf. > > On Android, we treat all its Browser A11y button nodes as leaves and > expose no child. > > Summary: > -------------------------------------------------------------------- > BEFORE: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[N],BATree[N] | AXTree[N],BATree[N] > BATreeAndroid[N] | BATreeAndroid[N] > > complex children: AXTree[N],BATree[N] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[Y] > -------------------------------------------------------------------- > AFTER: Exposed in AXTree & Browser A11y Tree (BATree): > > native button | role=button > single text child: AXTree[Y],BATree[N], | AXTree[Y],BATree[N], > BATreeAndroid[N] | BATreeAndroid[N] > > multiple children: AXTree[Y],BATree[Y] | AXTree[Y],BATree[Y] > BATreeAndroid[N] | BATreeAndroid[N] > -------------------------------------------------------------------- > > Note: > According to the ARIA spec (below), the children of role=button are > presentational, which means they should not be exposed to ATs > (a.k.a. should all be treated as leaf nodes). > However, we need the button contents to be exposed sometimes because > they may contain many rich, interactive descendants such as buttons > inside a calendar popup and screen readers need to interact with these > contents (See https://crbug.com/689204). > > Additionally, Firefox also expose the children of both native button and > role=button. > Due to the above, we decided to departure from the ARIA spec and not > enforce the leafiness of buttons. > > ARIA && core-aam specs: > https://w3c.github.io/aria/#button > https://www.w3.org/TR/core-aam-1.1/#exclude_elements > > ~~~~~~ > Note: > The actual functional changes are in the two files below, the rest are > tests: > content/browser/accessibility/browser_accessibility.cc > content/browser/accessibility/browser_accessibility_android.cc > third_party/blink/renderer/modules/accessibility/ax_node_object.cc > ~~~~~~ > > Bug:1013609 > > Change-Id: Ia7c4bac9940b34dd3a3122938057cb48e847b76a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845810 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709728} TBR=dmazzoni@chromium.org,boliu@chromium.org,aleventhal@chromium.org,kschmi@microsoft.com,adettenb@microsoft.com,vicfei@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013609 Change-Id: I2641def8c4e7b1fd610219ed3a99982c94b9f183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882198Reviewed-by:
-
Jason Lin authored
Bug: 929571 Test: Enable CrostiniWebUIInstaller flag, and test manually Change-Id: I890d5154e570c0b9f3bd59173f2696cba0211ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874073Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#709798}
-
Ella Ge authored
The test was flaky failing with RemovePendingUserActivationIfAvailable true and HasTransientUserActivation false. It's probably because of timing issue (InputEventAck arrive sooner than the UpdateUserActivationState IPC). This CL changes to wait until the target frame get activated. This CL also adds the test to INSTANTIATE_TEST_SUITE_P. (The test wasn't actually running after the crrev.com/c/1850736 fixed the scope feature list) Bug: 995285 Change-Id: I5651115487d7dd1beba51933ec67dbc3d38c28e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869072 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709797}
-
Joel Hockey authored
This reverts commit d5f9416a. Reason for revert: relanding as expected Original change's description: > Revert "Use attached browser CreateParams in CreateBrowserForDrag" > > This reverts commit 5a45cc91. > > Reason for revert: crbug.com/1015534 suspects performance regression. It is hard to interpret the results in that bug, so I will revert and rerun perf analysis. I suspect this change made no difference, and if that is confirmed, I will reland. > > Original change's description: > > Use attached browser CreateParams in CreateBrowserForDrag > > > > Use the attached browser CreateParams rather than > > BrowserList GetLastActive. > > > > It feels safer that the attached browser will always > > be the one that we want whereas BrowserList GetLastActive > > may not be so reliable. > > > > Bug: 1012169 > > Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 > > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > > Commit-Queue: Peter Kasting <pkasting@chromium.org> > > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706220} > > TBR=pkasting@chromium.org,joelhockey@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1015534 > Bug: 1012169 > Change-Id: Ief9fa8770467e12c14a3b86b6c004a0b6d2b62cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882202 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709793} TBR=pkasting@chromium.org,joelhockey@chromium.org Change-Id: Ifdef35496534b04a22d4b0627ebd6ed6dc60f347 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1015534, 1012169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882205Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709796}
-
Gyuyoung Kim authored
This CL applies the new Mojo types to CreateMediaPlayerRenderer and CreateFlingRenderer in InterfaceFactory interface. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Replace MakeStrongBinding with MakeSelfOwnedReceiver. Bug: 955171 Change-Id: I8dabcba8ebe6e53dd3a561d786c8bd5bf1edb257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880988 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709795}
-
Gang Wu authored
Home page button seems enabled for a while on switching between tabs. It is because during transition between views, HomeButton only check the active tab, if no active tab, HomeButton did not check go-to tab. In this CL, HomeButton will check go-to tab if no active tab. Bug: 935266 Change-Id: I59f5a617ebefce21b461fbcbf95ca0d04c186ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873396 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#709794}
-
Joel Hockey authored
This reverts commit 5a45cc91. Reason for revert: crbug.com/1015534 suspects performance regression. It is hard to interpret the results in that bug, so I will revert and rerun perf analysis. I suspect this change made no difference, and if that is confirmed, I will reland. Original change's description: > Use attached browser CreateParams in CreateBrowserForDrag > > Use the attached browser CreateParams rather than > BrowserList GetLastActive. > > It feels safer that the attached browser will always > be the one that we want whereas BrowserList GetLastActive > may not be so reliable. > > Bug: 1012169 > Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706220} TBR=pkasting@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015534 Bug: 1012169 Change-Id: Ief9fa8770467e12c14a3b86b6c004a0b6d2b62cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882202Reviewed-by:
-
Meredith Lane authored
This reverts commit a6f0d9ae. Reason for revert: Causing failures in chromeos_components_unittests. Bug: https://crbug.com/1018633 Original change's description: > [Wifi Sync] Implement the SyncedNetworkUpdater class. > > This is responsible for updating the local network stack to match > incoming WifiConfigurationSpecifics protos from the sync backend. > > Bug: 966270 > Change-Id: Ib4bdf1c22604b2528bc2abad5bc2ac1672e58290 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768877 > Commit-Queue: Jon Mann <jonmann@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709627} TBR=xiyuan@chromium.org,stevenjb@chromium.org,khorimoto@chromium.org,jonmann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966270 Change-Id: Idce7f0208c06412b9c950e3f833f50b5f15a816b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882201Reviewed-by:
-
David Staessens authored
The video_decode_accelerator_unittest is deprecated in favor of the video_decode_accelerator_tests and video_decode_accelerator_perf_tests. This CL removes all documentation related to the old tests. vdatest_usage.md documents both the VEA and VDA tests. It has been renamed to veatest_usage.md and all parts referring to the VDA tests have been removed. TEST=None BUG=1802897 Change-Id: I754c039238e553493bc4076b160ab6928e97a4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800853 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#709791}
-
