GitLab

Added unittest coverage removed from CL 634523004

BUG=57376

Review URL: https://codereview.chromium.org/677423004

Cr-Commit-Position: refs/heads/master@{#301538}

This fixes a bug where data sends that had been fully written to the
data pipe were not considered when deciding whether to cancel (or wait
for an in-progress cancel) during DataSender serialization.

Review URL: https://codereview.chromium.org/678223002

Cr-Commit-Position: refs/heads/master@{#301537}

BUG=378074

Review URL: https://codereview.chromium.org/668313002

Cr-Commit-Position: refs/heads/master@{#301536}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/679283002

Cr-Commit-Position: refs/heads/master@{#301535}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/678073006

Cr-Commit-Position: refs/heads/master@{#301534}

AppKit is responsible for determining the height of the NSSavePanel and
NSOpenPanel. It will never pick a height that causes the panel to be taller
than the screen, but it may pick a height that requires the panel to be
positioned near the top of its presenting window. Chrome's logic for
positioning panels did not take this into consideration, so it was possible to
position a panel that extended past the bottom of the screen.

This CL fixes this oversight.

BUG=423635

Review URL: https://codereview.chromium.org/665933005

Cr-Commit-Position: refs/heads/master@{#301533}

With this patch, if one extension has a recursive watcher, and another non-
recursive one, then the providing extension will know about both of them.

In an upcoming patch ObservedEntry will be renamed to Watcher, since now
we can have two observed entries for the same path, which doesn't sound the
best.

TEST=unit_tests, browser_tests: *FileSystemProvider*
BUG=248427

Review URL: https://codereview.chromium.org/679573002

Cr-Commit-Position: refs/heads/master@{#301532}

BUG=None

Review URL: https://codereview.chromium.org/684453004

Cr-Commit-Position: refs/heads/master@{#301531}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/686563002

Cr-Commit-Position: refs/heads/master@{#301530}

BUG=82385
R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/684643003

Cr-Commit-Position: refs/heads/master@{#301529}

This adds the renderer side of adding keep-alives while API calls
implemented on mojo services are in progress.

BUG=389016

Review URL: https://codereview.chromium.org/669303002

Cr-Commit-Position: refs/heads/master@{#301528}

- this is part of the implementation of scoring mechanism for next/prev page
  links.
- pagination info will be passed to the scoring framework.
- standalone content extractor outputs the page links.
- modified tests to verify pagination info.

BUG=425952

Review URL: https://codereview.chromium.org/678543002

Cr-Commit-Position: refs/heads/master@{#301527}

The feature is disabled through field trial infrastructure. Pass these
flags to try it out on a device:

--enable-password-generation
--local-heuristics-only-for-password-generation

BUG=412150

Review URL: https://codereview.chromium.org/606153002

Cr-Commit-Position: refs/heads/master@{#301526}

Meta_accessor is deprecated and we should use EnhancedBookmarkModel in
EnhancedBookmarkBridge. We might want to delete metadata_accessor files
after this CL.

BUG=415817

Review URL: https://codereview.chromium.org/679833002

Cr-Commit-Position: refs/heads/master@{#301525}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/683563002

Cr-Commit-Position: refs/heads/master@{#301524}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/685543003

Cr-Commit-Position: refs/heads/master@{#301523}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/676403006

Cr-Commit-Position: refs/heads/master@{#301522}

For other fields, we assume that if the author has specified autocomplete
attributes we should respect all their choices, including not trying to
determine field autocomplete values for fields that the author didn't specify.

This doesn't apply for password fields for two reasons. First, there is no way
for an author to specify generation for a particular field. Second, since
generation isn't a specced autocomplete value, the password field can reasonably
be set (e.g. "autocomplete=new-password") and also have generation enabled.

BUG=424793

Review URL: https://codereview.chromium.org/659793005

Cr-Commit-Position: refs/heads/master@{#301521}

R=tonyg@chromium.org,dtu@chromium.org
BUG=426649

Review URL: https://codereview.chromium.org/684673002

Cr-Commit-Position: refs/heads/master@{#301520}

Old code used a size, we now use a rect, and I didn't update the
quad clipping to use the origin offset.

We now correctly clip the quads, and I've updated the unit test
to use a visible rect that doesn't sit on (0,0), and will fail
without this change.

Though I wasn't able to reproduce it, it may also fix:
https://code.google.com/p/chromium/issues/detail?id=427467

BUG=18132446 (internal)

Review URL: https://codereview.chromium.org/678193002

Cr-Commit-Position: refs/heads/master@{#301519}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/657923005

Cr-Commit-Position: refs/heads/master@{#301518}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bdffb34..33edc61

TBR=leviw@chromium.org,yurys@chromium.org

Review URL: https://codereview.chromium.org/681913003

Cr-Commit-Position: refs/heads/master@{#301517}

BUG=395904

Review URL: https://codereview.chromium.org/413523003

Cr-Commit-Position: refs/heads/master@{#301516}

BUG=426561
TEST=None

Review URL: https://codereview.chromium.org/674303002

Cr-Commit-Position: refs/heads/master@{#301515}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/686553002

Cr-Commit-Position: refs/heads/master@{#301514}

BUG=414363
TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/657893006

Cr-Commit-Position: refs/heads/master@{#301513}

This may help startup time.

Review URL: https://codereview.chromium.org/648413004

Cr-Commit-Position: refs/heads/master@{#301512}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sky@chromium.org

Review URL: https://codereview.chromium.org/683623002

Cr-Commit-Position: refs/heads/master@{#301511}

BUG=

Review URL: https://codereview.chromium.org/680643003

Cr-Commit-Position: refs/heads/master@{#301510}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/686543002

Cr-Commit-Position: refs/heads/master@{#301509}

for CVC and PAN fields.

BUG=427103,427012

Review URL: https://codereview.chromium.org/681843002

Cr-Commit-Position: refs/heads/master@{#301508}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mdm@chromium.org

Review URL: https://codereview.chromium.org/682613003

Cr-Commit-Position: refs/heads/master@{#301507}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/681823004

Cr-Commit-Position: refs/heads/master@{#301506}

Review URL: https://codereview.chromium.org/673343003

Cr-Commit-Position: refs/heads/master@{#301505}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments code invoked from HttpStreamParser::OnIOComplete's callback, which is responsible for 16.2 jph

BUG=424359
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/675273004

Cr-Commit-Position: refs/heads/master@{#301504}

BUG=260879

Review URL: https://codereview.chromium.org/678073007

Cr-Commit-Position: refs/heads/master@{#301503}

The equivalent logs in SSLClientSocketNSS were never implemented here. This
will help in debugging problems which occur after the handshake.

BUG=425834

Review URL: https://codereview.chromium.org/651183004

Cr-Commit-Position: refs/heads/master@{#301502}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/681913002

Cr-Commit-Position: refs/heads/master@{#301501}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/681883002

Cr-Commit-Position: refs/heads/master@{#301500}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/683553002

Cr-Commit-Position: refs/heads/master@{#301499}