- 13 Nov, 2019 40 commits
-
-
Peter Kasting authored
Bug: 1003612 Change-Id: Idae4e5c015df0d9ee09129f26c8679892e42955e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913603 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715032}
-
Jesse McKenna authored
This change adds a new file "Last Path" to the user-data directory containing the path of the last chrome.exe that ran using it. The implementation mimics the "Last Version" file implementation, so the last-run chrome.exe path is updated each time chrome.exe is launched. This will be used by Progressive Web Apps, whose launcher executables will be located inside the user-data directory, to find the correct chrome.exe to launch. Bug: 960245 Change-Id: I0ec658d414dd1a67f03f7d02e645f21f03191360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891121Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#715031}
-
Michael Montvelishsky authored
Bug: none Test: build & run Change-Id: If79049c13291f1ebfcd627c690dd1e33ee9a94ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903622 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#715030}
-
Hector Carmona authored
Bug: 1015194 Change-Id: I71947da1d8f77365244496754518d1d722c234d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912802 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#715029}
-
Maks Orlovich authored
The way post-doom operations worked --- including completion of an optimistic create --- is by appending a callback to a table in the backend, to be invoked upon the doom's completion. This living in the backend meant that if the backend went away the operation would be quietly cancelled with no callback invocations, which is generally what is desired for backend operations... but in case of optimistic create, we have already returned an entry pointer, and entry operations do not get cancelled (and the entry is also expecting a callback to exit the IO pending state). Therefore, extract the table into a separate object with a refcount which entries can hang on to for a bit after backend destruction. This required making cancellation of ops that needed it be done explicitly. It also turned out this was not actually covered by tests, so a test was added for that as well. Bug: 1015774, 1016140, 1016251 Change-Id: Ib2bf64ead3b581795ba75b4d3c866f6f567a1a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888272 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715028}
-
Megan Jablonski authored
Change-Id: I0ca748b3e9e0db012057f690ae676f6c5f5cfbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913711Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715027}
-
Sergey Poromov authored
Add "UploadZippedSystemLogs" feature to the config. Bug: 940648 Change-Id: I2a1277eb37fbc8d6da20861a1adf1933f0e03d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914365 Commit-Queue: Sergey Poromov <poromov@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#715026}
-
Dana Fried authored
Previous to this, a page would have to be unoccluded and visible in order to create a new renderer, though the presence of a video capturer would prevent the page from being unloaded. This allows hover cards and the new touch tabstrip to cause tabs restored when the browser reloads to render. Previously, some tabs would never render until the user actually selected them. Failure to generate thumbnails after browser restore was one of the biggest complaints about hover cards in the user study that was done earlier this year. Bug: 1020782 Change-Id: I06a23c39ade22e15bef60798faca9fd4cdae53ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908060Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#715025}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57d0093ac901..1ba6deba4dfb Created with: gclient setdep -r src-internal@1ba6deba4dfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If0102945a9e35042d54fb0cf059918e5433143b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914602Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715024}
-
Morten Stenshorne authored
Float fragmentation currently doesn't work if the float is "inside" a line. But three existing (but disabled) tests actually had no lines, so they already behaved correctly. The expectation, however, was that we created a dummy line beside the floats (which we did, back in the days), but this is no longer the case, so I just removed that. Bug: 915929 Change-Id: I6b5d04c044860d1225b155fc9c7e70512602b398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913254Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715023}
-
Matt Menke authored
Wire NetworkIsolationKey through ProxyResolver API and all implementations. Also wire it through the Proxy Resolver Service API. net/ isn't yet passing a NetworkIsolationKey() to the ProxyResolver API, so this shouldn't affect behavior yet. Bug: 1021661 Change-Id: Ia9dab8ac7b5062ea85435022e85d1f1720c7da76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906247 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715022}
-
Hongchan Choi authored
When the tear-down process of BaseAudioContext occurs rapidly along with the destruction of an associated ExecutionContext, a scheduled task from the audio rendering thread can attempt to access `this` pointer of BaseAudioContext. This CL add a check to verify the validity of an ExecutionContext before the function accesses the `this` pointer for the audio graph lock. Test: Ran the repro case locally with this patch for 20 minutes and no UAP occurred. Bug: 1023810 Change-Id: I8e5b960b50aca5b0dcee52b5886804af2515806e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913872Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#715021}
-
Chris Lu authored
Adds a new "constants" source_set to avoid any chrome/app dependencies. Bug: 987646 Change-Id: I8fc61687cabc0618e43a7dcc92c30c5cf694e6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906893Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#715020}
-
Alex Clarke authored
This requires the following changes: * It must be possible for the Java App to turn DevTools on. To implement this I opted for an interface similar to AwDevToolsServer. * Telemetry expects the DevTools version query contain a product with a recognizable version number. This requires overriding ContentBrowserClientImpl::GetProduct * Telemetry expects DevTools targets to be discoverable, this requires overriding the DevToolsManagerDelegate. Bug: 1022812 Change-Id: Idae5ac1aa05e700781c96181d3fec0ab3776003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906151 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#715019}
-
Fabrice de Gans-Riberi authored
* Enables reporting of user-mode debugging to debug DevToolsPerContextListeners. * Remove DISALLOW_COPY_AND_ASSIGN in WebEngineDevToolsController implementations. * Add test enabling both user and debug-mode debugging. Bug: 1018371 Change-Id: Ie38c1c9318190e1e9c374f9ccf86a749aa531027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898473 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#715018}
-
Sven Zheng authored
We currently do not have sufficient tools to repro failure on bot without enable the test. Bug: 956016 Change-Id: I89a97d78310fbae96016909196e56cd33ead9230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914295Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715017}
-
Fabrice de Gans-Riberi authored
Bug: 1023510, 1023514, b/143383209 Change-Id: I36be0f276455b8d7441e0cb541a7c3f74cede5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907472Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715016}
-
Cliff Smolinsky authored
This change makes a few updates to the certificate viewer css: - Adds minheights to the three sections of the details tab - Changes layout to relative - Updates to use flex instead of -webkit-box (per presubmit) Bug: 1023970 Change-Id: Ia782ced8132be1ece4237b86eb5692297f2dd9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913574Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715015}
-
Anastasia Helfinstein authored
I've realized that the ordering of the functions in the node classes, while it makes sense to me, is fairly arbitrary. Reorder the functions to group by type (private/setters and getters/static/etc.) and alphabetize within those groups. This is a pure refactor. It changes no logic nor behavior, it only reorders the functions in the file. Bug: None Change-Id: I38d75a90df01070a817eb8847b7121d220193183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902535 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715014}
-
Koji Ishii authored
This patch adds |NGTextOffset| to represent a range of a text for miscellaneous text-related classes in LayoutNG. Start with |NGInlineCurosr| to avoid multiple calls to get |start| and |end|, each of them to compute the current object, but we can apply this to more classes in following patches. Bug: 982194 Change-Id: I79cd67bf6e9737f5af7e4d928212f6f01326f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911862Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715013}
-
Jordy Greenblatt authored
This is the implementation of the out-and-back routing DOM focus design for OS Settings [1]. Compare the tip of tree [2] behavior with the post-fix [3] behavior. [1] https://docs.google.com/document/d/1iNewLPex50WuF2ByJa3w250q_WdBbwCfVIo8C5RM6-w/edit?usp=sharing [2] https://drive.google.com/open?id=1aVRaRrwsMGxYiQ3_FXWSyekeMWOVkCo8 [3] https://drive.google.com/open?id=1A5iVSDgTa7ciqy2rK52B0qqEulw-mR18 Bug: 1003992 Change-Id: I1510a6c231270b3509ebd0c45750979781ee4a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900152Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#715012}
-
Tsuyoshi Horo authored
After this CL, navigation to primary URL of web bundle from network works. But navigation inside web bundle and history navigation doesn't work yet. Bug: 1018640 Change-Id: I1c25dfa7ff52de99da07f094cca2fd7d0de1e500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883468 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#715011}
-
Simon Que authored
Bug: None Change-Id: Iaf6e3974a884e61b4edb7a8c0d7c2df06385f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910981 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#715010}
-
Theresa Wellington authored
Move chrome/android/java/.../appmenu/ (excluding a handful of classes) to its chrome/browser/ui/android/appmenu/ and create a separate build target for the app menu. Also splits appmenu classes and resources between public and internal/ BUG=966644 Change-Id: I9d477981827078f2f0be1dc3929234ef3cdef958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903844 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#715009}
-
Vasilii Sukhanov authored
RemoveAllChildViews() deletes all the child views, thus, turning some members holding dangling pointers. The code should NULL them. Bug: 1023941 Change-Id: I642cff0f1a22e0c894fe4a46421a91182d662c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914364Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#715008}
-
James Cook authored
It runs in the browser_tests suite, so it should be named browsertest. Bug: none Change-Id: I795699ff791031218f4e63b1ab63fa6c13987517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913121 Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#715007}
-
Matt Menke authored
Wire NetworkIsolationKey through ProxyResolverV8[Tracing]. ProxyResolver itself still doesn't support NetworkIsolationKeys. Bug: 1021661 Change-Id: Id82eee857606c593f924a6d7ac213898aeb64c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904606 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715006}
-
Rakesh Soma authored
Add missing reauthcredential test as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1900159 Bug: 990079 Change-Id: Id26862afc1c9977544d3ca72cc23d3df8d23de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912890 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#715005}
-
Elly Fong-Jones authored
I missed this one incorrect call because it's not compiled when is_asan. Oops! Bug: 973128 Change-Id: I84346287759f13268cb97b1386463d2e363ae5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913873Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715004}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37becd02a08f..3f3aa545f7de git log 37becd02a08f..3f3aa545f7de --date=short --no-merges --format='%ad %ae %s' 2019-11-13 hablich@chromium.org [Docs] Fix email in design guidelines graphic Created with: gclient setdep -r src/third_party/devtools-frontend/src@3f3aa545f7de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC v8-waterfall-sheriff@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=v8-waterfall-sheriff@grotations.appspotmail.com Bug: None Change-Id: I6224e4ac0713479cd28441ecb65b5f5eec44ad90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913800Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715003}
-
Nikita Podguzov authored
This will be used in chrome.printing API handler, so we need to get this out of print job manager implementation. Bug: 996785 Change-Id: I0feedff6fdd6cde4da66f5ef61a2fed7fa575b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906153 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715002}
-
Gayane Petrosyan authored
Bug: 1022548 Change-Id: Ic367da17ca7e194d81f5bdab1291ff09c68e56ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904348Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#715001}
-
Victor Hsieh authored
This information will be used to prevent adbd being started, at least until we have well-defined policies to support managed use cases. TEST=see the value change the on reciver side corresponds to account's management status BUG=chromium:893332 Change-Id: I16bc10691dc1b150efc3803293504d82b9eb35bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907279 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#715000}
-
Colin Blundell authored
This CL provides an initial implementation of displaying network errors in WebLayer on Android. This implementation is copied from that of WebView. Note that there is no attempt made to share the code as this CL will need to be merged to 79. This CL does not copy WebView's support for suppressing the showing of error pages (AWContentRendererClient::ShouldSuppressErrorPage()). This support is present in WebView for apps that want to display custom error pages, which is not a requirement in WebLayer at this time. To test: put your device into airplane mode and visit a webpage in WebLayer. You should get an error page with the upside-down Android icon. Change-Id: I4e63cb577e433e3a34db126110ada9b91c851e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906349 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714999}
-
Jasper Chapman-Black authored
Since deriving symbol full_name and template_name is too costly to do for all dex and native symbols, we derive lazily and cache. Bug: 1011921 Change-Id: Ic7e530d1fde8202566c7e5872550d7315a3ad772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913079 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#714998}
-
Alex Newcomer authored
This reverts commit 70693f1c. Reason for revert:1024334 Original change's description: > cros: Detect race when going to tablet mode with no windows > > When going to tablet mode ShelfWidget/ShelfConfig > gets updated before the AppListController gets to notify observers > that AppList will be visible. This means ShelfWidget will update > thinking that the AppList is not visible, when it actually is. > > To fix this race, check whether the AppList *should* be visible at > ShelfConfig::is_in_app(). > > > Change-Id: I7d82b6ca5bd8933146dad75c0c1edb3257e41a67 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903595 > Commit-Queue: Manu Cornet <manucornet@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714829} TBR=newcomer@chromium.org,manucornet@chromium.org Change-Id: Ica5f605de54f57cd9c51bcdecc9a86889343931b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912898Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714997}
-
Xianzhu Wang authored
The previous method of temporary option for SameSite affected flag-specific expectatations because the temporary option was treated as the flag-specific name. This broke local rebaselines of tests. Move the temporary option into Driver.cmd_line() to prevent it from affecting flag-specific feature. Bug: 961439 Change-Id: I1b2c30feebb42a0a701b2085b63b0fde4ab2ea93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914196Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714996}
-
Maks Orlovich authored
We would sometimes do it to a cached 301, and then get really confused trying to read a body that wasn't there. 200 and 206 responses are the only in-caches ones (wire could also have a 304) which could possibly result in a 206 to our client, so others should just have range handling dropped; we do that already for things gotten on the wire but not from cache. Bug: 1015829 Change-Id: I6ba127aec8e88a7cbf72d7a87b94e5e7f10a3973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899890Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#714995}
-
Liquan (Max) Gu authored
ScrollToExpandPaymentHandler can be enabled with a cmd flag, but not from about://flags. In order to make it possible for users to enable this feature from about://flags, this CL attaches this feature to PaymentsExperimentalFeatures, which is one of about://flags, so that enabling PaymentsExperimentalFeatures from either about://flags, or cmd, will also enable this feature. Bug: 999196 Change-Id: I28dae381fe2e4123db078f7b85addb6616ee24a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913163 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714994}
-
Javier Fernandez authored
After r701601 there is no call to such private function, as the logic has been refactored as part of that change. This CL removes the unused method. Bug: 1003184 Change-Id: Iac1b38c4812d2ee924af208dfe71a409b8dfa636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913248Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#714993}
-