- 01 Nov, 2019 40 commits
-
-
Kelvin Jiang authored
This CL adds a new "unpacked" value which could be specied under the "location" key for extension features. APIs/events specified as "unpacked" will only be available for unpacked and command line extensions. This change was motivated by the declarativeNetRequest.OnRuleMatchedDebug event which should only be available for unpacked extensions. Bug: 1017934 Change-Id: Iafe0a64160dc4ca083bcf58393aba94a87bfd3a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892212 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#711807}
-
Torne (Richard Coles) authored
The new implementation of CookieManager::SetAcceptFileSchemeCookies introduced by the network servicification can deadlock when the embedding app is using the CookieManager API in a silly (but not forbidden) way. The deadlock occurs because the calling thread holds accept_file_scheme_cookies_lock_ while waiting synchronously for a task to complete on the CookieManagerClient thread, but it's possible that a task was already queued on that thread which is going to call GetCookieStore() and then attempt to acquire accept_file_scheme_cookies_lock_ to create the cookie store. Avoid this by moving the code which updates accept_file_scheme_cookies_ to run as part of the posted task instead. Also, add thread annotations to CookieManager to clarify which locks protect which state, as the existing comment was not correct. Fixed: 992829 Change-Id: I61aa3a505add2866fdf4317ffa7cf33e684ddc55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890953Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711806}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=kbr@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I2bfb718aa066e09050197565d36f8f11b34e8a93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894882 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#711805}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/076fae010165..fe26bae45243 git log 076fae010165..fe26bae45243 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 lehoangq@gmail.com Metal backend implementation pt 2 Created with: gclient setdep -r src/third_party/angle@fe26bae45243 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: Ia39e3e8ea03a9cc5dfa2659873d47e77c8cd78c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894689Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711804}
-
David Benjamin authored
&vector[0] is invalid if vector is empty. Instead, use vector.data(). This fixes a crash when building with _LIBCPP_DEBUG=0. Bug: 923166 Change-Id: I1de75f3fb4da62c3e70da90c8478e7672b0f16e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894309 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#711803}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=seantopping@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I5caea21fdb526caf65a2d918b64a58661e552019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895653 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#711802}
-
Kevin McNee authored
The win7 bots do not seem to recognize the MANUAL_ prefix, so we explicitly disable these tests as they are being run and are flaking. Tbr: jamiewalch@chromium.org Bug: 1020591 Change-Id: I245e2d8c4fcf59f35698561385cc8cc8a453b807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895780Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711801}
-
Karan Bhatia authored
Instead use the generated flat::RemoveHeaderType enum introduced in r709187. BUG=974391 Change-Id: I28c91cce82160f112edb458df552de27398e8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894066 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711800}
-
Sky Malice authored
Bug: 1020359 Change-Id: I78e3ba760cd00c0f8b7d49452881e6547649a25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894471Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#711799}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fda994c63075..855e8b1bc29d git log fda994c63075..855e8b1bc29d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 natsu@google.com Allow concurrent eglSwapBuffers() with same display but different surfaces 2019-11-01 natsu@google.com Move egl locking code from main.cpp to libEGL.cpp Created with: gclient setdep -r src/third_party/swiftshader@855e8b1bc29d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/135742693,chromium:b/135742693 Change-Id: I0d0c629ea807e0f9cfd4b1fa39e9a8827fe7d7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894681Reviewed-by:
-
Ben Pastene authored
Will revert if/when they get marked informational. Bug: 1006681 Change-Id: I82ac85781c3f20b749eb4b1963e1673534a7cd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895314 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#711797}
-
Manu Cornet authored
The general idea here is to encapsulate more of the hotseat's behavior into its own class rather than have it all over the shelf layout manager. Eventually, I hope to get rid of the huge "CalculateHotseatState" method by setting the hotseat state to the appropriate values from the relevant places. Change-Id: I03bf50bc9f6fb68f7f22f1b6ec966f08f48220da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893997 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#711796}
-
Shimi Zhang authored
Since we are not using jsObjectName until the next navigation, it will only until then we could tell if the parameter is valid or not, if it is not valid, the injection will fail sliently. We want to provide a early exception for developer to know if the object name is valid or not. Since it is hard for us to valid the full set of the allowed JavaScript variable name, we limited the scope to a manageable subset of it. Bug: 918065 Change-Id: I74909768fc9695e6d33302d880eb211a4b250c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894181 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
rbpotter authored
|activeUser| was left undefined, so the Polymer binding in the destination select never flipped hidden to true. Fix by setting the activeUser to empty explicitly in when cloud print is disabled. Fixed: 1018488 Change-Id: Id3b3271acf755617813e6c4f677f51095095e71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892061 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#711794}
-
Oksana Zhuravlova authored
This change is preparation for DocumentInterfaceBroker removal. Since the |document_interface_broker_blink_handle| will no longer be passed, blink will now pass a bool value to indicate whether BrowserInterfaceBroker connection needs to be re-established. Bug: 985120 Change-Id: Ifb5ac6aaf3acba529acc2aabb84301cf3640d126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893983 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711793}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=fdoray@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Idfdf967c4953e8293e420579ba6abc2d6f9e66f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895650 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711792}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e1ef7e22ff0..c93813be129d git log 5e1ef7e22ff0..c93813be129d --date=short --no-merges --format='%ad %ae %s' 2019-11-01 tneda@google.com Merge "perfetto-ui: Button to minimize/maximize track with heap profile flamegraph" 2019-11-01 eseckler@google.com Merge "processor: Remove stale memory_tracker.h/cc files" 2019-11-01 primiano@google.com Merge "Fix CI script to actually delete directory" 2019-11-01 primiano@google.com Merge "UI: Fix undefined in scroll handler" Created with: gclient setdep -r src/third_party/perfetto@c93813be129d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic60df3fdad376d20278777dc29bd280eb692487e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894684Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=skyostil@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I4bb88f91272c322e1056dfcb9b117f4ed21b6c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895651 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#711790}
-
Ian Kilpatrick authored
When table-cells have: - No direct children - "empty-cells: hide" - And their table have "border-collapse: separate" The table cell shouldn't paint. (This is extremely rare). This was handled directly within the table_cell_painter previously, but this patch utilizes the existing "IsHiddenForPaint" logic. Bug: 988015 Change-Id: Ic0a9989b66d1bcce734a796ac6f77942b629378d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895386 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#711789}
-
Austin Eng authored
https://dawn.googlesource.com/dawn.git/+log/c5e06a5d9f0d..314fd3513d0 git log c5e06a5d9f0d..314fd3513d0 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 enga@chromium.org Update SetBindGroup dynamic offsets to uint32_t Created with: gclient setdep -r src/third_party/dawn@314fd3513d04fdc7412df0b6c7defc7b79356e8d This CL also updates dynamic offsets in Chromium to be 32-bit to match the Dawn API change. TBR=cwallez@chromium.org Bug: None Change-Id: I4c61f1e0e81bfe28c5b5a83cf87610e8d4ca6e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894303Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#711788}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=afakhry@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I4f8b917edc1c858dde764dcec37fc04b4d8ca502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895649 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#711787}
-
Mitsuru Oshima authored
This fixes the regression in crrev.com/c/1826666. Bug: 1019737 Test: covered by unittest Change-Id: I45401bb8c482d763991ca34f51537f2a5a6889e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893511 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#711786}
-
Matt Jones authored
This patch removes ChromeActivity#getBottomSheet and replaced it with relevant getters in BottomSheetController. Bug: 986310, 1002277 Change-Id: Ibd3fc81122353551974a50a8259fad38428eaeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872798 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#711785}
-
Matt Menke authored
And a base::Feature to enable/disable respecting it. This CL does not add NetworkIsolationKey support to HostResolvers themselves, so when enabled in Chrome, the new base::Feature doesn't actually do anything yet. Bug: 997049 Change-Id: I86dd8a6c9bf4f00901cfeaa3aba120b8343e836d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894175Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#711784}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=yhirano@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I73d70979b1b3e1545de81963d2082652872f4f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893541 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711783}
-
David Tseng authored
Recently, the way in which brltty launches for usb changed. Previously, when a display plugs in via usb, a udev rule triggers a shell script. Now, the udev rule triggers a pre-existing Upstart job which triggers the original shell script. https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1869773 The pre-existing Upstart job had been used to launch brltty for bluetooth and provided programmatic start/stop via dbus from Chrome client code. As of the above change, there now exists a scenario in which Chrome client code might stop brltty but not re-start it. 1. plug in a usb display. This triggers udev -> start the Upstart job which correctly launches brltty. 2. toggle off ChromeVox. (this triggers a stop on the Upstart job). 3. toggle back on ChromeVox. (no action occurs from either udev or Chrome). result: no re-start occurs. This used to work because in 1, we directly launched brltty via a shell script. In 2, we stopped the Upstart job, which was never started. In 3, brltty is still around and never lost its connection to the display. The fix is to always start the Upstart job in 3. Bug: 1020394 Change-Id: Ied46d71852e97c750573fe0e79f03a2d2feabe3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893930Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#711782}
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=johannes@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: I0d64a4d78e73c5adfdb7f62b0be377a3a4b4cdf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895648 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#711781}
-
James Vecore authored
The preserve-focus attribute was clearing the menu item focus each time the Bluetooth devices list updated. Removing this attribute fixes the issue in a localized way. I tested explicitly to try to reproduce the issue in crbug.com/699001 with the attribute removed. I did not see any regression. Fixed: 940062 Change-Id: I7e886959c7f4b4b604320b73f75a52d401d593da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894266Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#711780}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: I64fdd77759d0f242923785a452ee6ed60318e312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895297Reviewed-by:
-
Leonard Grey authored
This is the "better than nothing" version; like KeywordHintView (press tab to search Google), it announces when the keyword is set. That means this sequence doesn't work as expected: 1) Type goo 2) Press tab to enter keyword mode 3) "Search Google announced" (so far so good) 4) backspace to leave keyword mode 5) Tab again to re-enter keyword mode 6) No announcement, since the keyword is the same. We might need to rearrange things to fix that part, but for now this is an improvement. Bug: 785375 Change-Id: Ia887f26d19af1a06f16beff5db1aba81eda96dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894304Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#711778}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0451e3cb7336..27bd02bf2385 git log 0451e3cb7336..27bd02bf2385 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 jbudorick@chromium.org devil: update default adb to 1.0.41. Created with: gclient setdep -r src/third_party/catapult@27bd02bf2385 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:1005504 Change-Id: I56bf03e3150a6129a8b73056c740256d7d9aa5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894682Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=mek@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Ie172f571ab430c800b6476186e82917743f46afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895638 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#711776}
-
Yue Li authored
- Set/reset focus while opening/closing the popup dialog. - Use cr-dialog instead of popup-overlay to trap the focus. - Adjust the popup dialog with according to the oobe dialog. Bug: b/142957550, 962415 Test: Manual Test Change-Id: I96fcc1bb713c4fb1c40bf3622dffaa5131fc45ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893825Reviewed-by:
-
Toby Huang authored
According to go/unicros-extensions-dd, we need to keep track of which extensions have received parental approval. This dictionary will map extension ids to the approved version. These extensions are safe for child users to install and enable. Deprecate global preference profile.managed.approved_extensions for legacy supervised users as well. Bug: 1014700 Change-Id: Ida8fdde0f264d42e5b101a0b3057c9866fd78d7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864516Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711774}
-
Raphael Kubo da Costa authored
IWYU. This fixes the libstdc++ build after commit 135dadb4 ("Encapsulate addrinfo in RAII type"): In file included from ../../net/dns/address_info.cc:5: ../../net/dns/address_info.h:56:12: error: no template named 'unique_ptr' in namespace 'std' std::unique_ptr<AddrInfoGetter> getter = nullptr); ~~~~~^ ../../net/dns/address_info.h:73:34: error: no template named 'unique_ptr' in namespace 'std' AddressInfo(addrinfo* ai, std::unique_ptr<AddrInfoGetter> getter); ~~~~~^ ../../net/dns/address_info.h:77:8: error: no template named 'unique_ptr' in namespace 'std' std::unique_ptr<AddrInfoGetter> getter_; ~~~~~^ Bug: 957519 Change-Id: I81f3403ad4b0aee6dc815241b41814d528b867ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894000 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
-
Adam Langley authored
This was left over from r702570. I'll probably add it back next week when reenabling this (hopefully for the last time), but best to clean it up just in case. Change-Id: Ic2b0b447ed6b88eade3585fe91076965e72e373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895382 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#711772}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/98f3379d14d4..e3c523e49ef5 git log 98f3379d14d4..e3c523e49ef5 --date=short --no-merges --format='%ad %ae %s' 2019-11-01 seanabraham@chromium.org chromeos_config: restore chell and glados to being critical Created with: gclient setdep -r src/third_party/chromite@e3c523e49ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I77c9b1fbaba7db83886ed3afbc5d423ebdda5f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894923Reviewed-by:
-
Lily Chen authored
This removes the 8 histograms Cookie.{Age,AllAges}For{Secure,NonSecure}{SameSite,CrossSite}Request and also the histogram Cookie.NetworkSecurity. Fixed: 953145, 1000084, 918394, 982138 Bug: 993120, 953145, 1000084, 918394, 982138 Change-Id: I8aeff796bb7119caa99d62c5d277a635f9f33e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893958Reviewed-by:Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#711770}
-
Brandon Goddard authored
This CL temporarily disables a network search test. This test will be rebaselined and re-enabled after lands https: //chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592 Bug: 963183 Change-Id: I31be37367f553660e350516c6ddd588f9a3ea131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895737Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711769}
-
Lei Zhang authored
Change-Id: Ifb157a184ba20ac9435659d91d11523503daa87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893995 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#711768}
-
