- 11 Dec, 2018 40 commits
-
-
Ryan Hansberry authored
Change-Id: I0c9c61c9671e6cbfebf419f1f148f268d79eb5e4 Reviewed-on: https://chromium-review.googlesource.com/c/1370855Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615596}
-
Robbie Gibson authored
Bug: 913958 Change-Id: Ib942171d8f94e7b37cb91cdebe52c5e02141917e Reviewed-on: https://chromium-review.googlesource.com/c/1371893 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615595}
-
Yannis Guyon authored
WEBP_REDUCE_SIZE is defined in chromium, disabling WebPPictureCrop() and WebPPictureRescale(), crashing ExtractAndCropOrScale() in fuzz.h. Disable ExtractAndCropOrScale() without returning an error when WEBP_REDUCE_SIZE is defined. BUG=chromium:912455 Change-Id: I10f66de59498f664d7e0603cfd10698fa3f5f114 Reviewed-on: https://chromium-review.googlesource.com/c/1368108 Commit-Queue: Yannis Guyon <yguyon@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#615594}
-
Alexander Hendrich authored
These changes show up as presubmit errors when working on internet_detail_page.js. Bug: none Change-Id: Ie1d3d8fb061f607d47f71fc3345a37c9e4851041 Reviewed-on: https://chromium-review.googlesource.com/c/1371867Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#615593}
-
Arthur Hemery authored
This patch removes deprecated method RenderFrameHostTester::NavigateAndCommitRendererInitiated and its remaining uses in unit tests. Bug: 728571 Change-Id: I6bd3c51a11b0892b9e3e0ebc0f9ea263f27a223d Reviewed-on: https://chromium-review.googlesource.com/c/1369936 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615592}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c8b5fd3f2752..1ec085624fc7 git log c8b5fd3f2752..1ec085624fc7 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 eseckler@google.com Merge "trace writer: Send patches after completing fragmented packet" Created with: gclient setdep -r src/third_party/perfetto@1ec085624fc7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6abac689f30af8a98120e210957b599be44d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/1372087Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615591}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bdff670a66b9..e98d9aa1ef9b git log bdff670a66b9..e98d9aa1ef9b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 yueherngl@google.com flapjack: add board and paladin Created with: gclient setdep -r src/third_party/chromite@e98d9aa1ef9b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17c3fec3522100def0ec2d29b5d7fd364026d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/1372090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615590}
-
Jeremy Roman authored
Bug: 736037 Change-Id: Ic43002666a0d33296b86b16400590f43ec628ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1372233Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615589}
-
David 'Digit' Turner authored
This allows --mode=system and --mode=universal (which replaces the obsolete --universal option). BUG=912934 R=jbudorick@chromium.org,benmason@chromium.org,tiborg@chromium.org,agrieve@chromium.org Change-Id: Ibd69369ff5aac5410409534319683f1f5db0f2d1 Reviewed-on: https://chromium-review.googlesource.com/c/1371844 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615588}
-
Theresa authored
BUG=452615 Change-Id: Ibc5b6782c2116ca21435e1afa52f41f5f9dc9ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1371900Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615587}
-
Jérôme Lebel authored
Removing ResponseCookies parameter from GaiaAuthFetcher::DispatchFetchedRequest() Change-Id: Ib63c24d88ea996cbd99f50789492cf0bc9f9d7fd Reviewed-on: https://chromium-review.googlesource.com/c/1371891Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615586}
-
Matt Menke authored
Pooling sockets from independent socket pools together breaks layering assumptions. A later point in time, these pools will also need to wrap lower layer objects than ClientSocketHandles. Bug: 895562 Change-Id: I8235f244048475bcb64bf48b3e15309e8607e85e Reviewed-on: https://chromium-review.googlesource.com/c/1362192 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615585}
-
Rayan Kanso authored
Update BackgroundFetchRegistration idl file to include the new changes in the spec. Bug: 913867 Change-Id: Ie94bc1a064734021e5bd98541d9ab47a4006aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/1371387Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#615584}
-
Alex Clarke authored
Based on the reverted https://crrev.com/c/1361103 but without any policy changes. I feel most of the changes are a net improvement in readability so I'd like to land them anyway. Change-Id: I3a60bfb3e5c6171c915f00afbbeb58ee2da01690 Reviewed-on: https://chromium-review.googlesource.com/c/1371428 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615583}
-
Dominik Röttsches authored
DirectWrite will only ever give us one file - we do not need an implementation for retrieving multiple files per IDWriteFont. In upcoming changes for unique local font matching for src: local(...) @font-face declarations, we need a way to retrieve the ttc index of a matched font. Taking those two aspects into account, refactor AddFontFiles to rely on a new method FontFilePathAndTtcIndex which retrieves path and ttc index for a IDWriteFont. Also move helper methods to anonymous namespace. No functional changes to the DWriteFontProxy mojo interface, which this DWriteFontProxyImpl implements. Implementation mostly moved and restructured, but mostly unchanged and taken from previous code. Bug: 889864 Change-Id: Ida13667533eb338bb62083026ddbb386b8dcf0b2 Reviewed-on: https://chromium-review.googlesource.com/c/1371884 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#615582}
-
Peter Boström authored
This reverts commit 742b8857. Reason for revert: Flaky tests should be fixed in r615470. Bug: chromium:912543, chromium:913135, chromium:913784 Original change's description: > Revert "Disable the new tab-loading animation" > > This reverts commit 355b8185. > > Reason for revert: Made several tests flaky: https://crbug.com/912543 > > Original change's description: > > Disable the new tab-loading animation > > > > Makes sure that a lot of animation-related code is bypassed when the > > new-tab-animation flag is off. This should hopefully fix a couple of > > performance regressions that have not yet been root caused so that they > > don't go out with M72. > > > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1364212 > > Reviewed-by: Sidney San Martín <sdy@chromium.org> > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614199} > > TBR=pbos@chromium.org,sdy@chromium.org > > Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > Reviewed-on: https://chromium-review.googlesource.com/c/1366359 > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614440} TBR=jyasskin@chromium.org,pbos@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 Change-Id: I3981455a00f743fae535de4626179dcceab9b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1372236Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615581}
-
Aiden Benner authored
Adds script for refactoring non-static native methods to static native methods using @JCaller and for refactoring static native methods that to use mockable natives. Bug: 898261 Change-Id: I5188a99c55bba028c375a9bf43d029a2c6752b08 Reviewed-on: https://chromium-review.googlesource.com/c/1361782 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615580}
-
David Bokan authored
When a wheel event listener is added or removed on a page, we set each layer as having a WheelEventHandlerRegion equal to the entire bounds of the layer. This happens in Layer::PushPropertiesTo. This means that when an event listener is changed, we need to cause all layers to need a push properties and commit. Prior to this CL, this happens in LayerTreeHost::SetEventListenerProperties by setting SetNeedsFullTreeSync and SetSubtreePropertyChanged. However, as noted by surrounding comments, this looks wrong; SetNeedsFullTreeSync only causes the tree structure to be synced, properties aren't pushed. SetSubtreePropertyChanged causes a property sync only on the root layer. This works prior to BGPT because SetNeedsFullTreeSync causes a property tree rebuild during which all layers are marked as needing a property push. See PropertyTreeBuilderContext::BuildPropertyTreesInternal which calls SetLayerPropertyTreeChangedForChild for all child layers as the tree is built. When BGPT is turned on, property trees are built in Blink independent of the layer tree so this doesn't cause us to SetNeedsPushProperties. This CL fixes SetEventListenerProperties to set the correct flags to propagate the listener state to the active tree. This CL fixes: PointerLockBrowserTest.PointerLockWheelEventRouting TouchpadPinchBrowserTest.WheelListenerAllowingPinch/0 TouchpadPinchBrowserTest.WheelListenerAllowingPinch/1 With BGPT turned on. Bug: 912334,881011 Change-Id: I4446ccfd32de12e618219e5fa15c48f5093bcc98 Reviewed-on: https://chromium-review.googlesource.com/c/1369059Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e011cb742d99..7025535b4bb4 git log e011cb742d99..7025535b4bb4 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d5698f68..573be063 (615355:615506) 2018-12-11 andersc@webrtc.org Fix header import in broadcast extension. 2018-12-11 terelius@webrtc.org Print media types for streams using the new event log format. 2018-12-11 saza@webrtc.org Change the type of indW32 back to int32_t Created with: gclient setdep -r src/third_party/webrtc@7025535b4bb4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:906379 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780646df3dae1ae436f82e3cfe3f897ec48ca41 Reviewed-on: https://chromium-review.googlesource.com/c/1372086Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615578}
-
Ben Pastene authored
Will watch for cycle time increases on the CQ bot: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/mac_chromium_compile_dbg_ng R=dpranke, erikchen, jbudorick Bug: 910227 Change-Id: I73f6e5cc18e707aebe6689034a734ee96fbaa97b Reviewed-on: https://chromium-review.googlesource.com/c/1370949Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#615577}
-
Dominik Röttsches authored
These switches were used in an trial to figure out whether they help with the Windows empty font handle issues. These trials have now been expired without the intended results and are no longer used. Bug: 889864 Change-Id: I9ed1376d989b59a71e325cd54604faeaae71a5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1371807Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#615576}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bf020164. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I640242d27bf5607e8fe5aa25bbddfcbfe5c2eb43 Reviewed-on: https://chromium-review.googlesource.com/c/1372228Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615575}
-
Gabriel Marin authored
Add MetricCollector, a baseline class for collectors. It implements the common functionality for a collector and the interaction between the various defined triggers. The majority of the implementation is copied from the PerfProvider class. The unit tests are mostly new. Added rules to compile the class and the associated unit tests, but the code will not be used in prod until a later CL that adds a perf events collector to replace PerfProvider. BUG=b:116527691 TEST=Unit tests pass Change-Id: Ia4053f0a70a2db2c4c5bf12ca9a9817a310ffad9 Reviewed-on: https://chromium-review.googlesource.com/c/1357598Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#615574}
-
Florin Malita authored
AddArc and AddEllipse take an "anticlockwise" parameter, which is no longer used. Remove the args and hoist related DCHECKs into CanvasPath's AdjustEndAngle (where the actual adjustment is applied). Change-Id: I445379021635b1a6d3fa35c36e9bae6a2563a66b Reviewed-on: https://chromium-review.googlesource.com/c/1366441 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615573}
-
Linwan Song authored
This change links tile raster tasks to the tile manager that initiated them. Tile managers are in turn linked to a frame, which is processed by telemetry later on to determine the time difference between when raster tasks start to when the compositor frame is submitted. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I876a029f6db1e664aafe945fcdd629da3bdc681e Bug: 912730 Reviewed-on: https://chromium-review.googlesource.com/c/1286889 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#615572}
-
Miguel Casas-Sanchez authored
This CL reduces the amount of PictureBuffers requested to be allocated by the |client_| when we are not |decode_using_client_picture_buffers_|. Instead, it "splits" the requested allocations into - the actual needed PictureBuffers (A) - the codec's requested reference frames (B) (a new method GetNumReferenceFrames() is added to AcceleratedVideoDecoder for this). This splitting saves a lot of memory, since we allocate A+B buffers instead of 2*(A+B). (B is 5 and A is 4-VP8, 4-12 H264/VP9) Test: crosvideo changing resolutions for each codec, v_d_a_unittest on nocturne (KBL) and caroline (SKL). Bug: 909926 Change-Id: I1fce92863beddce0e8b221861cf156b9c3ad0c0f Reviewed-on: https://chromium-review.googlesource.com/c/1363807Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615571}
-
ccameron authored
This reverts commit 00c1b7ab. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness." > > This reverts commit 0c873bf2. > > Reason for revert: Fix for flake in crrev.com/615269 > > Original change's description: > > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness. > > > > Tbr: ccameron@chromium.org > > Bug: 913490 > > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f > > Reviewed-on: https://chromium-review.googlesource.com/c/1369721 > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#615159} > > TBR=huangs@chromium.org,ccameron@chromium.org > > Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 913490 > Reviewed-on: https://chromium-review.googlesource.com/c/1370571 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615274} TBR=huangs@chromium.org,ccameron@chromium.org Change-Id: I72829b7b404a571095123f2ffd028ff189563ee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913490 Reviewed-on: https://chromium-review.googlesource.com/c/1371931Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615570}
-
Marc Treib authored
This test covers initial sync, i.e. when there are pre-existing autofill profiles at the time Sync is turned on. Bug: 904390 Change-Id: I7c7f32f9ceb754c5d517a8e182eca6415a2abc61 Reviewed-on: https://chromium-review.googlesource.com/c/1371845 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615569}
-
wutao authored
This feature has been enabled by default since M70 and stable enough to be always on. Bug: 913694 Test: manual and coverred by unittest Change-Id: Ice7240c8d47e45b89324c85de85d398dc9233df8 Reviewed-on: https://chromium-review.googlesource.com/c/1371066 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615568}
-
wutao authored
The old keyboard overlay has been removed in M72 and the flag kAshEnableKeyboardShortcutViewer is also removed. Bug: 778874 Test: manual Change-Id: I6ab9c350728c1e81f2d2437ac089187c4ab604c6 Reviewed-on: https://chromium-review.googlesource.com/c/1371073 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615567}
-
Boris Sazonov authored
This CL removes two SigninTestUtil.resetSigninState calls from tests. ClearBrowsingDataPreferencesBasicTest calls resetSigninState before starting a test, when these preferences are already wiped by SigninTestUtil setup method. HistoryActivityTest calls resetSigninState right before calling SigninManager.signOut, which should clear the state as the part of the sign-out process. Bug: 738533 Change-Id: I646313550ec0c52e979520f62c9a49e9ff137427 Reviewed-on: https://chromium-review.googlesource.com/c/1371804Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615566}
-
edchin authored
This CL removes unnecessary imports and forward declarations from the header file, and move them to the necessary implementation files. Change-Id: If6e41ffe9d85d063f2b14e4c74b12b06b46261b7 Reviewed-on: https://chromium-review.googlesource.com/c/1370581Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615565}
-
Josh Karlin authored
Bug: 851533 Change-Id: I6cc6def8e7def7b6231dfb7e735a66b596b90b36 Reviewed-on: https://chromium-review.googlesource.com/c/1371964Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615564}
-
Tien Mai authored
Bug: 899236 Change-Id: Id541261326bfd44528b08ebc6b0edbe5fafb317f Reviewed-on: https://chromium-review.googlesource.com/c/1370313Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#615563}
-
edchin authored
Bug: 905524 Change-Id: I5699e4b01c3a7f91bd98458e83064811aff53980 Reviewed-on: https://chromium-review.googlesource.com/c/1371218Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615562}
-
Aran Gilman authored
Bug: 832289 Change-Id: If82589e3e690fbf31b8806182e61568d8263119f Reviewed-on: https://chromium-review.googlesource.com/c/1368945Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#615561}
-
Xiaocheng Hu authored
This patch changes WebFrameContentDumper to use Element.innerText instead of its ad-hoc TextDumper, so that its output is more predictable. This patch also allows all WebFrameSwapTest to pass in LayoutNG. Bug: 781434 Change-Id: I961fa43c1821e2a0e7eae6b01a6affe884eacc72 Reviewed-on: https://chromium-review.googlesource.com/c/1371145Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84629852e33d..a030e16bdf09 Created with: gclient setdep -r src-internal@a030e16bdf09 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ff88d678adc149dc066d8f1000f1c2ae1e98bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1372084Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615559}
-
Aga Wronska authored
Removed string from ASSERT_DEATH, because official tests strip the string passed to CHECK(false) and LOG(FATAL). Bug: 913441 Change-Id: Ib68905b60d214064f341262789b31f763e8108b3 Reviewed-on: https://chromium-review.googlesource.com/c/1370307Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615558}
-
Kevin McNee authored
This is a reland of b9e5ed2a Original change's description: > Refactor OOPIF scroll bubbling state and cancellation > > Whether or not a child is bubbling scroll was being tracked in both > CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's > simpler to just have it in RWHVCF. > > There are several cases where we generate fake scroll updates when > cancelling scroll bubbling. This is a relic from the non-scroll latching > code paths and has been removed. We also deduplicate the scroll bubbling > cancellation code. > > We were tracking the view from which scroll events are bubbled by keeping > a reference to that view's parent. We now just keep a reference to the > originating view directly. > > We also now properly cancel scroll bubbling when a child detaches. > > Bug: 828422, 897216 > Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057 > Reviewed-on: https://chromium-review.googlesource.com/c/1357563 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615184} Tbr: kenrb@chromium.org Bug: 828422, 897216 Change-Id: If529545300f6bbb7a7056cdbebbd8317cb274f7a Reviewed-on: https://chromium-review.googlesource.com/c/1371010Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615557}
-